drm/amd/pp: Read vbios vddc limit before use them
Subsystems (2)
PATCH 1/2 drm/amd/pp: Read vbios vddc limit before use them
Use the vddc limit before read them from vbios
--- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +8 -3
@@ -289,7 +289,15 @@ static int vega10_odn_initial_default_setting(struct pp_hwmgr *hwmgr)struct phm_ppt_v1_voltage_lookup_table *vddc_lookup_table;struct phm_ppt_v1_clock_voltage_dependency_table *dep_table[3 ];struct phm_ppt_v1_clock_voltage_dependency_table *od_table[3 ]; +struct pp_atomfwctrl_avfs_parameters avfs_params = {0 };uint32_t i; +int result; + + result =pp_atomfwctrl_get_avfs_information (hwmgr, &avfs_params); +if (!result) { + data->odn_dpm_table.max_vddc = avfs_params.ulMaxVddc; + data->odn_dpm_table.min_vddc = avfs_params.ulMinVddc; + } od_lookup_table = &odn_table->vddc_lookup_table; vddc_lookup_table = table_info->vddc_lookup_table;
@@ -2072,9 +2080,6 @@ static int vega10_populate_avfs_parameters(struct pp_hwmgr *hwmgr)if (data->smu_features[GNLD_AVFS ].supported) { result =pp_atomfwctrl_get_avfs_information (hwmgr, &avfs_params);if (!result) { - data->odn_dpm_table.max_vddc = avfs_params.ulMaxVddc; - data->odn_dpm_table.min_vddc = avfs_params.ulMinVddc; - pp_table->MinVoltageVid = (uint8_t )convert_to_vid ((uint16_t )(avfs_params.ulMinVddc)); pp_table->MaxVoltageVid = (uint8_t)
Signature · 6 lines
1.9.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1531989895-29639-1-git-send-email-rex.zhu-5C7GfCeVMHo@public.gmane.org
PATCH 2/2 drm/amd/pp: Update clk with od setting when set power state
This can fix the issue resume from S3, the user's OD setting were reverted to default.
--- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +15 -0
@@ -3259,10 +3259,25 @@ static int vega10_populate_and_upload_sclk_mclk_dpm_levels( {int result =0 ;struct vega10_hwmgr *data = hwmgr->backend; +struct vega10_dpm_table *dpm_table = &data->dpm_table; +struct vega10_odn_dpm_table *odn_table = &(data->odn_dpm_table); +struct vega10_odn_clock_voltage_dependency_table *odn_clk_table = &(odn_table->vdd_dep_on_sclk); +int count;if (!data->need_update_dpm_table)return 0 ; +if (hwmgr->od_enabled && data->need_update_dpm_table &DPMTABLE_OD_UPDATE_SCLK ) { +for (count =0 ; count < dpm_table->gfx_table.count; count++) + dpm_table->gfx_table.dpm_levels[count].value = odn_clk_table->entries[count].clk; + } + + odn_clk_table = &(odn_table->vdd_dep_on_mclk); +if (hwmgr->od_enabled && data->need_update_dpm_table &DPMTABLE_OD_UPDATE_MCLK ) { +for (count =0 ; count < dpm_table->mem_table.count; count++) + dpm_table->mem_table.dpm_levels[count].value = odn_clk_table->entries[count].clk; + } +if (data->need_update_dpm_table & (DPMTABLE_OD_UPDATE_SCLK +DPMTABLE_UPDATE_SCLK +DPMTABLE_UPDATE_SOCCLK )) { result =vega10_populate_all_graphic_levels (hwmgr);
Signature · 6 lines
1.9.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1531989895-29639-2-git-send-email-rex.zhu-5C7GfCeVMHo@public.gmane.org
Alex Deucher
Reviewed-byRe: [PATCH 2/2] drm/amd/pp: Update clk with od setting when set power state
Quoted 4 lines · Rex Zhu
This can fix the issue resume from S3, the user's OD setting were reverted to default.
Signed-off-by Rex Zhu <[email protected]>
Series is:
Quoted 37 lines
--- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +15
-1@@ -3259,10 +3259,25 @@ static int vega10_populate_and_upload_sclk_mclk_dpm_levels( {int result =0 ;struct vega10_hwmgr *data = hwmgr->backend; +struct vega10_dpm_table *dpm_table = &data->dpm_table; +struct vega10_odn_dpm_table *odn_table = &(data->odn_dpm_table); +struct vega10_odn_clock_voltage_dependency_table *odn_clk_table = &(odn_table->vdd_dep_on_sclk); +int count;if (!data->need_update_dpm_table)return 0 ; +if (hwmgr->od_enabled && data->need_update_dpm_table &DPMTABLE_OD_UPDATE_SCLK ) { +for (count =0 ; count < dpm_table->gfx_table.count; count++) + dpm_table->gfx_table.dpm_levels[count].value = odn_clk_table->entries[count].clk; + } + + odn_clk_table = &(odn_table->vdd_dep_on_mclk); +if (hwmgr->od_enabled && data->need_update_dpm_table &DPMTABLE_OD_UPDATE_MCLK ) { +for (count =0 ; count < dpm_table->mem_table.count; count++) + dpm_table->mem_table.dpm_levels[count].value = odn_clk_table->entries[count].clk; + } +if (data->need_update_dpm_table & (DPMTABLE_OD_UPDATE_SCLK +DPMTABLE_UPDATE_SCLK +DPMTABLE_UPDATE_SOCCLK )) { result =vega10_populate_all_graphic_levels (hwmgr); --1.9.1
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx