drm/i915/dp: Refactor mav_vswing_tries variable
Subsystems (2)
PATCH v5 2/2 drm/i915/dp: Refactor mav_vswing_tries variable
Changes the type and renames the max_vswing_tries variable which was declared as an integer but used as a boolean making it easy to be confused with a counter.
Changes in v2:
- updated the title and commit message
- left the loop exit point in place
--- drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_dp_link_training.c +4 -4
@@ -129,7 +129,8 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) intel_dp_link_training_clock_recovery(struct intel_dp *intel_dp) {uint8_t voltage; -int voltage_tries, max_vswing_tries, cr_tries, max_cr_tries; +int voltage_tries, cr_tries, max_cr_tries; +bool max_vswing = false;uint8_t link_config[2 ];uint8_t link_bw, rate_select;
@@ -181,7 +182,6 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) max_cr_tries =80 ; voltage_tries =1 ; - max_vswing_tries =0 ;for (cr_tries =0 ; cr_tries < max_cr_tries; ++cr_tries) {uint8_t link_status[DP_LINK_STATUS_SIZE ];
@@ -202,7 +202,7 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp)return false; } -if (max_vswing_tries ==1 ) { +if (max_vswing) {DRM_DEBUG_KMS ("Max Voltage Swing reached\n" );return false; }
@@ -223,7 +223,7 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) voltage_tries =1 ;if (intel_dp_link_max_vswing_reached (intel_dp)) - ++max_vswing_tries; + max_vswing = true; }DRM_ERROR ("Failed clock recovery %d times, giving up!\n" , max_cr_tries);
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 1/1 drm/i915/dp: Refactor max_vswing_tries variable
Changes the type and renames the max_vswing_tries variable which was declared as an integer but used as a boolean making it easy to be confused with a counter.
Changes in v2:
- updated the title and commit message
- left the loop exit point in place
v3: fix typo in title
--- drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_dp_link_training.c +4 -4
@@ -129,7 +129,8 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) intel_dp_link_training_clock_recovery(struct intel_dp *intel_dp) {uint8_t voltage; -int voltage_tries, max_vswing_tries, cr_tries, max_cr_tries; +int voltage_tries, cr_tries, max_cr_tries; +bool max_vswing = false;uint8_t link_config[2 ];uint8_t link_bw, rate_select;
@@ -181,7 +182,6 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) max_cr_tries =80 ; voltage_tries =1 ; - max_vswing_tries =0 ;for (cr_tries =0 ; cr_tries < max_cr_tries; ++cr_tries) {uint8_t link_status[DP_LINK_STATUS_SIZE ];
@@ -202,7 +202,7 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp)return false; } -if (max_vswing_tries ==1 ) { +if (max_vswing) {DRM_DEBUG_KMS ("Max Voltage Swing reached\n" );return false; }
@@ -223,7 +223,7 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) voltage_tries =1 ;if (intel_dp_link_max_vswing_reached (intel_dp)) - ++max_vswing_tries; + max_vswing = true; }DRM_ERROR ("Failed clock recovery %d times, giving up!\n" , max_cr_tries);
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for series starting with [v5,2/2] drm/i915/dp: Refactor mav_vswing_tries variable (rev2)
In reply to Nathan Ciobanu== Series Details ==
== Series Details ==
Series: series starting with [v5,2/2] drm/i915/dp: Refactor mav_vswing_tries variable (rev2)
URL : https://patchwork.freedesktop.org/series/46897/
State : failure
== Summary ==
Applying: drm/i915/dp: Refactor mav_vswing_tries variable
error: sha1 information is lacking or useless (drivers/gpu/drm/i915/intel_dp_link_training.c).
error: could not build fake ancestor
Patch failed at 0001 drm/i915/dp: Refactor mav_vswing_tries variable
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 21 lines · Nathan Ciobanu
Changes the type and renames the
max_vswing_triesvariable which was declared as an integer but used as a boolean making it easy to be confused with a counter.Changes in v2:
- updated the title and commit message
- left the loop exit point in placeCc Dhinakaran Pandiyan <[email protected]>Cc Rodrigo Vivi <[email protected]>Cc Marc Herbert <[email protected]>Signed-off-by Nathan Ciobanu <[email protected]>--- drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/intel_dp_link_training.c +0
-0
drivers/gpu/drm/i915/intel_dp_link_training.c static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) · line 133
Quoted 6 lines
drivers/gpu/drm/i915/intel_dp_link_training.c +2
-1@@ -129,7 +129,8 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) intel_dp_link_training_clock_recovery(struct intel_dp *intel_dp) {uint8_t voltage; -int voltage_tries, max_vswing_tries, cr_tries, max_cr_tries; +int voltage_tries, cr_tries, max_cr_tries; +bool max_vswing = false;
max_vswing_reached?
Quoted 36 lines
drivers/gpu/drm/i915/intel_dp_link_training.c +2
-3uint8_t link_config[2 ];uint8_t link_bw, rate_select;@@ -181,7 +182,6 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) max_cr_tries =80 ; voltage_tries =1 ; - max_vswing_tries =0 ;for (cr_tries =0 ; cr_tries < max_cr_tries; ++cr_tries) {uint8_t link_status[DP_LINK_STATUS_SIZE ];@@ -202,7 +202,7 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp)return false; } -if (max_vswing_tries ==1 ) { +if (max_vswing) {DRM_DEBUG_KMS ("Max Voltage Swing reached\n" );return false; }@@ -223,7 +223,7 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) voltage_tries =1 ;if (intel_dp_link_max_vswing_reached (intel_dp)) - ++max_vswing_tries; + max_vswing = true; }DRM_ERROR ("Failed clock recovery %d times, giving up!\n" , max_cr_tries);Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 17 lines · Ville Syrjälä
Quoted 16 lines · Nathan Ciobanu
Changes the type and renames the
max_vswing_triesvariable which was declared as an integer but used as a boolean making it easy to be confused with a counter.Changes in v2:
- updated the title and commit message
- left the loop exit point in placeCc Dhinakaran Pandiyan <[email protected]>Cc Rodrigo Vivi <[email protected]>Cc Marc Herbert <[email protected]>Signed-off-by Nathan Ciobanu <[email protected]>--- drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Quoted 13 lines
drivers/gpu/drm/i915/intel_dp_link_training.c static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) · line 133
Quoted 11 lines
drivers/gpu/drm/i915/intel_dp_link_training.c +2
-1@@ -129,7 +129,8 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) intel_dp_link_training_clock_recovery(struct intel_dp *intel_dp) {uint8_t voltage; -int voltage_tries, max_vswing_tries, cr_tries, max_cr_tries; +int voltage_tries, cr_tries, max_cr_tries; +bool max_vswing = false;
max_vswing_reached?
Ok, I renamed it and resent the patch. Thanks,
Nathan
Quoted 33 lines
Quoted 33 lines
drivers/gpu/drm/i915/intel_dp_link_training.c +2
-3uint8_t link_config[2 ];uint8_t link_bw, rate_select;@@ -181,7 +182,6 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) max_cr_tries =80 ; voltage_tries =1 ; - max_vswing_tries =0 ;for (cr_tries =0 ; cr_tries < max_cr_tries; ++cr_tries) {uint8_t link_status[DP_LINK_STATUS_SIZE ];@@ -202,7 +202,7 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp)return false; } -if (max_vswing_tries ==1 ) { +if (max_vswing) {DRM_DEBUG_KMS ("Max Voltage Swing reached\n" );return false; }@@ -223,7 +223,7 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) voltage_tries =1 ;if (intel_dp_link_max_vswing_reached (intel_dp)) - ++max_vswing_tries; + max_vswing = true; }DRM_ERROR ("Failed clock recovery %d times, giving up!\n" , max_cr_tries);Signature · 1 line
1.9.1
Quoted 9 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 2 lines
Ville Syrjälä Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v5 1/1 drm/i915/dp: Refactor max_vswing_tries variable
In reply to Nathan CiobanuChanges the type and renames the max_vswing_tries variable which was declared as an integer but used as a boolean making it easy to be confused with a counter.
Changes in v2:
- updated the title and commit message
- left the loop exit point in place
v3: fix typo in title
v4: renamed max_vswing to max_vswing_reached (Ville)
--- drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_dp_link_training.c +4 -4
@@ -129,7 +129,8 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) intel_dp_link_training_clock_recovery(struct intel_dp *intel_dp) {uint8_t voltage; -int voltage_tries, max_vswing_tries, cr_tries, max_cr_tries; +int voltage_tries, cr_tries, max_cr_tries; +bool max_vswing_reached = false;uint8_t link_config[2 ];uint8_t link_bw, rate_select;
@@ -181,7 +182,6 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) max_cr_tries =80 ; voltage_tries =1 ; - max_vswing_tries =0 ;for (cr_tries =0 ; cr_tries < max_cr_tries; ++cr_tries) {uint8_t link_status[DP_LINK_STATUS_SIZE ];
@@ -202,7 +202,7 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp)return false; } -if (max_vswing_tries ==1 ) { +if (max_vswing_reached) {DRM_DEBUG_KMS ("Max Voltage Swing reached\n" );return false; }
@@ -223,7 +223,7 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) voltage_tries =1 ;if (intel_dp_link_max_vswing_reached (intel_dp)) - ++max_vswing_tries; + max_vswing_reached = true; }DRM_ERROR ("Failed clock recovery %d times, giving up!\n" , max_cr_tries);
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v5] drm/i915/dp: Refactor max_vswing_tries variable
Quoted 8 lines · Nathan Ciobanu
Changes the type and renames the
max_vswing_triesvariable which was declared as an integer but used as a boolean making it easy to be confused with a counter.Changes in v2:
- updated the title and commit message
- left the loop exit point in place
Quoted 7 lines
v3: fix typo in title
v4: renamedmax_vswingtomax_vswing_reached(Ville)Cc Dhinakaran Pandiyan <[email protected]>Cc Rodrigo Vivi <[email protected]>Cc Marc Herbert <[email protected]>Signed-off-by Nathan Ciobanu <[email protected]>
Quoted 47 lines
--- drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/intel_dp_link_training.c +4
-4@@ -129,7 +129,8 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) intel_dp_link_training_clock_recovery(struct intel_dp *intel_dp) {uint8_t voltage; -int voltage_tries, max_vswing_tries, cr_tries, max_cr_tries; +int voltage_tries, cr_tries, max_cr_tries; +bool max_vswing_reached = false;uint8_t link_config[2 ];uint8_t link_bw, rate_select;@@ -181,7 +182,6 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) max_cr_tries =80 ; voltage_tries =1 ; - max_vswing_tries =0 ;for (cr_tries =0 ; cr_tries < max_cr_tries; ++cr_tries) {uint8_t link_status[DP_LINK_STATUS_SIZE ];@@ -202,7 +202,7 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp)return false; } -if (max_vswing_tries ==1 ) { +if (max_vswing_reached) {DRM_DEBUG_KMS ("Max Voltage Swing reached\n" );return false; }@@ -223,7 +223,7 @@ static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp) voltage_tries =1 ;if (intel_dp_link_max_vswing_reached (intel_dp)) - ++max_vswing_tries; + max_vswing_reached = true; }DRM_ERROR ("Failed clock recovery %d times, giving up!\n" , max_cr_tries);Signature · 1 line
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for series starting with [v5] drm/i915/dp: Refactor max_vswing_tries variable (rev3)
In reply to Nathan Ciobanu== Series Details ==
== Series Details ==
Series: series starting with [v5] drm/i915/dp: Refactor max_vswing_tries variable (rev3)
URL : https://patchwork.freedesktop.org/series/46897/
State : failure
== Summary ==
Applying: drm/i915/dp: Refactor max_vswing_tries variable
error: sha1 information is lacking or useless (drivers/gpu/drm/i915/intel_dp_link_training.c).
error: could not build fake ancestor
Patch failed at 0001 drm/i915/dp: Refactor max_vswing_tries variable
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx