Skip to contentSkip to conversation

patch "uio: fix wrong return value from uio_mmap()" added to char-misc-testing

PATCH [email protected] 1 participant 1 message Jul 21, 2018

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

uio: fix wrong return value from uio_mmap()

to my char-misc git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
in the char-misc-testing branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will be merged to the char-misc-next branch sometime soon, after it passes testing, and the merge window is open.

If you have any questions about this process, please let me know.

Quoted 1 line

From e7de2590f18a272e63732b9d519250d1b522b2c4 Mon Sep 17 00:00:00 2001

From: Hailong Liu <[email protected]>
Date: Fri, 20 Jul 2018 08:31:56 +0800
Subject: uio: fix wrong return value from uio_mmap()

uio_mmap has multiple fail paths to set return value to nonzero then goto out. However, it always returns *0* from the *out* at end, and this will mislead callers who check the return value of this function.

Fixes 57c5f4df0a5a0ee ("uio: fix crash after the device is unregistered")
CC Xiubo Li <[email protected]>
Cc stable <[email protected]>
---
 drivers/uio/uio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/uio/uio.c +1 -1
index f63967c8e95a..144cf7365288 100644
@@ -813,7 +813,7 @@ static int uio_mmap(struct file *filep, struct vm_area_struct *vma)
 
 out:
 	mutex_unlock(&idev->info_lock);
-	return 0;
+	return ret;
 }
 
 static const struct file_operations uio_fops = {
Signature · 1 line
2.18.0