Skip to contentSkip to conversation

Add display clock controller driver for SDM845

PATCH Superseded Taniya Das 2 participants 5 messages Jul 23, 2018 – Aug 1, 2018

Subsystems (3)
lore
Share & tools
lore

Taniya Das

author
#0 lore raw

PATCH v5 1/1 Add display clock controller driver for SDM845

[v5]
* Initialize pll config before assigining l/alpha values for pll configure.
* Add module description.

[v4]
* Add comments for the RCGs/CBCRs using the CLK_GET_RATE_NOCACHE flag.

[v3]
* Move frequency table macro to common file,
add the patch along to maintain dependency.

[v2]
* Removed unused header file includes.
* Moved the frequency table macro to a common file [1].
* Move to pll config to probe.
* Update SoC name in device tree binding and also update the Kconfig.

Add support for the display clock controller found on SDM845 based devices. This would allow display drivers to probe and control their clocks.

Taniya Das (1):
clk: qcom: Add display clock controller driver for SDM845

 drivers/clk/qcom/Kconfig         |  10 +
 drivers/clk/qcom/Makefile        |   1 +
 drivers/clk/qcom/dispcc-sdm845.c | 687 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 698 insertions(+)
 create mode 100644 drivers/clk/qcom/dispcc-sdm845.c

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.

author
#1 lore raw

PATCH v5 1/1 clk: qcom: Add display clock controller driver for SDM845

Add support for the display clock controller found on SDM845 based devices. This would allow display drivers to probe and control their clocks.

---
 drivers/clk/qcom/Kconfig         |  10 +
 drivers/clk/qcom/Makefile        |   1 +
 drivers/clk/qcom/dispcc-sdm845.c | 687 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 698 insertions(+)
 create mode 100644 drivers/clk/qcom/dispcc-sdm845.c
drivers/clk/qcom/Kconfig +10 -0
index 2b69cf2..0647686 100644
@@ -254,6 +254,16 @@ config SDM_VIDEOCC_845
 	  Say Y if you want to support video devices and functionality such as
 	  video encode and decode.
 
+config SDM_DISPCC_845
+	tristate "SDM845 Display Clock Controller"
+	select SDM_GCC_845
+	depends on COMMON_CLK_QCOM
+	help
+	  Support for the display clock controller on Qualcomm Technologies, Inc
+	  SDM845 devices.
+	  Say Y if you want to support display devices and functionality such as
+	  splash screen.
+
 config SPMI_PMIC_CLKDIV
 	tristate "SPMI PMIC clkdiv Support"
 	depends on (COMMON_CLK_QCOM && SPMI) || COMPILE_TEST
drivers/clk/qcom/Makefile +1 -0
index 599ab91..21a4503 100644
@@ -39,6 +39,7 @@ obj-$(CONFIG_QCOM_CLK_APCS_MSM8916) += apcs-msm8916.o
 obj-$(CONFIG_QCOM_CLK_RPM) += clk-rpm.o
 obj-$(CONFIG_QCOM_CLK_RPMH) += clk-rpmh.o
 obj-$(CONFIG_QCOM_CLK_SMD_RPM) += clk-smd-rpm.o
+obj-$(CONFIG_SDM_DISPCC_845) += dispcc-sdm845.o
 obj-$(CONFIG_SDM_GCC_845) += gcc-sdm845.o
 obj-$(CONFIG_SDM_VIDEOCC_845) += videocc-sdm845.o
 obj-$(CONFIG_SPMI_PMIC_CLKDIV) += clk-spmi-pmic-div.o
drivers/clk/qcom/dispcc-sdm845.c new file +687 -0

687 lines not on this page · raw message

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.

maintainer
#2 lore raw

Re: [PATCH v5] clk: qcom: Add display clock controller driver for SDM845

Quoting Taniya Das (2018-07-23 03:54:35)

Quoted 6 lines

Add support for the display clock controller found on SDM845 based devices. This would allow display drivers to probe and control their clocks.

---

This is fine to merge as long as you're ok with removing the no rate cache flag. I can do that myself so you don't have to resend.

author
#3 lore raw

Re: [PATCH v5] clk: qcom: Add display clock controller driver for SDM845

Quoted 11 lines · Stephen Boyd

Quoting Taniya Das (2018-07-23 03:54:35)

Quoted 6 lines

Add support for the display clock controller found on SDM845 based devices. This would allow display drivers to probe and control their clocks.

---

This is fine to merge as long as you're ok with removing the no rate cache flag. I can do that myself so you don't have to resend.

Thanks, please go ahead and remove the flags, in case the display drivers would require the flags for any proper use case then we could think on re-introducing them.

Signature · 4 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--
maintainer Applied
#4 lore raw

Re: [PATCH v5] clk: qcom: Add display clock controller driver for SDM845

In reply to Taniya Das

Quoting Taniya Das (2018-07-23 03:54:35)

Quoted 6 lines

Add support for the display clock controller found on SDM845 based devices. This would allow display drivers to probe and control their clocks.

---

Applied to clk-next with removal of the rate cache flag.