Skip to contentSkip to conversation

memory: jz4780-nemc: build depend on OF

PATCH In review Corentin Labbe 2 participants 2 messages Jul 23, 2018 Memory controller drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 memory: jz4780-nemc: build depend on OF

jz4780-nemc use of_ functions, so it needs to depend on OF

This fix the following build failure on x86
drivers/memory/jz4780-nemc.c: In function ‘jz4780_nemc_num_banks’:
drivers/memory/jz4780-nemc.c:72:10: error: implicit declaration of function ‘of_read_number’ [-Werror=implicit-function-declaration]

---
 drivers/memory/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/memory/Kconfig +1 -0
index a642552..faa1a23 100644
@@ -124,6 +124,7 @@ config JZ4780_NEMC
 	default y
 	depends on MACH_JZ4780 || COMPILE_TEST
 	depends on HAS_IOMEM
+	depends on OF
 	help
 	  This driver is for the NAND/External Memory Controller (NEMC) in
 	  the Ingenic JZ4780. This controller is used to handle external
Signature · 1 line
2.7.4
#1 lore raw
Quoted 17 lines · Corentin Labbe

jz4780-nemc use of_ functions, so it needs to depend on OF

This fix the following build failure on x86
drivers/memory/jz4780-nemc.c: In function ‘jz4780_nemc_num_banks’:
drivers/memory/jz4780-nemc.c:72:10: error: implicit declaration of function ‘of_read_number’ [-Werror=implicit-function-declaration]

---
 drivers/memory/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/memory/Kconfig +0 -0
index a642552..faa1a23 100644

drivers/memory/Kconfig config JZ4780_NEMC · line 130

Quoted 7 lines
drivers/memory/Kconfig +1 -0
@@ -124,6 +124,7 @@ config JZ4780_NEMC
 	default y
 	depends on MACH_JZ4780 || COMPILE_TEST
 	depends on HAS_IOMEM
+	depends on OF
 	help
 	  This driver is for the NAND/External Memory Controller (NEMC) in
 	  the Ingenic JZ4780. This controller is used to handle external

Duplicate of https://lore.kernel.org/lkml/[email protected]/

Signature · 1 line
~Randy