Skip to contentSkip to conversation

android: binder: Include asm/cacheflush.h after linux/ include files

PATCH New Guenter Roeck 1 participant 1 message Jul 23, 2018 Android drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 android: binder: Include asm/cacheflush.h after linux/ include files

If asm/cacheflush.h is included first, the following build warnings are seen with sparc32 builds.

In file included from arch/sparc/include/asm/cacheflush.h:11:0,
from drivers/android/binder.c:54:
arch/sparc/include/asm/cacheflush_32.h:40:37: warning:
'struct page' declared inside parameter list will not be visible outside of this definition or declaration

Moving the asm/ include after linux/ includes solves the problem.

---
 drivers/android/binder.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/android/binder.c +3 -1
index 95283f3bb51c..1cc2fa16af8b 100644
@@ -51,7 +51,6 @@
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
-#include <asm/cacheflush.h>
 #include <linux/fdtable.h>
 #include <linux/file.h>
 #include <linux/freezer.h>
@@ -73,6 +72,9 @@
 #include <linux/spinlock.h>
 
 #include <uapi/linux/android/binder.h>
+
+#include <asm/cacheflush.h>
+
 #include "binder_alloc.h"
 #include "binder_trace.h"
 
Signature · 1 line
2.7.4