Skip to contentSkip to conversation

android: binder_alloc: Include asm/cacheflush.h after linux/ include files

PATCH New Guenter Roeck 1 participant 1 message Jul 23, 2018 Android drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 android: binder_alloc: Include asm/cacheflush.h after linux/ include files

If asm/cacheflush.h is included first, the following build warnings are seen with sparc32 builds.

In file included from ./arch/sparc/include/asm/cacheflush.h:11:0,
from drivers/android/binder_alloc.c:20:
./arch/sparc/include/asm/cacheflush_32.h:40:37: warning:
'struct page' declared inside parameter list

Moving the asm/ include after linux/ includes fixes the problem.

---
 drivers/android/binder_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/android/binder_alloc.c +1 -1
index 2628806c64a2..2c258dcf9d72 100644
@@ -17,7 +17,6 @@
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
-#include <asm/cacheflush.h>
 #include <linux/list.h>
 #include <linux/sched/mm.h>
 #include <linux/module.h>
@@ -28,6 +27,7 @@
 #include <linux/slab.h>
 #include <linux/sched.h>
 #include <linux/list_lru.h>
+#include <asm/cacheflush.h>
 #include "binder_alloc.h"
 #include "binder_trace.h"
 
Signature · 1 line
2.7.4