Skip to contentSkip to conversation

patch "iio: sca3000: Fix missing return in switch" added to staging-testing

PATCH [email protected] 1 participant 1 message Jul 25, 2018

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

iio: sca3000: Fix missing return in switch

to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-testing branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will be merged to the staging-next branch sometime soon, after it passes testing, and the merge window is open.

If you have any questions about this process, please let me know.

Quoted 1 line

From c5b974bee9d2ceae4c441ae5a01e498c2674e100 Mon Sep 17 00:00:00 2001

From: "Gustavo A. R. Silva" <[email protected]>
Date: Sat, 7 Jul 2018 12:44:01 -0500
Subject: iio: sca3000: Fix missing return in switch

The IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY case is missing a return and will fall through to the default case and errorenously return -EINVAL.

Fix this by adding in missing *return ret*.

Fixes 626f971b5b07 ("staging:iio:accel:sca3000 Add write support to the low pass filter control")
---
 drivers/iio/accel/sca3000.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/accel/sca3000.c +1 -0
index 4dceb75e3586..4964561595f5 100644
@@ -797,6 +797,7 @@ static int sca3000_write_raw(struct iio_dev *indio_dev,
 		mutex_lock(&st->lock);
 		ret = sca3000_write_3db_freq(st, val);
 		mutex_unlock(&st->lock);
+		return ret;
 	default:
 		return -EINVAL;
 	}
Signature · 1 line
2.18.0