Skip to contentSkip to conversation

Formfactor fix

PATCH Applied Paul Eggleton 3 participants 6 messages Mar 7, 2012 – Mar 12, 2012

lore
Share & tools
lore
#0 lore raw

cover Formfactor fix

The following change since commit d7b8c247227f3cc82f92292407f548927e9fde78:

base.bbclass: Fix PACKAGECONFIG handling when no flags are set (2012-03-05 13:03:41 -0800)

is available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib paule/formfactor
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/formfactor

Paul Eggleton (1):
formfactor: use full path to fbset

 meta/recipes-bsp/formfactor/files/config      |    6 +++---
 meta/recipes-bsp/formfactor/formfactor_0.0.bb |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 formfactor: use full path to fbset

When using rootless X, /usr/sbin is not in PATH and thus running "fbset" will fail; so specify /usr/sbin/fbset instead.

Fixes [YOCTO #1986]

---
 meta/recipes-bsp/formfactor/files/config      |    6 +++---
 meta/recipes-bsp/formfactor/formfactor_0.0.bb |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
meta/recipes-bsp/formfactor/files/config +3 -3
index e936916..a3f762a 100755
@@ -29,15 +29,15 @@ if [ -z "$DISPLAY_ORIENTATION" ]; then
 fi
 
 if [ -z "$DISPLAY_WIDTH_PIXELS" ]; then
-    DISPLAY_WIDTH_PIXELS=`fbset | grep geometry | awk '{ print $2 }'`
+    DISPLAY_WIDTH_PIXELS=`/usr/sbin/fbset | grep geometry | awk '{ print $2 }'`
 fi
 
 if [ -z "$DISPLAY_HEIGHT_PIXELS" ]; then
-    DISPLAY_HEIGHT_PIXELS=`fbset | grep geometry | awk '{ print $3 }'`
+    DISPLAY_HEIGHT_PIXELS=`/usr/sbin/fbset | grep geometry | awk '{ print $3 }'`
 fi
 
 if [ -z "$DISPLAY_BPP" ]; then
-    DISPLAY_BPP=`fbset | grep geometry | awk '{ print $6 }'`
+    DISPLAY_BPP=`/usr/sbin/fbset | grep geometry | awk '{ print $6 }'`
 fi
 
 # 
meta/recipes-bsp/formfactor/formfactor_0.0.bb +1 -1
index abf20e0..31b4490 100644
@@ -3,7 +3,7 @@ SECTION = "base"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
                     file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
-PR = "r19"
+PR = "r20"
 
 SRC_URI = "file://config file://machconfig"
 S = "${WORKDIR}"
Signature · 1 line
1.7.5.4
#2 lore raw

Re: [PATCH 1/1] formfactor: use full path to fbset

Quoted 3 lines · Paul Eggleton

When using rootless X, /usr/sbin is not in PATH and thus running "fbset" will fail; so specify /usr/sbin/fbset instead.

just curious why is /usr/sbin omitted from PATH ?

#3 lore raw

Re: [PATCH 1/1] formfactor: use full path to fbset

Quoted 5 lines · On Tuesday 06 March 2012 18:14:52 Khem Raj wrote:
Quoted 2 lines · Paul Eggleton

When using rootless X, /usr/sbin is not in PATH and thus running "fbset" will fail; so specify /usr/sbin/fbset instead.

just curious why is /usr/sbin omitted from PATH ?

With the rootless X implementation we have, you're logged in as "xuser" instead of root. I guess our default is to not include /sbin and /usr/sbin in PATH for non-root users.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#4 lore raw

Re: [PATCH 1/1] formfactor: use full path to fbset

Quoted 2 lines · Paul Eggleton

I guess our default is to not include /sbin and /usr/sbin in PATH for non-root users.

OK true. I get it now

Applied
#5 lore raw
In reply to Paul Eggleton
Quoted 8 lines · Paul Eggleton

The following change since commit d7b8c247227f3cc82f92292407f548927e9fde78:

base.bbclass: Fix PACKAGECONFIG handling when no flags are set (2012-03-05 13:03:41 -0800)

is available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib paule/formfactor
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/formfactor

Quoted 7 lines

Paul Eggleton (1):
formfactor: use full path to fbset

  meta/recipes-bsp/formfactor/files/config      |    6 +++---
  meta/recipes-bsp/formfactor/formfactor_0.0.bb |    2 +-
  2 files changed, 4 insertions(+), 4 deletions(-)

Merged into OE-Core

Thanks
Sau!