drm/ttm: move non-x86 definitions to the common header
Subsystems (3)
cover drm/ttm: move non-x86 definitions to the common header
Hi,
As suggested by Christian, we should move non-x86 definitions into one common header, and it will make the codes readable. They are based on the improvement fix of Bas (already rebase Bas's patch to drm-next).
Thanks,
Ray
Bas Nieuwenhuizen (1):
drm/ttm: Merge hugepage attr changes in ttm_dma_page_put.
Huang Rui (4):
drm/ttm: add ttm_set_memory header
drm/ttm: clean up non-x86 definitions on ttm_page_alloc_dma drm/ttm: clean up non-x86 definitions on ttm_page_alloc drm/ttm: use set_pages_wb instead of set_memory_wb
drivers/gpu/drm/ttm/ttm_page_alloc.c | 54 +------------ drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 53 ++----------- include/drm/ttm/ttm_set_memory.h | 127 +++++++++++++++++++++++++++++++ 3 files changed, 133 insertions(+), 101 deletions(-) create mode 100644 include/drm/ttm/ttm_set_memory.h
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1532596448-17831-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org
PATCH 1/5 drm/ttm: Merge hugepage attr changes in ttm_dma_page_put.
From: Bas Nieuwenhuizen <[email protected]>
Every set_pages_array_wb call resulted in cross-core interrupts and TLB flushes. Merge more of them for less overhead.
This reduces the time needed to free a 1.6 GiB GTT WC buffer as part of Vulkan CTS from ~2 sec to < 0.25 sec. (Allocation still takes more than 2 sec though)
--- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 30 +++++++++++++++++++++++------- 1 file changed, 23 insertions(+), 7 deletions(-)
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c +23 -7
@@ -301,6 +301,25 @@ static int set_pages_array_uc(struct page **pages, int addrinarray)#endif return 0 ; } + +static int ttm_set_page_range_wb (struct page *p,unsigned long numpages) +{ +#if IS_ENABLED (CONFIG_AGP ) +unsigned long i; + +for (i =0 ; i < numpages; i++) +unmap_page_from_agp (p + i); +#endif +return 0 ; +} + +#else /* for !CONFIG_X86 */ + +static int ttm_set_page_range_wb (struct page *p,unsigned long numpages) +{ +return set_memory_wb ((unsigned long )page_address (p), numpages); +} +#endif /* for !CONFIG_X86 */ static int ttm_set_pages_caching(struct dma_pool *pool,
@@ -389,17 +408,14 @@ static void ttm_pool_update_free_locked(struct dma_pool *pool,static void ttm_dma_page_put (struct dma_pool *pool,struct dma_page *d_page) {struct page *page = d_page->p; -unsigned i, num_pages; +unsigned num_pages;/* Don't set WB on WB page pool. */ if (!(pool->type &IS_CACHED )) { num_pages = pool->size /PAGE_SIZE ; -for (i =0 ; i < num_pages; ++i, ++page) { -if (set_pages_array_wb (&page,1 )) { -pr_err ("%s: Failed to set %d pages to wb!\n" , - pool->dev_name,1 ); - } - } +if (ttm_set_page_range_wb (page, num_pages)) +pr_err ("%s: Failed to set %d pages to wb!\n" , + pool->dev_name, num_pages); }list_del (&d_page->page_list);
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1532596448-17831-2-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org
Re: [PATCH 1/5] drm/ttm: Merge hugepage attr changes in ttm_dma_page_put.
Am 26.07.2018 um 11:14 schrieb Huang Rui:
Quoted 32 lines
From: Bas Nieuwenhuizen <[email protected]>
Every
set_pages_array_wbcall resulted in cross-core interrupts and TLB flushes. Merge more of them for less overhead.This reduces the time needed to free a 1.6 GiB GTT WC buffer as part of Vulkan CTS from ~2 sec to < 0.25 sec. (Allocation still takes more than 2 sec though)
Signed-off-by Bas Nieuwenhuizen <[email protected]>Signed-off-by Huang Rui <[email protected]>--- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 30 +++++++++++++++++++++++------- 1 file changed, 23 insertions(+), 7 deletions(-)drivers/gpu/drm/ttm/ttm_page_alloc_dma.c +8
-0@@ -301,6 +301,25 @@ static int set_pages_array_uc(struct page **pages, int addrinarray)#endif return 0 ; } + +static int ttm_set_page_range_wb (struct page *p,unsigned long numpages) +{ +#if IS_ENABLED (CONFIG_AGP ) +unsigned long i; + +for (i =0 ; i < numpages; i++) +unmap_page_from_agp (p + i);
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c static int set_pages_array_uc(struct page **pages, int addrinarray) · line 321
Quoted 10 lines
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c +10
-0+#endif +return 0 ; +} + +#else /* for !CONFIG_X86 */ + +static int ttm_set_page_range_wb (struct page *p,unsigned long numpages) +{ +return set_memory_wb ((unsigned long )page_address (p), numpages); +}
Please use set_pages_wb() here instead of set_memory_wb(), this way it should also work on 32bit systems.
Christian.
Quoted 16 lines
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c +2
-3+#endif /* for !CONFIG_X86 */ static int ttm_set_pages_caching(struct dma_pool *pool,@@ -389,17 +408,14 @@ static void ttm_pool_update_free_locked(struct dma_pool *pool,static void ttm_dma_page_put (struct dma_pool *pool,struct dma_page *d_page) {struct page *page = d_page->p; -unsigned i, num_pages; +unsigned num_pages;/* Don't set WB on WB page pool. */ if (!(pool->type &IS_CACHED )) { num_pages = pool->size /PAGE_SIZE ; -for (i =0 ; i < num_pages; ++i, ++page) { -if (set_pages_array_wb (&page,1 )) {
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c static void ttm_pool_update_free_locked(struct dma_pool *pool, · line 421
Quoted 10 lines
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c +3
-4-pr_err ("%s: Failed to set %d pages to wb!\n" , - pool->dev_name,1 ); - } - } +if (ttm_set_page_range_wb (page, num_pages)) +pr_err ("%s: Failed to set %d pages to wb!\n" , + pool->dev_name, num_pages); }list_del (&d_page->page_list);
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 297c3298-d1a0-743c-5de9-8e009677305a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Re: [PATCH 1/5] drm/ttm: Merge hugepage attr changes in ttm_dma_page_put.
Quoted 38 lines · Christian König
Am 26.07.2018 um 11:14 schrieb Huang Rui:
Quoted 37 lines
From: Bas Nieuwenhuizen <[email protected]>
Every
set_pages_array_wbcall resulted in cross-core interrupts and TLB flushes. Merge more of them for less overhead.This reduces the time needed to free a 1.6 GiB GTT WC buffer as part of Vulkan CTS from ~2 sec to < 0.25 sec. (Allocation still takes more than 2 sec though)
Signed-off-by Bas Nieuwenhuizen <[email protected]>Signed-off-by Huang Rui <[email protected]>--- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 30 +++++++++++++++++++++++------- 1 file changed, 23 insertions(+), 7 deletions(-)drivers/gpu/drm/ttm/ttm_page_alloc_dma.c +13
-0@@ -301,6 +301,25 @@ static int set_pages_array_uc(struct page **pages, int addrinarray)#endif return 0 ; } + +static int ttm_set_page_range_wb (struct page *p,unsigned long numpages) +{ +#if IS_ENABLED (CONFIG_AGP ) +unsigned long i; + +for (i =0 ; i < numpages; i++) +unmap_page_from_agp (p + i); +#endif +return 0 ; +} + +#else /* for !CONFIG_X86 */
Quoted 9 lines
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c static int set_pages_array_uc(struct page **pages, int addrinarray) · line 321
Quoted 5 lines
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c +5
-0+ +static int ttm_set_page_range_wb (struct page *p,unsigned long numpages) +{ +return set_memory_wb ((unsigned long )page_address (p), numpages); +}Please use
set_pages_wb()here instead ofset_memory_wb(), this way it should also work on 32bit systems.
Actually, I fix it in patch 5 ("drm/ttm: use set_pages_wb instead of set_memory_wb"). So should I sequeeze it int this patch? There is SMTP network issue in SRDC, other patches are timeout...
[Net::SMTP] Timeout at /usr/lib/git-core/git-send-email line 1393.
Let me resend them into dri-devel as well.
Thanks,
Ray
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 1/5] drm/ttm: Merge hugepage attr changes in ttm_dma_page_put.
Quoted 50 lines · Huang Rui
Quoted 38 lines · Christian König
Am 26.07.2018 um 11:14 schrieb Huang Rui:
Quoted 37 lines
From: Bas Nieuwenhuizen <[email protected]>
Every
set_pages_array_wbcall resulted in cross-core interrupts and TLB flushes. Merge more of them for less overhead.This reduces the time needed to free a 1.6 GiB GTT WC buffer as part of Vulkan CTS from ~2 sec to < 0.25 sec. (Allocation still takes more than 2 sec though)
Signed-off-by Bas Nieuwenhuizen <[email protected]>Signed-off-by Huang Rui <[email protected]>--- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 30 +++++++++++++++++++++++------- 1 file changed, 23 insertions(+), 7 deletions(-)drivers/gpu/drm/ttm/ttm_page_alloc_dma.c +13
-0@@ -301,6 +301,25 @@ static int set_pages_array_uc(struct page **pages, int addrinarray)#endif return 0 ; } + +static int ttm_set_page_range_wb (struct page *p,unsigned long numpages) +{ +#if IS_ENABLED (CONFIG_AGP ) +unsigned long i; + +for (i =0 ; i < numpages; i++) +unmap_page_from_agp (p + i); +#endif +return 0 ; +} + +#else /* for !CONFIG_X86 */ Quoted 9 lines
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c static int set_pages_array_uc(struct page **pages, int addrinarray) · line 321
Quoted 5 lines
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c +5
-0+ +static int ttm_set_page_range_wb (struct page *p,unsigned long numpages) +{ +return set_memory_wb ((unsigned long )page_address (p), numpages); +}Please use
set_pages_wb()here instead ofset_memory_wb(), this way it should also work on 32bit systems.
Quoted 3 lines
Actually, I fix it in patch 5 ("drm/ttm: use
set_pages_wbinstead ofset_memory_wb"). So should I sequeeze it int this patch? There is SMTP network issue in SRDC, other patches are timeout...
I'd say fix it up in this patch (You can avoid introducing ttm_set_page_range_wb that way as it is equal to set_pages_wb) and then put this patch at the end of your series. Since ttm_page_alloc.c already has a set_pages_wb fallback implementation that means we do not introduce code just to deduplicate it later in the series anymore.
Quoted 7 lines
[
Net::SMTP] Timeout at/usr/lib/git-core/git-send-emailline 1393.Let me resend them into dri-devel as well.
Thanks,
Ray
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CAJXbfOCxrt40XqVCNYS01BBk4=rZrv5OoojrZ8AQPG+TBXfh5g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Re: [PATCH 1/5] drm/ttm: Merge hugepage attr changes in ttm_dma_page_put.
Quoted 55 lines · Bas Nieuwenhuizen
Quoted 50 lines · Huang Rui
Quoted 38 lines · Christian König
Am 26.07.2018 um 11:14 schrieb Huang Rui:
Quoted 37 lines
From: Bas Nieuwenhuizen <[email protected]>
Every
set_pages_array_wbcall resulted in cross-core interrupts and TLB flushes. Merge more of them for less overhead.This reduces the time needed to free a 1.6 GiB GTT WC buffer as part of Vulkan CTS from ~2 sec to < 0.25 sec. (Allocation still takes more than 2 sec though)
Signed-off-by Bas Nieuwenhuizen <[email protected]>Signed-off-by Huang Rui <[email protected]>--- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 30 +++++++++++++++++++++++------- 1 file changed, 23 insertions(+), 7 deletions(-)drivers/gpu/drm/ttm/ttm_page_alloc_dma.c +13
-0@@ -301,6 +301,25 @@ static int set_pages_array_uc(struct page **pages, int addrinarray)#endif return 0 ; } + +static int ttm_set_page_range_wb (struct page *p,unsigned long numpages) +{ +#if IS_ENABLED (CONFIG_AGP ) +unsigned long i; + +for (i =0 ; i < numpages; i++) +unmap_page_from_agp (p + i); +#endif +return 0 ; +} + +#else /* for !CONFIG_X86 */ Quoted 9 lines
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c static int set_pages_array_uc(struct page **pages, int addrinarray) · line 321
Quoted 5 lines
drivers/gpu/drm/ttm/ttm_page_alloc_dma.c +5
-0+ +static int ttm_set_page_range_wb (struct page *p,unsigned long numpages) +{ +return set_memory_wb ((unsigned long )page_address (p), numpages); +}Please use
set_pages_wb()here instead ofset_memory_wb(), this way it should also work on 32bit systems.Quoted 3 lines
Actually, I fix it in patch 5 ("drm/ttm: use
set_pages_wbinstead ofset_memory_wb"). So should I sequeeze it int this patch? There is SMTP network issue in SRDC, other patches are timeout...
Quoted 6 lines
I'd say fix it up in this patch (You can avoid introducing
ttm_set_page_range_wbthat way as it is equal toset_pages_wb) and then put this patch at the end of your series. Sincettm_page_alloc.calready has aset_pages_wbfallback implementation that means we do not introduce code just to deduplicate it later in the series anymore.
That makes sense. :-)
Will update it in V2.
Thanks,
Ray
Quoted 7 lines
Quoted 7 lines
[
Net::SMTP] Timeout at/usr/lib/git-core/git-send-emailline 1393.Let me resend them into dri-devel as well.
Thanks,
Ray
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 2/5 drm/ttm: add ttm_set_memory header
In reply to a message not in the archiveThis patch moves all non-x86 abstraction to the ttm_set_memory header. It is to make function calling more clearly.
--- include/drm/ttm/ttm_set_memory.h | 127 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 127 insertions(+) create mode 100644 include/drm/ttm/ttm_set_memory.h
include/drm/ttm/ttm_set_memory.h new file +127 -0
@@ -0,0 +1,127 @@ +/************************************************************************** +* +* Copyright (c) 2018 Advanced Micro Devices, Inc. +* All Rights Reserved. +* +* Permission is hereby granted, free of charge, to any person obtaining a +* copy of this software and associated documentation files (the +* "Software"), to deal in the Software without restriction, including +* without limitation the rights to use, copy, modify, merge, publish, +* distribute, sub license, and/or sell copies of the Software, and to +* permit persons to whom the Software is furnished to do so, subject to +* the following conditions: +* +* The above copyright notice and this permission notice (including the +* next paragraph) shall be included in all copies or substantial portions +* of the Software. +* +* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +* FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL +* THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, +* DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +* OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE +* USE OR OTHER DEALINGS IN THE SOFTWARE. +* +**************************************************************************/ +/* +* Authors: Huang Rui <[email protected]> +*/ + +#ifndef TTM_SET_MEMORY +#define TTM_SET_MEMORY + +#include <linux/mm.h> + +#ifdef CONFIG_X86 + +#include <asm/set_memory.h> + +static inline int ttm_set_page_range_wb (struct page *p,unsigned long numpages) +{ +return set_memory_wb ((unsigned long )page_address (p), numpages); +} + +#else /* for CONFIG_X86 */ + +#if IS_ENABLED (CONFIG_AGP ) + +#include <asm/agp.h> + +static inline int set_pages_array_wb (struct page **pages,int addrinarray) +{ +int i; + +for (i =0 ; i < addrinarray; i++) +unmap_page_from_agp (pages[i]); +return 0 ; +} + +static inline int set_pages_array_wc (struct page **pages,int addrinarray) +{ +int i; + +for (i =0 ; i < addrinarray; i++) +map_page_into_agp (pages[i]); +return 0 ; +} + +static inline int set_pages_array_uc (struct page **pages,int addrinarray) +{ +int i; + +for (i =0 ; i < addrinarray; i++) +map_page_into_agp (pages[i]); +return 0 ; +} + +static inline int ttm_set_page_range_wb (struct page *p,unsigned long numpages) +{ +unsigned long i; + +for (i =0 ; i < numpages; i++) +unmap_page_from_agp (p + i); +return 0 ; +} + +static inline int set_pages_wb (struct page *page,int numpages) +{ +int i; + +for (i =0 ; i < numpages; i++) +unmap_page_from_agp (page++); +return 0 ; +} + +#else /* for CONFIG_AGP */ + +static inline int set_pages_array_wb (struct page **pages,int addrinarray) +{ +return 0 ; +} + +static inline int set_pages_array_wc (struct page **pages,int addrinarray) +{ +return 0 ; +} + +static inline int set_pages_array_uc (struct page **pages,int addrinarray) +{ +return 0 ; +} + +static inline int ttm_set_page_range_wb (struct page *p,unsigned long numpages) +{ +return 0 ; +} + +static inline int set_pages_wb (struct page *page,int numpages) +{ +return 0 ; +} + +#endif /* for CONFIG_AGP */ + +#endif /* for CONFIG_X86 */ + +#endif
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1532596448-17831-3-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org
Re: [PATCH 2/5] drm/ttm: add ttm_set_memory header
Am 26.07.2018 um 11:14 schrieb Huang Rui:
Quoted 57 lines
This patch moves all non-x86 abstraction to the
ttm_set_memoryheader. It is to make function calling more clearly.Suggested-by Christian König <[email protected]>Signed-off-by Huang Rui <[email protected]>--- include/drm/ttm/ttm_set_memory.h | 127 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 127 insertions(+)create mode 100644
include/drm/ttm/ttm_set_memory.hinclude/drm/ttm/ttm_set_memory.h new file +41
-0@@ -0,0 +1,127 @@ +/************************************************************************** +* +* Copyright (c) 2018 Advanced Micro Devices, Inc. +* All Rights Reserved. +* +* Permission is hereby granted, free of charge, to any person obtaining a +* copy of this software and associated documentation files (the +* "Software"), to deal in the Software without restriction, including +* without limitation the rights to use, copy, modify, merge, publish, +* distribute, sub license, and/or sell copies of the Software, and to +* permit persons to whom the Software is furnished to do so, subject to +* the following conditions: +* +* The above copyright notice and this permission notice (including the +* next paragraph) shall be included in all copies or substantial portions +* of the Software. +* +* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +* FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL +* THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, +* DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +* OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE +* USE OR OTHER DEALINGS IN THE SOFTWARE. +* +**************************************************************************/ +/* +* Authors: Huang Rui <[email protected]> +*/ + +#ifndef TTM_SET_MEMORY +#define TTM_SET_MEMORY + +#include <linux/mm.h> + +#ifdef CONFIG_X86 + +#include <asm/set_memory.h> + +static inline int ttm_set_page_range_wb(struct page *p, unsigned long numpages) +{
include/drm/ttm/ttm_set_memory.h line 51
Quoted 10 lines
include/drm/ttm/ttm_set_memory.h new file +10
-0+ return set_memory_wb((unsigned long)page_address(p), numpages); +} + +#else /* for CONFIG_X86 */ + +#if IS_ENABLED (CONFIG_AGP ) + +#include <asm/agp.h> + +static inline int set_pages_array_wb (struct page **pages,int addrinarray)
While at it please add a ttm_ prefix to all those functions.
Additional to that you need to send TTM changes to dri-devel as well and for some reason patch #3-#5 didn't made it to the mailing list.
Christian.
Quoted 66 lines
include/drm/ttm/ttm_set_memory.h new file +66
-0+{ +int i; + +for (i =0 ; i < addrinarray; i++) +unmap_page_from_agp (pages[i]); +return 0 ; +} + +static inline int set_pages_array_wc (struct page **pages,int addrinarray) +{ +int i; + +for (i =0 ; i < addrinarray; i++) +map_page_into_agp (pages[i]); +return 0 ; +} + +static inline int set_pages_array_uc (struct page **pages,int addrinarray) +{ +int i; + +for (i =0 ; i < addrinarray; i++) +map_page_into_agp (pages[i]); +return 0 ; +} + +static inline int ttm_set_page_range_wb (struct page *p,unsigned long numpages) +{ +unsigned long i; + +for (i =0 ; i < numpages; i++) +unmap_page_from_agp (p + i); +return 0 ; +} + +static inline int set_pages_wb (struct page *page,int numpages) +{ +int i; + +for (i =0 ; i < numpages; i++) +unmap_page_from_agp (page++); +return 0 ; +} + +#else /* for CONFIG_AGP */ + +static inline int set_pages_array_wb (struct page **pages,int addrinarray) +{ +return 0 ; +} + +static inline int set_pages_array_wc (struct page **pages,int addrinarray) +{ +return 0 ; +} + +static inline int set_pages_array_uc (struct page **pages,int addrinarray) +{ +return 0 ; +} + +static inline int ttm_set_page_range_wb (struct page *p,unsigned long numpages) +{ +return 0 ; +} +
include/drm/ttm/ttm_set_memory.h line 127
Quoted 10 lines
include/drm/ttm/ttm_set_memory.h new file +10
-0+static inline int set_pages_wb (struct page *page,int numpages) +{ +return 0 ; +} + +#endif /* for CONFIG_AGP */ + +#endif /* for CONFIG_X86 */ + +#endif
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Hi Ray,
Quoted 5 lines · Huang Rui
Hi,
As suggested by Christian, we should move non-x86 definitions into one common header, and it will make the codes readable. They are based on the improvement fix of Bas (already rebase Bas's patch to drm-next).
TTM patches need to be sent to the dri-devel list as well for review.
Signature · 6 lines
Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 7f08ebdb-f42d-287f-81ec-c375ba852dc6-otUistvHUpPR7s880joybQ@public.gmane.org
Quoted 4 lines · Michel Dänzer
Hi Ray,
Quoted 9 lines
Quoted 5 lines · Huang Rui
Hi,
As suggested by Christian, we should move non-x86 definitions into one common header, and it will make the codes readable. They are based on the improvement fix of Bas (already rebase Bas's patch to drm-next).
TTM patches need to be sent to the dri-devel list as well for review.
Oh, right! Michel, thanks to reminder. I will re-send them.
Thanks,
Ray
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx