machine: remove kernel-modules from RRECOMMENDS
PATCH 1/1 machine: remove kernel-modules from RRECOMMENDS
qemumips,qemumips64 and x86 based machines include kernel-modules by default. Remove the kernel modules from RRECOMMENDS to make it consistent across the machines.
Tested using core-image-sato on qemumips, qemumips64, qemux86 and qemux86-64
[YOCTO #12383]
--- meta/conf/machine/include/x86-base.inc | 2 -- meta/conf/machine/qemumips.conf | 2 -- meta/conf/machine/qemumips64.conf | 2 -- 3 files changed, 6 deletions(-)
meta/conf/machine/include/x86-base.inc +0 -2
@@ -8,8 +8,6 @@ MACHINE_FEATURES += "screen keyboard pci usbhost ext2 ext3 x86 \ acpi serial usbgadget alsa" -MACHINE_EXTRA_RRECOMMENDS += "kernel-modules" - IMAGE_FSTYPES ?= "hddimg" KERNEL_IMAGETYPE ?= "bzImage"
meta/conf/machine/qemumips.conf +0 -2
@@ -10,5 +10,3 @@ KERNEL_IMAGETYPE = "vmlinux" KERNEL_ALT_IMAGETYPE = "vmlinux.bin" SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1" - -MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
meta/conf/machine/qemumips64.conf +0 -2
@@ -10,5 +10,3 @@ KERNEL_IMAGETYPE = "vmlinux" KERNEL_ALT_IMAGETYPE = "vmlinux.bin" SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1" - -MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
Signature · 1 line
2.4.0
Quoted 8 lines · Maxin B. John
qemumips,qemumips64 and x86 based machines include kernel-modules by default. Remove the kernel modules from RRECOMMENDS to make it consistent
across the machines.Tested using core-image-sato on qemumips, qemumips64, qemux86 and qemux86-64
Quoted 8 lines
[YOCTO #12383]
Signed-off-by Maxin B. John <[email protected]>--- meta/conf/machine/include/x86-base.inc | 2 -- meta/conf/machine/qemumips.conf | 2 -- meta/conf/machine/qemumips64.conf | 2 -- 3 files changed, 6 deletions(-)
Looks good, do we need to add this to genericx86 or anything in meta- intel given its changing x86-base.inc?
Cheers,
Richard
Quoted 18 lines · On 07/31/2018 11:22 PM, [email protected] wrote:
Quoted 8 lines · Maxin B. John
qemumips,qemumips64 and x86 based machines include kernel-modules by default. Remove the kernel modules from RRECOMMENDS to make it consistent
across the machines.Tested using core-image-sato on qemumips, qemumips64, qemux86 and qemux86-64
Quoted 8 lines
[YOCTO #12383]
Signed-off-by Maxin B. John <[email protected]>--- meta/conf/machine/include/x86-base.inc | 2 -- meta/conf/machine/qemumips.conf | 2 -- meta/conf/machine/qemumips64.conf | 2 -- 3 files changed, 6 deletions(-)
Quoted 3 lines
Looks good, do we need to add this to genericx86 or anything in meta- intel given its changing x86-base.inc?
meta-intel explicitly includes the modules so no change needed there. I have sent the patch for genericx86 where it should be included now.
Thanks,
Anuj
Hi Anuj,
Quoted 20 lines · Anuj Mittal
Quoted 18 lines · On 07/31/2018 11:22 PM, [email protected] wrote:
Quoted 16 lines · Maxin B. John
qemumips,qemumips64 and x86 based machines include kernel-modules by default. Remove the kernel modules from RRECOMMENDS to make it consistent
across the machines.Tested using core-image-sato on qemumips, qemumips64, qemux86 and qemux86-64
[YOCTO #12383]
Signed-off-by Maxin B. John <[email protected]>--- meta/conf/machine/include/x86-base.inc | 2 -- meta/conf/machine/qemumips.conf | 2 -- meta/conf/machine/qemumips64.conf | 2 -- 3 files changed, 6 deletions(-)
Quoted 6 lines
Quoted 3 lines
Looks good, do we need to add this to genericx86 or anything in meta- intel given its changing x86-base.inc?
meta-intel explicitly includes the modules so no change needed there. I have sent the patch for genericx86 where it should be included now.
Thanks, Just curious why we need to change genericx86. Do we have a list of kernel modules which are required there ?
Quoted 2 lines
Thanks,
Anuj
Best Regards,
Maxin
I believe the rationale for genericx86 is "this BSP should boot on most hardware, so build and ship all the modules".
Ross
Quoted 43 lines · Maxin B. John
Hi Anuj,
Quoted 20 lines · Anuj Mittal
Quoted 18 lines · On 07/31/2018 11:22 PM, [email protected] wrote:
Quoted 16 lines · Maxin B. John
qemumips,qemumips64 and x86 based machines include kernel-modules by default. Remove the kernel modules from RRECOMMENDS to make it consistent
across the machines.Tested using core-image-sato on qemumips, qemumips64, qemux86 and qemux86-64
[YOCTO #12383]
Signed-off-by Maxin B. John <[email protected]>--- meta/conf/machine/include/x86-base.inc | 2 -- meta/conf/machine/qemumips.conf | 2 -- meta/conf/machine/qemumips64.conf | 2 -- 3 files changed, 6 deletions(-)Quoted 6 lines
Quoted 3 lines
Looks good, do we need to add this to genericx86 or anything in meta- intel given its changing x86-base.inc?
meta-intel explicitly includes the modules so no change needed there. I have sent the patch for genericx86 where it should be included now.
Thanks, Just curious why we need to change genericx86. Do we have a list of kernel modules which are required there ?
Quoted 2 lines
Thanks,
AnujBest Regards,
Maxin
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core