libnvdimm, bus: check id immediately following ida_simple_get
PATCH 1/1 libnvdimm, bus: check id immediately following ida_simple_get
From: Ocean He <[email protected]>
The id check was not executed immediately following ida_simple_get. Just change the codes position, without function change.
--- drivers/nvdimm/bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/nvdimm/bus.c +2 -2
@@ -350,12 +350,12 @@ struct nvdimm_bus *nvdimm_bus_register(struct device *parent,INIT_LIST_HEAD (&nvdimm_bus->mapping_list);init_waitqueue_head (&nvdimm_bus->probe_wait); nvdimm_bus->id =ida_simple_get (&nd_ida,0 ,0 ,GFP_KERNEL ); -mutex_init (&nvdimm_bus->reconfig_mutex); -badrange_init (&nvdimm_bus->badrange);if (nvdimm_bus->id <0 ) {kfree (nvdimm_bus);return NULL ; } +mutex_init (&nvdimm_bus->reconfig_mutex); +badrange_init (&nvdimm_bus->badrange); nvdimm_bus->nd_desc = nd_desc; nvdimm_bus->dev.parent = parent; nvdimm_bus->dev.release = nvdimm_bus_release;
Signature · 6 lines
1.8.3.1 _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
Quoted 10 lines · Ocean He
From: Ocean He <[email protected]>
The id check was not executed immediately following
ida_simple_get. Just
change the codes position, without function change.Signed-off-by Ocean He <[email protected]>--- drivers/nvdimm/bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Looks good, feel free to add
Quoted 20 lines
drivers/nvdimm/bus.c +2
-2@@ -350,12 +350,12 @@ struct nvdimm_bus *nvdimm_bus_register(struct device *parent,INIT_LIST_HEAD (&nvdimm_bus->mapping_list);init_waitqueue_head (&nvdimm_bus->probe_wait); nvdimm_bus->id =ida_simple_get (&nd_ida,0 ,0 ,GFP_KERNEL ); -mutex_init (&nvdimm_bus->reconfig_mutex); -badrange_init (&nvdimm_bus->badrange);if (nvdimm_bus->id <0 ) {kfree (nvdimm_bus);return NULL ; } +mutex_init (&nvdimm_bus->reconfig_mutex); +badrange_init (&nvdimm_bus->badrange); nvdimm_bus->nd_desc = nd_desc; nvdimm_bus->dev.parent = parent;
Quoted 1 line
nvdimm_bus->dev.release=nvdimm_bus_release;
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
Quoted 6 lines · Ocean He
From: Ocean He <[email protected]>
The id check was not executed immediately following
ida_simple_get. Just change the codes position, without function change.Signed-off-by Ocean He <[email protected]>
Applied.
Quoted 14 lines
--- drivers/nvdimm/bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/nvdimm/bus.c +0
-1@@ -350,12 +350,12 @@ struct nvdimm_bus *nvdimm_bus_register(struct device *parent,INIT_LIST_HEAD (&nvdimm_bus->mapping_list);init_waitqueue_head (&nvdimm_bus->probe_wait); nvdimm_bus->id =ida_simple_get (&nd_ida,0 ,0 ,GFP_KERNEL ); -mutex_init (&nvdimm_bus->reconfig_mutex);
drivers/nvdimm/bus.c struct nvdimm_bus *nvdimm_bus_register(struct device *parent, · line 361
Quoted 10 lines
drivers/nvdimm/bus.c +2
-1-badrange_init (&nvdimm_bus->badrange);if (nvdimm_bus->id <0 ) {kfree (nvdimm_bus);return NULL ; } +mutex_init (&nvdimm_bus->reconfig_mutex); +badrange_init (&nvdimm_bus->badrange); nvdimm_bus->nd_desc = nd_desc; nvdimm_bus->dev.parent = parent; nvdimm_bus->dev.release = nvdimm_bus_release;
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm