Skip to contentSkip to conversation

Staging: rtl8712: rtl871x: removed unused code, to fix a coding style issue

PATCH In review Frank Werner-Krippendorf 2 participants 2 messages Aug 5, 2018 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rtl8712: rtl871x: removed unused code, to fix a coding style issue

Fixed a coding style issue.

---
 drivers/staging/rtl8712/rtl871x_event.h   | 10 +++++-----
 drivers/staging/rtl8712/rtl871x_io.h      |  2 +-
 drivers/staging/rtl8712/rtl871x_pwrctrl.h | 10 +++++-----
 drivers/staging/rtl8712/rtl871x_xmit.h    | 14 +++++++-------
 4 files changed, 18 insertions(+), 18 deletions(-)
drivers/staging/rtl8712/rtl871x_event.h +5 -5
index 5171379..2e59e8e 100644
@@ -90,13 +90,13 @@ struct event_node {
 	unsigned char *node;
 	unsigned char evt_code;
 	unsigned short evt_sz;
-	/*volatile*/ int *caller_ff_tail;
+	int *caller_ff_tail;
 	int	caller_ff_sz;
 };
 
 struct c2hevent_queue {
-	/*volatile*/ int	head;
-	/*volatile*/ int	tail;
+	int	head;
+	int	tail;
 	struct	event_node	nodes[C2HEVENT_SZ];
 	unsigned char	seq;
 };
@@ -104,8 +104,8 @@ struct c2hevent_queue {
 #define NETWORK_QUEUE_SZ	4
 
 struct network_queue {
-	/*volatile*/ int	head;
-	/*volatile*/ int	tail;
+	int	head;
+	int	tail;
 	struct wlan_bssid_ex networks[NETWORK_QUEUE_SZ];
 };
 
drivers/staging/rtl8712/rtl871x_io.h +1 -1
index dd054d7..61d9e41 100644
@@ -113,7 +113,7 @@ struct	_io_ops {
 struct io_req {
 	struct list_head list;
 	u32	addr;
-	/*volatile*/ u32	val;
+	u32	val;
 	u32	command;
 	u32	status;
 	u8	*pbuf;
drivers/staging/rtl8712/rtl871x_pwrctrl.h +5 -5
index bd2c3a2..6451beb 100644
@@ -89,14 +89,14 @@ struct reportpwrstate_parm {
 
 struct	pwrctrl_priv {
 	struct mutex mutex_lock;
-	/*volatile*/ u8 rpwm; /* requested power state for fw */
+	u8 rpwm; /* requested power state for fw */
 	/* fw current power state. updated when 1. read from HCPWM or
 	 * 2. driver lowers power level
 	 */
-	/*volatile*/ u8 cpwm;
-	/*volatile*/ u8 tog; /* toggling */
-	/*volatile*/ u8 cpwm_tog; /* toggling */
-	/*volatile*/ u8 tgt_rpwm; /* wanted power state */
+	u8 cpwm;
+	u8 tog; /* toggling */
+	u8 cpwm_tog; /* toggling */
+	u8 tgt_rpwm; /* wanted power state */
 	uint pwr_mode;
 	uint smart_ps;
 	uint alives;
drivers/staging/rtl8712/rtl871x_xmit.h +7 -7
index 4092727..aac0e14 100644
@@ -160,8 +160,8 @@ struct xmit_frame {
 	_pkt *pkt;
 	int frame_tag;
 	struct _adapter *padapter;
-	 u8 *buf_addr;
-	 struct xmit_buf *pxmitbuf;
+	u8 *buf_addr;
+	struct xmit_buf *pxmitbuf;
 	u8 *mem_addr;
 	u16 sz[8];
 	struct urb *pxmit_urb[8];
@@ -194,11 +194,11 @@ struct sta_xmit_priv {
 };
 
 struct	hw_txqueue {
-	/*volatile*/ sint	head;
-	/*volatile*/ sint	tail;
-	/*volatile*/ sint	free_sz;	/*in units of 64 bytes*/
-	/*volatile*/ sint      free_cmdsz;
-	/*volatile*/ sint	 txsz[8];
+	sint	head;
+	sint	tail;
+	sint	free_sz;	/*in units of 64 bytes*/
+	sint    free_cmdsz;
+	sint	txsz[8];
 	uint	ff_hwaddr;
 	uint	cmd_hwaddr;
 	sint	ac_tag;
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 9 lines · Frank Werner-Krippendorf

Fixed a coding style issue.

---
 drivers/staging/rtl8712/rtl871x_event.h   | 10 +++++-----
 drivers/staging/rtl8712/rtl871x_io.h      |  2 +-
 drivers/staging/rtl8712/rtl871x_pwrctrl.h | 10 +++++-----
 drivers/staging/rtl8712/rtl871x_xmit.h    | 14 +++++++-------
 4 files changed, 18 insertions(+), 18 deletions(-)

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause.

- You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot