Skip to contentSkip to conversation

drm/i915/psr: Add PSR mode/revision to debugfs

PATCH Superseded Azhar Shaikh 3 participants 4 messages Aug 8, 2018 – Aug 9, 2018

Subsystems (2)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/psr: Add PSR mode/revision to debugfs

Log the PSR mode/revision (PSR1 or PSR2) in the debugfs file i915_edp_psr_status.

---
 drivers/gpu/drm/i915/i915_debugfs.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/i915_debugfs.c +2 -0
index f9ce35da4123..d6e3830fc513 100644
@@ -2708,6 +2708,8 @@ static int i915_edp_psr_status(struct seq_file *m, void *data)
 	intel_runtime_pm_get(dev_priv);
 
 	mutex_lock(&dev_priv->psr.lock);
+	seq_printf(m, "PSR mode: %s\n",
+		       dev_priv->psr.psr2_enabled ? "PSR2" : "PSR1");
 	seq_printf(m, "Enabled: %s\n", yesno((bool)dev_priv->psr.enabled));
 	seq_printf(m, "Busy frontbuffer bits: 0x%03x\n",
 		   dev_priv->psr.busy_frontbuffer_bits);
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: Add PSR mode/revision to debugfs

== Series Details ==

== Series Details ==

Series: drm/i915/psr: Add PSR mode/revision to debugfs
URL : https://patchwork.freedesktop.org/series/47902/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
35d0453e2699 drm/i915/psr: Add PSR mode/revision to debugfs
-:21: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#21: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2712:
+	seq_printf(m, "PSR mode: %s\n",
+		       dev_priv->psr.psr2_enabled ? "PSR2" : "PSR1");

total: 0 errors, 0 warnings, 1 checks, 8 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✗ Fi.CI.BAT: failure for drm/i915/psr: Add PSR mode/revision to debugfs

In reply to Azhar Shaikh
== Series Details ==

== Series Details ==

Series: drm/i915/psr: Add PSR mode/revision to debugfs
URL : https://patchwork.freedesktop.org/series/47902/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4635 -> Patchwork_9890 =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_9890 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9890, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/47902/revisions/1/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9890:

=== IGT changes ===

    ==== Possible regressions ====

    igt@drv_selftest@live_hangcheck:
      fi-cfl-guc:         PASS -> DMESG-FAIL

== Known issues ==

Here are the changes found in Patchwork_9890 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    {igt@amdgpu/amd_prime@amd-to-i915}:
      {fi-kbl-8809g}:     NOTRUN -> FAIL (fdo#107341)

    igt@drv_module_reload@basic-reload-inject:
      fi-hsw-4770r:       PASS -> DMESG-WARN (fdo#107425)

    igt@drv_selftest@live_coherency:
      fi-gdg-551:         PASS -> DMESG-FAIL (fdo#107164)

    igt@drv_selftest@live_workarounds:
      {fi-bsw-kefka}:     PASS -> DMESG-FAIL (fdo#107292)
      fi-skl-6700hq:      PASS -> DMESG-FAIL (fdo#107292)
      fi-cnl-psr:         PASS -> DMESG-FAIL (fdo#107292)

    igt@kms_frontbuffer_tracking@basic:
      {fi-byt-clapper}:   PASS -> FAIL (fdo#103167)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      {fi-byt-clapper}:   PASS -> FAIL (fdo#107362, fdo#103191)

    
    ==== Possible fixes ====

    {igt@amdgpu/amd_basic@userptr}:
      {fi-kbl-8809g}:     INCOMPLETE (fdo#107402) -> PASS

    igt@drv_selftest@live_hangcheck:
      fi-cnl-psr:         DMESG-FAIL (fdo#106560) -> PASS
      fi-skl-guc:         DMESG-FAIL (fdo#107174) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-b:
      {fi-byt-clapper}:   FAIL (fdo#107362) -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107402 https://bugs.freedesktop.org/show_bug.cgi?id=107402
fdo#107425 https://bugs.freedesktop.org/show_bug.cgi?id=107425

== Participating hosts (50 -> 47) ==

Additional (1): fi-hsw-peppy
Missing (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u

== Build changes ==

* Linux: CI_DRM_4635 -> Patchwork_9890

CI_DRM_4635: a9f34f7e3bab765e2b1320a1b154a76be38602a7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4589: 779d2d42f9db6a2797d1ef50036af6fac4e62e73 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9890: 35d0453e2699c5e5627fee800bd3c641d928a906 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

35d0453e2699 drm/i915/psr: Add PSR mode/revision to debugfs

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9890/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#3 lore raw
In reply to Azhar Shaikh
Quoted 1 line · Azhar Shaikh

Log the PSR mode/revision (PSR1 or PSR2) in the debugfs file

This is not the revision.

Quoted 14 lines

i915_edp_psr_status.

---
 drivers/gpu/drm/i915/i915_debugfs.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/i915_debugfs.c +0 -0
index f9ce35da4123..d6e3830fc513 100644

drivers/gpu/drm/i915/i915_debugfs.c static int i915_edp_psr_status(struct seq_file · line 2714

Quoted 7 lines
drivers/gpu/drm/i915/i915_debugfs.c +2 -0
@@ -2708,6 +2708,8 @@ static int i915_edp_psr_status(struct seq_file
 *m, void *data)
 	intel_runtime_pm_get(dev_priv);
 
 	mutex_lock(&dev_priv->psr.lock);
+	seq_printf(m, "PSR mode: %s\n",
+		       dev_priv->psr.psr2_enabled ? "PSR2" :
 "PSR1");

^With alignment fixed,

drivers/gpu/drm/i915/i915_debugfs.c static int i915_edp_psr_status(struct seq_file *m, void *data) · line 2715

Quoted 4 lines
drivers/gpu/drm/i915/i915_debugfs.c +0 -0
 	seq_printf(m, "Enabled: %s\n", yesno((bool)dev_priv-
Quoted 1 line

psr.enabled));

drivers/gpu/drm/i915/i915_debugfs.c +0 -0
 	seq_printf(m, "Busy frontbuffer bits: 0x%03x\n",
 		   dev_priv->psr.busy_frontbuffer_bits);

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx