usb storage: remove inherited SCSI dependency for USB_STORAGE subentries

PATCH New Oliver Neukum 1 participant 1 message Aug 9, 2018 USB

lore

Share & tools

lore

Oliver Neukum

author

2018-08-09 08:23 UTC #0 lore raw

PATCH 2/2 usb storage: remove inherited SCSI dependency for USB_STORAGE subentries

Quoted 19 lines · Vladimir Zapolskiy

Hi Oliver,
Quoted 16 lines · Oliver Neukum
Quoted 3 lines · Vladimir Zapolskiy
Because USB_STORAGE build symbol strictly depends on SCSI build symbol, there is no need to specify it again for USB_UAS and USB_STORAGE_ENE_UB6250 build options.
[..]
Review
Quoted 6 lines
config USB_UAS
(quoted diff) +0 -1
 	tristate "USB Attached SCSI"
-	depends on SCSI
 	help
 	  The USB Attached SCSI protocol is supported by some USB
 	  storage devices.  It permits higher performance by supporting
Hi,

Quoted 5 lines

Quoted 1 line
I am sorry, but this is wrong. You can build and use UAS without
can you please elaborate what is wrong exactly.
The change is non-functional.

Hi,

as far as I can tell you are introducing an implicit dependency of CONFIG_USB_UAS on CONFIG_USB_STORAGE.
Now, firstly implicit references are bad anyway, secondly in this case it is wrong. Uas works without usb-storage.

Regards
Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html