Skip to contentSkip to conversation

usb storage: remove inherited SCSI dependency for USB_STORAGE subentries

PATCH New Oliver Neukum 1 participant 1 message Aug 9, 2018 USB

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 usb storage: remove inherited SCSI dependency for USB_STORAGE subentries

Quoted 17 lines · Greg Kroah-Hartman
Quoted 16 lines · Oliver Neukum
Quoted 3 lines · Vladimir Zapolskiy

Because USB_STORAGE build symbol strictly depends on SCSI build symbol, there is no need to specify it again for USB_UAS and USB_STORAGE_ENE_UB6250 build options.

[..]

Review

Quoted 6 lines

config USB_UAS

(quoted diff) +0 -1
 	tristate "USB Attached SCSI"
-	depends on SCSI
 	help
 	  The USB Attached SCSI protocol is supported by some USB
 	  storage devices.  It permits higher performance by supporting

Hi,

Quoted 7 lines
Quoted 4 lines

I am sorry, but this is wrong. You can build and use UAS without old style storage support. I do not recommend that you do so, but in theory it is possible.
And UAS very much depends on storage.

But today UAS depends on SCSI and USB_STORAGE, so if this is true, it's not very obvious :)

Hi,

yes, this is an issue. Nevertheless UAS depends on SCSI and this dependency better stay.

Regards
Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html