Skip to contentSkip to conversation

x86: i8259: Add missing include file

PATCH Applied Guenter Roeck 2 participants 2 messages Aug 15, 2018 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: i8259: Add missing include file

i8259.h uses inb/outb and thus needs to include asm/io.h to avoid the following build error, as seen with x86_64:defconfig and CONFIG_SMP=n.

In file included from drivers/rtc/rtc-cmos.c:45:0:
arch/x86/include/asm/i8259.h: In function 'inb_pic':
arch/x86/include/asm/i8259.h:32:24: error:
implicit declaration of function 'inb'

arch/x86/include/asm/i8259.h: In function 'outb_pic':
arch/x86/include/asm/i8259.h:45:2: error:
implicit declaration of function 'outb'

Fixes 447ae3166702 ("x86: Don't include linux/irq.h from asm/hardirq.h")

---
I have not seen a patch fly by, so here it is.

 arch/x86/include/asm/i8259.h | 1 +
 1 file changed, 1 insertion(+)
arch/x86/include/asm/i8259.h +1 -0
index 5cdcdbd4d892..89789e8c80f6 100644
@@ -3,6 +3,7 @@
 #define _ASM_X86_I8259_H
 
 #include <linux/delay.h>
+#include <asm/io.h>
 
 extern unsigned int cached_irq_mask;
 
Signature · 1 line
2.7.4
#1 lore raw
Quoted 2 lines · Guenter Roeck

I have not seen a patch fly by, so here it is.

Applied.

Linus