Skip to contentSkip to conversation

net/mlx5: fix ETH validation for GTP

PATCH Applied Lior Margalit 2 participants 2 messages Jul 20, 2021 – Jul 22, 2021 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5: fix ETH validation for GTP

The user is able to create a flow rule pattern with ETH after GTP although it is not supported by the flex-parser configuration.

Failed the rule validation in such case with proper error message.

Fixes 23c1d42c7138 ("net/mlx5: split flow validation to dedicated function")
---
 drivers/net/mlx5/mlx5_flow.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/mlx5/mlx5_flow.c +4 -0
index 347e8c1a09..69a6a5c76b 100644
@@ -1992,6 +1992,10 @@ mlx5_flow_validate_item_eth(const struct rte_flow_item *item,
 		return rte_flow_error_set(error, EINVAL,
 					  RTE_FLOW_ERROR_TYPE_ITEM, item,
 					  "L2 layer should not follow VLAN");
+	if (item_flags & MLX5_FLOW_LAYER_GTP)
+		return rte_flow_error_set(error, EINVAL,
+					  RTE_FLOW_ERROR_TYPE_ITEM, item,
+					  "L2 layer should not follow GTP");
 	if (!mask)
 		mask = &rte_flow_item_eth_mask;
 	ret = mlx5_flow_item_acceptable(item, (const uint8_t *)mask,
Signature · 1 line
2.25.1
#1 lore raw

20/07/2021 17:17, Lior Margalit:

Quoted 10 lines

The user is able to create a flow rule pattern with ETH after GTP although it is not supported by the flex-parser configuration.

Failed the rule validation in such case with proper error message.

Fixes 23c1d42c7138 ("net/mlx5: split flow validation to dedicated function")

Applied, thanks.