compat: fix symbol version support with meson
PATCH 1/1 compat: fix symbol version support with meson
For meson builds, the define to enable the symbol version macros in rte_compat.h was missing. This led to symbols being omitted from shared objects. For example, checking rte_distributor.so with objdump and comparing make and meson built versions:
$ objdump -T make-build/lib/librte_distributor.so | grep _flush 0000000000001b60 g DF .text 00000000000000a7 (DPDK_2.0) rte_distributor_flush 0000000000003f10 g DF .text 0000000000000434 DPDK_17.05 rte_distributor_flush $ objdump -T meson-build/lib/librte_distributor.so | grep _flush 0000000000001d50 g DF .text 00000000000000fb DPDK_2.0 rte_distributor_flush
Adding in the missing define fixes this.
--- config/rte_config.h | 3 +++ 1 file changed, 3 insertions(+)
config/rte_config.h +3 -0
@@ -20,6 +20,9 @@/****** library defines ********/ +/* compat defines */ +#define RTE_BUILD_SHARED_LIB +/* EAL defines */ #define RTE_MAX_MEMSEG_LISTS 128#define RTE_MAX_MEMSEG_PER_LIST 8192
Signature · 1 line
2.17.1
Quoted 35 lines · Bruce Richardson
For meson builds, the define to enable the symbol version macros in
rte_compat.hwas missing. This led to symbols being omitted from shared objects. For example, checking rte_distributor.so with objdump and comparing make and meson built versions:$ objdump -T make-build/lib/librte_distributor.so | grep _flush 0000000000001b60 g DF .text 00000000000000a7 (DPDK_2.0) rte_distributor_flush 0000000000003f10 g DF .text 0000000000000434 DPDK_17.05 rte_distributor_flush $ objdump -T meson-build/lib/librte_distributor.so | grep _flush 0000000000001d50 g DF .text 00000000000000fb DPDK_2.0 rte_distributor_flushAdding in the missing define fixes this.
Fixes 5b9656b157d3 ("lib: build with meson")Reported-by Luca Boccassi <[email protected]>Signed-off-by Bruce Richardson <[email protected]>---
config/rte_config.h | 3 +++1 file changed, 3 insertions(+)config/rte_config.h +0
-0@@ -20,6 +20,9 @@
/****** library defines ********/config/rte_config.h +3
-0+/* compat defines */ +#define RTE_BUILD_SHARED_LIB +
Quoted 3 lines
/* EAL defines */
#defineRTE_MAX_MEMSEG_LISTS128
#defineRTE_MAX_MEMSEG_PER_LIST8192
Signature · 2 lines
Kind regards, Luca Boccassi
30/08/2018 19:31, Luca Boccassi:
Quoted 15 lines · Bruce Richardson
Quoted 14 lines
For meson builds, the define to enable the symbol version macros in
rte_compat.hwas missing. This led to symbols being omitted from shared objects. For example, checking rte_distributor.so with objdump and comparing make and meson built versions:$ objdump -T make-build/lib/librte_distributor.so | grep _flush 0000000000001b60 g DF .text 00000000000000a7 (DPDK_2.0) rte_distributor_flush 0000000000003f10 g DF .text 0000000000000434 DPDK_17.05 rte_distributor_flush $ objdump -T meson-build/lib/librte_distributor.so | grep _flush 0000000000001d50 g DF .text 00000000000000fb DPDK_2.0 rte_distributor_flush
Quoted 8 lines
Quoted 6 lines
Adding in the missing define fixes this.
Fixes 5b9656b157d3 ("lib: build with meson")Reported-by Luca Boccassi <[email protected]>Signed-off-by Bruce Richardson <[email protected]>Tested-by Luca Boccassi <[email protected]>
Cc stable?
Quoted 18 lines · Thomas Monjalon
30/08/2018 19:31, Luca Boccassi:
Quoted 17 lines · Bruce Richardson
Quoted 16 lines
For meson builds, the define to enable the symbol version macros in
rte_compat.hwas missing. This led to symbols being omitted from shared objects. For example, checking rte_distributor.so with objdump and comparing make and meson built versions:$ objdump -T make-build/lib/librte_distributor.so | grep _flush 0000000000001b60 g DF .text 00000000000000a7 (DPDK_2.0) rte_distributor_flush 0000000000003f10 g DF .text 0000000000000434 DPDK_17.05 rte_distributor_flush $ objdump -T meson-build/lib/librte_distributor.so | grep _flush 0000000000001d50 g DF .text 00000000000000fb DPDK_2.0 rte_distributor_flushAdding in the missing define fixes this.
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Fixes 5b9656b157d3 ("lib: build with meson")Reported-by Luca Boccassi <[email protected]>Signed-off-by Bruce Richardson <[email protected]>Tested-by Luca Boccassi <[email protected]>Cc stable?
Yes, will add on a V2.
PATCH v2 1/1 compat: fix symbol version support with meson
In reply to Bruce RichardsonFor meson builds, the define to enable the symbol version macros in rte_compat.h was missing. This led to symbols being omitted from shared objects. For example, checking rte_distributor.so with objdump and comparing make and meson built versions:
$ objdump -T make-build/lib/librte_distributor.so | grep _flush 0000000000001b60 g DF .text 00000000000000a7 (DPDK_2.0) rte_distributor_flush 0000000000003f10 g DF .text 0000000000000434 DPDK_17.05 rte_distributor_flush $ objdump -T meson-build/lib/librte_distributor.so | grep _flush 0000000000001d50 g DF .text 00000000000000fb DPDK_2.0 rte_distributor_flush
Adding in the missing define fixes this.
--- config/rte_config.h | 3 +++ 1 file changed, 3 insertions(+)
config/rte_config.h +3 -0
@@ -20,6 +20,9 @@/****** library defines ********/ +/* compat defines */ +#define RTE_BUILD_SHARED_LIB +/* EAL defines */ #define RTE_MAX_MEMSEG_LISTS 128#define RTE_MAX_MEMSEG_PER_LIST 8192
Signature · 1 line
2.17.1
Thomas Monjalon
Applied17/09/2018 10:18, Bruce Richardson:
Quoted 11 lines
For meson builds, the define to enable the symbol version macros in
rte_compat.hwas missing. This led to symbols being omitted from shared objects. For example, checking rte_distributor.so with objdump and comparing make and meson built versions:$ objdump -T make-build/lib/librte_distributor.so | grep _flush 0000000000001b60 g DF .text 00000000000000a7 (DPDK_2.0) rte_distributor_flush 0000000000003f10 g DF .text 0000000000000434 DPDK_17.05 rte_distributor_flush $ objdump -T meson-build/lib/librte_distributor.so | grep _flush 0000000000001d50 g DF .text 00000000000000fb DPDK_2.0 rte_distributor_flush
Quoted 8 lines
Adding in the missing define fixes this.
Fixes 5b9656b157d3 ("lib: build with meson")Reported-by Luca Boccassi <[email protected]>Signed-off-by Bruce Richardson <[email protected]>Tested-by Luca Boccassi <[email protected]>
Applied, thanks