Skip to contentSkip to conversation

amdgpu: amdgpu_bo_inc_ref don't return dummy int

PATCH In review Qiang Yu 3 participants 4 messages Sep 3, 2018 3 messages not in the archive

lore
Share & tools
lore

Qiang Yu

author
#0 lore raw

PATCH 1/1 amdgpu: amdgpu_bo_inc_ref don't return dummy int

---
 amdgpu/amdgpu-symbol-check | 2 +-
 amdgpu/amdgpu.h            | 5 +----
 amdgpu/amdgpu_bo.c         | 3 +--
 3 files changed, 3 insertions(+), 7 deletions(-)
amdgpu/amdgpu-symbol-check +1 -1
index 487610e..58646e8 100755
@@ -15,8 +15,8 @@ amdgpu_bo_cpu_map
 amdgpu_bo_cpu_unmap
 amdgpu_bo_export
 amdgpu_bo_free
-amdgpu_bo_inc_ref
 amdgpu_bo_import
+amdgpu_bo_inc_ref
 amdgpu_bo_list_create
 amdgpu_bo_list_destroy
 amdgpu_bo_list_update
amdgpu/amdgpu.h +1 -4
index e1f93f8..dc51659 100644
@@ -725,13 +725,10 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle);
  *
  * \param   bo - \c [in]  Buffer object handle to increase the reference count
  *
- * \return   0 on success\n
- *          <0 - Negative POSIX Error code
- *
  * \sa amdgpu_bo_alloc(), amdgpu_bo_free()
  *
 */
-int amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
+void amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
 
 /**
  * Request CPU access to GPU accessable memory
amdgpu/amdgpu_bo.c +1 -2
index dceab01..6a95929 100644
@@ -438,10 +438,9 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle)
 	return 0;
 }
 
-int amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
+void amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
 {
 	atomic_inc(&bo->refcount);
-	return 0;
 }
 
 int amdgpu_bo_cpu_map(amdgpu_bo_handle bo, void **cpu)
Signature · 6 lines
1.9.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1535969162-28716-1-git-send-email-Qiang.Yu-5C7GfCeVMHo@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 47 lines · Qiang Yu
---
 amdgpu/amdgpu-symbol-check | 2 +-
 amdgpu/amdgpu.h            | 5 +----
 amdgpu/amdgpu_bo.c         | 3 +--
 3 files changed, 3 insertions(+), 7 deletions(-)
amdgpu/amdgpu-symbol-check +1 -1
index 487610e..58646e8 100755
@@ -15,8 +15,8 @@ amdgpu_bo_cpu_map
 amdgpu_bo_cpu_unmap
 amdgpu_bo_export
 amdgpu_bo_free
-amdgpu_bo_inc_ref
 amdgpu_bo_import
+amdgpu_bo_inc_ref
 amdgpu_bo_list_create
 amdgpu_bo_list_destroy
 amdgpu_bo_list_update
amdgpu/amdgpu.h +1 -4
index e1f93f8..dc51659 100644
@@ -725,13 +725,10 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle);
  *
  * \param   bo - \c [in]  Buffer object handle to increase the reference count
  *
- * \return   0 on success\n
- *          <0 - Negative POSIX Error code
- *
  * \sa amdgpu_bo_alloc(), amdgpu_bo_free()
  *
 */
-int amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
+void amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
 
 /**
  * Request CPU access to GPU accessable memory
amdgpu/amdgpu_bo.c +0 -0
index dceab01..6a95929 100644
@@ -438,10 +438,9 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle)
 	return 0;

amdgpu/amdgpu_bo.c int amdgpu_bo_free(amdgpu_bo_handle buf_handle) · line 446

Quoted 10 lines
amdgpu/amdgpu_bo.c +1 -2
 }
 
-int amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
+void amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
 {
 	atomic_inc(&bo->refcount);
-	return 0;
 }
 
 int amdgpu_bo_cpu_map(amdgpu_bo_handle bo, void **cpu)
Signature · 6 lines
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 387fe239-c0d6-b2c1-5f95-b49877e38852-otUistvHUpPR7s880joybQ@public.gmane.org

#4 lore raw

Am 03.09.2018 um 12:13 schrieb Michel Dänzer:

Quoted 56 lines · Qiang Yu
Quoted 55 lines
---
  amdgpu/amdgpu-symbol-check | 2 +-
  amdgpu/amdgpu.h            | 5 +----
  amdgpu/amdgpu_bo.c         | 3 +--
  3 files changed, 3 insertions(+), 7 deletions(-)
amdgpu/amdgpu-symbol-check +1 -1
index 487610e..58646e8 100755
@@ -15,8 +15,8 @@ amdgpu_bo_cpu_map
  amdgpu_bo_cpu_unmap
  amdgpu_bo_export
  amdgpu_bo_free
-amdgpu_bo_inc_ref
  amdgpu_bo_import
+amdgpu_bo_inc_ref
  amdgpu_bo_list_create
  amdgpu_bo_list_destroy
  amdgpu_bo_list_update
amdgpu/amdgpu.h +1 -4
index e1f93f8..dc51659 100644
@@ -725,13 +725,10 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle);
   *
   * \param   bo - \c [in]  Buffer object handle to increase the reference count
   *
- * \return   0 on success\n
- *          <0 - Negative POSIX Error code
- *
   * \sa amdgpu_bo_alloc(), amdgpu_bo_free()
   *
  */
-int amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
+void amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
 
  /**
   * Request CPU access to GPU accessable memory
amdgpu/amdgpu_bo.c +1 -2
index dceab01..6a95929 100644
@@ -438,10 +438,9 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle)
  	return 0;
  }
 
-int amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
+void amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
  {
  	atomic_inc(&bo->refcount);
-	return 0;
  }
 
Quoted 3 lines

amdgpu/amdgpu_bo.c int amdgpu_bo_free(amdgpu_bo_handle buf_handle) · line 446

Quoted 2 lines
amdgpu/amdgpu_bo.c +0 -0
  int amdgpu_bo_cpu_map(amdgpu_bo_handle bo, void **cpu)

Added this and my rb as well and pushed it to master repository.

BTW: In the original patch there seems to be an unrelated change:

Quoted 1 line

- * Request CPU access to GPU accessible memory

...

Quoted 1 line

+ * Request CPU access to GPU accessable memory

That doesn't looks correct to me and we should probably revert that.

Christian.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 4b37db56-172c-87e0-29f7-3e3f4dd04252-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

author
#6 lore raw

Sorry for not check this patch carefully, indeed a typo, will revert it.

Regards,
Qiang

________________________________________
From: Christian König <[email protected]>
Sent: Monday, September 3, 2018 6:40:33 PM
To: Michel Dänzer; Yu, Qiang
Cc: Zhang, Jerry; Koenig, Christian; [email protected]; Deng, Hui
Subject: Re: [PATCH libdrm] amdgpu: amdgpu_bo_inc_ref don't return dummy int

Am 03.09.2018 um 12:13 schrieb Michel Dänzer:

Quoted 56 lines · Qiang Yu
Quoted 55 lines
---
  amdgpu/amdgpu-symbol-check | 2 +-
  amdgpu/amdgpu.h            | 5 +----
  amdgpu/amdgpu_bo.c         | 3 +--
  3 files changed, 3 insertions(+), 7 deletions(-)
amdgpu/amdgpu-symbol-check +1 -1
index 487610e..58646e8 100755
@@ -15,8 +15,8 @@ amdgpu_bo_cpu_map
  amdgpu_bo_cpu_unmap
  amdgpu_bo_export
  amdgpu_bo_free
-amdgpu_bo_inc_ref
  amdgpu_bo_import
+amdgpu_bo_inc_ref
  amdgpu_bo_list_create
  amdgpu_bo_list_destroy
  amdgpu_bo_list_update
amdgpu/amdgpu.h +1 -4
index e1f93f8..dc51659 100644
@@ -725,13 +725,10 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle);
   *
   * \param   bo - \c [in]  Buffer object handle to increase the reference count
   *
- * \return   0 on success\n
- *          <0 - Negative POSIX Error code
- *
   * \sa amdgpu_bo_alloc(), amdgpu_bo_free()
   *
  */
-int amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
+void amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
 
  /**
   * Request CPU access to GPU accessable memory
amdgpu/amdgpu_bo.c +1 -2
index dceab01..6a95929 100644
@@ -438,10 +438,9 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle)
     return 0;
  }
 
-int amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
+void amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
  {
     atomic_inc(&bo->refcount);
-    return 0;
  }
 
Quoted 3 lines

amdgpu/amdgpu_bo.c int amdgpu_bo_free(amdgpu_bo_handle buf_handle) · line 446

Quoted 2 lines
amdgpu/amdgpu_bo.c +0 -0
  int amdgpu_bo_cpu_map(amdgpu_bo_handle bo, void **cpu)

Added this and my rb as well and pushed it to master repository.

BTW: In the original patch there seems to be an unrelated change:

Quoted 1 line

- * Request CPU access to GPU accessible memory

...

Quoted 1 line

+ * Request CPU access to GPU accessable memory

That doesn't looks correct to me and we should probably revert that.

Christian.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx