Skip to contentSkip to conversation

Add support to dump tx stats histogram

PATCH In review [email protected] 2 participants 7 messages Sep 4, 2018 – Sep 6, 2018 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore
#0 lore raw

v2 cover Add support to dump tx stats histogram

From: Anilkumar Kolli <[email protected]>

This patch series adds support to dump per station tx stats histogram.

These stats can be enabled through ath10k/enable_extd_tx_stats debugfs entry, enabling this may impact in cpu usage and throughput.

ath10k/enable_extd_tx_stats is disabled by default.

Tx histogram has Per station tx stats which includes,
- pkts/bytes transmitted at all possible rates(mcs/nss/bw/gi).
- ACK fails count
- ampdu bytes/pkts transmitted at all possible rates(mcs/nss/bw/gi).
- BA fails count
- tx duration

Tested on QCA9984/QCA4019/QCA988x
Firmware: 10.4-3.5.3-00057

	  10.2.4-1.0-00037

Example output format:

# cat /sys/kernel/debug/ieee80211/phy0/netdev\:wlan0/stations/8c\:
fd\:f0\:0a\:8c\:14/tx_stats

succ_pkts
VHT MCS packets
0 0 0 0 0 138 26 18 23 38747
HT MCS packets
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
BW packets (20,40,80,160 MHz)
41 337 38574 0
NSS packets (1x1,2x2,3x3,4x4)
38952 0 0 0
GI packets (LGI,SGI)
38 38914
legacy rate packets (1,2 ... Mbps)
0 0 0 0 68 0 0 0 0 0 0 0
succ_bytes
VHT MCS bytes
0 0 0 0 0 16407 3288 2360 2703 4651892
HT MCS bytes
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
BW bytes (20,40,80,160 MHz)
5163 40962 4630525 0
NSS bytes (1x1,2x2,3x3,4x4)
4676650 0 0 0
GI bytes (LGI,SGI)
4471 4672179
legacy rate bytes (1,2 ... Mbps)
0 0 0 0 3270 0 0 0 0 0 0 0
ampdu_pkts
VHT MCS packets
0 0 0 8 20 7872 34 21 33 39730
HT MCS packets
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
BW packets (20,40,80,160 MHz)
72 567 47079 0
NSS packets (1x1,2x2,3x3,4x4)
40035 7683 0 0
GI packets (LGI,SGI)
7698 40020
legacy rate packets (1,2 ... Mbps)
0 0 0 0 0 0 0 0 0 0 0 0

ampdu_bytes
VHT MCS bytes
0 0 0 896 2579 941417 4222 2666 3857 4774284
HT MCS bytes
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
BW bytes (20,40,80,160 MHz)
9262 70052 5650607 0
NSS bytes (1x1,2x2,3x3,4x4)
4811265 918656 0 0
GI bytes (LGI,SGI)
920650 4809271
legacy rate bytes (1,2 ... Mbps)
0 0 0 0 0 0 0 0 0 0 0 0
fail_pkts
VHT MCS packets
0 0 0 0 0 0 0 0 0 0
HT MCS packets
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
BW packets (20,40,80,160 MHz)
0 0 0 0
NSS packets (1x1,2x2,3x3,4x4)
0 0 0 0
GI packets (LGI,SGI)
0 0
legacy rate packets (1,2 ... Mbps)
0 0 0 0 0 0 0 0 0 0 0 0
fail_bytes
VHT MCS bytes
0 0 0 0 0 0 0 0 0 0
HT MCS bytes
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
BW bytes (20,40,80,160 MHz)
0 0 0 0
NSS bytes (1x1,2x2,3x3,4x4)
0 0 0 0
GI bytes (LGI,SGI)
0 0
legacy rate bytes (1,2 ... Mbps)
0 0 0 0 0 0 0 0 0 0 0 0
retry_pkts
VHT MCS packets
0 0 0 8 20 7734 8 3 10 983
HT MCS packets
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
BW packets (20,40,80,160 MHz)
31 230 8505 0
NSS packets (1x1,2x2,3x3,4x4)
1083 7683 0 0
GI packets (LGI,SGI)
7660 1106
legacy rate packets (1,2 ... Mbps)
0 0 0 0 0 0 0 0 0 0 0 0
retry_bytes
VHT MCS bytes
0 0 0 896 2579 925010 934 306 1154 122392
HT MCS bytes
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
BW bytes (20,40,80,160 MHz)
4099 29090 1020082 0
NSS bytes (1x1,2x2,3x3,4x4)
134615 918656 0 0
GI bytes (LGI,SGI)
916179 137092
legacy rate bytes (1,2 ... Mbps)
0 0 0 0 0 0 0 0 0 0 0 0
TX duration
6639098 usecs
BA fails
8610
ack fails
0

Anilkumar Kolli (4):
ath10k: get the legacy rate index to update the txrate table
ath10k: add debugfs entry to enable extended tx stats
ath10k: add extended per sta tx statistics support
ath10k: add debugfs support to dump per sta tx stats

 drivers/net/wireless/ath/ath10k/core.h        |   32 ++++++
 drivers/net/wireless/ath/ath10k/debug.c       |   62 +++++++++++-
 drivers/net/wireless/ath/ath10k/debug.h       |    9 ++
 drivers/net/wireless/ath/ath10k/debugfs_sta.c |  101 +++++++++++++++++++
 drivers/net/wireless/ath/ath10k/htt_rx.c      |  133 ++++++++++++++++++++++---
 drivers/net/wireless/ath/ath10k/mac.c         |   10 ++
 drivers/net/wireless/ath/ath10k/wmi.h         |   13 ++-
 7 files changed, 341 insertions(+), 19 deletions(-)
Signature · 7 lines
1.7.9.5


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#1 lore raw

PATCH v2 1/4 ath10k: get the legacy rate index to update the txrate table

From: Anilkumar Kolli <[email protected]>

Get the legacy rate index to update the pkts/bytes counter against each possible tx rate.

---
 drivers/net/wireless/ath/ath10k/htt_rx.c |   24 ++++++++++--------------
 1 file changed, 10 insertions(+), 14 deletions(-)
drivers/net/wireless/ath/ath10k/htt_rx.c +10 -14
index 4d1cd90d6d27..01eb4a7f4a69 100644
@@ -2488,7 +2488,7 @@ void ath10k_htt_htc_t2h_msg_handler(struct ath10k *ar, struct sk_buff *skb)
 		dev_kfree_skb_any(skb);
 }
 
-static inline bool is_valid_legacy_rate(u8 rate)
+static inline int ath10k_get_legacy_rate_idx(struct ath10k *ar, u8 rate)
 {
 	static const u8 legacy_rates[] = {1, 2, 5, 11, 6, 9, 12,
 					  18, 24, 36, 48, 54};
@@ -2496,10 +2496,11 @@ static inline bool is_valid_legacy_rate(u8 rate)
 
 	for (i = 0; i < ARRAY_SIZE(legacy_rates); i++) {
 		if (rate == legacy_rates[i])
-			return true;
+			return i;
 	}
 
-	return false;
+	ath10k_warn(ar, "Invalid legacy rate %hhd peer stats", rate);
+	return -EINVAL;
 }
 
 static void
@@ -2508,7 +2509,7 @@ static inline bool is_valid_legacy_rate(u8 rate)
 				struct ath10k_per_peer_tx_stats *peer_stats)
 {
 	struct ath10k_sta *arsta = (struct ath10k_sta *)sta->drv_priv;
-	u8 rate = 0, sgi;
+	u8 rate = 0, rate_idx = 0, sgi;
 	struct rate_info txrate;
 
 	lockdep_assert_held(&ar->data_lock);
@@ -2536,17 +2537,12 @@ static inline bool is_valid_legacy_rate(u8 rate)
 	if (txrate.flags == WMI_RATE_PREAMBLE_CCK ||
 	    txrate.flags == WMI_RATE_PREAMBLE_OFDM) {
 		rate = ATH10K_HW_LEGACY_RATE(peer_stats->ratecode);
-
-		if (!is_valid_legacy_rate(rate)) {
-			ath10k_warn(ar, "Invalid legacy rate %hhd peer stats",
-				    rate);
-			return;
-		}
-
 		/* This is hacky, FW sends CCK rate 5.5Mbps as 6 */
-		rate *= 10;
-		if (rate == 60 && txrate.flags == WMI_RATE_PREAMBLE_CCK)
-			rate = rate - 5;
+		if (rate == 6 && txrate.flags == WMI_RATE_PREAMBLE_CCK)
+			rate = 5;
+		rate_idx = ath10k_get_legacy_rate_idx(ar, rate);
+		if (rate_idx < 0)
+			return;
 		arsta->txrate.legacy = rate;
 	} else if (txrate.flags == WMI_RATE_PREAMBLE_HT) {
 		arsta->txrate.flags = RATE_INFO_FLAGS_MCS;
Signature · 7 lines
1.7.9.5


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#2 lore raw

Re: [PATCHv2 1/4] ath10k: get the legacy rate index to update the txrate table

Quoted 5 lines · [email protected] wrote:

Get the legacy rate index to update the pkts/bytes counter against each possible tx rate.

4 patches applied to ath-next branch of ath.git, thanks.

0189dbd71cbd ath10k: get the legacy rate index to update the txrate table 348cd95c8196 ath10k: add debugfs entry to enable extended tx stats a904417fc876 ath10k: add extended per sta tx statistics support 85dd28eb9917 ath10k: add debugfs support to dump per sta tx stats

Signature · 9 lines
https://patchwork.kernel.org/patch/10586755/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#3 lore raw

Re: [PATCHv2 1/4] ath10k: get the legacy rate index to update the txrate table

In reply to [email protected]
Quoted 5 lines · [email protected] wrote:

Get the legacy rate index to update the pkts/bytes counter against each possible tx rate.

4 patches applied to ath-next branch of ath.git, thanks.

0189dbd71cbd ath10k: get the legacy rate index to update the txrate table 348cd95c8196 ath10k: add debugfs entry to enable extended tx stats a904417fc876 ath10k: add extended per sta tx statistics support 85dd28eb9917 ath10k: add debugfs support to dump per sta tx stats

Signature · 3 lines
https://patchwork.kernel.org/patch/10586755/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#4 lore raw

PATCH v2 2/4 ath10k: add debugfs entry to enable extended tx stats

In reply to [email protected]

From: Anilkumar Kolli <[email protected]>

This patch adds debugfs entry to enable/disable extended tx statistics. Extended tx statistics are from peer stats feature.

---
V2:
- fix kbuild error: 'struct ath10k' has no member named 'debug'

 drivers/net/wireless/ath/ath10k/core.h  |    1 +
 drivers/net/wireless/ath/ath10k/debug.c |   62 ++++++++++++++++++++++++++++++-
 drivers/net/wireless/ath/ath10k/debug.h |    9 +++++
 3 files changed, 71 insertions(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/core.h +1 -0
index 9feea02e7d37..b5f6940bb102 100644
@@ -607,6 +607,7 @@ struct ath10k_debug {
 	u32 reg_addr;
 	u32 nf_cal_period;
 	void *cal_data;
+	u32 enable_extd_tx_stats;
 };
 
 enum ath10k_state {
drivers/net/wireless/ath/ath10k/debug.c +61 -1

77 lines not on this page · raw message

drivers/net/wireless/ath/ath10k/debug.h +9 -0
index 0afca5c106b6..3a6191cff2f9 100644
@@ -128,6 +128,10 @@ static inline u32 ath10k_debug_get_fw_dbglog_level(struct ath10k *ar)
 	return ar->debug.fw_dbglog_level;
 }
 
+static inline int ath10k_debug_is_extd_tx_stats_enabled(struct ath10k *ar)
+{
+	return ar->debug.enable_extd_tx_stats;
+}
 #else
 
 static inline int ath10k_debug_start(struct ath10k *ar)
@@ -190,6 +194,11 @@ static inline u32 ath10k_debug_get_fw_dbglog_level(struct ath10k *ar)
 	return 0;
 }
 
+static inline int ath10k_debug_is_extd_tx_stats_enabled(struct ath10k *ar)
+{
+	return 0;
+}
+
 #define ATH10K_DFS_STAT_INC(ar, c) do { } while (0)
 
 #define ath10k_debug_get_et_strings NULL
Signature · 7 lines
1.7.9.5


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#5 lore raw

PATCH v2 3/4 ath10k: add extended per sta tx statistics support

In reply to [email protected]

From: Anilkumar Kolli <[email protected]>

This patch adds per station tx statistics support.

Per station tx stats include
- pkts/bytes transmitted at all possible rates(mcs/nss/bw/gi).
- ACK fails count
- ampdu bytes/pkts transmitted at all possible rates(mcs/nss/bw/gi).
- BA fails count

Tested on QCA9984/QCA4019/QCA988x
Firmware: 10.4-3.5.3-00057

	  10.2.4-1.0-00037

---
V2:
- Fix kbuild error, error: 'struct ath10k' has no member named 'debug'
- Addressed the Macro changes, ATH10K_ prefix (kvalo)

 drivers/net/wireless/ath/ath10k/core.h   |   31 +++++++++
 drivers/net/wireless/ath/ath10k/htt_rx.c |  109 ++++++++++++++++++++++++++++++
 drivers/net/wireless/ath/ath10k/mac.c    |   10 +++
 drivers/net/wireless/ath/ath10k/wmi.h    |   13 ++--
 4 files changed, 159 insertions(+), 4 deletions(-)
drivers/net/wireless/ath/ath10k/core.h +31 -0
index b5f6940bb102..2266c49444f3 100644
@@ -461,6 +461,36 @@ struct ath10k_sta_tid_stats {
 	unsigned long int rx_pkt_amsdu[ATH10K_AMSDU_SUBFRM_NUM_MAX];
 };
 
+enum ath10k_counter_type {
+	ATH10K_COUNTER_TYPE_BYTES,
+	ATH10K_COUNTER_TYPE_PKTS,
+	ATH10K_COUNTER_TYPE_MAX,
+};
+
+enum ath10k_stats_type {
+	ATH10K_STATS_TYPE_SUCC,
+	ATH10K_STATS_TYPE_FAIL,
+	ATH10K_STATS_TYPE_RETRY,
+	ATH10K_STATS_TYPE_AMPDU,
+	ATH10K_STATS_TYPE_MAX,
+};
+
+struct ath10k_htt_data_stats {
+	u64 legacy[ATH10K_COUNTER_TYPE_MAX][ATH10K_LEGACY_NUM];
+	u64 ht[ATH10K_COUNTER_TYPE_MAX][ATH10K_HT_MCS_NUM];
+	u64 vht[ATH10K_COUNTER_TYPE_MAX][ATH10K_VHT_MCS_NUM];
+	u64 bw[ATH10K_COUNTER_TYPE_MAX][ATH10K_BW_NUM];
+	u64 nss[ATH10K_COUNTER_TYPE_MAX][ATH10K_NSS_NUM];
+	u64 gi[ATH10K_COUNTER_TYPE_MAX][ATH10K_GI_NUM];
+};
+
+struct ath10k_htt_tx_stats {
+	struct ath10k_htt_data_stats stats[ATH10K_STATS_TYPE_MAX];
+	u64 tx_duration;
+	u64 ba_fails;
+	u64 ack_fails;
+};
+
 struct ath10k_sta {
 	struct ath10k_vif *arvif;
 
@@ -474,6 +504,7 @@ struct ath10k_sta {
 
 	struct work_struct update_wk;
 	u64 rx_duration;
+	struct ath10k_htt_tx_stats *tx_stats;
 
 #ifdef CONFIG_MAC80211_DEBUGFS
 	/* protected by conf_mutex */
drivers/net/wireless/ath/ath10k/htt_rx.c +109 -0

121 lines not on this page · raw message

drivers/net/wireless/ath/ath10k/mac.c +10 -0
index 90f9372dec25..5ae7913c9f03 100644
@@ -6243,6 +6243,13 @@ static int ath10k_sta_state(struct ieee80211_hw *hw,
 			   ar->num_stations + 1, ar->max_num_stations,
 			   ar->num_peers + 1, ar->max_num_peers);
 
+		if (ath10k_debug_is_extd_tx_stats_enabled(ar)) {
+			arsta->tx_stats = kzalloc(sizeof(*arsta->tx_stats),
+						  GFP_KERNEL);
+			if (!arsta->tx_stats)
+				goto exit;
+		}
+
 		num_tdls_stations = ath10k_mac_tdls_vif_stations_count(hw, vif);
 		num_tdls_vifs = ath10k_mac_tdls_vifs_count(hw);
 
@@ -6328,6 +6335,9 @@ static int ath10k_sta_state(struct ieee80211_hw *hw,
 			   "mac vdev %d peer delete %pM sta %pK (sta gone)\n",
 			   arvif->vdev_id, sta->addr, sta);
 
+		if (ath10k_debug_is_extd_tx_stats_enabled(ar))
+			kfree(arsta->tx_stats);
+
 		if (sta->tdls) {
 			ret = ath10k_mac_tdls_peer_update(ar, arvif->vdev_id,
 							  sta,
drivers/net/wireless/ath/ath10k/wmi.h +9 -4
index 36220258e3c7..9d0ef34381d5 100644
@@ -4958,10 +4958,15 @@ enum wmi_rate_preamble {
 #define ATH10K_HW_GI(flags)		(((flags) >> 5) & 0x1)
 #define ATH10K_HW_RATECODE(rate, nss, preamble) \
 	(((preamble) << 6) | ((nss) << 4) | (rate))
-
-#define VHT_MCS_NUM     10
-#define VHT_BW_NUM      4
-#define VHT_NSS_NUM     4
+#define ATH10K_HW_AMPDU(flags)		((flags) & 0x1)
+#define ATH10K_HW_BA_FAIL(flags)	(((flags) >> 1) & 0x3)
+
+#define ATH10K_VHT_MCS_NUM	10
+#define ATH10K_BW_NUM		4
+#define ATH10K_NSS_NUM		4
+#define ATH10K_LEGACY_NUM	12
+#define ATH10K_GI_NUM		2
+#define ATH10K_HT_MCS_NUM	32
 
 /* Value to disable fixed rate setting */
 #define WMI_FIXED_RATE_NONE    (0xff)
Signature · 7 lines
1.7.9.5


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#6 lore raw

PATCH v2 4/4 ath10k: add debugfs support to dump per sta tx stats

In reply to [email protected]

From: Anilkumar Kolli <[email protected]>

This patch adds 'tx_stats' in per station debugfs entry.

Use this command to dump tx_stats:
cat /sys/kernel/debug/ieee80211/phy0/netdev\:wlan0/
stations/<MACADDR>/tx_stats

---
V2:
- Fix kbuild, warning: the frame size of 1088 bytes is larger than 1024 bytes [-Wframe-larger-than=]

 drivers/net/wireless/ath/ath10k/debugfs_sta.c |  101 +++++++++++++++++++++++++
 1 file changed, 101 insertions(+)
drivers/net/wireless/ath/ath10k/debugfs_sta.c +101 -0
index a63c97e2c50c..929f2f66fdce 100644
@@ -626,9 +626,105 @@ static ssize_t ath10k_dbg_sta_read_tid_stats(struct file *file,
 	.llseek = default_llseek,
 };
 
+static ssize_t ath10k_dbg_sta_dump_tx_stats(struct file *file,
+					    char __user *user_buf,
+					    size_t count, loff_t *ppos)
+{
+	struct ieee80211_sta *sta = file->private_data;
+	struct ath10k_sta *arsta = (struct ath10k_sta *)sta->drv_priv;
+	struct ath10k *ar = arsta->arvif->ar;
+	struct ath10k_htt_data_stats *stats;
+	const char *str_name[ATH10K_STATS_TYPE_MAX] = {"succ", "fail",
+						       "retry", "ampdu"};
+	const char *str[ATH10K_COUNTER_TYPE_MAX] = {"bytes", "packets"};
+	int len = 0, i, j, k, retval = 0;
+	const int size = 2 * 4096;
+	char *buf;
+
+	buf = kzalloc(size, GFP_KERNEL);
+	if (!buf)
+		return -ENOMEM;
+
+	mutex_lock(&ar->conf_mutex);
+
+	spin_lock_bh(&ar->data_lock);
+	for (k = 0; k < ATH10K_STATS_TYPE_MAX; k++) {
+		for (j = 0; j < ATH10K_COUNTER_TYPE_MAX; j++) {
+			stats = &arsta->tx_stats->stats[k];
+			len += scnprintf(buf + len, size - len, "%s_%s\n",
+					 str_name[k],
+					 str[j]);
+			len += scnprintf(buf + len, size - len,
+					 " VHT MCS %s\n",
+					 str[j]);
+			for (i = 0; i < ATH10K_VHT_MCS_NUM; i++)
+				len += scnprintf(buf + len, size - len,
+						 "  %llu ",
+						 stats->vht[j][i]);
+			len += scnprintf(buf + len, size - len, "\n");
+			len += scnprintf(buf + len, size - len, " HT MCS %s\n",
+					 str[j]);
+			for (i = 0; i < ATH10K_HT_MCS_NUM; i++)
+				len += scnprintf(buf + len, size - len,
+						 "  %llu ", stats->ht[j][i]);
+			len += scnprintf(buf + len, size - len, "\n");
+			len += scnprintf(buf + len, size - len,
+					" BW %s (20,40,80,160 MHz)\n", str[j]);
+			len += scnprintf(buf + len, size - len,
+					 "  %llu %llu %llu %llu\n",
+					 stats->bw[j][0], stats->bw[j][1],
+					 stats->bw[j][2], stats->bw[j][3]);
+			len += scnprintf(buf + len, size - len,
+					 " NSS %s (1x1,2x2,3x3,4x4)\n", str[j]);
+			len += scnprintf(buf + len, size - len,
+					 "  %llu %llu %llu %llu\n",
+					 stats->nss[j][0], stats->nss[j][1],
+					 stats->nss[j][2], stats->nss[j][3]);
+			len += scnprintf(buf + len, size - len,
+					 " GI %s (LGI,SGI)\n",
+					 str[j]);
+			len += scnprintf(buf + len, size - len, "  %llu %llu\n",
+					 stats->gi[j][0], stats->gi[j][1]);
+			len += scnprintf(buf + len, size - len,
+					 " legacy rate %s (1,2 ... Mbps)\n  ",
+					 str[j]);
+			for (i = 0; i < ATH10K_LEGACY_NUM; i++)
+				len += scnprintf(buf + len, size - len, "%llu ",
+						 stats->legacy[j][i]);
+			len += scnprintf(buf + len, size - len, "\n");
+		}
+	}
+
+	len += scnprintf(buf + len, size - len,
+			 "\nTX duration\n %llu usecs\n",
+			 arsta->tx_stats->tx_duration);
+	len += scnprintf(buf + len, size - len,
+			"BA fails\n %llu\n", arsta->tx_stats->ba_fails);
+	len += scnprintf(buf + len, size - len,
+			"ack fails\n %llu\n", arsta->tx_stats->ack_fails);
+	spin_unlock_bh(&ar->data_lock);
+
+	if (len > size)
+		len = size;
+	retval = simple_read_from_buffer(user_buf, count, ppos, buf, len);
+	kfree(buf);
+
+	mutex_unlock(&ar->conf_mutex);
+	return retval;
+}
+
+static const struct file_operations fops_tx_stats = {
+	.read = ath10k_dbg_sta_dump_tx_stats,
+	.open = simple_open,
+	.owner = THIS_MODULE,
+	.llseek = default_llseek,
+};
+
 void ath10k_sta_add_debugfs(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
 			    struct ieee80211_sta *sta, struct dentry *dir)
 {
+	struct ath10k *ar = hw->priv;
+
 	debugfs_create_file("aggr_mode", 0644, dir, sta, &fops_aggr_mode);
 	debugfs_create_file("addba", 0200, dir, sta, &fops_addba);
 	debugfs_create_file("addba_resp", 0200, dir, sta, &fops_addba_resp);
@@ -637,4 +733,9 @@ void ath10k_sta_add_debugfs(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
 			    &fops_peer_debug_trigger);
 	debugfs_create_file("dump_tid_stats", 0400, dir, sta,
 			    &fops_tid_stats_dump);
+
+	if (ath10k_peer_stats_enabled(ar) &&
+	    ath10k_debug_is_extd_tx_stats_enabled(ar))
+		debugfs_create_file("tx_stats", 0400, dir, sta,
+				    &fops_tx_stats);
 }
Signature · 7 lines
1.7.9.5


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k