ixgbevf: fix msglen for ipsec mbx messages
Subsystems (2)
PATCH 1/1 ixgbevf: fix msglen for ipsec mbx messages
Don't be fancy with message lengths, just set lengths to number of dwords, not bytes.
Fixes 0062e7cc955e ("ixgbevf: add VF IPsec offload code")
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Shannon Nelson <[email protected]>
--- drivers/net/ethernet/intel/ixgbevf/ipsec.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
drivers/net/ethernet/intel/ixgbevf/ipsec.c +4 -7
@@ -21,7 +21,6 @@ static int ixgbevf_ipsec_set_pf_sa(struct ixgbevf_adapter *adapter,u32 msgbuf[IXGBE_VFMAILBOX_SIZE ] = {0 };struct ixgbe_hw *hw = &adapter->hw;struct sa_mbx_msg *sam; -u16 msglen;int ret;/* send the important bits to the PF */
@@ -38,16 +37,14 @@ static int ixgbevf_ipsec_set_pf_sa(struct ixgbevf_adapter *adapter,memcpy (sam->key, xs->aead->alg_key,sizeof (sam->key)); msgbuf[0 ] =IXGBE_VF_IPSEC_ADD ; - msglen =sizeof (*sam) +sizeof (msgbuf[0 ]);spin_lock_bh (&adapter->mbx_lock); - ret = hw->mbx.ops.write_posted (hw, msgbuf, msglen); + ret = hw->mbx.ops.write_posted (hw, msgbuf,IXGBE_VFMAILBOX_SIZE );if (ret) goto out; - msglen =sizeof (msgbuf[0 ]) *2 ; - ret = hw->mbx.ops.read_posted (hw, msgbuf, msglen); + ret = hw->mbx.ops.read_posted (hw, msgbuf,2 );if (ret) goto out;
@@ -80,11 +77,11 @@ static int ixgbevf_ipsec_del_pf_sa(struct ixgbevf_adapter *adapter, int pfsa)spin_lock_bh (&adapter->mbx_lock); - err = hw->mbx.ops.write_posted (hw, msgbuf,sizeof (msgbuf)); + err = hw->mbx.ops.write_posted (hw, msgbuf,2 );if (err) goto out; - err = hw->mbx.ops.read_posted (hw, msgbuf,sizeof (msgbuf)); + err = hw->mbx.ops.read_posted (hw, msgbuf,2 );if (err) goto out;
Signature · 1 line
2.7.4
Bowers
PATCH 1/1 ixgbevf: fix msglen for ipsec mbx messages
Quoted 13 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Shannon Nelson
Sent: Tuesday, September 4, 2018 12:33 PM
To: intel-wired-lan at lists.osuosl.org; Kirsher, Jeffrey T <[email protected]>
Cc: dan.carpenter at oracle.com
Subject: [Intel-wired-lan] [PATCH next-queue] ixgbevf: fix msglen for ipsec mbx messagesDon't be fancy with message lengths, just set lengths to number of dwords, not bytes.
Quoted 6 lines
Fixes 0062e7cc955e ("ixgbevf: add VF IPsec offload code")Reported-by Dan Carpenter <[email protected]>Signed-off-by Shannon Nelson <[email protected]>--- drivers/net/ethernet/intel/ixgbevf/ipsec.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
Tested-by Andrew Bowers <[email protected]>