Skip to contentSkip to conversation

patch "usb: Don't die twice if PCI xhci host is not responding in resume" added to usb-linus

PATCH [email protected] 1 participant 1 message Sep 5, 2018

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

usb: Don't die twice if PCI xhci host is not responding in resume

to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.

If you have any questions about this process, please let me know.

Quoted 1 line

From f3dc41c5d22b2ca14a0802a65d8cdc33a3882d4e Mon Sep 17 00:00:00 2001

From: Mathias Nyman <[email protected]>
Date: Tue, 4 Sep 2018 17:35:16 +0300
Subject: usb: Don't die twice if PCI xhci host is not responding in resume

usb_hc_died() should only be called once, and with the primary HCD as parameter. It will mark both primary and secondary hcd's dead.

Remove the extra call to usb_cd_died with the shared hcd as parameter.

Fixes ff9d78b36f76 ("USB: Set usb_hcd->state and flags for shared roothubs")
Cc stable <[email protected]>
---
 drivers/usb/core/hcd-pci.c | 2 --
 1 file changed, 2 deletions(-)
drivers/usb/core/hcd-pci.c +0 -2
index 66fe1b78d952..03432467b05f 100644
@@ -515,8 +515,6 @@ static int resume_common(struct device *dev, int event)
 				event == PM_EVENT_RESTORE);
 		if (retval) {
 			dev_err(dev, "PCI post-resume error %d!\n", retval);
-			if (hcd->shared_hcd)
-				usb_hc_died(hcd->shared_hcd);
 			usb_hc_died(hcd);
 		}
 	}
Signature · 1 line
2.18.0