ath10k: Fix tx status flag setting for management frames
PATCH v2 1/1 ath10k: Fix tx status flag setting for management frames
The tx_status for management frames is being filled incorrectly in the flags of skb_cb. This incorrect flag setting causes the upper layers to consider that the particular frame was not transmitted properly, leading to improper behavior.
Set the IEEE80211_TX_STAT_ACK flag in the info flags of skb_cb, to indicate the successful transmission of the management frame.
Tested HW: WCN3990
Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1
--- drivers/net/wireless/ath/ath10k/wmi.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/wmi.c +6 -1
@@ -2336,7 +2336,12 @@ static int wmi_process_mgmt_tx_comp(struct ath10k *ar, u32 desc_id,dma_unmap_single (ar->dev, pkt_addr->paddr, msdu->len,DMA_FROM_DEVICE ); info =IEEE80211_SKB_CB (msdu); - info->flags |= status; + +if (status) + info->flags &= ~IEEE80211_TX_STAT_ACK ; +else + info->flags |=IEEE80211_TX_STAT_ACK ; +ieee80211_tx_status_irqsafe (ar->hw, msdu); ret =0 ;
Signature · 7 lines
2.7.4 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 10 lines · Rakesh Pillai
The
tx_statusfor management frames is being filled incorrectly in the flags ofskb_cb. This incorrect flag setting causes the upper layers to consider that the particular frame was not transmitted properly, leading to improper behavior.Set the
IEEE80211_TX_STAT_ACKflag in the info flags ofskb_cb, to indicate the successful transmission of the management frame.
Quoted 6 lines
Tested HW: WCN3990
Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1Fixes dc405152bb64d4ae01c9ac669de25b2d1fb6fc2dSigned-off-by Rakesh Pillai <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
058a7eab9d9e ath10k: fix tx status flag setting for management frames
Signature · 3 lines
https://patchwork.kernel.org/patch/10590621/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 10 lines · Rakesh Pillai
The
tx_statusfor management frames is being filled incorrectly in the flags ofskb_cb. This incorrect flag setting causes the upper layers to consider that the particular frame was not transmitted properly, leading to improper behavior.Set the
IEEE80211_TX_STAT_ACKflag in the info flags ofskb_cb, to indicate the successful transmission of the management frame.
Quoted 6 lines
Tested HW: WCN3990
Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1Fixes dc405152bb64d4ae01c9ac669de25b2d1fb6fc2dSigned-off-by Rakesh Pillai <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
058a7eab9d9e ath10k: fix tx status flag setting for management frames
Signature · 9 lines
https://patchwork.kernel.org/patch/10590621/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k