Skip to contentSkip to conversation

ARM: qcom_defconfig: Enable MAILBOX

PATCH In review [email protected] 2 participants 2 messages Sep 7, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: qcom_defconfig: Enable MAILBOX

From: Frank Rowand <[email protected]>

Problem:
ab460a2e72da ("rpmsg: qcom_smd: Access APCS through mailbox framework" added a "depends on MAILBOX") to RPMSG_QCOM_SMD, thus RPMSG_QCOM_SMD becomes unset since MAILBOX was not enabled in qcom_defconfig and is not otherwise selected for the dragonboard. When the resulting kernel is booted the mmc device which contains the root file system is not available.

Fix:
add CONFIG_MAILBOX to qcom_defconfig

Fixes ab460a2e72da ("rpmsg: qcom_smd: Access APCS through mailbox framework"

added a "depends on MAILBOX")

---

Bjorn suggested that multi_v7_defconfig might need this same fix but I don't have a target to test on so I have not included that change in this patch

Tested on Qualcomm APQ8074 Dragonboard

 arch/arm/configs/qcom_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/qcom_defconfig +1 -0
index 6aa7046fb91f..bd6440f23493 100644
@@ -207,6 +207,7 @@ CONFIG_MSM_MMCC_8974=y
 CONFIG_MSM_IOMMU=y
 CONFIG_HWSPINLOCK=y
 CONFIG_HWSPINLOCK_QCOM=y
+CONFIG_MAILBOX=y
 CONFIG_REMOTEPROC=y
 CONFIG_QCOM_ADSP_PIL=y
 CONFIG_QCOM_Q6V5_PIL=y
Signature · 1 line
Frank Rowand <[email protected]>
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · On Thu 06 Sep 21:44 PDT 2018, [email protected] wrote:

From: Frank Rowand <[email protected]>

Problem:
ab460a2e72da ("rpmsg: qcom_smd: Access APCS through mailbox framework" added a "depends on MAILBOX") to RPMSG_QCOM_SMD, thus RPMSG_QCOM_SMD becomes unset since MAILBOX was not enabled in qcom_defconfig and is not otherwise selected for the dragonboard. When the resulting kernel is booted the mmc device which contains the root file system is not available.

Quoted 7 lines

Fix:
add CONFIG_MAILBOX to qcom_defconfig

Fixes ab460a2e72da ("rpmsg: qcom_smd: Access APCS through mailbox framework"

added a "depends on MAILBOX")

Quoted 6 lines

---

Bjorn suggested that multi_v7_defconfig might need this same fix but I don't have a target to test on so I have not included that change in this patch

multi_v7_defconfig should boot on 8974 as well, but I would not be a surprise if there are other things missing there.

Regards,
Bjorn

Quoted 20 lines

Tested on Qualcomm APQ8074 Dragonboard

 arch/arm/configs/qcom_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/qcom_defconfig +1 -0
index 6aa7046fb91f..bd6440f23493 100644
@@ -207,6 +207,7 @@ CONFIG_MSM_MMCC_8974=y
 CONFIG_MSM_IOMMU=y
 CONFIG_HWSPINLOCK=y
 CONFIG_HWSPINLOCK_QCOM=y
+CONFIG_MAILBOX=y
 CONFIG_REMOTEPROC=y
 CONFIG_QCOM_ADSP_PIL=y
 CONFIG_QCOM_Q6V5_PIL=y
Signature · 1 line
Frank Rowand <[email protected]>