Skip to contentSkip to conversation

dmaengine: imx-sdma: implement channel termination via worker

PATCH New Lucas Stach 1 participant 1 message Sep 12, 2018 dmaengine

lore
Share & tools
lore
#0 lore raw

PATCH 3/4 dmaengine: imx-sdma: implement channel termination via worker

Hi Robin,

Am Dienstag, den 11.09.2018, 08:18 +0000 schrieb Robin Gong:

Quoted 3 lines

Hi Lucas,
I have quick test for UART, seems this patch set broke uart function on i.mx7d,
I believe it should be same on other i.mx6 family. Could you double check it?

Can you describe your testcase and the issue you've seen in more detail? I'm running this patch series on a system that does a lot of communication with an UART attached Co-processor and I'm not seeing any issues.

Regards,
Lucas

Quoted 98 lines
Quoted 98 lines

-----Original Message-----
From: Lucas Stach <[email protected]>
Sent: 2018年9月10日 17:59
To: Robin Gong <[email protected]>; Vinod Koul <[email protected]>
Cc: [email protected]; dl-linux-imx <[email protected]>; [email protected]; [email protected]
Subject: Re: [PATCH 3/4] dmaengine: imx-sdma: implement channel termination via worker

Am Dienstag, den 04.09.2018, 02:36 +0000 schrieb Robin Gong:

Quoted 71 lines
Quoted 63 lines

-----Original Message-----
From: Lucas Stach <[email protected]>
Sent: 2018年9月3日 21:12
To: Robin Gong <[email protected]>; Vinod Koul <[email protected] rg>
Cc: [email protected]; dl-linux-imx <[email protected]> ;
[email protected]; [email protected]
Subject: Re: [PATCH 3/4] dmaengine: imx-sdma: implement channel termination via worker

Am Montag, den 03.09.2018, 08:59 +0000 schrieb Robin Gong:

Quoted 45 lines
Quoted 45 lines

-----Original Message-----
From: Lucas Stach <[email protected]>
Sent: 2018年9月3日 16:41
To: Robin Gong <[email protected]>; Vinod Koul <vkoul@kern el.o
rg>
Cc: [email protected]; dl-linux-imx <linux-imx@nxp. com>
; [email protected]; [email protected]
Subject: Re: [PATCH 3/4] dmaengine: imx-sdma: implement channel
termination via worker

Hi Robin,

Am Freitag, den 31.08.2018, 09:49 +0000 schrieb Robin Gong:

Quoted 5 lines

Hi Lucas,
Seems I miss your previous mail. Thanks for your patch,
but
if move most jobs of sdma_disable_channel_with_delay() into

Quoted 8 lines

worker, that will bring another race condition that upper driver such as Audio terminate channel and free resource of
dma channel without really channel stop, if dma transfer done
interrupt come after that, oops or kernel cash may be caught.
Leave 'sdmac->desc = NULL' in the

sdma_disable_channel_with_delay() may fix such potential issue.

No, there is no such issue. The audio channel terminate will
call dmaengine_terminate_sync(), which internally calls dmaengine_terminate_async() and then does a dmaengine_synchronize().
As this patchset implements the device_synchronize function in
the sdma driver, this will wait for the worker to finish its
execution, so there is no race condition to worry about here.

Quoted 5 lines
Quoted 2 lines

Regards,
Lucas

Yes, but how about other drivers which not call
dmaengine_terminate_sync()?

Quoted 7 lines

Please read the dmaengine documentation. device_terminate_all has no
requirement that the transfer is actually canceled when the call
returns. If the caller needs a guarantee that the channel is stopped
it _must_ call device_synchronize.

Quoted 4 lines

I know that, but the fact is some driver still use dmaengine_terminate_all() such as
Spi/uart driver.  My concern is how to avoid to break their function.

They should simply be fixed to not use a deprecated function. Both of those are
only using device_terminate_all in error or shutdown paths, so the risk of races
is pretty minimal even with the current code. And I think the SPI driver is trivial
to fix, as we can just use the terminate_sync variant  there. The UART driver
is a bit more tricky.

Regards,
Lucas