Skip to contentSkip to conversation

net: ethernet: ti: add missing GENERIC_ALLOCATOR dependency

PATCH Applied Corentin Labbe 2 participants 2 messages Sep 14, 2018 – Sep 17, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: ethernet: ti: add missing GENERIC_ALLOCATOR dependency

This patch mades TI_DAVINCI_CPDMA select GENERIC_ALLOCATOR. without that, the following sparc64 build failure happen

drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_check_free_tx_desc':
(.text+0x278): undefined reference to gen_pool_avail' drivers/net/ethernet/ti/davinci_cpdma.o: In function cpdma_chan_submit':
(.text+0x340): undefined reference to `gen_pool_alloc'
(.text+0x5c4): undefined reference to gen_pool_free' drivers/net/ethernet/ti/davinci_cpdma.o: In function __cpdma_chan_free':
davinci_cpdma.c:(.text+0x64c): undefined reference to gen_pool_free' drivers/net/ethernet/ti/davinci_cpdma.o: In function cpdma_desc_pool_destroy.isra.6':
davinci_cpdma.c:(.text+0x17ac): undefined reference to gen_pool_size' davinci_cpdma.c:(.text+0x17b8): undefined reference to gen_pool_avail' davinci_cpdma.c:(.text+0x1824): undefined reference to gen_pool_size' davinci_cpdma.c:(.text+0x1830): undefined reference to gen_pool_avail' drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_ctlr_create':
(.text+0x19f8): undefined reference to devm_gen_pool_create' (.text+0x1a90): undefined reference to gen_pool_add_virt' Makefile:1011: recipe for target 'vmlinux' failed

---
 drivers/net/ethernet/ti/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/ti/Kconfig +1 -0
index 9263d63..f932923 100644
@@ -41,6 +41,7 @@ config TI_DAVINCI_MDIO
 config TI_DAVINCI_CPDMA
 	tristate "TI DaVinci CPDMA Support"
 	depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST
+	select GENERIC_ALLOCATOR
 	---help---
 	  This driver supports TI's DaVinci CPDMA dma engine.
 
Signature · 1 line
2.7.4
maintainer Applied
#1 lore raw

From: Corentin Labbe <[email protected]>
Date: Fri, 14 Sep 2018 11:20:07 +0000

Quoted 20 lines

This patch mades TI_DAVINCI_CPDMA select GENERIC_ALLOCATOR. without that, the following sparc64 build failure happen

drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_check_free_tx_desc':
(.text+0x278): undefined reference to gen_pool_avail' drivers/net/ethernet/ti/davinci_cpdma.o: In function cpdma_chan_submit':
(.text+0x340): undefined reference to `gen_pool_alloc'
(.text+0x5c4): undefined reference to gen_pool_free' drivers/net/ethernet/ti/davinci_cpdma.o: In function __cpdma_chan_free':
davinci_cpdma.c:(.text+0x64c): undefined reference to gen_pool_free' drivers/net/ethernet/ti/davinci_cpdma.o: In function cpdma_desc_pool_destroy.isra.6':
davinci_cpdma.c:(.text+0x17ac): undefined reference to gen_pool_size' davinci_cpdma.c:(.text+0x17b8): undefined reference to gen_pool_avail' davinci_cpdma.c:(.text+0x1824): undefined reference to gen_pool_size' davinci_cpdma.c:(.text+0x1830): undefined reference to gen_pool_avail' drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_ctlr_create':
(.text+0x19f8): undefined reference to devm_gen_pool_create' (.text+0x1a90): undefined reference to gen_pool_add_virt' Makefile:1011: recipe for target 'vmlinux' failed

Quoted 1 line

Applied.