Skip to contentSkip to conversation

colibri_imx7: Do not hardcode the memory size

RFC In review Fabio Estevam 2 participants 3 messages Sep 17, 2018 – Sep 19, 2018 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

RFC 1/1 colibri_imx7: Do not hardcode the memory size

Instead of hardcoding the memory size, use the generic imx_ddr_size() function, which extracts the memory size in runtime by reading the DDR controller registers.

This helps in supporting 512MB and 1GB modules.

---
Hi Stefan,

I don't have the hardware to test, but I think we should be good by using imx_ddr_size() here.

 board/toradex/colibri_imx7/colibri_imx7.c | 2 +-
 include/configs/colibri_imx7.h            | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
board/toradex/colibri_imx7/colibri_imx7.c +1 -1
index 2b7591e..9029c0b 100644
@@ -52,7 +52,7 @@ DECLARE_GLOBAL_DATA_PTR;
 
 int dram_init(void)
 {
-	gd->ram_size = get_ram_size((void *)PHYS_SDRAM, PHYS_SDRAM_SIZE);
+	gd->ram_size = imx_ddr_size();
 
 	return 0;
 }
include/configs/colibri_imx7.h +0 -1
index ff6bd67..02849ba 100644
@@ -14,7 +14,6 @@
 #include "mx7_common.h"
 
 /*#define CONFIG_DBG_MONITOR*/
-#define PHYS_SDRAM_SIZE			SZ_1G
 
 /* Size of malloc() pool */
 #define CONFIG_SYS_MALLOC_LEN		(32 * SZ_1M)
Signature · 1 line
2.7.4
#1 lore raw

Hi Fabio

Stefan is currently at Linaro Connect and may not have access to hardware.

Quoted 3 lines · Fabio Estevam

Instead of hardcoding the memory size, use the generic imx_ddr_size() function, which extracts the memory size in runtime by reading the DDR controller registers.

In theory that sounds fine. However, in practise that function seems to return zero on our modules which leads to it freezing during boot.

I am currently looking more closely into it and will keep you posted.

Quoted 19 lines

This helps in supporting 512MB and 1GB modules.

---
Hi Stefan,

I don't have the hardware to test, but I think we should be good by using imx_ddr_size() here.

 board/toradex/colibri_imx7/colibri_imx7.c | 2 +-
 include/configs/colibri_imx7.h            | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
board/toradex/colibri_imx7/colibri_imx7.c +0 -0
index 2b7591e..9029c0b 100644

board/toradex/colibri_imx7/colibri_imx7.c DECLARE_GLOBAL_DATA_PTR; · line 55

Quoted 5 lines
board/toradex/colibri_imx7/colibri_imx7.c +0 -1
@@ -52,7 +52,7 @@ DECLARE_GLOBAL_DATA_PTR;
 
 int dram_init(void)
 {
-	gd->ram_size = get_ram_size((void *)PHYS_SDRAM,
 PHYS_SDRAM_SIZE);

BTW: Notice the generic get_ram_size() function which actually already did/does figure out the RAM size across all our modules regardless of being NXP/imx based or not. The size given there is just some kind of upper bound maxsize:

https://git.denx.de/?p=u-boot.git;a=blob;f=common/memsize.c#l21

Quoted 10 lines
board/toradex/colibri_imx7/colibri_imx7.c +1 -0
+	gd->ram_size = imx_ddr_size();
 
 	return 0;

}

include/configs/colibri_imx7.h +0 -0
index ff6bd67..02849ba 100644

include/configs/colibri_imx7.h line 19

Quoted 7 lines
include/configs/colibri_imx7.h +0 -1
@@ -14,7 +14,6 @@
 #include "mx7_common.h"
 
 /*#define CONFIG_DBG_MONITOR*/
-#define PHYS_SDRAM_SIZE			SZ_1G
 
 /* Size of malloc() pool */
 #define CONFIG_SYS_MALLOC_LEN		(32 * SZ_1M)

Cheers

Marcel

#2 lore raw

Hi Fabio

Quoted 8 lines · Marcel Ziswiler

Stefan is currently at Linaro Connect and may not have access to hardware.

Quoted 3 lines · Fabio Estevam

Instead of hardcoding the memory size, use the generic imx_ddr_size() function, which extracts the memory size in runtime by reading the DDR controller registers.

Quoted 5 lines

In theory that sounds fine. However, in practise that function seems to
return zero on our modules which leads to it freezing during boot.

I am currently looking more closely into it and will keep you posted.

I had a closer look at it. It turns out we kind of over provision the DDR controller in order to be able to actually use various kinds and sizes of chips without any need to change anything. So while this really works the imx_ddr_size() function currently seems to overflow in which case it just returns zero. I suggest fixing this by capping the function which I will send out a patch for shortly.

Quoted 1 line
Quoted 1 line

This helps in supporting 512MB and 1GB modules.

No, due to us over provisioning the DDR controller and using the generic get_ram_size() function we already do automatically detecting 256MB, 512MB or 1GB modules.

Quoted 29 lines
Quoted 17 lines

---
Hi Stefan,

I don't have the hardware to test, but I think we should be good by using imx_ddr_size() here.

 board/toradex/colibri_imx7/colibri_imx7.c | 2 +-
 include/configs/colibri_imx7.h            | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
board/toradex/colibri_imx7/colibri_imx7.c +0 -0
index 2b7591e..9029c0b 100644

board/toradex/colibri_imx7/colibri_imx7.c DECLARE_GLOBAL_DATA_PTR; · line 55

Quoted 5 lines
board/toradex/colibri_imx7/colibri_imx7.c +0 -1
@@ -52,7 +52,7 @@ DECLARE_GLOBAL_DATA_PTR;
 
 int dram_init(void)
 {
-	gd->ram_size = get_ram_size((void *)PHYS_SDRAM,
 PHYS_SDRAM_SIZE);

BTW: Notice the generic get_ram_size() function which actually already
did/does figure out the RAM size across all our modules regardless of being NXP/imx based or not. The size given there is just some kind of upper bound maxsize:

Quoted 1 line

https://git.denx.de/?p=u-boot.git;a=blob;f=common/memsize.c#l21

I suggest we keep using the generic get_ram_size() function which works very well but rather than passing a hardcoded maxsize we use the i.MX 7 specific imx_ddr_size() function. I will send out an updated patch.

Quoted 12 lines
Quoted 12 lines
board/toradex/colibri_imx7/colibri_imx7.c +1 -0
+	gd->ram_size = imx_ddr_size();
 
 	return 0;

}

include/configs/colibri_imx7.h +0 -0
index ff6bd67..02849ba 100644
@@ -14,7 +14,6 @@
 #include "mx7_common.h"
 
Quoted 5 lines

include/configs/colibri_imx7.h line 19

Quoted 5 lines
include/configs/colibri_imx7.h +0 -1
 /*#define CONFIG_DBG_MONITOR*/
-#define PHYS_SDRAM_SIZE			SZ_1G
 
 /* Size of malloc() pool */
 #define CONFIG_SYS_MALLOC_LEN		(32 * SZ_1M)

Cheers

Marcel