src/gprs.c: make sure that the context is properly released

---
  src/gprs.c | 4 ++++
  1 file changed, 4 insertions(+)

src/gprs.c +3 -0

index 8f5d195..40f43e3 100644
@@ -1642,6 +1642,9 @@ static void release_active_contexts(struct ofono_gprs *gprs)
 
  		if (gc->driver->detach_shutdown != NULL)
  			gc->driver->detach_shutdown(gc, ctx->context.cid);
+
+		/* Make sure the context is properly cleared */
+		release_context(ctx);
  	}
  }
 

Hi Giacinto,

src/gprs.c static void release_active_contexts(struct

Quoted 9 lines · Giacinto Cifelli

---
  src/gprs.c | 4 ++++
  1 file changed, 4 insertions(+)

src/gprs.c +0 -0

index 8f5d195..40f43e3 100644
@@ -1642,6 +1642,9 @@ static void release_active_contexts(struct

ofono_gprs *gprs)

src/gprs.c static DBusMessage

Quoted 10 lines

src/gprs.c +3 -0

              if (gc->driver->detach_shutdown != NULL)
                      gc->driver->detach_shutdown(gc, ctx->context.cid);
+
+             /* Make sure the context is properly cleared */
+             release_context(ctx);
      }
  }
 

@@ -2241,6 +2244,7 @@ static DBusMessage

*gprs_remove_context(DBusConnection *conn,

src/gprs.c static DBusMessage *gprs_remove_context(DBusConnection *conn, · line 2247

Quoted 4 lines

src/gprs.c +1 -0

      }
 
      DBG("Unregistering context: %s", ctx->path);
+     release_context(ctx);

If we get here then the context isn't active and doesn't need to be released. Active context release happens in gprs_deactivate_for_remove.
So I don't think this is needed?

src/gprs.c static DBusMessage *gprs_remove_context(DBusConnection *conn, · line 2250

Quoted 4 lines

src/gprs.c +0 -0

      context_dbus_unregister(ctx);
      gprs->contexts = g_slist_remove(gprs->contexts, ctx);
 

Regards,
-Denis

I got this change from external branches.

I doubted it was needed anymore, but couldn't be sure that I had tested all cases.

thank you for checking it, and it can then be left out.

Hi Giacinto,

Quoted 2 lines

I got this change from external branches.

Quoted 4 lines

I doubted it was needed anymore, but couldn't be sure that I had tested all cases.

thank you for checking it, and it can then be left out.

I can apply this patch without the chunk in question. Or do you want to resubmit?

Regards,
-Denis

If you can apply directly it would be great, thanks.