Skip to contentSkip to conversation

drm/i915: Add new AML_ULX support list

PATCH In review Lee, Shawn C 4 participants 8 messages Sep 27, 2018 – Oct 5, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/i915: Add new AML_ULX support list

According to patch "drm/i915/aml: Introducing Amber Lake platform" (e364672477a1). Add a new marco for AML ULX GT2 devices.

Cc Jani Nikula <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Jose Roberto de Souza <[email protected]>
---
 drivers/gpu/drm/i915/i915_drv.h | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/i915_drv.h +2 -0
index 808204a7ca7c..0c3de2d14db0 100644
@@ -2461,6 +2461,8 @@ intel_info(const struct drm_i915_private *dev_priv)
 #define IS_KBL_ULX(dev_priv)	(INTEL_DEVID(dev_priv) == 0x590E || \
 				 INTEL_DEVID(dev_priv) == 0x5915 || \
 				 INTEL_DEVID(dev_priv) == 0x591E)
+#define IS_AML_ULX(dev_priv)	(INTEL_DEVID(dev_priv) == 0x591C || \
+				 INTEL_DEVID(dev_priv) == 0x87C0)
 #define IS_SKL_GT2(dev_priv)	(IS_SKYLAKE(dev_priv) && \
 				 (dev_priv)->info.gt == 2)
 #define IS_SKL_GT3(dev_priv)	(IS_SKYLAKE(dev_priv) && \
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 2/2 drm/i915: Apply correct ddi translation table for AML device

Amber Lake used the same gen graphics as Kaby Lake. Kernel driver should configure KBL's DDI buffer setting for AML ULX as well.

So far, driver would load DDI translation table that used for KBL H/S platform and apply it on AML devices. But AML is belong to ULX series. This change will lead driver to apply KBL-Y's DDI table for AML devices to avoid unexpected eDP/DP signal quality issue.

Cc Jani Nikula <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Jose Roberto de Souza <[email protected]>
---
 drivers/gpu/drm/i915/intel_ddi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_ddi.c +3 -3
index b6910c8b4e08..b051970912a3 100644
@@ -642,7 +642,7 @@ skl_get_buf_trans_dp(struct drm_i915_private *dev_priv, int *n_entries)
 static const struct ddi_buf_trans *
 kbl_get_buf_trans_dp(struct drm_i915_private *dev_priv, int *n_entries)
 {
-	if (IS_KBL_ULX(dev_priv)) {
+	if (IS_KBL_ULX(dev_priv) || IS_AML_ULX(dev_priv)) {
 		*n_entries = ARRAY_SIZE(kbl_y_ddi_translations_dp);
 		return kbl_y_ddi_translations_dp;
 	} else if (IS_KBL_ULT(dev_priv) || IS_CFL_ULT(dev_priv)) {
@@ -658,7 +658,7 @@ static const struct ddi_buf_trans *
 skl_get_buf_trans_edp(struct drm_i915_private *dev_priv, int *n_entries)
 {
 	if (dev_priv->vbt.edp.low_vswing) {
-		if (IS_SKL_ULX(dev_priv) || IS_KBL_ULX(dev_priv)) {
+		if (IS_SKL_ULX(dev_priv) || IS_KBL_ULX(dev_priv) || IS_AML_ULX(dev_priv)) {
 			*n_entries = ARRAY_SIZE(skl_y_ddi_translations_edp);
 			return skl_y_ddi_translations_edp;
 		} else if (IS_SKL_ULT(dev_priv) || IS_KBL_ULT(dev_priv) ||
@@ -680,7 +680,7 @@ skl_get_buf_trans_edp(struct drm_i915_private *dev_priv, int *n_entries)
 static const struct ddi_buf_trans *
 skl_get_buf_trans_hdmi(struct drm_i915_private *dev_priv, int *n_entries)
 {
-	if (IS_SKL_ULX(dev_priv) || IS_KBL_ULX(dev_priv)) {
+	if (IS_SKL_ULX(dev_priv) || IS_KBL_ULX(dev_priv) || IS_AML_ULX(dev_priv)) {
 		*n_entries = ARRAY_SIZE(skl_y_ddi_translations_hdmi);
 		return skl_y_ddi_translations_hdmi;
 	} else {
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] drm/i915: Apply correct ddi translation table for AML device

Quoted 11 lines · Shawn C

Amber Lake used the same gen graphics as Kaby Lake. Kernel driver should configure KBL's DDI buffer setting for AML ULX as well.

So far, driver would load DDI translation table that used for KBL H/S platform and apply it on AML devices. But AML is belong to ULX series. This change will lead driver to apply KBL-Y's DDI table for AML devices to avoid unexpected eDP/DP signal quality issue.

Cc Jani Nikula <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Jose Roberto de Souza <[email protected]>

On both patches:

Quoted 43 lines
---
 drivers/gpu/drm/i915/intel_ddi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_ddi.c +1 -1
index b6910c8b4e08..b051970912a3 100644
@@ -642,7 +642,7 @@ skl_get_buf_trans_dp(struct drm_i915_private
 *dev_priv, int *n_entries)
 static const struct ddi_buf_trans *
 kbl_get_buf_trans_dp(struct drm_i915_private *dev_priv, int
 *n_entries)
 {
-	if (IS_KBL_ULX(dev_priv)) {
+	if (IS_KBL_ULX(dev_priv) || IS_AML_ULX(dev_priv)) {
 		*n_entries = ARRAY_SIZE(kbl_y_ddi_translations_dp);
drivers/gpu/drm/i915/intel_ddi.c +1 -1
 		return kbl_y_ddi_translations_dp;
 	} else if (IS_KBL_ULT(dev_priv) || IS_CFL_ULT(dev_priv)) {
@@ -658,7 +658,7 @@ static const struct ddi_buf_trans *
 skl_get_buf_trans_edp(struct drm_i915_private *dev_priv, int
 *n_entries)
 {
 	if (dev_priv->vbt.edp.low_vswing) {
-		if (IS_SKL_ULX(dev_priv) || IS_KBL_ULX(dev_priv)) {
+		if (IS_SKL_ULX(dev_priv) || IS_KBL_ULX(dev_priv) ||
 IS_AML_ULX(dev_priv)) {
 			*n_entries =

ARRAY_SIZE(skl_y_ddi_translations_edp);

drivers/gpu/drm/i915/intel_ddi.c +0 -0
 			return skl_y_ddi_translations_edp;
 		} else if (IS_SKL_ULT(dev_priv) || IS_KBL_ULT(dev_priv)

||

drivers/gpu/drm/i915/intel_ddi.c +1 -1
@@ -680,7 +680,7 @@ skl_get_buf_trans_edp(struct drm_i915_private
 *dev_priv, int *n_entries)
 static const struct ddi_buf_trans *
 skl_get_buf_trans_hdmi(struct drm_i915_private *dev_priv, int
 *n_entries)
 {
-	if (IS_SKL_ULX(dev_priv) || IS_KBL_ULX(dev_priv)) {
+	if (IS_SKL_ULX(dev_priv) || IS_KBL_ULX(dev_priv) ||
 IS_AML_ULX(dev_priv)) {

drivers/gpu/drm/i915/intel_ddi.c skl_get_buf_trans_edp(struct drm_i915_private *dev_priv, int *n_entries) · line 686

Quoted 3 lines
drivers/gpu/drm/i915/intel_ddi.c +0 -0
 		*n_entries = ARRAY_SIZE(skl_y_ddi_translations_hdmi);
 		return skl_y_ddi_translations_hdmi;
 	} else {

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#3 lore raw

Re: [PATCH 2/2] drm/i915: Apply correct ddi translation table for AML device

Quoted 9 lines · Jose
Quoted 8 lines · Shawn C

Amber Lake used the same gen graphics as Kaby Lake. Kernel driver should configure KBL's DDI buffer setting for AML ULX as well.

So far, driver would load DDI translation table that used for KBL H/S platform and apply it on AML devices. But AML is belong to ULX series. This change will lead driver to apply KBL-Y's DDI table for AML devices to avoid unexpected eDP/DP signal quality issue.

Quoted 6 lines
Quoted 3 lines
Cc Jani Nikula <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Jose Roberto de Souza <[email protected]>

On both patches:

Pushed both patches to dinq.

I accidentally forgot to propagate the rv-b to one of the patches. I'm so sorry...

Quoted 43 lines
Quoted 43 lines
---
 drivers/gpu/drm/i915/intel_ddi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_ddi.c +1 -1
index b6910c8b4e08..b051970912a3 100644
@@ -642,7 +642,7 @@ skl_get_buf_trans_dp(struct drm_i915_private
 *dev_priv, int *n_entries)
 static const struct ddi_buf_trans *
 kbl_get_buf_trans_dp(struct drm_i915_private *dev_priv, int
 *n_entries)
 {
-	if (IS_KBL_ULX(dev_priv)) {
+	if (IS_KBL_ULX(dev_priv) || IS_AML_ULX(dev_priv)) {
 		*n_entries = ARRAY_SIZE(kbl_y_ddi_translations_dp);
drivers/gpu/drm/i915/intel_ddi.c +1 -1
 		return kbl_y_ddi_translations_dp;
 	} else if (IS_KBL_ULT(dev_priv) || IS_CFL_ULT(dev_priv)) {
@@ -658,7 +658,7 @@ static const struct ddi_buf_trans *
 skl_get_buf_trans_edp(struct drm_i915_private *dev_priv, int
 *n_entries)
 {
 	if (dev_priv->vbt.edp.low_vswing) {
-		if (IS_SKL_ULX(dev_priv) || IS_KBL_ULX(dev_priv)) {
+		if (IS_SKL_ULX(dev_priv) || IS_KBL_ULX(dev_priv) ||
 IS_AML_ULX(dev_priv)) {
 			*n_entries =

ARRAY_SIZE(skl_y_ddi_translations_edp);

drivers/gpu/drm/i915/intel_ddi.c +0 -0
 			return skl_y_ddi_translations_edp;
 		} else if (IS_SKL_ULT(dev_priv) || IS_KBL_ULT(dev_priv)

||

drivers/gpu/drm/i915/intel_ddi.c +1 -1
@@ -680,7 +680,7 @@ skl_get_buf_trans_edp(struct drm_i915_private
 *dev_priv, int *n_entries)
 static const struct ddi_buf_trans *
 skl_get_buf_trans_hdmi(struct drm_i915_private *dev_priv, int
 *n_entries)
 {
-	if (IS_SKL_ULX(dev_priv) || IS_KBL_ULX(dev_priv)) {
+	if (IS_SKL_ULX(dev_priv) || IS_KBL_ULX(dev_priv) ||
Quoted 8 lines

drivers/gpu/drm/i915/intel_ddi.c skl_get_buf_trans_edp(struct drm_i915_private *dev_priv, int *n_entries) · line 686

Quoted 4 lines
drivers/gpu/drm/i915/intel_ddi.c +0 -0
 IS_AML_ULX(dev_priv)) {
drivers/gpu/drm/i915/intel_ddi.c +0 -0
 		*n_entries = ARRAY_SIZE(skl_y_ddi_translations_hdmi);
 		return skl_y_ddi_translations_hdmi;
 	} else {

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Add new AML_ULX support list

In reply to Lee, Shawn C
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915: Add new AML_ULX support list
URL : https://patchwork.freedesktop.org/series/50258/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
774790f183ba drm/i915: Add new AML_ULX support list
-:22: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#22: FILE: drivers/gpu/drm/i915/i915_drv.h:2467:
+#define IS_AML_ULX(dev_priv)	(INTEL_DEVID(dev_priv) == 0x591C || \
+				 INTEL_DEVID(dev_priv) == 0x87C0)

total: 0 errors, 0 warnings, 1 checks, 8 lines checked 30479deb52c9 drm/i915: Apply correct ddi translation table for AML device

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Add new AML_ULX support list

In reply to Lee, Shawn C
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915: Add new AML_ULX support list
URL : https://patchwork.freedesktop.org/series/50258/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Commit: drm/i915: Add new AML_ULX support list
-drivers/gpu/drm/i915/selftests/../i915_drv.h:3720:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/selftests/../i915_drv.h:3722:16: warning: expression using sizeof(void)

Commit: drm/i915: Apply correct ddi translation table for AML device Okay!

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Add new AML_ULX support list

In reply to Lee, Shawn C
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915: Add new AML_ULX support list
URL : https://patchwork.freedesktop.org/series/50258/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4891 -> Patchwork_10293 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/50258/revisions/1/mbox/

== Known issues ==

Here are the changes found in Patchwork_10293 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_suspend@basic-s3:
      fi-bdw-samus:       PASS -> INCOMPLETE (fdo#107773)

    igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
      fi-byt-clapper:     PASS -> FAIL (fdo#103191, fdo#107362) +1

    
    ==== Possible fixes ====

    igt@debugfs_test@read_all_entries:
      fi-icl-u:           DMESG-WARN (fdo#108070, fdo#107724) -> PASS

    igt@drv_module_reload@basic-reload:
      fi-blb-e6850:       INCOMPLETE (fdo#107718) -> PASS

fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#108070 https://bugs.freedesktop.org/show_bug.cgi?id=108070

== Participating hosts (44 -> 40) ==

Missing (4): fi-bsw-cyan fi-ilk-m540 fi-byt-squawks fi-icl-u2

== Build changes ==

* Linux: CI_DRM_4891 -> Patchwork_10293

CI_DRM_4891: 6dd054dcd512197a7f607a46356038529e807de8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4652: 83352d08b52acd6ee677f9f62dd032b0b8d31835 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10293: 30479deb52c915cda1fd3458a089c6a03f25635b @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

30479deb52c9 drm/i915: Apply correct ddi translation table for AML device 774790f183ba drm/i915: Add new AML_ULX support list

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10293/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Add new AML_ULX support list

In reply to Lee, Shawn C
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915: Add new AML_ULX support list
URL : https://patchwork.freedesktop.org/series/50258/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4891_full -> Patchwork_10293_full =

== Summary - SUCCESS ==

No regressions found.

== Known issues ==

Here are the changes found in Patchwork_10293_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-kbl:          PASS -> INCOMPLETE (fdo#106886, fdo#103665)

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          NOTRUN -> INCOMPLETE (fdo#106023, fdo#103665)

    igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
      shard-hsw:          PASS -> DMESG-WARN (fdo#107956)

    igt@kms_flip@flip-vs-fences-interruptible:
      shard-snb:          PASS -> INCOMPLETE (fdo#105411)

    
    ==== Possible fixes ====

    igt@drv_suspend@shrink:
      shard-glk:          INCOMPLETE (fdo#106886, fdo#103359, k.org#198133) -> PASS

    igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
      shard-kbl:          DMESG-WARN (fdo#107956) -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    igt@perf_pmu@rc6-runtime-pm-long:
      shard-glk:          FAIL (fdo#105010) -> PASS

    igt@prime_mmap@test_refcounting:
      shard-apl:          INCOMPLETE (fdo#103927) -> PASS

    igt@prime_vgem@fence-wait-blt:
      shard-glk:          DMESG-WARN (fdo#106538, fdo#105763) -> PASS +1

fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105010 https://bugs.freedesktop.org/show_bug.cgi?id=105010
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133

== Participating hosts (6 -> 5) ==

Missing (1): shard-skl

== Build changes ==

* Linux: CI_DRM_4891 -> Patchwork_10293

CI_DRM_4891: 6dd054dcd512197a7f607a46356038529e807de8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4652: 83352d08b52acd6ee677f9f62dd032b0b8d31835 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10293: 30479deb52c915cda1fd3458a089c6a03f25635b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10293/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx