Skip to contentSkip to conversation

mm: dax: add comment for PFN_SPECIAL

PATCH In review Yang Shi 2 participants 2 messages Sep 27, 2018 Memory management

lore
Share & tools
lore

Yang Shi

author
#0 lore raw

PATCH v2 1/1 mm: dax: add comment for PFN_SPECIAL

The comment for PFN_SPECIAL is missed in pfn_t.h. Add comment to get consistent with other pfn flags.

---
v2: rephrase the comment per Dan

 include/linux/pfn_t.h | 2 ++
 1 file changed, 2 insertions(+)
include/linux/pfn_t.h +2 -0
index 21713dc..d6cc4b5 100644
@@ -9,6 +9,8 @@
  * PFN_SG_LAST - pfn references a page and is the last scatterlist entry
  * PFN_DEV - pfn is not covered by system memmap by default
  * PFN_MAP - pfn has a dynamic page mapping established by a device driver
+ * PFN_SPECIAL - for CONFIG_FS_DAX_LIMITED builds to allow XIP, but not
+ *		 get_user_pages 
  */
 #define PFN_FLAGS_MASK (((u64) ~PAGE_MASK) << (BITS_PER_LONG_LONG - PAGE_SHIFT))
 #define PFN_SG_CHAIN (1ULL << (BITS_PER_LONG_LONG - 1))
Signature · 1 line
1.8.3.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 8 lines · On Thu, Sep 27, 2018 at 3:17 PM <[email protected]> wrote:

The comment for PFN_SPECIAL is missed in pfn_t.h. Add comment to get consistent with other pfn flags.

---
v2: rephrase the comment per Dan

Looks good for the -mm tree.

Quoted 20 lines
 include/linux/pfn_t.h | 2 ++
 1 file changed, 2 insertions(+)
include/linux/pfn_t.h +2 -1
index 21713dc..d6cc4b5 100644
@@ -9,6 +9,8 @@
  * PFN_SG_LAST - pfn references a page and is the last scatterlist entry
  * PFN_DEV - pfn is not covered by system memmap by default
  * PFN_MAP - pfn has a dynamic page mapping established by a device driver
+ * PFN_SPECIAL - for CONFIG_FS_DAX_LIMITED builds to allow XIP, but not
+ *              get_user_pages
  */
 #define PFN_FLAGS_MASK (((u64) ~PAGE_MASK) << (BITS_PER_LONG_LONG - PAGE_SHIFT))
 #define PFN_SG_CHAIN (1ULL << (BITS_PER_LONG_LONG - 1))
--

1.8.3.1