Skip to contentSkip to conversation

f2fs: do not update REQ_TIME in case of error conditions

PATCH In review Sahitya Tummala 3 participants 6 messages Oct 5, 2018 – Oct 16, 2018 F2FS file system

lore
Share & tools
lore

Sahitya Tummala

author
#0 lore raw

PATCH 1/2 f2fs: do not update REQ_TIME in case of error conditions

The REQ_TIME should be updated only in case of success cases as followed at all other places in the file system.

Signed-off-by Sahitya Tummala <[email protected]>
---
 fs/f2fs/dir.c  | 2 +-
 fs/f2fs/file.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
fs/f2fs/dir.c +1 -1
index c77a580..e02db5d 100644
@@ -655,9 +655,9 @@ int f2fs_do_tmpfile(struct inode *inode, struct inode *dir)
 	f2fs_put_page(page, 1);
 
 	clear_inode_flag(inode, FI_NEW_INODE);
+	f2fs_update_time(F2FS_I_SB(inode), REQ_TIME);
 fail:
 	up_write(&F2FS_I(inode)->i_sem);
-	f2fs_update_time(F2FS_I_SB(inode), REQ_TIME);
 	return err;
 }
fs/f2fs/file.c +1 -1
index b1aaa73..543c742 100644
@@ -106,6 +106,7 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
 		SetPageUptodate(page);
 
 	f2fs_update_iostat(sbi, APP_MAPPED_IO, F2FS_BLKSIZE);
+	f2fs_update_time(sbi, REQ_TIME);
 
 	trace_f2fs_vm_page_mkwrite(page, DATA);
 out_sem:

@@ -114,7 +115,6 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
 	f2fs_balance_fs(sbi, dn.node_changed);
 
 	sb_end_pagefault(inode->i_sb);
-	f2fs_update_time(sbi, REQ_TIME);
 err:
 	return block_page_mkwrite_return(err);
 }
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
author
#1 lore raw

PATCH 2/2 f2fs: update REQ_TIME in f2fs_cross_rename()

Update REQ_TIME in the missing path - f2fs_cross_rename().

Signed-off-by Sahitya Tummala <[email protected]>
---
 fs/f2fs/namei.c | 2 ++
 1 file changed, 2 insertions(+)
fs/f2fs/namei.c +2 -0
index a146327..e37af23 100644
@@ -1154,6 +1154,8 @@ static int f2fs_cross_rename(struct inode *old_dir, struct dentry *old_dentry,
 
 	if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir))
 		f2fs_sync_fs(sbi->sb, 1);
+
+	f2fs_update_time(sbi, REQ_TIME);
 	return 0;
 out_new_dir:
 	if (new_dir_entry) {
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
#2 lore raw

Re: [PATCH 2/2] f2fs: update REQ_TIME in f2fs_cross_rename()

Quoted 1 line · Sahitya Tummala

Update REQ_TIME in the missing path - f2fs_cross_rename().

Needs to cover f2fs_rename() as well?

Thanks,

Quoted 20 lines
Signed-off-by Sahitya Tummala <[email protected]>
---
 fs/f2fs/namei.c | 2 ++
 1 file changed, 2 insertions(+)
fs/f2fs/namei.c +2 -0
index a146327..e37af23 100644
@@ -1154,6 +1154,8 @@ static int f2fs_cross_rename(struct inode *old_dir, struct dentry *old_dentry,
 
 	if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir))
 		f2fs_sync_fs(sbi->sb, 1);
+
+	f2fs_update_time(sbi, REQ_TIME);
 	return 0;
 out_new_dir:
 	if (new_dir_entry) {
maintainer
#3 lore raw

Re: [PATCH 2/2] f2fs: update REQ_TIME in f2fs_cross_rename()

Quoted 4 lines · Chao Yu
Quoted 1 line · Sahitya Tummala

Update REQ_TIME in the missing path - f2fs_cross_rename().

Needs to cover f2fs_rename() as well?

Hi, I've added this in f2fs_rename().

Thanks,

Quoted 23 lines

Thanks,

Quoted 20 lines
Signed-off-by Sahitya Tummala <[email protected]>
---
 fs/f2fs/namei.c | 2 ++
 1 file changed, 2 insertions(+)
fs/f2fs/namei.c +2 -0
index a146327..e37af23 100644
@@ -1154,6 +1154,8 @@ static int f2fs_cross_rename(struct inode *old_dir, struct dentry *old_dentry,
 
 	if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir))
 		f2fs_sync_fs(sbi->sb, 1);
+
+	f2fs_update_time(sbi, REQ_TIME);
 	return 0;
 out_new_dir:
 	if (new_dir_entry) {
Reviewed-by
#4 lore raw

Re: [PATCH 2/2] f2fs: update REQ_TIME in f2fs_cross_rename()

Quoted 7 lines · Jaegeuk Kim
Quoted 4 lines · Chao Yu
Quoted 1 line · Sahitya Tummala

Update REQ_TIME in the missing path - f2fs_cross_rename().

Needs to cover f2fs_rename() as well?

Hi, I've added this in f2fs_rename().

Oh, I see, it looks okay to me now. :)

Reviewed-by Chao Yu <[email protected]>

Thanks,

Quoted 29 lines

Thanks,

Quoted 15 lines

Thanks,

Quoted 12 lines
Signed-off-by Sahitya Tummala <[email protected]>
---
 fs/f2fs/namei.c | 2 ++
 1 file changed, 2 insertions(+)
fs/f2fs/namei.c +0 -0
index a146327..e37af23 100644
@@ -1154,6 +1154,8 @@ static int f2fs_cross_rename(struct inode *old_dir, struct dentry *old_dentry,
Quoted 8 lines

fs/f2fs/namei.c static int f2fs_cross_rename(struct inode *old_dir, struct dentry *old_dentry, · line 1161

Quoted 8 lines
fs/f2fs/namei.c +2 -0
 	if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir))
 		f2fs_sync_fs(sbi->sb, 1);
+
+	f2fs_update_time(sbi, REQ_TIME);
 	return 0;
 out_new_dir:
 	if (new_dir_entry) {

.