Skip to contentSkip to conversation

ACPI / SBS: Fix check in acpi_ac_get_present()

PATCH New Rafael J. Wysocki 1 participant 1 message Sep 27, 2014 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI / SBS: Fix check in acpi_ac_get_present()

From: Rafael J. Wysocki <[email protected]>

Parentheses are missing under an if () statement in acpi_ac_get_present() which makes the check work differently from what was intended (at least according to the comment right above it). Add the missing parens.

The problem was found by sparse.

---
 drivers/acpi/sbs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/sbs.c +1 -1
Index: linux-pm/drivers/acpi/sbs.c
===================================================================
@@ -441,7 +441,7 @@ static int acpi_ac_get_present(struct ac
 	 * The spec requires that bit 4 always be 1. If it's not set, assume
 	 * that the implementation doesn't support an SBS charger
 	 */
-	if (!(status >> 4) & 0x1)
+	if (!((status >> 4) & 0x1))
 		return -ENODEV;
 
 	sbs->charger_present = (status >> 15) & 0x1;