Skip to contentSkip to conversation

Make meta-oe pass again

PATCH In review Armin Kuster 6 participants 13 messages Oct 12, 2018 – Oct 13, 2018

lore
Share & tools
lore
#0 lore raw

cover Make meta-oe pass again

There is a yocto-check-layer regression in meta-openembedded do to new packages being added. These changes make meta-oe pass again

Armin Kuster (5):
directfb: add x11 to REQUIRED_DISTRO_FEATURES
vlc: add x11 to REQUIRED_DISTRO_FEATURES
directfb-examples: add x11 to REQUIRED_DISTRO_FEATURES
blueman: add x11 to REQUIRED_DISTRO_FEATURES
blueman: really belongs in meta-networking

 meta-multimedia/recipes-multimedia/vlc/vlc.inc                        | 4 +++-
 .../blueman/blueman/0001-Search-for-cython3.patch                     | 0
 .../recipes-connectivity/blueman/blueman_git.bb                       | 3 ++-
 meta-oe/recipes-graphics/directfb/directfb-examples_1.7.0.bb          | 3 ++-
 meta-oe/recipes-graphics/directfb/directfb.inc                        | 3 ++-
 5 files changed, 9 insertions(+), 4 deletions(-)
 rename {meta-oe => meta-networking}/recipes-connectivity/blueman/blueman/0001-Search-for-cython3.patch (100%)
 rename {meta-oe => meta-networking}/recipes-connectivity/blueman/blueman_git.bb (95%)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/5 directfb: add x11 to REQUIRED_DISTRO_FEATURES

package has depends on vlc and gtk

---
 meta-oe/recipes-graphics/directfb/directfb.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-oe/recipes-graphics/directfb/directfb.inc +2 -1
index 96aa311..cf8f19a 100644
@@ -32,7 +32,8 @@ LDFLAGS_append_arm = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -f
 
 BINCONFIG = "${bindir}/directfb-config"
 
-inherit autotools binconfig-disabled pkgconfig
+inherit autotools binconfig-disabled pkgconfig distro_features_check
+REQUIRED_DISTRO_FEATURES = "x11"
 
 PACKAGECONFIG ??= "linuxinput"
 PACKAGECONFIG[jpeg2000] = "--enable-jpeg2000,--disable-jpeg2000,jasper"
Signature · 1 line
2.7.4
#2 lore raw

Re: [meta-oe][PATCH 1/5] directfb: add x11 to REQUIRED_DISTRO_FEATURES

Quoted 12 lines · Armin Kuster

package has depends on vlc and gtk

---
  meta-oe/recipes-graphics/directfb/directfb.inc | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
meta-oe/recipes-graphics/directfb/directfb.inc +0 -0
index 96aa311..cf8f19a 100644

meta-oe/recipes-graphics/directfb/directfb.inc LDFLAGS_append_arm = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -f · line 37

Quoted 7 lines
meta-oe/recipes-graphics/directfb/directfb.inc +2 -1
@@ -32,7 +32,8 @@ LDFLAGS_append_arm = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -f
 
  BINCONFIG = "${bindir}/directfb-config"
 
-inherit autotools binconfig-disabled pkgconfig
+inherit autotools binconfig-disabled pkgconfig distro_features_check
+REQUIRED_DISTRO_FEATURES = "x11"
 

Wrong method?

Quote from:
https://github.com/DirectFB/directfb

"Optionally, depending on the configuration you want:

FBDev
- Linux kernel 2.2.x or newer with working frame buffer device (check /proc/fb) for the fbdev system.

SDL
- libSDL (Simple Direct Media Layer) for the sdl system.

X11
- libX11 (X11 client library) for the X11 system (libx11-dev and libxext-dev packages)."

#3 lore raw

Re: [meta-oe][PATCH 1/5] directfb: add x11 to REQUIRED_DISTRO_FEATURES

DirectFB depending on X11 would be *very wrong*.

Ross

Quoted 44 lines · Vesa Jääskeläinen
Quoted 12 lines · Armin Kuster

package has depends on vlc and gtk

---
  meta-oe/recipes-graphics/directfb/directfb.inc | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
meta-oe/recipes-graphics/directfb/directfb.inc +0 -0
index 96aa311..cf8f19a 100644

meta-oe/recipes-graphics/directfb/directfb.inc LDFLAGS_append_arm = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -f · line 37

Quoted 7 lines
meta-oe/recipes-graphics/directfb/directfb.inc +2 -1
@@ -32,7 +32,8 @@ LDFLAGS_append_arm = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -f
 
  BINCONFIG = "${bindir}/directfb-config"
 
-inherit autotools binconfig-disabled pkgconfig
+inherit autotools binconfig-disabled pkgconfig distro_features_check
+REQUIRED_DISTRO_FEATURES = "x11"
 

Wrong method?

Quote from:
https://github.com/DirectFB/directfb

"Optionally, depending on the configuration you want:

FBDev
- Linux kernel 2.2.x or newer with working frame buffer device (check /proc/fb) for the fbdev system.

SDL
- libSDL (Simple Direct Media Layer) for the sdl system.

X11
- libX11 (X11 client library) for the X11 system (libx11-dev and libxext-dev packages)."

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

author
#4 lore raw

Re: [meta-oe][PATCH 1/5] directfb: add x11 to REQUIRED_DISTRO_FEATURES

In reply to Vesa Jääskeläinen
Quoted 9 lines · Vesa Jääskeläinen
Quoted 7 lines · Armin Kuster

package has depends on vlc and gtk

---
  meta-oe/recipes-graphics/directfb/directfb.inc | 3 ++-

  1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 13 lines
Quoted 11 lines
meta-oe/recipes-graphics/directfb/directfb.inc +0 -0
index 96aa311..cf8f19a 100644
@@ -32,7 +32,8 @@ LDFLAGS_append_arm =

"${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -f BINCONFIG = "${bindir}/directfb-config" -inherit autotools binconfig-disabled pkgconfig

meta-oe/recipes-graphics/directfb/directfb.inc +2 -0
+inherit autotools binconfig-disabled pkgconfig distro_features_check
+REQUIRED_DISTRO_FEATURES = "x11"
Quoted 1 line

Wrong method?

How about sending a the "Correct method"?

- armin

Quoted 17 lines

Quote from:
https://github.com/DirectFB/directfb

"Optionally, depending on the configuration you want:

   FBDev
     - Linux kernel 2.2.x or newer with working frame buffer device (check /proc/fb) for the fbdev system.

   SDL
     - libSDL (Simple Direct Media Layer) for the sdl system.

   X11
     - libX11 (X11 client library) for the X11 system (libx11-dev and libxext-dev packages)."

#5 lore raw

Re: [meta-oe][PATCH 1/5] directfb: add x11 to REQUIRED_DISTRO_FEATURES

In reply to Armin Kuster
Quoted 2 lines · Armin Kuster

package has depends on vlc and gtk
...

Where does directfb depend on vlc and gtk?

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#6 lore raw

PATCH 2/5 vlc: add x11 to REQUIRED_DISTRO_FEATURES

In reply to Armin Kuster

Nothing PROVIDES gtk+

---
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta-multimedia/recipes-multimedia/vlc/vlc.inc +3 -1
index f13c0ea..e395b24 100644
@@ -19,6 +19,8 @@ LICENSE_FLAGS = "commercial"
 SRC_URI = "http://download.videolan.org/pub/videolan/${BPN}/${PV}/${BP}.tar.xz"
 
 inherit autotools gettext pkgconfig distro_features_check
+#REQUIRED_DISTRO_FEATURES = "x11"
+
 
 ARM_INSTRUCTION_SET = "arm"
 
@@ -40,7 +42,7 @@ EXTRA_OECONF = "\
     ac_cv_path_UIC=${STAGING_BINDIR_NATIVE}/uic4 \
 "
 
-PACKAGECONFIG ?= " live555 dc1394 dv1394 notify fontconfig freetype dvdread png ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 sdl vdpau', '', d)}"
+PACKAGECONFIG ?= " live555 dc1394 dv1394 fontconfig freetype dvdread png ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 sdl vdpau notify', '', d)}"
 PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
 PACKAGECONFIG[sdl] = "--enable-sdl,--disable-sdl,virtual/libsdl libsdl-image "
 PACKAGECONFIG[a52] = "--enable-a52,--disable-a52,liba52"
Signature · 1 line
2.7.4
#7 lore raw

Re: [meta-oe][PATCH 2/5] vlc: add x11 to REQUIRED_DISTRO_FEATURES

Hi Armin

Quoted 3 lines · Armin Kuster

Nothing PROVIDES gtk+

Commit message and code changes seems to not matching

Quoted 35 lines
---
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta-multimedia/recipes-multimedia/vlc/vlc.inc +3 -2
index f13c0ea..e395b24 100644
@@ -19,6 +19,8 @@ LICENSE_FLAGS = "commercial"
 SRC_URI = "http://download.videolan.org/pub/videolan/${BPN}/${PV}/${BP}.tar.xz"
 
 inherit autotools gettext pkgconfig distro_features_check
+#REQUIRED_DISTRO_FEATURES = "x11"
+
 
 ARM_INSTRUCTION_SET = "arm"
 
@@ -40,7 +42,7 @@ EXTRA_OECONF = "\
     ac_cv_path_UIC=${STAGING_BINDIR_NATIVE}/uic4 \
 "
 
-PACKAGECONFIG ?= " live555 dc1394 dv1394 notify fontconfig freetype dvdread png ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 sdl vdpau', '', d)}"
+PACKAGECONFIG ?= " live555 dc1394 dv1394 fontconfig freetype dvdread png ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 sdl vdpau notify', '', d)}"
 PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
 PACKAGECONFIG[sdl] = "--enable-sdl,--disable-sdl,virtual/libsdl libsdl-image "
 PACKAGECONFIG[a52] = "--enable-a52,--disable-a52,liba52"
--

2.7.4

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#8 lore raw

PATCH 3/5 directfb-examples: add x11 to REQUIRED_DISTRO_FEATURES

In reply to Armin Kuster

Nothing PROVIDES 'directfb'

---
 meta-oe/recipes-graphics/directfb/directfb-examples_1.7.0.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-oe/recipes-graphics/directfb/directfb-examples_1.7.0.bb +2 -1
index 7907c5c..a9d29dc 100644
@@ -15,7 +15,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=ecf6fd2b19915afc4da56043926ca18f"
 
 S = "${WORKDIR}/DirectFB-examples-${PV}"
 
-inherit autotools pkgconfig
+inherit autotools pkgconfig distro_features_check
+REQUIRED_DISTRO_FEATURES = "x11"
 
 SRC_URI[md5sum] = "8b60c867af295481c32a8c7fc5802307"
 SRC_URI[sha256sum] = "9a2104cc4da8123c8371813551b66b943198979f745cbebc034bb5e10844122a"
Signature · 1 line
2.7.4
#9 lore raw

PATCH 4/5 blueman: add x11 to REQUIRED_DISTRO_FEATURES

In reply to Armin Kuster

Nothing RPROVIDES 'thunar'

---
 meta-oe/recipes-connectivity/blueman/blueman_git.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-oe/recipes-connectivity/blueman/blueman_git.bb +2 -1
index 947db78..8eb99ed 100644
@@ -4,7 +4,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
 
 DEPENDS = "bluez5 python3-pygobject python3-cython-native python3-setuptools-native intltool-native"
 
-inherit autotools systemd gsettings python3native gtk-icon-cache
+inherit autotools systemd gsettings python3native gtk-icon-cache distro_features_check
+REQUIRED_DISTRO_FEATURES = "x11"
 
 SRC_URI = " \
     git://github.com/blueman-project/blueman.git \
Signature · 1 line
2.7.4
#10 lore raw

Re: [meta-oe][PATCH 4/5] blueman: add x11 to REQUIRED_DISTRO_FEATURES

Quoted 8 lines · Armin Kuster

Nothing RPROVIDES 'thunar'

---
 meta-oe/recipes-connectivity/blueman/blueman_git.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

If thunar is the only reason then this has to go to append in meta-xfce - there thunar PACKAGECONFIG is activated.

Andreas

#11 lore raw

Re: [meta-oe][PATCH 4/5] blueman: add x11 to REQUIRED_DISTRO_FEATURES

Quoted 5 lines · Andreas Müller
Quoted 3 lines · Armin Kuster

Nothing RPROVIDES 'thunar'

Quoted 8 lines
Quoted 5 lines
---
 meta-oe/recipes-connectivity/blueman/blueman_git.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

If thunar is the only reason then this has to go to append in meta-xfce - there thunar PACKAGECONFIG is activated.

I agree.

Quoted 6 lines

Andreas
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#12 lore raw

PATCH 5/5 blueman: really belongs in meta-networking

In reply to Armin Kuster

it has a build dependancy on python-cython and python-pyparsing with are in meta-python

---
 .../recipes-connectivity/blueman/blueman/0001-Search-for-cython3.patch    | 0
 {meta-oe => meta-networking}/recipes-connectivity/blueman/blueman_git.bb  | 0
 2 files changed, 0 insertions(+), 0 deletions(-)
 rename {meta-oe => meta-networking}/recipes-connectivity/blueman/blueman/0001-Search-for-cython3.patch (100%)
 rename {meta-oe => meta-networking}/recipes-connectivity/blueman/blueman_git.bb (100%)
meta-networking/recipes-connectivity/blueman/blueman/0001-Search-for-cython3.patch renamed from meta-oe/recipes-connectivity/blueman/blueman/0001-Search-for-cython3.patch +0 -0
similarity index 100%
rename from meta-oe/recipes-connectivity/blueman/blueman/0001-Search-for-cython3.patch
rename to meta-networking/recipes-connectivity/blueman/blueman/0001-Search-for-cython3.patch
meta-networking/recipes-connectivity/blueman/blueman_git.bb renamed from meta-oe/recipes-connectivity/blueman/blueman_git.bb +0 -0
similarity index 100%
rename from meta-oe/recipes-connectivity/blueman/blueman_git.bb
rename to meta-networking/recipes-connectivity/blueman/blueman_git.bb
Signature · 1 line
2.7.4