Skip to contentSkip to conversation

cpu: Add DM_FLAG_PRE_RELOC flag to various cpu drivers

PATCH New Bin Meng 3 participants 6 messages Oct 14, 2018 – Nov 6, 2018 x86

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH v2 1/2 cpu: Add DM_FLAG_PRE_RELOC flag to various cpu drivers

It turns out commit c0434407b595 broke some boards which have DM CPU driver with CONFIG_DISPLAY_CPUINFO option on. These boards just fail to boot when print_cpuinfo() is called during boot.

Fixes c0434407b595 ("board_f: Use static print_cpuinfo if CONFIG_CPU is active")

---

Changes in v2:
- drop the sandbox cpu driver change

 arch/x86/cpu/baytrail/cpu.c          | 1 +
 arch/x86/cpu/broadwell/cpu.c         | 1 +
 arch/x86/cpu/cpu_x86.c               | 1 +
 arch/x86/cpu/ivybridge/model_206ax.c | 1 +
 4 files changed, 4 insertions(+)
arch/x86/cpu/baytrail/cpu.c +1 -0
index 56e9813..2eb9172 100644
@@ -203,4 +203,5 @@ U_BOOT_DRIVER(cpu_x86_baytrail_drv) = {
 	.bind		= cpu_x86_bind,
 	.probe		= cpu_x86_baytrail_probe,
 	.ops		= &cpu_x86_baytrail_ops,
+	.flags		= DM_FLAG_PRE_RELOC,
 };
arch/x86/cpu/broadwell/cpu.c +1 -0
index 02b3169..232fa40 100644
@@ -764,4 +764,5 @@ U_BOOT_DRIVER(cpu_x86_broadwell_drv) = {
 	.probe		= cpu_x86_broadwell_probe,
 	.ops		= &cpu_x86_broadwell_ops,
 	.priv_auto_alloc_size	= sizeof(struct cpu_broadwell_priv),
+	.flags		= DM_FLAG_PRE_RELOC,
 };
arch/x86/cpu/cpu_x86.c +1 -0
index 2b6cc9f..1aaf851 100644
@@ -94,4 +94,5 @@ U_BOOT_DRIVER(cpu_x86_drv) = {
 	.of_match	= cpu_x86_ids,
 	.bind		= cpu_x86_bind,
 	.ops		= &cpu_x86_ops,
+	.flags		= DM_FLAG_PRE_RELOC,
 };
arch/x86/cpu/ivybridge/model_206ax.c +1 -0
index 33e5c62..6edc3e2 100644
@@ -478,4 +478,5 @@ U_BOOT_DRIVER(cpu_x86_model_206ax_drv) = {
 	.bind		= cpu_x86_bind,
 	.probe		= cpu_x86_model_206ax_probe,
 	.ops		= &cpu_x86_model_206ax_ops,
+	.flags		= DM_FLAG_PRE_RELOC,
 };
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH v2 2/2 cpu: sandbox: Add "u-boot, dm-pre-reloc" for all cpu nodes

To support CONFIG_DISPLAY_CPUINFO, add "u-boot,dm-pre-reloc" for all cpu nodes in Sandbox test.dts.

---

Changes in v2:
- new patch to add "u-boot,dm-pre-reloc" for all cpu nodes in Sandbox

 arch/sandbox/dts/test.dts | 3 +++
 1 file changed, 3 insertions(+)
arch/sandbox/dts/test.dts +3 -0
index 0635b91..c52f5a9 100644
@@ -350,14 +350,17 @@
 
 	cpu-test1 {
 		compatible = "sandbox,cpu_sandbox";
+		u-boot,dm-pre-reloc;
 	};
 
 	cpu-test2 {
 		compatible = "sandbox,cpu_sandbox";
+		u-boot,dm-pre-reloc;
 	};
 
 	cpu-test3 {
 		compatible = "sandbox,cpu_sandbox";
+		u-boot,dm-pre-reloc;
 	};
 
 	misc-test {
Signature · 1 line
2.7.4
#4 lore raw

PATCH v2 1/2 cpu: Add DM_FLAG_PRE_RELOC flag to various cpu drivers

In reply to Bin Meng
Quoted 7 lines · Bin Meng

It turns out commit c0434407b595 broke some boards which have DM CPU driver with CONFIG_DISPLAY_CPUINFO option on. These boards just fail to boot when print_cpuinfo() is called during boot.

Fixes c0434407b595 ("board_f: Use static print_cpuinfo if CONFIG_CPU is active")

Thanks,
Stefan

#5 lore raw

PATCH v2 1/2 cpu: Add DM_FLAG_PRE_RELOC flag to various cpu drivers

Quoted 7 lines · Bin Meng

It turns out commit c0434407b595 broke some boards which have DM CPU driver with CONFIG_DISPLAY_CPUINFO option on. These boards just fail to boot when print_cpuinfo() is called during boot.

Fixes c0434407b595 ("board_f: Use static print_cpuinfo if CONFIG_CPU is active")

Thanks,
Stefan

Applied to u-boot-dm/master, thanks!