Skip to contentSkip to conversation

Enabling the IGT for HDCP1.4

PATCH Superseded Ramalingam C 3 participants 12 messages Oct 22, 2018 – Oct 23, 2018

Subsystems (2)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v4 cover Enabling the IGT for HDCP1.4

Adding a debugfs entry for detecting the valid HDCP sinks to perform kms_content_protection.

In case of dummy HDMI/DP sinks(EDID whisperers without any parsers) IGT will skip the HDCP test on that connector instead of failing it. Hence false alarm are avoided.

For serving above purpose this series has pulled out few changes from "Implement HDCP2.2" series under review at
https://patchwork.freedesktop.org/series/38254/

"drm/i915: hdcp_check_link only on CP_IRQ" is just a improvement patch for HDCP1.4. Already received the reviewed-by from Sean Paul.

v4:
Squashed patch #2 into #4.
Pulled the conn_to_dig_port into intel_drv.h

Ramalingam C (3):
drm/i915: Pullout the bksv read and validation
drm/i915: hdcp_check_link only on CP_IRQ
drm/i915/debugfs: hdcp capability of a sink

 drivers/gpu/drm/i915/i915_debugfs.c | 29 ++++++++++++
 drivers/gpu/drm/i915/intel_dp.c     | 10 ++---
 drivers/gpu/drm/i915/intel_drv.h    |  7 +++
 drivers/gpu/drm/i915/intel_hdcp.c   | 89 ++++++++++++++++++++++++-------------
 drivers/gpu/drm/i915/intel_hdmi.c   | 16 ++++++-
 5 files changed, 115 insertions(+), 36 deletions(-)
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH v4 1/3 drm/i915: Pullout the bksv read and validation

For reusability purpose, this patch implements the hdcp1.4 bksv's read and validation as a functions.

For detecting the HDMI panel's HDCP capability this fucntions will be used.

v2:
Rebased.
v3:
No Changes.
v4:
inline tag is removed with modified error msg.
v5:
No Changes.
v6:
No Changes.
v7:
Realigned the code.

---
 drivers/gpu/drm/i915/intel_hdcp.c | 62 ++++++++++++++++++++++++---------------
 1 file changed, 38 insertions(+), 24 deletions(-)
drivers/gpu/drm/i915/intel_hdcp.c +38 -24
index 26e48fc95543..20908ff018e6 100644
@@ -16,6 +16,41 @@
 
 #define KEY_LOAD_TRIES	5
 
+static
+bool intel_hdcp_is_ksv_valid(u8 *ksv)
+{
+	int i, ones = 0;
+	/* KSV has 20 1's and 20 0's */
+	for (i = 0; i < DRM_HDCP_KSV_LEN; i++)
+		ones += hweight8(ksv[i]);
+	if (ones != 20)
+		return false;
+
+	return true;
+}
+
+static
+int intel_hdcp_read_valid_bksv(struct intel_digital_port *intel_dig_port,
+			       const struct intel_hdcp_shim *shim, u8 *bksv)
+{
+	int ret, i, tries = 2;
+
+	/* HDCP spec states that we must retry the bksv if it is invalid */
+	for (i = 0; i < tries; i++) {
+		ret = shim->read_bksv(intel_dig_port, bksv);
+		if (ret)
+			return ret;
+		if (intel_hdcp_is_ksv_valid(bksv))
+			break;
+	}
+	if (i == tries) {
+		DRM_ERROR("Bksv is invalid\n");
+		return -ENODEV;
+	}
+
+	return 0;
+}
+
 static int intel_hdcp_poll_ksv_fifo(struct intel_digital_port *intel_dig_port,
 				    const struct intel_hdcp_shim *shim)
 {
@@ -168,18 +203,6 @@ u32 intel_hdcp_get_repeater_ctl(struct intel_digital_port *intel_dig_port)
 }
 
 static
-bool intel_hdcp_is_ksv_valid(u8 *ksv)
-{
-	int i, ones = 0;
-	/* KSV has 20 1's and 20 0's */
-	for (i = 0; i < DRM_HDCP_KSV_LEN; i++)
-		ones += hweight8(ksv[i]);
-	if (ones != 20)
-		return false;
-	return true;
-}
-
-static
 int intel_hdcp_validate_v_prime(struct intel_digital_port *intel_dig_port,
 				const struct intel_hdcp_shim *shim,
 				u8 *ksv_fifo, u8 num_downstream, u8 *bstatus)
@@ -527,18 +550,9 @@ static int intel_hdcp_auth(struct intel_digital_port *intel_dig_port,
 
 	memset(&bksv, 0, sizeof(bksv));
 
-	/* HDCP spec states that we must retry the bksv if it is invalid */
-	for (i = 0; i < tries; i++) {
-		ret = shim->read_bksv(intel_dig_port, bksv.shim);
-		if (ret)
-			return ret;
-		if (intel_hdcp_is_ksv_valid(bksv.shim))
-			break;
-	}
-	if (i == tries) {
-		DRM_ERROR("HDCP failed, Bksv is invalid\n");
-		return -ENODEV;
-	}
+	ret = intel_hdcp_read_valid_bksv(intel_dig_port, shim, bksv.shim);
+	if (ret < 0)
+		return ret;
 
 	I915_WRITE(PORT_HDCP_BKSVLO(port), bksv.reg[0]);
 	I915_WRITE(PORT_HDCP_BKSVHI(port), bksv.reg[1]);
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

PATCH v4 2/3 drm/i915: hdcp_check_link only on CP_IRQ

In reply to Ramalingam C

HDCP check link is invoked only on CP_IRQ detection, instead of all short pulses.

v3:
No Changes.
v4:
Added sean in cc and collected the reviewed-by received.
v5:
No Change.
v6:
No Change.
v7:
No Change.
v8:
Rebased.

---
 drivers/gpu/drm/i915/intel_dp.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +5 -5
index 1f098e509143..27377bf8105c 100644
@@ -4530,8 +4530,11 @@ static void intel_dp_check_service_irq(struct intel_dp *intel_dp)
 	if (val & DP_AUTOMATED_TEST_REQUEST)
 		intel_dp_handle_test_request(intel_dp);
 
-	if (val & (DP_CP_IRQ | DP_SINK_SPECIFIC_IRQ))
-		DRM_DEBUG_DRIVER("CP or sink specific irq unhandled\n");
+	if (val & DP_CP_IRQ)
+		intel_hdcp_check_link(intel_dp->attached_connector);
+
+	if (val & DP_SINK_SPECIFIC_IRQ)
+		DRM_DEBUG_DRIVER("Sink specific irq unhandled\n");
 }
 
 /*
@@ -5694,9 +5697,6 @@ intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd)
 
 		handled = intel_dp_short_pulse(intel_dp);
 
-		/* Short pulse can signify loss of hdcp authentication */
-		intel_hdcp_check_link(intel_dp->attached_connector);
-
 		if (!handled)
 			goto put_power;
 	}
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

PATCH v4 3/3 drm/i915/debugfs: hdcp capability of a sink

In reply to Ramalingam C

Add a debugfs entry for providing the hdcp capabilities of the sink connected to the HDCP capable connectors.

v2:
Squashed the sink's hdcp capability into this patch. [Daniel]

---
 drivers/gpu/drm/i915/i915_debugfs.c | 29 +++++++++++++++++++++++++++++
 drivers/gpu/drm/i915/intel_drv.h    |  7 +++++++
 drivers/gpu/drm/i915/intel_hdcp.c   | 27 +++++++++++++++++++++------
 drivers/gpu/drm/i915/intel_hdmi.c   | 16 +++++++++++++++-
 4 files changed, 72 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +29 -0
index 5f3c639522fa..6d09af66da0f 100644
@@ -4946,6 +4946,28 @@ static int i915_panel_show(struct seq_file *m, void *data)
 }
 DEFINE_SHOW_ATTRIBUTE(i915_panel);
 
+static int i915_hdcp_sink_capability_show(struct seq_file *m, void *data)
+{
+	struct drm_connector *connector = m->private;
+	struct intel_connector *intel_connector = to_intel_connector(connector);
+
+	if (connector->status != connector_status_connected)
+		return -ENODEV;
+
+	/* HDCP is supported by connector */
+	if (!intel_connector->hdcp_shim)
+		return -EINVAL;
+
+	seq_printf(m, "%s:%d HDCP version: ", connector->name,
+		   connector->base.id);
+	seq_printf(m, "%s ", !intel_hdcp_capable(intel_connector) ?
+		   "None" : "HDCP1.4");
+	seq_puts(m, "\n");
+
+	return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(i915_hdcp_sink_capability);
+
 /**
  * i915_debugfs_connector_add - add i915 specific connector debugfs files
  * @connector: pointer to a registered drm_connector
@@ -4975,5 +4997,12 @@ int i915_debugfs_connector_add(struct drm_connector *connector)
 				    connector, &i915_psr_sink_status_fops);
 	}
 
+	if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
+	    connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
+	    connector->connector_type == DRM_MODE_CONNECTOR_HDMIB) {
+		debugfs_create_file("i915_hdcp_sink_capability", S_IRUGO, root,
+				    connector, &i915_hdcp_sink_capability_fops);
+	}
+
 	return 0;
 }
drivers/gpu/drm/i915/intel_drv.h +7 -0
index b2ca9f278b36..249bb9d1b5d0 100644
@@ -1296,6 +1296,12 @@ enc_to_dig_port(struct drm_encoder *encoder)
 		return NULL;
 }
 
+static inline struct intel_digital_port *
+conn_to_dig_port(struct intel_connector *connector)
+{
+	return enc_to_dig_port(&intel_attached_encoder(&connector->base)->base);
+}
+
 static inline struct intel_dp_mst_encoder *
 enc_to_mst(struct drm_encoder *encoder)
 {
@@ -1956,6 +1962,7 @@ int intel_hdcp_enable(struct intel_connector *connector);
 int intel_hdcp_disable(struct intel_connector *connector);
 int intel_hdcp_check_link(struct intel_connector *connector);
 bool is_hdcp_supported(struct drm_i915_private *dev_priv, enum port port);
+bool intel_hdcp_capable(struct intel_connector *connector);
 
 /* intel_psr.c */
 #define CAN_PSR(dev_priv) (HAS_PSR(dev_priv) && dev_priv->psr.sink_support)
drivers/gpu/drm/i915/intel_hdcp.c +21 -6
index 20908ff018e6..283b45636668 100644
@@ -51,6 +51,27 @@ int intel_hdcp_read_valid_bksv(struct intel_digital_port *intel_dig_port,
 	return 0;
 }
 
+/* Is HDCP1.4 capable on Platform and Sink */
+bool intel_hdcp_capable(struct intel_connector *connector)
+{
+	struct intel_digital_port *intel_dig_port = conn_to_dig_port(connector);
+	const struct intel_hdcp_shim *shim = connector->hdcp_shim;
+	bool capable = false;
+	u8 bksv[5];
+
+	if (!shim)
+		return capable;
+
+	if (shim->hdcp_capable) {
+		shim->hdcp_capable(intel_dig_port, &capable);
+	} else {
+		if (!intel_hdcp_read_valid_bksv(intel_dig_port, shim, bksv))
+			capable = true;
+	}
+
+	return capable;
+}
+
 static int intel_hdcp_poll_ksv_fifo(struct intel_digital_port *intel_dig_port,
 				    const struct intel_hdcp_shim *shim)
 {
@@ -632,12 +653,6 @@ static int intel_hdcp_auth(struct intel_digital_port *intel_dig_port,
 	return 0;
 }
 
-static
-struct intel_digital_port *conn_to_dig_port(struct intel_connector *connector)
-{
-	return enc_to_dig_port(&intel_attached_encoder(&connector->base)->base);
-}
-
 static int _intel_hdcp_disable(struct intel_connector *connector)
 {
 	struct drm_i915_private *dev_priv = connector->base.dev->dev_private;
drivers/gpu/drm/i915/intel_hdmi.c +15 -1
index 89d5e3984452..72e8a73dfa1c 100644
@@ -2072,6 +2072,20 @@ static void chv_hdmi_pre_enable(struct intel_encoder *encoder,
 	chv_phy_release_cl2_override(encoder);
 }
 
+static int
+intel_hdmi_connector_register(struct drm_connector *connector)
+{
+	int ret;
+
+	ret = intel_connector_register(connector);
+	if (ret)
+		return ret;
+
+	i915_debugfs_connector_add(connector);
+
+	return ret;
+}
+
 static void intel_hdmi_destroy(struct drm_connector *connector)
 {
 	if (intel_attached_hdmi(connector)->cec_notifier)
@@ -2086,7 +2100,7 @@ static const struct drm_connector_funcs intel_hdmi_connector_funcs = {
 	.fill_modes = drm_helper_probe_single_connector_modes,
 	.atomic_get_property = intel_digital_connector_atomic_get_property,
 	.atomic_set_property = intel_digital_connector_atomic_set_property,
-	.late_register = intel_connector_register,
+	.late_register = intel_hdmi_connector_register,
 	.early_unregister = intel_connector_unregister,
 	.destroy = intel_hdmi_destroy,
 	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

✗ Fi.CI.CHECKPATCH: warning for Enabling the IGT for HDCP1.4 (rev4)

In reply to Ramalingam C
== Series Details ==

== Series Details ==

Series: Enabling the IGT for HDCP1.4 (rev4)
URL : https://patchwork.freedesktop.org/series/51113/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
1698e218c4ae drm/i915: Pullout the bksv read and validation
e82aaa2cb827 drm/i915: hdcp_check_link only on CP_IRQ
757bbb8cb440 drm/i915/debugfs: hdcp capability of a sink
-:54: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
#54: FILE: drivers/gpu/drm/i915/i915_debugfs.c:5034:
+		debugfs_create_file("i915_hdcp_sink_capability", S_IRUGO, root,

total: 0 errors, 1 warnings, 0 checks, 126 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

✗ Fi.CI.BAT: failure for Enabling the IGT for HDCP1.4 (rev4)

In reply to Ramalingam C
== Series Details ==

== Series Details ==

Series: Enabling the IGT for HDCP1.4 (rev4)
URL : https://patchwork.freedesktop.org/series/51113/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_5017 -> Patchwork_10527 =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_10527 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10527, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/51113/revisions/4/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10527:

=== IGT changes ===

    ==== Possible regressions ====

    igt@debugfs_test@read_all_entries:
      fi-skl-iommu:       PASS -> DMESG-WARN
      fi-bdw-gvtdvm:      PASS -> DMESG-WARN
      fi-bdw-5557u:       PASS -> DMESG-WARN
      fi-skl-guc:         PASS -> DMESG-WARN
      fi-glk-j4005:       PASS -> DMESG-WARN
      fi-cfl-8700k:       PASS -> DMESG-WARN
      fi-cfl-guc:         PASS -> DMESG-WARN

== Known issues ==

Here are the changes found in Patchwork_10527 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_store@basic-all:
      fi-icl-u:           NOTRUN -> DMESG-WARN (fdo#107732) +5

    igt@gem_exec_suspend@basic:
      fi-icl-u:           NOTRUN -> DMESG-WARN (fdo#107724) +24

    igt@gem_exec_suspend@basic-s3:
      fi-icl-u:           NOTRUN -> DMESG-WARN (fdo#108512)

    igt@gem_mmap@basic-small-bo:
      fi-icl-u2:          NOTRUN -> DMESG-WARN (fdo#107732) +1

    
    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-kbl-7500u:       DMESG-WARN (fdo#105128, fdo#107139) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     FAIL (fdo#103167) -> PASS

    igt@prime_vgem@basic-fence-flip:
      fi-cfl-8700k:       FAIL (fdo#104008) -> PASS

fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
fdo#107732 https://bugs.freedesktop.org/show_bug.cgi?id=107732
fdo#108512 https://bugs.freedesktop.org/show_bug.cgi?id=108512

== Participating hosts (51 -> 46) ==

Additional (1): fi-icl-u
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600

== Build changes ==

* Linux: CI_DRM_5017 -> Patchwork_10527

CI_DRM_5017: 9510f8e44127260f92b5b6c3127aafa22b15f741 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4685: 78619fde4008424c472906041edb1d204e014f7c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10527: 757bbb8cb440de47c5c48ba5ca87c76681075424 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

757bbb8cb440 drm/i915/debugfs: hdcp capability of a sink e82aaa2cb827 drm/i915: hdcp_check_link only on CP_IRQ 1698e218c4ae drm/i915: Pullout the bksv read and validation

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10527/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

Re: ✗ Fi.CI.BAT: failure for Enabling the IGT for HDCP1.4 (rev4)

Quoted 23 lines · Patchwork

== Series Details ==

Series: Enabling the IGT for HDCP1.4 (rev4)
URL : https://patchwork.freedesktop.org/series/51113/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_5017 -> Patchwork_10527 =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_10527 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10527, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

   External URL: https://patchwork.freedesktop.org/api/1.0/series/51113/revisions/4/mbox/

== Possible new issues ==

Quoted 14 lines
   Here are the unknown changes that may have been introduced in Patchwork_10527:

   === IGT changes ===

     ==== Possible regressions ====

     igt@debugfs_test@read_all_entries:
       fi-skl-iommu:       PASS -> DMESG-WARN
       fi-bdw-gvtdvm:      PASS -> DMESG-WARN
       fi-bdw-5557u:       PASS -> DMESG-WARN
       fi-skl-guc:         PASS -> DMESG-WARN
       fi-glk-j4005:       PASS -> DMESG-WARN
       fi-cfl-8700k:       PASS -> DMESG-WARN
       fi-cfl-guc:         PASS -> DMESG-WARN

All these dmesg warnings are there because of the sink in CI which doesn't support hdcp registers. Which is expected in case of dummy HDMI sinks. So we could go ahead and merge these patches.

--Ram

Quoted 60 lines

== Known issues ==

   Here are the changes found in Patchwork_10527 that come from known issues:

   === IGT changes ===

     ==== Issues hit ====

     igt@gem_exec_store@basic-all:
       fi-icl-u:           NOTRUN -> DMESG-WARN (fdo#107732) +5

     igt@gem_exec_suspend@basic:
       fi-icl-u:           NOTRUN -> DMESG-WARN (fdo#107724) +24

     igt@gem_exec_suspend@basic-s3:
       fi-icl-u:           NOTRUN -> DMESG-WARN (fdo#108512)

     igt@gem_mmap@basic-small-bo:
       fi-icl-u2:          NOTRUN -> DMESG-WARN (fdo#107732) +1

     
     ==== Possible fixes ====

     igt@gem_exec_suspend@basic-s4-devices:
       fi-kbl-7500u:       DMESG-WARN (fdo#105128, fdo#107139) -> PASS

     igt@kms_frontbuffer_tracking@basic:
       fi-byt-clapper:     FAIL (fdo#103167) -> PASS

     igt@prime_vgem@basic-fence-flip:
       fi-cfl-8700k:       FAIL (fdo#104008) -> PASS

     
   fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
   fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
   fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
   fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
   fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
   fdo#107732 https://bugs.freedesktop.org/show_bug.cgi?id=107732
   fdo#108512 https://bugs.freedesktop.org/show_bug.cgi?id=108512

== Participating hosts (51 -> 46) ==

Additional (1): fi-icl-u
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600

== Build changes ==

* Linux: CI_DRM_5017 -> Patchwork_10527

   CI_DRM_5017: 9510f8e44127260f92b5b6c3127aafa22b15f741 @ git://anongit.freedesktop.org/gfx-ci/linux
   IGT_4685: 78619fde4008424c472906041edb1d204e014f7c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
   Patchwork_10527: 757bbb8cb440de47c5c48ba5ca87c76681075424 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

Quoted 7 lines

757bbb8cb440 drm/i915/debugfs: hdcp capability of a sink e82aaa2cb827 drm/i915: hdcp_check_link only on CP_IRQ 1698e218c4ae drm/i915: Pullout the bksv read and validation

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10527/issues.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

Re: ✗ Fi.CI.BAT: failure for Enabling the IGT for HDCP1.4 (rev4)

Quoted 40 lines · Ramalingam
Quoted 27 lines · Patchwork

== Series Details ==

Series: Enabling the IGT for HDCP1.4 (rev4)
URL : https://patchwork.freedesktop.org/series/51113/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_5017 -> Patchwork_10527 =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_10527 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10527, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/51113/revisions/4/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10527:

=== IGT changes ===

Quoted 10 lines
    ==== Possible regressions ====

    igt@debugfs_test@read_all_entries:
      fi-skl-iommu:       PASS -> DMESG-WARN
      fi-bdw-gvtdvm:      PASS -> DMESG-WARN
      fi-bdw-5557u:       PASS -> DMESG-WARN
      fi-skl-guc:         PASS -> DMESG-WARN
      fi-glk-j4005:       PASS -> DMESG-WARN
      fi-cfl-8700k:       PASS -> DMESG-WARN
      fi-cfl-guc:         PASS -> DMESG-WARN
Quoted 2 lines

All these dmesg warnings are there because of the sink in CI which doesn't support hdcp registers. Which is expected in case of dummy HDMI sinks. So we could go ahead and merge these patches.

DMESG-WARN is not allowed for any test, so the patch is currently unacceptable. Please simply report that the sync does not support HDCP in i915_hdcp_sink_capability, but no warnings are allowed in dmesg.

In Linux, we put the cost of integration on the person writing the patch. Thus, if you need to rework the internals of i915 to achieve a warning-free dmesg log, you will be expected to do so, so as not to regress anything.

Looking forward to seeing an updated patch :)

PS: The retry button should not be pressed lightly as it steals machine time from other tasks. If you believe some noise might just have happened and blocked the testing of your patch series, please contact me to file a bug in our suppression system (CI Bug Log) *before* being allowed to press the button.

Quoted 67 lines

--Ram

Quoted 64 lines

== Known issues ==

Here are the changes found in Patchwork_10527 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_store@basic-all:
      fi-icl-u:           NOTRUN -> DMESG-WARN (fdo#107732) +5

    igt@gem_exec_suspend@basic:
      fi-icl-u:           NOTRUN -> DMESG-WARN (fdo#107724) +24

    igt@gem_exec_suspend@basic-s3:
      fi-icl-u:           NOTRUN -> DMESG-WARN (fdo#108512)

    igt@gem_mmap@basic-small-bo:
      fi-icl-u2:          NOTRUN -> DMESG-WARN (fdo#107732) +1

    
    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-kbl-7500u:       DMESG-WARN (fdo#105128, fdo#107139) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     FAIL (fdo#103167) -> PASS

    igt@prime_vgem@basic-fence-flip:
      fi-cfl-8700k:       FAIL (fdo#104008) -> PASS

fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
fdo#107732 https://bugs.freedesktop.org/show_bug.cgi?id=107732
fdo#108512 https://bugs.freedesktop.org/show_bug.cgi?id=108512

== Participating hosts (51 -> 46) ==

Additional (1): fi-icl-u
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600

== Build changes ==

* Linux: CI_DRM_5017 -> Patchwork_10527

CI_DRM_5017: 9510f8e44127260f92b5b6c3127aafa22b15f741 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4685: 78619fde4008424c472906041edb1d204e014f7c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10527: 757bbb8cb440de47c5c48ba5ca87c76681075424 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

757bbb8cb440 drm/i915/debugfs: hdcp capability of a sink e82aaa2cb827 drm/i915: hdcp_check_link only on CP_IRQ 1698e218c4ae drm/i915: Pullout the bksv read and validation

Quoted 9 lines
Quoted 3 lines

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10527/issues.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

Re: ✗ Fi.CI.BAT: failure for Enabling the IGT for HDCP1.4 (rev4)

Quoted 41 lines · Martin Peres
Quoted 38 lines · Ramalingam
Quoted 23 lines · Patchwork

== Series Details ==

Series: Enabling the IGT for HDCP1.4 (rev4)
URL : https://patchwork.freedesktop.org/series/51113/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_5017 -> Patchwork_10527 =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_10527 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10527, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

   External URL: https://patchwork.freedesktop.org/api/1.0/series/51113/revisions/4/mbox/

== Possible new issues ==

Quoted 14 lines
   Here are the unknown changes that may have been introduced in Patchwork_10527:

   === IGT changes ===

     ==== Possible regressions ====

     igt@debugfs_test@read_all_entries:
       fi-skl-iommu:       PASS -> DMESG-WARN
       fi-bdw-gvtdvm:      PASS -> DMESG-WARN
       fi-bdw-5557u:       PASS -> DMESG-WARN
       fi-skl-guc:         PASS -> DMESG-WARN
       fi-glk-j4005:       PASS -> DMESG-WARN
       fi-cfl-8700k:       PASS -> DMESG-WARN
       fi-cfl-guc:         PASS -> DMESG-WARN
Quoted 2 lines

All these dmesg warnings are there because of the sink in CI which doesn't support hdcp registers. Which is expected in case of dummy HDMI sinks. So we could go ahead and merge these patches.

Quoted 8 lines

DMESG-WARN is not allowed for any test, so the patch is currently unacceptable. Please simply report that the sync does not support HDCP in i915_hdcp_sink_capability, but no warnings are allowed in dmesg.

In Linux, we put the cost of integration on the person writing the patch. Thus, if you need to rework the internals of i915 to achieve a warning-free dmesg log, you will be expected to do so, so as not to regress anything.

Thanks Martin, for pointing it out. These errors were part of authentication we have. New patches are using a routine from auth flow hence when DDC request fail caused these errors. As I had a closure with danvet, I will move these errors to debug level.

Quoted 8 lines

Looking forward to seeing an updated patch :)

PS: The retry button should not be pressed lightly as it steals machine time from other tasks. If you believe some noise might just have happened and blocked the testing of your patch series, please contact me to file a bug in our suppression system (CI Bug Log) *before* being allowed to press the button.

Agreed. At first attempt to request retest I saw that without result update, re-queued for test state was gone. So clicked couple of times.
I remember this mistake next time. :)

Thanks,
--Ram

Quoted 67 lines
Quoted 67 lines

--Ram

Quoted 64 lines

== Known issues ==

   Here are the changes found in Patchwork_10527 that come from known issues:

   === IGT changes ===

     ==== Issues hit ====

     igt@gem_exec_store@basic-all:
       fi-icl-u:           NOTRUN -> DMESG-WARN (fdo#107732) +5

     igt@gem_exec_suspend@basic:
       fi-icl-u:           NOTRUN -> DMESG-WARN (fdo#107724) +24

     igt@gem_exec_suspend@basic-s3:
       fi-icl-u:           NOTRUN -> DMESG-WARN (fdo#108512)

     igt@gem_mmap@basic-small-bo:
       fi-icl-u2:          NOTRUN -> DMESG-WARN (fdo#107732) +1

     
     ==== Possible fixes ====

     igt@gem_exec_suspend@basic-s4-devices:
       fi-kbl-7500u:       DMESG-WARN (fdo#105128, fdo#107139) -> PASS

     igt@kms_frontbuffer_tracking@basic:
       fi-byt-clapper:     FAIL (fdo#103167) -> PASS

     igt@prime_vgem@basic-fence-flip:
       fi-cfl-8700k:       FAIL (fdo#104008) -> PASS

     
   fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
   fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
   fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
   fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
   fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
   fdo#107732 https://bugs.freedesktop.org/show_bug.cgi?id=107732
   fdo#108512 https://bugs.freedesktop.org/show_bug.cgi?id=108512

== Participating hosts (51 -> 46) ==

Additional (1): fi-icl-u
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600

== Build changes ==

* Linux: CI_DRM_5017 -> Patchwork_10527

   CI_DRM_5017: 9510f8e44127260f92b5b6c3127aafa22b15f741 @ git://anongit.freedesktop.org/gfx-ci/linux
   IGT_4685: 78619fde4008424c472906041edb1d204e014f7c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
   Patchwork_10527: 757bbb8cb440de47c5c48ba5ca87c76681075424 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

757bbb8cb440 drm/i915/debugfs: hdcp capability of a sink e82aaa2cb827 drm/i915: hdcp_check_link only on CP_IRQ 1698e218c4ae drm/i915: Pullout the bksv read and validation

Quoted 8 lines
Quoted 8 lines
Quoted 3 lines

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10527/issues.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw

✗ Fi.CI.BAT: failure for Enabling the IGT for HDCP1.4 (rev4)

In reply to Ramalingam C
== Series Details ==

== Series Details ==

Series: Enabling the IGT for HDCP1.4 (rev4)
URL : https://patchwork.freedesktop.org/series/51113/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_5019 -> Patchwork_10534 =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_10534 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10534, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/51113/revisions/4/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10534:

=== IGT changes ===

    ==== Possible regressions ====

    igt@debugfs_test@read_all_entries:
      fi-skl-iommu:       PASS -> DMESG-WARN
      fi-bdw-gvtdvm:      PASS -> DMESG-WARN
      fi-bdw-5557u:       PASS -> DMESG-WARN
      fi-glk-j4005:       PASS -> DMESG-WARN
      fi-cfl-8700k:       PASS -> DMESG-WARN
      fi-cfl-guc:         PASS -> DMESG-WARN

    
    ==== Warnings ====

    igt@drv_selftest@live_guc:
      fi-apl-guc:         PASS -> SKIP

== Known issues ==

Here are the changes found in Patchwork_10534 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_execlists:
      fi-apl-guc:         PASS -> INCOMPLETE (fdo#106693)

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     PASS -> FAIL (fdo#103167)

    
    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-blb-e6850:       INCOMPLETE (fdo#107718) -> PASS

    igt@pm_rpm@module-reload:
      fi-skl-6600u:       INCOMPLETE (fdo#107807) -> PASS

fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#106693 https://bugs.freedesktop.org/show_bug.cgi?id=106693
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807

== Participating hosts (48 -> 44) ==

Additional (1): fi-byt-j1900
Missing (5): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-u

== Build changes ==

* Linux: CI_DRM_5019 -> Patchwork_10534

CI_DRM_5019: 8d7ffd2298c607c3e1a16f94d51450d7940fd6a7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4685: 78619fde4008424c472906041edb1d204e014f7c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10534: 00a5edf03c741ef06b40e18851ffc31658aa78e4 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

00a5edf03c74 drm/i915/debugfs: hdcp capability of a sink bc4480524e0a drm/i915: hdcp_check_link only on CP_IRQ 5ab3b00a3d86 drm/i915: Pullout the bksv read and validation

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10534/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

✗ Fi.CI.BAT: failure for Enabling the IGT for HDCP1.4 (rev4)

In reply to Ramalingam C
== Series Details ==

== Series Details ==

Series: Enabling the IGT for HDCP1.4 (rev4)
URL : https://patchwork.freedesktop.org/series/51113/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_5019 -> Patchwork_10535 =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_10535 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10535, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/51113/revisions/4/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10535:

=== IGT changes ===

    ==== Possible regressions ====

    igt@debugfs_test@read_all_entries:
      fi-skl-iommu:       PASS -> DMESG-WARN
      fi-bdw-gvtdvm:      PASS -> DMESG-WARN
      fi-bdw-5557u:       PASS -> DMESG-WARN
      fi-glk-j4005:       PASS -> DMESG-WARN
      fi-cfl-8700k:       PASS -> DMESG-WARN
      fi-cfl-guc:         PASS -> DMESG-WARN

== Known issues ==

Here are the changes found in Patchwork_10535 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_store@basic-render:
      fi-icl-u:           PASS -> DMESG-WARN (fdo#107732) +4

    igt@gem_exec_suspend@basic-s3:
      fi-kbl-soraka:      NOTRUN -> INCOMPLETE (fdo#107859, fdo#107774, fdo#107556)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-icl-u:           PASS -> INCOMPLETE (fdo#107713)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-skl-6700k2:      PASS -> FAIL (fdo#103191, fdo#107362)
      fi-blb-e6850:       NOTRUN -> INCOMPLETE (fdo#107718)

    
    ==== Possible fixes ====

    igt@gem_exec_store@basic-all:
      fi-icl-u:           DMESG-WARN (fdo#107732) -> PASS

    igt@gem_exec_suspend@basic-s4-devices:
      fi-blb-e6850:       INCOMPLETE (fdo#107718) -> PASS

    igt@pm_rpm@module-reload:
      fi-skl-6600u:       INCOMPLETE (fdo#107807) -> PASS

fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
fdo#107713 https://bugs.freedesktop.org/show_bug.cgi?id=107713
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107732 https://bugs.freedesktop.org/show_bug.cgi?id=107732
fdo#107774 https://bugs.freedesktop.org/show_bug.cgi?id=107774
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107859 https://bugs.freedesktop.org/show_bug.cgi?id=107859

== Participating hosts (48 -> 45) ==

Additional (1): fi-kbl-soraka
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan

== Build changes ==

* Linux: CI_DRM_5019 -> Patchwork_10535

CI_DRM_5019: 8d7ffd2298c607c3e1a16f94d51450d7940fd6a7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4685: 78619fde4008424c472906041edb1d204e014f7c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10535: 056ea167bc744dfee0f65d4a09380afaeacc36f5 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

056ea167bc74 drm/i915/debugfs: hdcp capability of a sink 5cec031f358a drm/i915: hdcp_check_link only on CP_IRQ 9c00eb624e93 drm/i915: Pullout the bksv read and validation

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10535/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#11 lore raw

✗ Fi.CI.BAT: failure for Enabling the IGT for HDCP1.4 (rev4)

In reply to Ramalingam C
== Series Details ==

== Series Details ==

Series: Enabling the IGT for HDCP1.4 (rev4)
URL : https://patchwork.freedesktop.org/series/51113/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_5019 -> Patchwork_10536 =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_10536 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10536, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/51113/revisions/4/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10536:

=== IGT changes ===

    ==== Possible regressions ====

    igt@debugfs_test@read_all_entries:
      fi-skl-iommu:       PASS -> DMESG-WARN
      fi-bdw-gvtdvm:      PASS -> DMESG-WARN
      fi-bdw-5557u:       PASS -> DMESG-WARN
      fi-skl-guc:         NOTRUN -> DMESG-WARN
      fi-glk-j4005:       PASS -> DMESG-WARN
      fi-cfl-8700k:       PASS -> DMESG-WARN
      fi-cfl-guc:         PASS -> DMESG-WARN

== Known issues ==

Here are the changes found in Patchwork_10536 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_suspend@basic-s3:
      fi-kbl-soraka:      NOTRUN -> INCOMPLETE (fdo#107774, fdo#107859, fdo#107556)

    igt@kms_flip@basic-flip-vs-modeset:
      fi-skl-6700hq:      PASS -> DMESG-WARN (fdo#105998) +1

    
    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-blb-e6850:       INCOMPLETE (fdo#107718) -> PASS

    igt@pm_rpm@module-reload:
      fi-skl-6600u:       INCOMPLETE (fdo#107807) -> PASS

fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107774 https://bugs.freedesktop.org/show_bug.cgi?id=107774
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107859 https://bugs.freedesktop.org/show_bug.cgi?id=107859

== Participating hosts (48 -> 44) ==

Additional (2): fi-kbl-soraka fi-skl-guc
Missing (6): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-icl-u2 fi-ctg-p8600 fi-icl-u

== Build changes ==

* Linux: CI_DRM_5019 -> Patchwork_10536

CI_DRM_5019: 8d7ffd2298c607c3e1a16f94d51450d7940fd6a7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4685: 78619fde4008424c472906041edb1d204e014f7c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10536: ea670f55266cec1c91b43a20c228f72b51a9d7d1 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

ea670f55266c drm/i915/debugfs: hdcp capability of a sink d6f421dcb115 drm/i915: hdcp_check_link only on CP_IRQ f8c22efafec2 drm/i915: Pullout the bksv read and validation

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10536/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx