Skip to contentSkip to conversation

ARM: dts: fsl-imx8qxp-mek: Move regulator outside "simple-bus"

PATCH New Fabio Estevam 2 participants 4 messages Oct 26, 2018

Subsystems (2)
Arm (32-bit) Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: dts: fsl-imx8qxp-mek: Move regulator outside "simple-bus"

Commit 3c28576bb0f0 ("arm: dts: imx8qxp: fix build warining") fixed the dts warning by removing the unnecessary #address-cells/#size-cells, but the recommendation for regulators is not to place them under "simple-bus", so move the reg_usdhc2_vmmc regulator accordingly.

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/dts/fsl-imx8qxp-mek.dts | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)
arch/arm/dts/fsl-imx8qxp-mek.dts +8 -12
index c14e184..adab494 100644
@@ -16,18 +16,14 @@
 		stdout-path = &lpuart0;
 	};
 
-	regulators {
-		compatible = "simple-bus";
-
-		reg_usdhc2_vmmc: usdhc2-vmmc {
-			compatible = "regulator-fixed";
-			regulator-name = "SD1_SPWR";
-			regulator-min-microvolt = <3000000>;
-			regulator-max-microvolt = <3000000>;
-			gpio = <&gpio4 19 GPIO_ACTIVE_HIGH>;
-			off-on-delay = <3480>;
-			enable-active-high;
-		};
+	reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
+		compatible = "regulator-fixed";
+		regulator-name = "SD1_SPWR";
+		regulator-min-microvolt = <3000000>;
+		regulator-max-microvolt = <3000000>;
+		gpio = <&gpio4 19 GPIO_ACTIVE_HIGH>;
+		off-on-delay = <3480>;
+		enable-active-high;
 	};
 };
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 ARM: dts: fsl-imx8qxp-mek: Move regulator outside "simple-bus"

Hi Fabio,

Quoted 25 lines

-----Original Message-----
From: Fabio Estevam [mailto:festevam at gmail.com]
Sent: 2018年10月26日 8:50
To: sbabic at denx.de
Cc: Peng Fan <[email protected]>; u-boot at lists.denx.de; Fabio Estevam <[email protected]>
Subject: [PATCH] ARM: dts: fsl-imx8qxp-mek: Move regulator outside "simple-bus"

Commit 3c28576bb0f0 ("arm: dts: imx8qxp: fix build warining") fixed the dts warning by removing the unnecessary #address-cells/#size-cells, but the recommendation for regulators is not to place them under "simple-bus", so move the reg_usdhc2_vmmc regulator accordingly.

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/dts/fsl-imx8qxp-mek.dts | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)
arch/arm/dts/fsl-imx8qxp-mek.dts +0 -0
index c14e184..adab494 100644

arch/arm/dts/fsl-imx8qxp-mek.dts line 19

Quoted 4 lines
arch/arm/dts/fsl-imx8qxp-mek.dts +0 -1
@@ -16,18 +16,14 @@
 		stdout-path = &lpuart0;
 	};
 
-	regulators {

Will it be better to keep regulators node? Currently it only has the usdhc2, but in future, the usb regulator will also be added.

Thanks,
Peng.

Quoted 24 lines
arch/arm/dts/fsl-imx8qxp-mek.dts +8 -12
-		compatible = "simple-bus";
-
-		reg_usdhc2_vmmc: usdhc2-vmmc {
-			compatible = "regulator-fixed";
-			regulator-name = "SD1_SPWR";
-			regulator-min-microvolt = <3000000>;
-			regulator-max-microvolt = <3000000>;
-			gpio = <&gpio4 19 GPIO_ACTIVE_HIGH>;
-			off-on-delay = <3480>;
-			enable-active-high;
-		};
+	reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
+		compatible = "regulator-fixed";
+		regulator-name = "SD1_SPWR";
+		regulator-min-microvolt = <3000000>;
+		regulator-max-microvolt = <3000000>;
+		gpio = <&gpio4 19 GPIO_ACTIVE_HIGH>;
+		off-on-delay = <3480>;
+		enable-active-high;
 	};
 };
 
--

2.7.4

author reviewer
#2 lore raw

PATCH 1/1 ARM: dts: fsl-imx8qxp-mek: Move regulator outside "simple-bus"

Hi Peng,

Quoted 4 lines · Peng Fan
Quoted 1 line

- regulators {

Will it be better to keep regulators node? Currently it only has the usdhc2, but in future, the usb regulator will also be added.

When USB regulator gets added it will stay below the usdhc2 regulator. No problem about this.

Upstream device tree maintainers do not like this unneeded regulator container node, so we should better align with upstream here.

#3 lore raw

PATCH 1/1 ARM: dts: fsl-imx8qxp-mek: Move regulator outside "simple-bus"

Quoted 16 lines

-----Original Message-----
From: Fabio Estevam [mailto:festevam at gmail.com]
Sent: 2018年10月26日 8:57
To: Peng Fan <[email protected]>
Cc: Stefano Babic <[email protected]>; U-Boot-Denx <[email protected]>
Subject: Re: [PATCH] ARM: dts: fsl-imx8qxp-mek: Move regulator outside "simple-bus"

Hi Peng,

Quoted 2 lines · Peng Fan
Quoted 1 line

- regulators {

Quoted 8 lines
Quoted 2 lines

Will it be better to keep regulators node? Currently it only has the usdhc2, but in future, the usb regulator will also be added.

When USB regulator gets added it will stay below the usdhc2 regulator. No problem about this.

Upstream device tree maintainers do not like this unneeded regulator container node, so we should better align with upstream here.

ok for me. Acked-by: Peng Fan <[email protected]>

Thanks,
Peng.