drm/amdgpu: Refine function name
Subsystems (2)
PATCH 1/2 drm/amdgpu: Refine function name
there is no functional changes.just
refine function name to keep
consistence with other files.
change amdgpu_get_sdma_instance toamdgpu_sdma_get_instance_from_ring.
suggested by alex.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 2 +- drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++-- 6 files changed, 10 insertions(+), 10 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c +1 -1
@@ -28,7 +28,7 @@* GPU SDMA IP block helpers function. */ -struct amdgpu_sdma_instance *amdgpu_get_sdma_instance (struct amdgpu_ring *ring) +struct amdgpu_sdma_instance *amdgpu_sdma_get_instance_from_ring (struct amdgpu_ring *ring) {struct amdgpu_device *adev = ring->adev;int i;
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h +1 -1
@@ -94,6 +94,6 @@ struct amdgpu_buffer_funcs {#define amdgpu_emit_fill_buffer (adev, ib, s, d, b) (adev)->mman.buffer_funcs->emit_fill_buffer((ib), (s), (d), (b))struct amdgpu_sdma_instance * -amdgpu_get_sdma_instance (struct amdgpu_ring *ring); +amdgpu_sdma_get_instance_from_ring (struct amdgpu_ring *ring);#endif
drivers/gpu/drm/amd/amdgpu/cik_sdma.c +2 -2
@@ -198,7 +198,7 @@ static void cik_sdma_ring_set_wptr(struct amdgpu_ring *ring)static void cik_sdma_ring_insert_nop (struct amdgpu_ring *ring,uint32_t count) { -struct amdgpu_sdma_instance *sdma =amdgpu_get_sdma_instance (ring); +struct amdgpu_sdma_instance *sdma =amdgpu_sdma_get_instance_from_ring (ring);int i;for (i =0 ; i < count; i++)
@@ -803,7 +803,7 @@ static void cik_sdma_vm_set_pte_pde(struct amdgpu_ib *ib, uint64_t pe,*/ static void cik_sdma_ring_pad_ib (struct amdgpu_ring *ring,struct amdgpu_ib *ib) { -struct amdgpu_sdma_instance *sdma =amdgpu_get_sdma_instance (ring); +struct amdgpu_sdma_instance *sdma =amdgpu_sdma_get_instance_from_ring (ring);u32 pad_count;int i;
drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c +2 -2
@@ -225,7 +225,7 @@ static void sdma_v2_4_ring_set_wptr(struct amdgpu_ring *ring)static void sdma_v2_4_ring_insert_nop (struct amdgpu_ring *ring,uint32_t count) { -struct amdgpu_sdma_instance *sdma =amdgpu_get_sdma_instance (ring); +struct amdgpu_sdma_instance *sdma =amdgpu_sdma_get_instance_from_ring (ring);int i;for (i =0 ; i < count; i++)
@@ -740,7 +740,7 @@ static void sdma_v2_4_vm_set_pte_pde(struct amdgpu_ib *ib, uint64_t pe,*/ static void sdma_v2_4_ring_pad_ib (struct amdgpu_ring *ring,struct amdgpu_ib *ib) { -struct amdgpu_sdma_instance *sdma =amdgpu_get_sdma_instance (ring); +struct amdgpu_sdma_instance *sdma =amdgpu_sdma_get_instance_from_ring (ring);u32 pad_count;int i;
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c +2 -2
@@ -399,7 +399,7 @@ static void sdma_v3_0_ring_set_wptr(struct amdgpu_ring *ring)static void sdma_v3_0_ring_insert_nop (struct amdgpu_ring *ring,uint32_t count) { -struct amdgpu_sdma_instance *sdma =amdgpu_get_sdma_instance (ring); +struct amdgpu_sdma_instance *sdma =amdgpu_sdma_get_instance_from_ring (ring);int i;for (i =0 ; i < count; i++)
@@ -1011,7 +1011,7 @@ static void sdma_v3_0_vm_set_pte_pde(struct amdgpu_ib *ib, uint64_t pe,*/ static void sdma_v3_0_ring_pad_ib (struct amdgpu_ring *ring,struct amdgpu_ib *ib) { -struct amdgpu_sdma_instance *sdma =amdgpu_get_sdma_instance (ring); +struct amdgpu_sdma_instance *sdma =amdgpu_sdma_get_instance_from_ring (ring);u32 pad_count;int i;
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c +2 -2
@@ -477,7 +477,7 @@ static void sdma_v4_0_page_ring_set_wptr(struct amdgpu_ring *ring)static void sdma_v4_0_ring_insert_nop (struct amdgpu_ring *ring,uint32_t count) { -struct amdgpu_sdma_instance *sdma =amdgpu_get_sdma_instance (ring); +struct amdgpu_sdma_instance *sdma =amdgpu_sdma_get_instance_from_ring (ring);int i;for (i =0 ; i < count; i++)
@@ -1373,7 +1373,7 @@ static void sdma_v4_0_vm_set_pte_pde(struct amdgpu_ib *ib,*/ static void sdma_v4_0_ring_pad_ib (struct amdgpu_ring *ring,struct amdgpu_ib *ib) { -struct amdgpu_sdma_instance *sdma =amdgpu_get_sdma_instance (ring); +struct amdgpu_sdma_instance *sdma =amdgpu_sdma_get_instance_from_ring (ring);u32 pad_count;int i;
Signature · 6 lines
1.9.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1541051874-24185-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org
PATCH 2/2 drm/amdgpu: Add helper function to get sdma index
Get the sdma index from ring
v2: refine function name
--- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 16 ++++++++++++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 1 + 2 files changed, 17 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c +16 -0
@@ -40,3 +40,19 @@ struct amdgpu_sdma_instance *amdgpu_sdma_get_instance_from_ring(struct amdgpu_rireturn NULL ; } + +int amdgpu_sdma_get_index_from_ring (struct amdgpu_ring *ring,uint32_t *index) +{ +struct amdgpu_device *adev = ring->adev; +int i; + +for (i =0 ; i < adev->sdma.num_instances; i++) { +if (ring == &adev->sdma.instance[i].ring || + ring == &adev->sdma.instance[i].page) { + *index = i; +return 0 ; + } + } + +return -EINVAL ; +}
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h +1 -0
@@ -95,5 +95,6 @@ struct amdgpu_buffer_funcs {struct amdgpu_sdma_instance *amdgpu_sdma_get_instance_from_ring (struct amdgpu_ring *ring); +int amdgpu_sdma_get_index_from_ring (struct amdgpu_ring *ring,uint32_t *index);#endif
Signature · 6 lines
1.9.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1541051874-24185-2-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org
Re: [PATCH 2/2] drm/amdgpu: Add helper function to get sdma index
serie is Reviewed-by: Flora Cui <[email protected]>
Quoted 39 lines · Rex Zhu
Get the sdma index from ring
v2: refine function name
Signed-off-by Rex Zhu <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 16 ++++++++++++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 1 + 2 files changed, 17 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c +16
-0@@ -40,3 +40,19 @@ struct amdgpu_sdma_instance *amdgpu_sdma_get_instance_from_ring(struct amdgpu_rireturn NULL ; } + +int amdgpu_sdma_get_index_from_ring (struct amdgpu_ring *ring,uint32_t *index) +{ +struct amdgpu_device *adev = ring->adev; +int i; + +for (i =0 ; i < adev->sdma.num_instances; i++) { +if (ring == &adev->sdma.instance[i].ring || + ring == &adev->sdma.instance[i].page) { + *index = i; +return 0 ; + } + } + +return -EINVAL ; +}drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h struct amdgpu_buffer_funcs { · line 100
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h +1
-0@@ -95,5 +95,6 @@ struct amdgpu_buffer_funcs {struct amdgpu_sdma_instance *amdgpu_sdma_get_instance_from_ring (struct amdgpu_ring *ring); +int amdgpu_sdma_get_index_from_ring (struct amdgpu_ring *ring,uint32_t *index);#endif
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Alex Deucher
Reviewed-byRe: [PATCH 2/2] drm/amdgpu: Add helper function to get sdma index
In reply to a message not in the archiveQuoted 6 lines · Rex Zhu
Get the sdma index from ring
v2: refine function name
Signed-off-by Rex Zhu <[email protected]>
Series is:
Quoted 43 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 16 ++++++++++++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 1 + 2 files changed, 17 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c +16
-0@@ -40,3 +40,19 @@ struct amdgpu_sdma_instance *amdgpu_sdma_get_instance_from_ring(struct amdgpu_rireturn NULL ; } + +int amdgpu_sdma_get_index_from_ring (struct amdgpu_ring *ring,uint32_t *index) +{ +struct amdgpu_device *adev = ring->adev; +int i; + +for (i =0 ; i < adev->sdma.num_instances; i++) { +if (ring == &adev->sdma.instance[i].ring || + ring == &adev->sdma.instance[i].page) { + *index = i; +return 0 ; + } + } + +return -EINVAL ; +}drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h +1
-1@@ -95,5 +95,6 @@ struct amdgpu_buffer_funcs {struct amdgpu_sdma_instance *amdgpu_sdma_get_instance_from_ring (struct amdgpu_ring *ring); +int amdgpu_sdma_get_index_from_ring (struct amdgpu_ring *ring,uint32_t *index);#endif --1.9.1
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx