Skip to contentSkip to conversation

xen/grant-table: Fix incorrect gnttab_dma_free_pages() pr_debug message

PATCH Applied Liam Merwick 2 participants 5 messages Nov 2, 2018 – Nov 6, 2018 Xen hypervisor interface

lore
Share & tools
lore

Liam Merwick

author
#0 lore raw

PATCH 1/1 xen/grant-table: Fix incorrect gnttab_dma_free_pages() pr_debug message

If a call to xenmem_reservation_increase() in gnttab_dma_free_pages() fails it triggers a message "Failed to decrease reservation..." which should be "Failed to increase reservation..."

Fixes 9bdc7304f536 ('xen/grant-table: Allow allocating buffers suitable for DMA')
Reported-by Ross Philipson <[email protected]>
Signed-off-by Liam Merwick <[email protected]>
Reviewed-by Mark Kanda <[email protected]>
---
 drivers/xen/grant-table.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/xen/grant-table.c +1 -1
index 84575baceebc..97341fa75458 100644
@@ -914,7 +914,7 @@ int gnttab_dma_free_pages(struct gnttab_dma_alloc_args *args)
 
 	ret = xenmem_reservation_increase(args->nr_pages, args->frames);
 	if (ret != args->nr_pages) {
-		pr_debug("Failed to decrease reservation for DMA buffer\n");
+		pr_debug("Failed to increase reservation for DMA buffer\n");
 		ret = -EFAULT;
 	} else {
 		ret = 0;
Signature · 1 line
1.8.3.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Liam Merwick

If a call to xenmem_reservation_increase() in gnttab_dma_free_pages() fails it triggers a message "Failed to decrease reservation..." which should be "Failed to increase reservation..."

Fixes 9bdc7304f536 ('xen/grant-table: Allow allocating buffers suitable for DMA')
Reported-by Ross Philipson <[email protected]>
Signed-off-by Liam Merwick <[email protected]>
Reviewed-by Mark Kanda <[email protected]>
Reviewed-by Juergen Gross <[email protected]>

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Liam Merwick
Quoted 8 lines · Liam Merwick

If a call to xenmem_reservation_increase() in gnttab_dma_free_pages() fails it triggers a message "Failed to decrease reservation..." which should be "Failed to increase reservation..."

Fixes 9bdc7304f536 ('xen/grant-table: Allow allocating buffers suitable for DMA')
Reported-by Ross Philipson <[email protected]>
Signed-off-by Liam Merwick <[email protected]>
Reviewed-by Mark Kanda <[email protected]>
Reviewed-by Juergen Gross <[email protected]>

Juergen

maintainer Applied
#3 lore raw
In reply to Liam Merwick
Quoted 8 lines · Liam Merwick

If a call to xenmem_reservation_increase() in gnttab_dma_free_pages() fails it triggers a message "Failed to decrease reservation..." which should be "Failed to increase reservation..."

Fixes 9bdc7304f536 ('xen/grant-table: Allow allocating buffers suitable for DMA')
Reported-by Ross Philipson <[email protected]>
Signed-off-by Liam Merwick <[email protected]>
Reviewed-by Mark Kanda <[email protected]>

Pushed to xen.git for-linus-4.20a

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

maintainer Applied
#4 lore raw
In reply to Liam Merwick
Quoted 8 lines · Liam Merwick

If a call to xenmem_reservation_increase() in gnttab_dma_free_pages() fails it triggers a message "Failed to decrease reservation..." which should be "Failed to increase reservation..."

Fixes 9bdc7304f536 ('xen/grant-table: Allow allocating buffers suitable for DMA')
Reported-by Ross Philipson <[email protected]>
Signed-off-by Liam Merwick <[email protected]>
Reviewed-by Mark Kanda <[email protected]>

Pushed to xen.git for-linus-4.20a

Juergen