Skip to contentSkip to conversation

Fix warning in tc-skbprio.8 manpage

PATCH Applied Luca Boccassi 3 participants 5 messages Nov 2, 2018 – Nov 10, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix warning in tc-skbprio.8 manpage

". If" gets interpreted as a macro, so move the period to the previous line:

33: warning: macro `If' not defined

Fixes 141b55f8544e ("Add SKB Priority qdisc support in tc(8)")
---
 man/man8/tc-skbprio.8 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
man/man8/tc-skbprio.8 +2 -2
index 844bbf46..8b259839 100644
@@ -29,8 +29,8 @@ While SKB Priority Queue is agnostic to how
 .B skb->priority
 is assigned. A typical use case is to copy
 the 6-bit DS field of IPv4 and IPv6 packets using
-.BR tc-skbedit (8)
-. If
+.BR tc-skbedit (8) .
+If
 .B skb->priority
 is greater or equal to 64, the priority is assumed to be 63.
 Priorities less than 64 are taken at face value.
Signature · 1 line
2.19.1
#1 lore raw
Quoted 17 lines · Luca Boccassi

". If" gets interpreted as a macro, so move the period to the previous line:

33: warning: macro `If' not defined

Fixes 141b55f8544e ("Add SKB Priority qdisc support in tc(8)")
---
 man/man8/tc-skbprio.8 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
man/man8/tc-skbprio.8 +0 -0
index 844bbf46..8b259839 100644

man/man8/tc-skbprio.8 While SKB Priority Queue is agnostic to how · line 33

Quoted 7 lines
man/man8/tc-skbprio.8 +2 -2
@@ -29,8 +29,8 @@ While SKB Priority Queue is agnostic to how
 .B skb->priority
 is assigned. A typical use case is to copy
 the 6-bit DS field of IPv4 and IPv6 packets using
-.BR tc-skbedit (8)
-. If
+.BR tc-skbedit (8) .
+If

Won't that make the full-stop bold?
Removing the space, i.e.
.BR rc-skbedit (8).
ought to work.
-Ed

Quoted 3 lines
man/man8/tc-skbprio.8 +0 -0
 .B skb->priority
 is greater or equal to 64, the priority is assumed to be 63.
 Priorities less than 64 are taken at face value.
#2 lore raw
Quoted 24 lines · Edward Cree
Quoted 23 lines · Luca Boccassi

". If" gets interpreted as a macro, so move the period to the previous
line:

  33: warning: macro `If' not defined

Fixes 141b55f8544e ("Add SKB Priority qdisc support in tc(8)")

---
 man/man8/tc-skbprio.8 | 4 ++--

 1 file changed, 2 insertions(+), 2 deletions(-)
man/man8/tc-skbprio.8 +0 -0
index 844bbf46..8b259839 100644
@@ -29,8 +29,8 @@ While SKB Priority Queue is agnostic to how

 .B skb->priority
 is assigned. A typical use case is to copy the 6-bit DS field of IPv4 and IPv6 packets using -.BR tc-skbedit (8)
-. If

Quoted 8 lines
Quoted 2 lines

+.BR tc-skbedit (8) .
+If

Won't that make the full-stop bold?
Removing the space, i.e.
.BR rc-skbedit (8).
ought to work.
-Ed

Yes you are right, fixed in v2, thanks.

Signature · 2 lines
Kind regards,
Luca Boccassi
#3 lore raw

PATCH v2 1/1 Fix warning in tc-skbprio.8 manpage

In reply to Luca Boccassi

". If" gets interpreted as a macro, so move the period to the previous line:

33: warning: macro `If' not defined

Fixes 141b55f8544e ("Add SKB Priority qdisc support in tc(8)")

---
v2: remove extra space to avoid making the full-stop bold.

 man/man8/tc-skbprio.8 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
man/man8/tc-skbprio.8 +2 -2
index 844bbf46..a0a316ba 100644
@@ -29,8 +29,8 @@ While SKB Priority Queue is agnostic to how
 .B skb->priority
 is assigned. A typical use case is to copy
 the 6-bit DS field of IPv4 and IPv6 packets using
-.BR tc-skbedit (8)
-. If
+.BR tc-skbedit (8).
+If
 .B skb->priority
 is greater or equal to 64, the priority is assumed to be 63.
 Priorities less than 64 are taken at face value.
Signature · 1 line
2.19.1