Skip to contentSkip to conversation

s390: numa: Export __node_distance

PATCH In review Guenter Roeck 3 participants 3 messages Nov 4, 2018 – Nov 5, 2018 s390

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390: numa: Export __node_distance

__node_distance is used by nvme, resulting in:

ERROR: "__node_distance" [drivers/nvme/host/nvme-core.ko] undefined!

when trying to build nvme as module.

Fixes f333444708f8 ("nvme: take node locality into account when selecting a path")
Cc Christoph Hellwig <[email protected]>

---
I thought I had seen that patch already, but I don't find it anywhere. Maybe that was for another architecture. My apologies for the noise if it is already queued.

 arch/s390/numa/numa.c | 1 +
 1 file changed, 1 insertion(+)
arch/s390/numa/numa.c +1 -0
index ae0d9e889534..d31bde0870d8 100644
@@ -53,6 +53,7 @@ int __node_distance(int a, int b)
 {
 	return mode->distance ? mode->distance(a, b) : 0;
 }
+EXPORT_SYMBOL(__node_distance);
 
 int numa_debug_enabled;
 
Signature · 1 line
2.7.4
#1 lore raw
Quoted 22 lines · On Sun, 4 Nov 2018 13:28:06 -0800 Guenter Roeck <[email protected]> wrote:

__node_distance is used by nvme, resulting in:

ERROR: "__node_distance" [drivers/nvme/host/nvme-core.ko] undefined!

when trying to build nvme as module.

Fixes f333444708f8 ("nvme: take node locality into account when selecting a path")
Cc Christoph Hellwig <[email protected]>

---
I thought I had seen that patch already, but I don't find it anywhere. Maybe that was for another architecture. My apologies for the noise if it is already queued.

 arch/s390/numa/numa.c | 1 +
 1 file changed, 1 insertion(+)
arch/s390/numa/numa.c +0 -0
index ae0d9e889534..d31bde0870d8 100644

arch/s390/numa/numa.c int __node_distance(int a, int b) · line 59

Quoted 7 lines
arch/s390/numa/numa.c +1 -0
@@ -53,6 +53,7 @@ int __node_distance(int a, int b)
 {
 	return mode->distance ? mode->distance(a, b) : 0;
 }
+EXPORT_SYMBOL(__node_distance);
 
 int numa_debug_enabled;
 

That one is already queued. I'll do the __no_kasan_or_inline change that Linus requested and then send a please pull. Should be upstream in a few days.

For reference:

https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit/?h=for-linus&id=a541f0ebcc08ed8bc0cc492eec9a86cb280a9f24

Signature · 4 lines
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.
#2 lore raw
In reply to Guenter Roeck
Quoted 6 lines · Guenter Roeck

__node_distance is used by nvme, resulting in:

ERROR: "__node_distance" [drivers/nvme/host/nvme-core.ko] undefined!

when trying to build nvme as module.

Quoted 7 lines
Fixes f333444708f8 ("nvme: take node locality into account when selecting a path")
Cc Christoph Hellwig <[email protected]>

---
I thought I had seen that patch already, but I don't find it anywhere. Maybe that was for another architecture. My apologies for the noise if it is already queued.

It's already queued here: https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit/?h=for-linus&id=a541f0ebcc08ed8bc0cc492eec9a86cb280a9f24

Quoted 9 lines
arch/s390/numa/numa.c +1 -0
index ae0d9e889534..d31bde0870d8 100644
@@ -53,6 +53,7 @@ int __node_distance(int a, int b)
 {
 	return mode->distance ? mode->distance(a, b) : 0;
 }
+EXPORT_SYMBOL(__node_distance);