Enable ath10k wcn3990 wifi driver support on sdm845

PATCH In review Govind Singh 3 participants 15 messages Nov 5, 2018 – Dec 20, 2018

Subsystems (5)

Device tree bindings Arm Qualcomm mailing list Networking drivers (wireless) Arm Qualcomm support +1 more subsystems

lore

Share & tools

lore

Govind Singh

author

2018-11-05 13:08 UTC #0 lore raw

v4 cover Enable ath10k wcn3990 wifi driver support on sdm845

This series enables ath10k wifi driver support for WCN3990 target on sdm845 SOC. This series also updates the missing dt binding documentation and adds optional iommu property.

Changes since v3:
Moved interrupt/reg/reg-name to required property. Removed unused clocks.
Corrected interrupt no's.

Changes since v2:
dropped [v2,4/4] dts: arm64/sdm845: Enable iommu for WCN3990 wifi module device node patch from the series as dependent patch is not yet merged. Enabled status flag from sdm845-mtp.dts.

Changes since v1:
Listed no of interrupts/clocks for each set of compatible. Added missing 'wifi' label to sdm845.dtsi.

Govind Singh (3):
dt: bindings: add missing dt properties for WCN3990 wifi node
dts: arm64/sdm845: Add WCN3990 WLAN module device node
dt: bindings: add bindings for wifi iommu node

 .../bindings/net/wireless/qcom,ath10k.txt          | 62 ++++++++++++++--------
 arch/arm64/boot/dts/qcom/sdm845-mtp.dts            |  8 +++
 arch/arm64/boot/dts/qcom/sdm845.dtsi               | 26 +++++++++
 3 files changed, 74 insertions(+), 22 deletions(-)

Signature · 2 lines

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Govind Singh

author

2018-11-05 13:08 UTC #1 lore raw

PATCH v4 1/3 dt: bindings: add missing dt properties for WCN3990 wifi node

Add missing optional properties in WCN3990 wifi node.

Signed-off-by Govind Singh <[email protected]>

Reviewed-by Rob Herring <[email protected]>

Reviewed-by Brian Norris <[email protected]>

Tested-by Brian Norris <[email protected]>

---
 .../bindings/net/wireless/qcom,ath10k.txt          | 57 +++++++++++++---------
 1 file changed, 35 insertions(+), 22 deletions(-)

Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt +35 ~~-22~~

index 7fd4e8c..55d255c 100644
@@ -21,10 +21,22 @@ can be provided per device.
 
 SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
 
-Optional properties:
 - reg: Address and length of the register set for the device.
 - reg-names: Must include the list of following reg names,
 	     "membase"
+- interrupts: reference to the list of 17 interrupt numbers for "qcom,ipq4019-wifi"
+	      compatible target.
+	      reference to the list of 12 interrupt numbers for "qcom,wcn3990-wifi"
+	      compatible target.
+	      Must contain interrupt-names property per entry for
+	      "qcom,ath10k", "qcom,ipq4019-wifi" compatible targets.
+
+- interrupt-names: Must include the entries for MSI interrupt
+		   names ("msi0" to "msi15") and legacy interrupt
+		   name ("legacy") for "qcom,ath10k", "qcom,ipq4019-wifi"
+		   compatible targets.
+
+Optional properties:
 - resets: Must contain an entry for each entry in reset-names.
           See ../reset/reseti.txt for details.
 - reset-names: Must include the list of following reset names,

@@ -37,12 +49,9 @@ Optional properties:
 - clocks: List of clock specifiers, must contain an entry for each required
           entry in clock-names.
 - clock-names: Should contain the clock names "wifi_wcss_cmd", "wifi_wcss_ref",
-               "wifi_wcss_rtc".
-- interrupts: List of interrupt lines. Must contain an entry
-	      for each entry in the interrupt-names property.
-- interrupt-names: Must include the entries for MSI interrupt
-		   names ("msi0" to "msi15") and legacy interrupt
-		   name ("legacy"),
+	       "wifi_wcss_rtc" for "qcom,ipq4019-wifi" compatible target and
+	       "cxo_ref_clk_pin" for "qcom,wcn3990-wifi"
+	       compatible target.
 - qcom,msi_addr: MSI interrupt address.
 - qcom,msi_base: Base value to add before writing MSI data into
 		MSI address register.

@@ -55,7 +64,8 @@ Optional properties:
 - qcom,ath10k-pre-calibration-data : pre calibration data as an array,
 				     the length can vary between hw versions.
 - <supply-name>-supply: handle to the regulator device tree node
-			   optional "supply-name" is "vdd-0.8-cx-mx".
+			   optional "supply-name" are "vdd-0.8-cx-mx",
+			   "vdd-1.8-xo", "vdd-1.3-rfa" and "vdd-3.3-ch0".
 
 Example (to supply the calibration data alone):

@@ -133,20 +143,23 @@ wifi@18000000 {
 		compatible = "qcom,wcn3990-wifi";
 		reg = <0x18800000 0x800000>;
 		reg-names = "membase";
-		clocks = <&clock_gcc clk_aggre2_noc_clk>;
-		clock-names = "smmu_aggre2_noc_clk"
+		clocks = <&clock_gcc clk_rf_clk2_pin>;
+		clock-names = "cxo_ref_clk_pin";
 		interrupts =
-			   <0 130 0 /* CE0 */ >,
-			   <0 131 0 /* CE1 */ >,
-			   <0 132 0 /* CE2 */ >,
-			   <0 133 0 /* CE3 */ >,
-			   <0 134 0 /* CE4 */ >,
-			   <0 135 0 /* CE5 */ >,
-			   <0 136 0 /* CE6 */ >,
-			   <0 137 0 /* CE7 */ >,
-			   <0 138 0 /* CE8 */ >,
-			   <0 139 0 /* CE9 */ >,
-			   <0 140 0 /* CE10 */ >,
-			   <0 141 0 /* CE11 */ >;
+			<GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH>,
+			<GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH>,
+			<GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>,
+			<GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>,
+			<GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH>,
+			<GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH>,
+			<GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>,
+			<GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH>,
+			<GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH>,
+			<GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>,
+			<GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
+			<GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>;
 		vdd-0.8-cx-mx-supply = <&pm8998_l5>;
+		vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
+		vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
+		vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
 };

Signature · 2 lines

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Kalle Valo

2018-12-20 17:08 UTC #2 lore raw

Re: [PATCH v4 1/3] dt: bindings: add missing dt properties for WCN3990 wifi node

Quoted 7 lines · Govind Singh

Add missing optional properties in WCN3990 wifi node.
Signed-off-by Govind Singh <[email protected]>
Reviewed-by Rob Herring <[email protected]>
Reviewed-by Brian Norris <[email protected]>
Tested-by Brian Norris <[email protected]>
Signed-off-by Kalle Valo <[email protected]>

2 patches applied to ath-next branch of ath.git, thanks.

5fac78aac91d dt: bindings: ath10k: add missing dt properties for WCN3990 wifi node a3542d0c73ce dt: bindings: ath10k: add bindings for wifi iommu node

Signature · 3 lines

https://patchwork.kernel.org/patch/10668237/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Kalle Valo

2018-12-20 17:08 UTC #3 lore raw

Re: [PATCH v4 1/3] dt: bindings: add missing dt properties for WCN3990 wifi node

In reply to Govind Singh

Quoted 7 lines · Govind Singh

Add missing optional properties in WCN3990 wifi node.
Signed-off-by Govind Singh <[email protected]>
Reviewed-by Rob Herring <[email protected]>
Reviewed-by Brian Norris <[email protected]>
Tested-by Brian Norris <[email protected]>
Signed-off-by Kalle Valo <[email protected]>

2 patches applied to ath-next branch of ath.git, thanks.

5fac78aac91d dt: bindings: ath10k: add missing dt properties for WCN3990 wifi node a3542d0c73ce dt: bindings: ath10k: add bindings for wifi iommu node

Signature · 3 lines

https://patchwork.kernel.org/patch/10668237/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Kalle Valo

2018-12-20 17:08 UTC #4 lore raw

Re: [PATCH v4 1/3] dt: bindings: add missing dt properties for WCN3990 wifi node

In reply to Govind Singh

Quoted 7 lines · Govind Singh

Add missing optional properties in WCN3990 wifi node.
Signed-off-by Govind Singh <[email protected]>
Reviewed-by Rob Herring <[email protected]>
Reviewed-by Brian Norris <[email protected]>
Tested-by Brian Norris <[email protected]>
Signed-off-by Kalle Valo <[email protected]>

2 patches applied to ath-next branch of ath.git, thanks.

5fac78aac91d dt: bindings: ath10k: add missing dt properties for WCN3990 wifi node a3542d0c73ce dt: bindings: ath10k: add bindings for wifi iommu node

Signature · 3 lines

https://patchwork.kernel.org/patch/10668237/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Govind Singh

author

2018-11-05 13:08 UTC #5 lore raw

PATCH v4 2/3 dts: arm64/sdm845: Add WCN3990 WLAN module device node

In reply to Govind Singh

Add device node for the ath10k SNOC platform driver probe and add resources required for WCN3990 on SDM845 soc.

Signed-off-by Govind Singh <[email protected]>

Reviewed-by Brian Norris <[email protected]>

Tested-by Brian Norris <[email protected]>

---
 arch/arm64/boot/dts/qcom/sdm845-mtp.dts |  8 ++++++++
 arch/arm64/boot/dts/qcom/sdm845.dtsi    | 26 ++++++++++++++++++++++++++
 2 files changed, 34 insertions(+)

arch/arm64/boot/dts/qcom/sdm845-mtp.dts +8 -0

index eedfaf8..c062c5c 100644
@@ -440,3 +440,11 @@
 		bias-pull-up;
 	};
 };
+
+&wifi {
+	status = "okay";
+	vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>;
+	vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
+	vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
+	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
+};

arch/arm64/boot/dts/qcom/sdm845.dtsi +26 -0

index b72bdb0..324be5b 100644
@@ -87,6 +87,11 @@
 			reg = <0 0x86200000 0 0x2d00000>;
 			no-map;
 		};
+
+		wlan_msa_mem: memory@96700000 {
+			reg = <0 0x96700000 0 0x100000>;
+			no-map;
+		};
 	};
 
 	cpus {

@@ -1403,5 +1408,26 @@
 				status = "disabled";
 			};
 		};
+
+		wifi: wifi@18800000 {
+			compatible = "qcom,wcn3990-wifi";
+			status = "disabled";
+			reg = <0x18800000 0x800000>;
+			reg-names = "membase";
+			memory-region = <&wlan_msa_mem>;
+			interrupts =
+				<GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>;
+		};
 	};
 };

Signature · 2 lines

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Brian Norris

2018-11-15 02:26 UTC #6 lore raw

Re: [PATCH v4 2/3] dts: arm64/sdm845: Add WCN3990 WLAN module device node

Hi Govind,

Quoted 17 lines · Govind Singh

Add device node for the ath10k SNOC platform driver probe and add resources required for WCN3990 on SDM845 soc.
Signed-off-by Govind Singh <[email protected]>
Reviewed-by Brian Norris <[email protected]>
Tested-by Brian Norris <[email protected]>
---
 arch/arm64/boot/dts/qcom/sdm845-mtp.dts |  8 ++++++++
 arch/arm64/boot/dts/qcom/sdm845.dtsi    | 26 ++++++++++++++++++++++++++
 2 files changed, 34 insertions(+)
arch/arm64/boot/dts/qcom/sdm845-mtp.dts +0 -0
index eedfaf8..c062c5c 100644
@@ -440,3 +440,11 @@
 		bias-pull-up;

arch/arm64/boot/dts/qcom/sdm845-mtp.dts line 450

Quoted 10 lines

arch/arm64/boot/dts/qcom/sdm845-mtp.dts +8 -0

 	};
 };
+
+&wifi {
+	status = "okay";
+	vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>;
+	vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
+	vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
+	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
+};

This node should be above the PINCTRL section.

Brian

Quoted 47 lines

arch/arm64/boot/dts/qcom/sdm845.dtsi +26 -0

index b72bdb0..324be5b 100644
@@ -87,6 +87,11 @@
 			reg = <0 0x86200000 0 0x2d00000>;
 			no-map;
 		};
+
+		wlan_msa_mem: memory@96700000 {
+			reg = <0 0x96700000 0 0x100000>;
+			no-map;
+		};
 	};
 
 	cpus {

@@ -1403,5 +1408,26 @@
 				status = "disabled";
 			};
 		};
+
+		wifi: wifi@18800000 {
+			compatible = "qcom,wcn3990-wifi";
+			status = "disabled";
+			reg = <0x18800000 0x800000>;
+			reg-names = "membase";
+			memory-region = <&wlan_msa_mem>;
+			interrupts =
+				<GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>;
+		};
 	};
 };

Signature · 2 lines

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Govind Singh

author

2018-11-05 13:08 UTC #7 lore raw

PATCH v4 3/3 dt: bindings: add bindings for wifi iommu node

In reply to Govind Singh

WCN3990 wifi module can optionally make use of the IOMMU. Add binding documentation for phandle to the IOMMU and the stream id of wifi iommu block.

Signed-off-by Govind Singh <[email protected]>

Reviewed-by Rob Herring <[email protected]>

Reviewed-by Brian Norris <[email protected]>

Tested-by Brian Norris <[email protected]>

---
 Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 5 +++++
 1 file changed, 5 insertions(+)

Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt +5 -0

index 55d255c..78fb56a 100644
@@ -66,6 +66,10 @@ Optional properties:
 - <supply-name>-supply: handle to the regulator device tree node
 			   optional "supply-name" are "vdd-0.8-cx-mx",
 			   "vdd-1.8-xo", "vdd-1.3-rfa" and "vdd-3.3-ch0".
+- iommus:
+	Usage: optional
+	Value type: <prop-encoded-array>
+	Definition: A list of phandle and IOMMU specifier pairs.
 
 Example (to supply the calibration data alone):

@@ -162,4 +166,5 @@ wifi@18000000 {
 		vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
 		vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
 		vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
+		iommus = <&apps_smmu 0x0040 0x1>;
 };

Signature · 2 lines

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Kalle Valo

2018-11-16 13:29 UTC #8 lore raw

In reply to Govind Singh

Quoted 23 lines · Govind Singh

This series enables ath10k wifi driver support for WCN3990 target on sdm845 SOC. This series also updates the missing dt binding documentation and adds optional iommu property.
Changes since v3:
Moved interrupt/reg/reg-name to required property. Removed unused clocks.
Corrected interrupt no's.
Changes since v2:
dropped [v2,4/4] dts: arm64/sdm845: Enable iommu for WCN3990 wifi module device node patch from the series as dependent patch is not yet merged. Enabled status flag from sdm845-mtp.dts.
Changes since v1:
Listed no of interrupts/clocks for each set of compatible. Added missing 'wifi' label to sdm845.dtsi.
Govind Singh (3):
dt: bindings: add missing dt properties for WCN3990 wifi node
dts: arm64/sdm845: Add WCN3990 WLAN module device node
dt: bindings: add bindings for wifi iommu node

Quoted 4 lines

 .../bindings/net/wireless/qcom,ath10k.txt          | 62 ++++++++++++++--------
 arch/arm64/boot/dts/qcom/sdm845-mtp.dts            |  8 +++
 arch/arm64/boot/dts/qcom/sdm845.dtsi               | 26 +++++++++
 3 files changed, 74 insertions(+), 22 deletions(-)

Via which tree are these patches going? That's not clear for me.

Signature · 1 line

Kalle Valo

Govind Singh

author

2018-11-16 16:06 UTC #9 lore raw

Quoted 27 lines · Kalle Valo

Quoted 25 lines · Govind Singh
This series enables ath10k wifi driver support for WCN3990 target on sdm845 SOC. This series also updates the missing dt binding documentation and adds optional iommu property.
Changes since v3:
Moved interrupt/reg/reg-name to required property. Removed unused clocks.
Corrected interrupt no's.
Changes since v2:
    dropped [v2,4/4] dts: arm64/sdm845: Enable iommu for WCN3990 wifi 
module
device node patch from the series as dependent patch is not yet
merged.
Enabled status flag from sdm845-mtp.dts.
Changes since v1:
Listed no of interrupts/clocks for each set of compatible. Added missing 'wifi' label to sdm845.dtsi.
Govind Singh (3):
dt: bindings: add missing dt properties for WCN3990 wifi node
dts: arm64/sdm845: Add WCN3990 WLAN module device node
dt: bindings: add bindings for wifi iommu node

Quoted 7 lines

Quoted 5 lines

 .../bindings/net/wireless/qcom,ath10k.txt          | 62 
++++++++++++++--------
 arch/arm64/boot/dts/qcom/sdm845-mtp.dts            |  8 +++
 arch/arm64/boot/dts/qcom/sdm845.dtsi               | 26 +++++++++
 3 files changed, 74 insertions(+), 22 deletions(-)

Via which tree are these patches going? That's not clear for me.

I guess sdm845 dtsi change should be going to git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git.
I need to send v5 to address one comment from Brian.

BR,
Govind

Kalle Valo

2018-11-17 11:09 UTC #10 lore raw

Quoted 35 lines · Govind Singh

Quoted 34 lines · Kalle Valo
Quoted 31 lines · Govind Singh
This series enables ath10k wifi driver support for WCN3990 target on sdm845 SOC. This series also updates the missing dt binding documentation
and adds optional iommu property.
Changes since v3:
Moved interrupt/reg/reg-name to required property. Removed unused clocks.
Corrected interrupt no's.
Changes since v2:
    dropped [v2,4/4] dts: arm64/sdm845: Enable iommu for WCN3990
wifi module
device node patch from the series as dependent patch is not yet
merged.
Enabled status flag from sdm845-mtp.dts.
Changes since v1:
Listed no of interrupts/clocks for each set of compatible. Added missing 'wifi' label to sdm845.dtsi.
Govind Singh (3):
dt: bindings: add missing dt properties for WCN3990 wifi node
dts: arm64/sdm845: Add WCN3990 WLAN module device node
dt: bindings: add bindings for wifi iommu node
 .../bindings/net/wireless/qcom,ath10k.txt          | 62
++++++++++++++--------
 arch/arm64/boot/dts/qcom/sdm845-mtp.dts            |  8 +++
 arch/arm64/boot/dts/qcom/sdm845.dtsi               | 26 +++++++++
 3 files changed, 74 insertions(+), 22 deletions(-)

Quoted 5 lines

Quoted 1 line
Via which tree are these patches going? That's not clear for me.
I guess sdm845 dtsi change should be going to
git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git.
I need to send v5 to address one comment from Brian.

Ok, I'll then drop these from my queue.

Signature · 1 line

Kalle Valo

Govind Singh

author

2018-12-19 15:41 UTC #11 lore raw

Hi Kalle,

Quoted 37 lines · Kalle Valo

Quoted 35 lines · Govind Singh
Quoted 34 lines · Kalle Valo
Quoted 31 lines · Govind Singh
This series enables ath10k wifi driver support for WCN3990 target on sdm845 SOC. This series also updates the missing dt binding documentation
and adds optional iommu property.
Changes since v3:
Moved interrupt/reg/reg-name to required property. Removed unused clocks.
Corrected interrupt no's.
Changes since v2:
    dropped [v2,4/4] dts: arm64/sdm845: Enable iommu for WCN3990
wifi module
device node patch from the series as dependent patch is not yet
merged.
Enabled status flag from sdm845-mtp.dts.
Changes since v1:
Listed no of interrupts/clocks for each set of compatible. Added missing 'wifi' label to sdm845.dtsi.
Govind Singh (3):
dt: bindings: add missing dt properties for WCN3990 wifi node
dts: arm64/sdm845: Add WCN3990 WLAN module device node
dt: bindings: add bindings for wifi iommu node
 .../bindings/net/wireless/qcom,ath10k.txt          | 62
++++++++++++++--------
 arch/arm64/boot/dts/qcom/sdm845-mtp.dts            |  8 +++
 arch/arm64/boot/dts/qcom/sdm845.dtsi               | 26 +++++++++
 3 files changed, 74 insertions(+), 22 deletions(-)

Quoted 7 lines

Quoted 5 lines
Quoted 1 line
Via which tree are these patches going? That's not clear for me.
I guess sdm845 dtsi change should be going to
git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git.
I need to send v5 to address one comment from Brian.
Ok, I'll then drop these from my queue.

Can you pls apply below changes to ath10k tree, i will send sdm845 dtsi change as separate patch after rebase.

Quoted 2 lines

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
dt: bindings: add missing dt properties for WCN3990 wifi node
dt: bindings: add bindings for wifi iommu node

BR,
Govind

Kalle Valo

2018-12-20 11:58 UTC #12 lore raw

Quoted 42 lines · Govind Singh

Hi Kalle,
Quoted 39 lines · Kalle Valo
Quoted 37 lines · Govind Singh
Quoted 35 lines · Kalle Valo
Quoted 26 lines · Govind Singh
This series enables ath10k wifi driver support for WCN3990 target on sdm845 SOC. This series also updates the missing dt binding documentation
and adds optional iommu property.
Changes since v3:
Moved interrupt/reg/reg-name to required property. Removed unused clocks.
Corrected interrupt no's.
Changes since v2:
    dropped [v2,4/4] dts: arm64/sdm845: Enable iommu for WCN3990
wifi module
device node patch from the series as dependent patch is not yet
merged.
Enabled status flag from sdm845-mtp.dts.
Changes since v1:
Listed no of interrupts/clocks for each set of compatible. Added missing 'wifi' label to sdm845.dtsi.
Govind Singh (3):
dt: bindings: add missing dt properties for WCN3990 wifi node
dts: arm64/sdm845: Add WCN3990 WLAN module device node
dt: bindings: add bindings for wifi iommu node
Quoted 5 lines
 .../bindings/net/wireless/qcom,ath10k.txt          | 62
++++++++++++++--------
 arch/arm64/boot/dts/qcom/sdm845-mtp.dts            |  8 +++
 arch/arm64/boot/dts/qcom/sdm845.dtsi               | 26 +++++++++
 3 files changed, 74 insertions(+), 22 deletions(-)
Via which tree are these patches going? That's not clear for me.

Quoted 11 lines

Quoted 5 lines
Quoted 3 lines
I guess sdm845 dtsi change should be going to
git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git.
I need to send v5 to address one comment from Brian.
Ok, I'll then drop these from my queue.
Can you pls apply below changes to ath10k tree, i will send sdm845 dtsi change as separate patch after rebase.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
dt: bindings: add missing dt properties for WCN3990 wifi node
dt: bindings: add bindings for wifi iommu node

Ok, these two are back in my queue:

https://patchwork.kernel.org/patch/10668237/

https://patchwork.kernel.org/patch/10668245/

I'll just modify the titles to use ath10k prefix to make it more clear these are for ath10k:

dt: bindings: ath10k: .....

Signature · 1 line

Kalle Valo

Kalle Valo

2018-12-20 13:18 UTC #13 lore raw

Quoted 25 lines · Kalle Valo

Quoted 9 lines · Govind Singh
Hi Kalle,
Quoted 6 lines · Kalle Valo
Quoted 4 lines · Govind Singh
Quoted 2 lines · Kalle Valo
Via which tree are these patches going? That's not clear for me.
Quoted 11 lines
Quoted 5 lines
Quoted 3 lines
I guess sdm845 dtsi change should be going to
git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git.
I need to send v5 to address one comment from Brian.
Ok, I'll then drop these from my queue.
Can you pls apply below changes to ath10k tree, i will send sdm845 dtsi change as separate patch after rebase.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
dt: bindings: add missing dt properties for WCN3990 wifi node
dt: bindings: add bindings for wifi iommu node
Ok, these two are back in my queue:

Quoted 8 lines

https://patchwork.kernel.org/patch/10668237/
https://patchwork.kernel.org/patch/10668245/
I'll just modify the titles to use ath10k prefix to make it more clear these are for ath10k:
   dt: bindings: ath10k: .....

There were conflicts with this commit:

2b741a8aaa34 dt: bindings: add bindings for msa memory region

I fixed them in the pending branch, please double check carefully:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=5bb88d4d49783c75ac083e4ea19b7527bc115857

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=a6d53e207670eacd72a74277658bac1ab346fabd

Signature · 1 line

Kalle Valo

Govind Singh

author

2018-12-20 13:24 UTC #14 lore raw

Hi Kalle,

Quoted 34 lines · Kalle Valo

Quoted 32 lines · Kalle Valo
Quoted 9 lines · Govind Singh
Hi Kalle,
Quoted 6 lines · Kalle Valo
Quoted 4 lines · Govind Singh
Quoted 2 lines · Kalle Valo
Via which tree are these patches going? That's not clear for me.
Quoted 11 lines
Quoted 5 lines
Quoted 3 lines
I guess sdm845 dtsi change should be going to
git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git.
I need to send v5 to address one comment from Brian.
Ok, I'll then drop these from my queue.
Can you pls apply below changes to ath10k tree, i will send sdm845 dtsi change as separate patch after rebase.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
dt: bindings: add missing dt properties for WCN3990 wifi node
dt: bindings: add bindings for wifi iommu node
Ok, these two are back in my queue:
https://patchwork.kernel.org/patch/10668237/
https://patchwork.kernel.org/patch/10668245/
I'll just modify the titles to use ath10k prefix to make it more clear these are for ath10k:

Quoted 8 lines

Quoted 1 line
   dt: bindings: ath10k: .....
There were conflicts with this commit:
2b741a8aaa34 dt: bindings: add bindings for msa memory region
I fixed them in the pending branch, please double check carefully:

Changes looks good to me.

Quoted 3 lines

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=5bb88d4d49783c75ac083e4ea19b7527bc115857
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=a6d53e207670eacd72a74277658bac1ab346fabd

BR,
Govind