tooloftrade: add missing subject of sentence
PATCH 1/1 tooloftrade: add missing subject of sentence
---
Hi Paul,
This is the only patch for Chapter Tools of Trade. Please take a look.
Thanks,
--Junchang
--
toolsoftrade/toolsoftrade.tex | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
toolsoftrade/toolsoftrade.tex +2 -2
@@ -2043,8 +2043,8 @@ machine-sized and properly aligned. It can also prevent load fusing, store fusing, invented loads, and invented stores. However, although it does prevent the compiler from reordering \co{volatile} -accesses with each other, does nothing to prevent the CPU from reordering -these accesses. +accesses with each other, \co{volatile} keyword does nothing to prevent the +CPU from reordering these accesses. Furthermore, it does nothing to prevent either compiler or CPU from reordering non-\co{volatile} accesses with each other or with \co{volatile} accesses.
Signature · 1 line
2.7.4
Quoted 19 lines · Junchang Wang
Signed-off-by Junchang Wang <[email protected]>---
Hi Paul,This is the only patch for Chapter Tools of Trade. Please take a look.
Thanks,
--Junchang--
toolsoftrade/toolsoftrade.tex | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)toolsoftrade/toolsoftrade.tex +0
-0
toolsoftrade/toolsoftrade.tex machine-sized and properly aligned. · line 2047
Quoted 7 lines
toolsoftrade/toolsoftrade.tex +2
-2@@ -2043,8 +2043,8 @@ machine-sized and properly aligned. It can also prevent load fusing, store fusing, invented loads, and invented stores. However, although it does prevent the compiler from reordering \co{volatile} -accesses with each other, does nothing to prevent the CPU from reordering -these accesses. +accesses with each other, \co{volatile} keyword does nothing to prevent the +CPU from reordering these accesses.
In this context, I think
+accesses with each other, it does nothing to prevent the CPU from reordering
these accesses.
should be good enough.
Thanks, Akira
Quoted 4 lines
toolsoftrade/toolsoftrade.tex +0
-0Furthermore, it does nothing to prevent either compiler or CPU from reordering non-\co{volatile} accesses with each other or with \co{volatile} accesses.
Quoted 31 lines · Akira Yokosawa
Quoted 19 lines · Junchang Wang
Signed-off-by Junchang Wang <[email protected]>---
Hi Paul,This is the only patch for Chapter Tools of Trade. Please take a look.
Thanks,
--Junchang--
toolsoftrade/toolsoftrade.tex | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)toolsoftrade/toolsoftrade.tex +0
-0toolsoftrade/toolsoftrade.tex machine-sized and properly aligned. · line 2047
Quoted 7 lines
toolsoftrade/toolsoftrade.tex +2
-2@@ -2043,8 +2043,8 @@ machine-sized and properly aligned. It can also prevent load fusing, store fusing, invented loads, and invented stores. However, although it does prevent the compiler from reordering \co{volatile} -accesses with each other, does nothing to prevent the CPU from reordering -these accesses. +accesses with each other, \co{volatile} keyword does nothing to prevent the +CPU from reordering these accesses.In this context, I think
Quoted 4 lines
+accesses with each other, it does nothing to prevent the CPU from reordering
these accesses.should be good enough.
Hi Akira,
After reading the whole paragraph a few times, I realized you are right :-). Thanks a lot!
--Junchang
Quoted 8 lines
Thanks, Akira
Quoted 4 lines
toolsoftrade/toolsoftrade.tex +0
-0Furthermore, it does nothing to prevent either compiler or CPU from reordering non-\co{volatile} accesses with each other or with \co{volatile} accesses.
Quoted 6 lines · Junchang Wang
Signed-off-by Junchang Wang <[email protected]>---
Hi Paul,This is the only patch for Chapter Tools of Trade. Please take a look.
Good catch! I took this with Akira's suggested update as shown below, thank you both!!!
Thanx, Paul
-------------------------------------------------------------------------
commit 59d25618814ae5333e243f536f1295ff49a035ff
Author: Junchang Wang <[email protected]> Date: Sat Nov 10 20:49:58 2018 +0800
tooloftrade: add missing subject of sentence
toolsoftrade/toolsoftrade.tex +2 -2
@@ -2043,8 +2043,8 @@ machine-sized and properly aligned. It can also prevent load fusing, store fusing, invented loads, and invented stores. However, although it does prevent the compiler from reordering \co{volatile} -accesses with each other, does nothing to prevent the CPU from reordering -these accesses. +accesses with each other, it does nothing to prevent the +CPU from reordering these accesses. Furthermore, it does nothing to prevent either compiler or CPU from reordering non-\co{volatile} accesses with each other or with \co{volatile} accesses.