Skip to contentSkip to conversation

media: venus: change the default value of GOP size

PATCH In review Malathi Gottam 2 participants 2 messages Nov 12, 2018

Subsystems (4)
Media (V4L/DVB) Arm Qualcomm mailing list Qualcomm media platform Qualcomm venus video accelerator driver
lore
Share & tools
lore

Malathi Gottam

author
#0 lore raw

PATCH 1/1 media: venus: change the default value of GOP size

When the client doesn't explicitly set any GOP size, current default value is low and overshoots bitrate beyond tolerance. Hence default value is modified so as to have intra period of 1sec.

Signed-off-by Malathi Gottam <[email protected]>
---
 drivers/media/platform/qcom/venus/venc_ctrls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/qcom/venus/venc_ctrls.c +1 -1
index 45910172..e6a43e9 100644
@@ -295,7 +295,7 @@ int venc_ctrl_init(struct venus_inst *inst)
 		0, INTRA_REFRESH_MBS_MAX, 1, 0);
 
 	v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops,
-		V4L2_CID_MPEG_VIDEO_GOP_SIZE, 0, (1 << 16) - 1, 1, 12);
+		V4L2_CID_MPEG_VIDEO_GOP_SIZE, 0, (1 << 16) - 1, 1, 30);
 
 	v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops,
 		V4L2_CID_MPEG_VIDEO_VPX_MIN_QP, 1, 128, 1, 1);
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#1 lore raw

Hi Malathi,

Thanks for the patch!

Quoted 9 lines · Malathi Gottam

When the client doesn't explicitly set any GOP size, current default value is low and overshoots bitrate beyond tolerance. Hence default value is modified so as to have intra period of 1sec.

Signed-off-by Malathi Gottam <[email protected]>
---
 drivers/media/platform/qcom/venus/venc_ctrls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Sounds reasonable :

Acked-by Stanimir Varbanov <[email protected]>
Quoted 14 lines
drivers/media/platform/qcom/venus/venc_ctrls.c +1 -1
index 45910172..e6a43e9 100644
@@ -295,7 +295,7 @@ int venc_ctrl_init(struct venus_inst *inst)
 		0, INTRA_REFRESH_MBS_MAX, 1, 0);
 
 	v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops,
-		V4L2_CID_MPEG_VIDEO_GOP_SIZE, 0, (1 << 16) - 1, 1, 12);
+		V4L2_CID_MPEG_VIDEO_GOP_SIZE, 0, (1 << 16) - 1, 1, 30);
 
 	v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops,
 		V4L2_CID_MPEG_VIDEO_VPX_MIN_QP, 1, 128, 1, 1);
Signature · 2 lines
regards,
Stan