Skip to contentSkip to conversation

media: v4l: v4l2-controls.h must include types.h

PATCH In review Jean Delvare 2 participants 3 messages Nov 12, 2018 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: v4l: v4l2-controls.h must include types.h

Fix the following build-time warning:
./usr/include/linux/v4l2-controls.h:1105: found __[us]{8,16,32,64} type without #include <linux/types.h>

Fixes c27bb30e7b6d ("media: v4l: Add definitions for MPEG-2 slice format and metadata")
Cc Paul Kocialkowski <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
---
 include/uapi/linux/v4l2-controls.h |    2 ++
 1 file changed, 2 insertions(+)
include/uapi/linux/v4l2-controls.h +2 -0
@@ -50,6 +50,8 @@
 #ifndef __LINUX_V4L2_CONTROLS_H
 #define __LINUX_V4L2_CONTROLS_H
 
+#include <linux/types.h>		/* for __u* typedefs */
+
 /* Control classes */
 #define V4L2_CTRL_CLASS_USER		0x00980000	/* Old-style 'user' controls */
 #define V4L2_CTRL_CLASS_MPEG		0x00990000	/* MPEG-compression controls */
Signature · 2 lines
Jean Delvare
SUSE L3 Support
#1 lore raw

Hi,

Quoted 2 lines · Jean Delvare

Fix the following build-time warning:
./usr/include/linux/v4l2-controls.h:1105: found __[us]{8,16,32,64} type without #include <linux/types.h>

We already have a similar fix in the media tree:
https://git.linuxtv.org/media_tree.git/commit/?h=request_api&id=dafb7f9aef2fd44991ff1691721ff765a23be27b

So it looks like we won't be needing this one!

Cheers,

Paul

Quoted 21 lines
Fixes c27bb30e7b6d ("media: v4l: Add definitions for MPEG-2 slice format and metadata")
Cc Paul Kocialkowski <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
---
 include/uapi/linux/v4l2-controls.h |    2 ++
 1 file changed, 2 insertions(+)
include/uapi/linux/v4l2-controls.h +2 -0
@@ -50,6 +50,8 @@
 #ifndef __LINUX_V4L2_CONTROLS_H
 #define __LINUX_V4L2_CONTROLS_H
 
+#include <linux/types.h>		/* for __u* typedefs */
+
 /* Control classes */
 #define V4L2_CTRL_CLASS_USER		0x00980000	/* Old-style 'user' controls */
 #define V4L2_CTRL_CLASS_MPEG		0x00990000	/* MPEG-compression controls */
Signature · 3 lines
Paul Kocialkowski, Bootlin (formerly Free Electrons)
Embedded Linux and kernel engineering
https://bootlin.com
#2 lore raw
Quoted 8 lines · Paul Kocialkowski
Quoted 2 lines · Jean Delvare

Fix the following build-time warning:
./usr/include/linux/v4l2-controls.h:1105: found __[us]{8,16,32,64} type without #include <linux/types.h>

We already have a similar fix in the media tree:
https://git.linuxtv.org/media_tree.git/commit/?h=request_api&id=dafb7f9aef2fd44991ff1691721ff765a23be27b

So it looks like we won't be needing this one!

Perfect, thanks for letting me know and sorry for the noise.

Signature · 2 lines
Jean Delvare
SUSE L3 Support