Skip to contentSkip to conversation

fpga fixes for 4.20

PATCH RESEND In review Alan Tull 2 participants 4 messages Nov 12, 2018

Subsystems (2)
lore
Share & tools
lore

Alan Tull

author
#0 lore raw

cover fpga fixes for 4.20

Hi Greg,

Here's a reposting of the two small fixes for fpga, please take them in. They've been reviewed on the mailing list and apply cleanly on today's char-misc-test.

Thanks,
Alan

Moritz Fischer (2):
fpga: of-fpga-region: Use platform_set_drvdata
fpga: dfl-fme-region: Use platform_get_drvdata()

 drivers/fpga/dfl-fme-region.c | 2 +-
 drivers/fpga/of-fpga-region.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH RESEND 1/2 fpga: of-fpga-region: Use platform_set_drvdata

From: Moritz Fischer <[email protected]>

Use platform_set_drvdata rather than dev_set_drvdata to match the platform_get_drvdata in the _remove() function of the platform driver.

---
 drivers/fpga/of-fpga-region.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/fpga/of-fpga-region.c +1 -1
index 122286f..75f64ab 100644
@@ -421,7 +421,7 @@ static int of_fpga_region_probe(struct platform_device *pdev)
 		goto eprobe_mgr_put;
 
 	of_platform_populate(np, fpga_region_of_match, NULL, &region->dev);
-	dev_set_drvdata(dev, region);
+	platform_set_drvdata(pdev, region);
 
 	dev_info(dev, "FPGA Region probed\n");
 
Signature · 1 line
2.7.4
author
#2 lore raw

PATCH RESEND 2/2 fpga: dfl-fme-region: Use platform_get_drvdata()

In reply to Alan Tull

From: Moritz Fischer <[email protected]>

Use platform_get_drvdata() in remove() function of the platform driver rather than dev_get_drvdata() to match the platform_set_drvdata in the probe().

---
 drivers/fpga/dfl-fme-region.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/fpga/dfl-fme-region.c +1 -1
index ec134ec..1eeb42a 100644
@@ -64,7 +64,7 @@ static int fme_region_probe(struct platform_device *pdev)
 
 static int fme_region_remove(struct platform_device *pdev)
 {
-	struct fpga_region *region = dev_get_drvdata(&pdev->dev);
+	struct fpga_region *region = platform_get_drvdata(pdev);
 	struct fpga_manager *mgr = region->mgr;
 
 	fpga_region_unregister(region);
Signature · 1 line
2.7.4
#3 lore raw
In reply to Alan Tull
Quoted 5 lines · Alan Tull

Hi Greg,

Here's a reposting of the two small fixes for fpga, please take them in. They've been reviewed on the mailing list and apply cleanly on today's char-misc-test.

This isn't a bugfix, they should just go into my "next" branch to be merged for the next -rc1 release, right? I thought that is what I said last time...

thanks,

greg k-h