doc: drop some incorrect instructions
PATCH 1/1 doc: drop some incorrect instructions
From: Ming Liu <[email protected]>
image_types bbclass now is being inherited mandatorily in image.bbclass through the variable IMGCLASSES, and the users do not have to inherit it in their customized image type bbclass, or put it in IMAGE_CLASSES.
Drop the incorrect descriptions, it's confusing the developers.
--- documentation/ref-manual/ref-classes.xml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)
documentation/ref-manual/ref-classes.xml +2 -7
@@ -1275,15 +1275,10 @@ </para> <para> - By default, this class is enabled through the - <link linkend='var-IMAGE_CLASSES'><filename>IMAGE_CLASSES</filename></link> - variable in + By default, this class is enabled mandatorily in <link linkend='ref-classes-image'><filename>image.bbclass</filename></link>. If you define your own image types using a custom BitBake class and - then use <filename>IMAGE_CLASSES</filename> to enable it, the custom - class must either inherit <filename>image_types</filename> or - <filename>image_types</filename> must also appear in - <filename>IMAGE_CLASSES</filename>. + then use <filename>IMAGE_CLASSES</filename> to enable it. </para> <para>
Signature · 1 line
2.7.4
Ming,
I could not simply apply this patch. I had to do some re-writing for clarity. Please look at this link to the updated section on the image_types class and let me know if this is technically correct.
https://yoctoproject.org/docs/2.6/ref-manual/ref-manual.html#ref-classes-image_types
Thanks,
Scott
Quoted 49 lines · On Wed, Nov 14, 2018 at 11:06 AM <[email protected]> wrote:
From: Ming Liu <[email protected]>
image_typesbbclass now is being inherited mandatorily in image.bbclass through the variable IMGCLASSES, and the users do not have to inherit it in their customized image type bbclass, or put it inIMAGE_CLASSES.Drop the incorrect descriptions, it's confusing the developers.
Signed-off-by Ming Liu <[email protected]>--- documentation/ref-manual/ref-classes.xml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)documentation/ref-manual/ref-classes.xml +0
-2@@ -1275,15 +1275,10 @@ </para> <para> - By default, this class is enabled through the - <linklinkend='var-IMAGE_CLASSES'><filename>IMAGE_CLASSES</filename></link>
documentation/ref-manual/ref-classes.xml +1
-1- variable in + By default, this class is enabled mandatorily in <linklinkend='ref-classes-image'><filename>image.bbclass</filename></link>.
If you define your own image types using a custom BitBake class
and
- then use <filename>IMAGE_CLASSES</filename> to enable it, the
customdocumentation/ref-manual/ref-classes.xml +1
-4- class must either inherit <filename>image_types</filename> or - <filename>image_types</filename> must also appear in - <filename>IMAGE_CLASSES</filename>. + then use <filename>IMAGE_CLASSES</filename> to enable it. </para> <para> --2.7.4
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Hi, Scott:
Thanks for the re-writing, I think it's correct technically, the incorrect description had been removed.
//Ming Liu
Scott Rifenbark <[email protected]> 於 2018年11月14日 週三 下午8:36寫道：
Quoted 64 lines
Ming,
I could not simply apply this patch. I had to do some re-writing for clarity. Please look at this link to the updated section on the
image_typesclass and let me know if this is technically correct.https://yoctoproject.org/docs/2.6/ref-manual/ref-manual.html#ref-classes-image_types
Thanks,
ScottQuoted 49 lines · On Wed, Nov 14, 2018 at 11:06 AM <[email protected]> wrote:
From: Ming Liu <[email protected]>
image_typesbbclass now is being inherited mandatorily in image.bbclass through the variable IMGCLASSES, and the users do not have to inherit it in their customized image type bbclass, or put it inIMAGE_CLASSES.Drop the incorrect descriptions, it's confusing the developers.
Signed-off-by Ming Liu <[email protected]>--- documentation/ref-manual/ref-classes.xml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)documentation/ref-manual/ref-classes.xml +0
-2@@ -1275,15 +1275,10 @@ </para> <para> - By default, this class is enabled through the - <linklinkend='var-IMAGE_CLASSES'><filename>IMAGE_CLASSES</filename></link>
documentation/ref-manual/ref-classes.xml +1
-1- variable in + By default, this class is enabled mandatorily in <linklinkend='ref-classes-image'><filename>image.bbclass</filename></link>.
If you define your own image types using a custom BitBake class
and
- then use <filename>IMAGE_CLASSES</filename> to enable it, the
customdocumentation/ref-manual/ref-classes.xml +1
-4- class must either inherit <filename>image_types</filename> or - <filename>image_types</filename> must also appear in - <filename>IMAGE_CLASSES</filename>. + then use <filename>IMAGE_CLASSES</filename> to enable it. </para> <para> --2.7.4
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
✗ patchtest: failure for doc: drop some incorrect instructions
In reply to [email protected]== Series Details ==
Series: doc: drop some incorrect instructions
Revision: 1
URL : https://patchwork.openembedded.org/series/14919/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:
* Issue Series sent to the wrong mailing list or some patches from the series correspond to different mailing lists [test_target_mailing_list]
Suggested fix Send the series again to the correct mailing list (ML) Suggested ML [email protected] [http://git.yoctoproject.org/cgit/cgit.cgi/yocto-docs/] Patch's path: documentation/ref-manual/ref-classes.xml
* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at ae12c5f866)
If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe