Skip to contentSkip to conversation

FAILED: patch "[PATCH] scsi: qla2xxx: Fix NVMe Target discovery" failed to apply to 4.18-stable tree

PATCH [email protected] 1 participant 1 message Nov 15, 2018

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.18-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From db186382af21e926e90df19499475f2552192b77 Mon Sep 17 00:00:00 2001

From: Quinn Tran <[email protected]>
Date: Wed, 26 Sep 2018 22:05:12 -0700
Subject: [PATCH] scsi: qla2xxx: Fix NVMe Target discovery

This patch fixes issue when remoteport registers itself as both FCP and FC-NVMe with the switch, driver will pick FC-NVMe personality as default when scanning for targets.

Driver was using comaprative operator instead of bitwise operator to check for fc4_type for both FCP and FC-NVME.

Fixes 2b5b96473efc ("scsi: qla2xxx: Fix FC-NVMe LUN discovery")
drivers/scsi/qla2xxx/qla_os.c +2 -2
index 429033ab6897..dba672f87cb2 100644
@@ -4880,10 +4880,10 @@ void qla24xx_create_new_sess(struct scsi_qla_host *vha, struct qla_work_evt *e)
 			fcport->d_id = e->u.new_sess.id;
 			fcport->flags |= FCF_FABRIC_DEVICE;
 			fcport->fw_login_state = DSC_LS_PLOGI_PEND;
-			if (e->u.new_sess.fc4_type == FS_FC4TYPE_FCP)
+			if (e->u.new_sess.fc4_type & FS_FC4TYPE_FCP)
 				fcport->fc4_type = FC4_TYPE_FCP_SCSI;
 
-			if (e->u.new_sess.fc4_type == FS_FC4TYPE_NVME) {
+			if (e->u.new_sess.fc4_type & FS_FC4TYPE_NVME) {
 				fcport->fc4_type = FC4_TYPE_OTHER;
 				fcport->fc4f_nvme = FC4_TYPE_NVME;
 			}