Skip to contentSkip to conversation

Add Colorspace connector property interface

PATCH Superseded Uma Shankar 4 participants 13 messages Nov 20, 2018 – Nov 27, 2018

Subsystems (3)

v3 of 17 Superseded Latest is v17 →

lore
Share & tools
lore
#0 lore raw

v3 cover Add Colorspace connector property interface

This patch series creates a new connector property to program colorspace to sink devices. Modern sink devices support more than 1 type of colorspace like 601, 709, BT2020 etc. This helps to switch based on content type which is to be displayed. The decision lies with compositors as to in which scenarios, a particular colorspace will be picked.

This will be helpful mostly to switch to higher gamut colorspaces like BT2020 when the media content is encoded as BT2020. Thereby giving a good visual experience to users.

The expectation from userspace is that it should parse the EDID and get supported colorspaces. Use this property and switch to the one supported. Kernel will not give the supported colorspaces since this is panel dependent and our curremt property infrastructure is not supporting it.

This can be tested by using xrandr with below command:
xrandr --output HDMI2 --set "HDMI_Colorspace" "BT2020_rgb"
Note: Haven't tested this version. Wanted to get feedback if this approach looks ok. Will test and refloat next version along with review fixes if any.

v2: Addressed Ville and Maarten's review comments. Merged the 2nd and 3rd patch into one common logical patch.

v3: Removed Adobe references from enum definitions as per Ville, Hans Verkuil and Jonas Karlman suggestions. Changed default to an unset state where driver will assign the colorspace when not chosen by user, suggested by Ville and Maarten. Addressed other misc review comments from Maarten. Split the changes to have separate colorspace property for DP and HDMI.

Uma Shankar (3):
drm: Add HDMI colorspace property
drm: Add DP colorspace property
drm/i915: Attach colorspace property and enable modeset

 drivers/gpu/drm/drm_atomic_uapi.c      |  8 +++
 drivers/gpu/drm/drm_connector.c        | 97 ++++++++++++++++++++++++++++++++++
 drivers/gpu/drm/i915/intel_atomic.c    |  2 +
 drivers/gpu/drm/i915/intel_connector.c |  8 +++
 drivers/gpu/drm/i915/intel_drv.h       |  1 +
 drivers/gpu/drm/i915/intel_hdmi.c      |  7 +++
 include/drm/drm_connector.h            | 15 ++++++
 include/drm/drm_mode_config.h          | 12 +++++
 include/uapi/drm/drm_mode.h            | 35 ++++++++++++
 9 files changed, 185 insertions(+)
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH v3 1/3 drm: Add HDMI colorspace property

This patch adds a HDMI colorspace property, enabling userspace to switch to various supported colorspaces. This will help enable BT2020 along with other colorspaces.

v2: Addressed Maarten and Ville's review comments. Enhanced the colorspace enum to incorporate both HDMI and DP supported colorspaces. Also, added a default option for colorspace.

v3: Removed Adobe references from enum definitions as per Ville, Hans Verkuil and Jonas Karlman suggestions. Changed Default to an unset state where driver will assign the colorspace is not chosen by user, suggested by Ville and Maarten. Addressed other misc review comments from Maarten. Split the changes to have separate colorspace property for DP and HDMI.

---
 drivers/gpu/drm/drm_atomic_uapi.c |  4 +++
 drivers/gpu/drm/drm_connector.c   | 62 +++++++++++++++++++++++++++++++++++++++
 include/drm/drm_connector.h       |  8 +++++
 include/drm/drm_mode_config.h     |  6 ++++
 include/uapi/drm/drm_mode.h       | 16 ++++++++++
 5 files changed, 96 insertions(+)
drivers/gpu/drm/drm_atomic_uapi.c +4 -0
index 86ac339..4e09a38 100644
@@ -721,6 +721,8 @@ static int drm_atomic_connector_set_property(struct drm_connector *connector,
 		state->picture_aspect_ratio = val;
 	} else if (property == config->content_type_property) {
 		state->content_type = val;
+	} else if (property == config->hdmi_colorspace_property) {
+		state->hdmi_colorspace = val;
 	} else if (property == connector->scaling_mode_property) {
 		state->scaling_mode = val;
 	} else if (property == connector->content_protection_property) {
@@ -797,6 +799,8 @@ static int drm_atomic_connector_set_property(struct drm_connector *connector,
 		*val = state->picture_aspect_ratio;
 	} else if (property == config->content_type_property) {
 		*val = state->content_type;
+	} else if (property == config->hdmi_colorspace_property) {
+		*val = state->hdmi_colorspace;
 	} else if (property == connector->scaling_mode_property) {
 		*val = state->scaling_mode;
 	} else if (property == connector->content_protection_property) {
drivers/gpu/drm/drm_connector.c +62 -0

74 lines not on this page · raw message

include/drm/drm_connector.h +8 -0
index af0a761..5fda56d 100644
@@ -497,6 +497,13 @@ struct drm_connector_state {
 	unsigned int content_protection;
 
 	/**
+	 * @hdmi_colorspace: Connector property to request colorspace
+	 * change on HDMI Sink. This is most commonly used to switch to
+	 * wider color gamuts like BT2020.
+	 */
+	enum hdmi_full_colorimetry hdmi_colorspace;
+
+	/**
 	 * @writeback_job: Writeback job for writeback connectors
 	 *
 	 * Holds the framebuffer and out-fence for a writeback connector. As
@@ -1272,6 +1279,7 @@ int drm_connector_attach_scaling_mode_property(struct drm_connector *connector,
 int drm_connector_attach_content_protection_property(
 		struct drm_connector *connector);
 int drm_mode_create_aspect_ratio_property(struct drm_device *dev);
+int drm_mode_create_colorspace_property(struct drm_connector *connector);
 int drm_mode_create_content_type_property(struct drm_device *dev);
 void drm_hdmi_avi_infoframe_content_type(struct hdmi_avi_infoframe *frame,
 					 const struct drm_connector_state *conn_state);
include/drm/drm_mode_config.h +6 -0
index 5dbeabd..ec7cab8 100644
@@ -869,6 +869,12 @@ struct drm_mode_config {
 	uint32_t cursor_width, cursor_height;
 
 	/**
+	 * @hdmi_colorspace_property: Connector property to set the suitable
+	 * colorspace supported by the HDMI sink.
+	 */
+	struct drm_property *hdmi_colorspace_property;
+
+	/**
 	 * @suspend_state:
 	 *
 	 * Atomic state when suspended.
include/uapi/drm/drm_mode.h +16 -0
index d3e0fe3..cc4df26 100644
@@ -210,6 +210,22 @@
 #define DRM_MODE_CONTENT_PROTECTION_DESIRED     1
 #define DRM_MODE_CONTENT_PROTECTION_ENABLED     2
 
+enum hdmi_full_colorimetry {
+	/* CEA 861 Normal Colorimetry options */
+	COLORIMETRY_ITU_601 = 0,
+	COLORIMETRY_ITU_709,
+	/* CEA 861 Extended Colorimetry Options */
+	COLORIMETRY_XV_YCC_601,
+	COLORIMETRY_XV_YCC_709,
+	COLORIMETRY_S_YCC_601,
+	COLORIMETRY_OPYCC_601,
+	COLORIMETRY_OPRGB,
+	COLORIMETRY_BT2020_RGB,
+	COLORIMETRY_BT2020_YCC,
+	COLORIMETRY_BT2020_CYCC,
+	COLORIMETRY_DEFAULT,
+};
+
 struct drm_mode_modeinfo {
 	__u32 clock;
 	__u16 hdisplay;
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

Re: [v3 1/3] drm: Add HDMI colorspace property

Quoted 51 lines · Uma Shankar

This patch adds a HDMI colorspace property, enabling userspace to switch to various supported colorspaces. This will help enable BT2020 along with other colorspaces.

v2: Addressed Maarten and Ville's review comments. Enhanced the colorspace enum to incorporate both HDMI and DP supported colorspaces. Also, added a default option for colorspace.

v3: Removed Adobe references from enum definitions as per Ville, Hans Verkuil and Jonas Karlman suggestions. Changed Default to an unset state where driver will assign the colorspace is not chosen by user, suggested by Ville and Maarten. Addressed other misc review comments from Maarten. Split the changes to have separate colorspace property for DP and HDMI.

---
 drivers/gpu/drm/drm_atomic_uapi.c |  4 +++
 drivers/gpu/drm/drm_connector.c   | 62 +++++++++++++++++++++++++++++++++++++++
 include/drm/drm_connector.h       |  8 +++++
 include/drm/drm_mode_config.h     |  6 ++++
 include/uapi/drm/drm_mode.h       | 16 ++++++++++
 5 files changed, 96 insertions(+)
drivers/gpu/drm/drm_atomic_uapi.c +4 -0
index 86ac339..4e09a38 100644
@@ -721,6 +721,8 @@ static int drm_atomic_connector_set_property(struct drm_connector *connector,
 		state->picture_aspect_ratio = val;
 	} else if (property == config->content_type_property) {
 		state->content_type = val;
+	} else if (property == config->hdmi_colorspace_property) {
+		state->hdmi_colorspace = val;
 	} else if (property == connector->scaling_mode_property) {
 		state->scaling_mode = val;
 	} else if (property == connector->content_protection_property) {
@@ -797,6 +799,8 @@ static int drm_atomic_connector_set_property(struct drm_connector *connector,
 		*val = state->picture_aspect_ratio;
 	} else if (property == config->content_type_property) {
 		*val = state->content_type;
+	} else if (property == config->hdmi_colorspace_property) {
+		*val = state->hdmi_colorspace;
 	} else if (property == connector->scaling_mode_property) {
 		*val = state->scaling_mode;
 	} else if (property == connector->content_protection_property) {
drivers/gpu/drm/drm_connector.c +0 -0
index fa9baac..1906e4a 100644

drivers/gpu/drm/drm_connector.c int drm_display_info_set_bus_formats(struct drm_display_info *info, · line 829

Quoted 4 lines
drivers/gpu/drm/drm_connector.c +1 -0
@@ -826,6 +826,30 @@ int drm_display_info_set_bus_formats(struct drm_display_info *info,
 };
 DRM_ENUM_NAME_FN(drm_get_content_protection_name, drm_cp_enum_list)
 
+static const struct drm_prop_enum_list hdmi_colorspace[] = {

My idea was that we create just the one prop, and filter it as needed.

Quoted 11 lines
drivers/gpu/drm/drm_connector.c +11 -0
+	/* Standard Definition Colorimetry based on CEA 861 */
+	{ COLORIMETRY_ITU_601, "ITU_601" },
+	{ COLORIMETRY_ITU_709, "ITU_709" },
+	/* Standard Definition Colorimetry based on IEC 61966-2-4 */
+	{ COLORIMETRY_XV_YCC_601, "XV_YCC_601" },
+	/* High Definition Colorimetry based on IEC 61966-2-4 */
+	{ COLORIMETRY_XV_YCC_709, "XV_YCC_709" },
+	/* Colorimetry based on IEC 61966-2-1/Amendment 1 */
+	{ COLORIMETRY_S_YCC_601, "S_YCC_601" },
+	/* Colorimetry based on IEC 61966-2-5 [33] */
+	{ COLORIMETRY_OPYCC_601, "opYCC_601" },

drivers/gpu/drm/drm_connector.c int drm_display_info_set_bus_formats(struct drm_display_info *info, · line 850

Quoted 10 lines
drivers/gpu/drm/drm_connector.c +10 -0
+	/* Colorimetry based on IEC 61966-2-5 */
+	{ COLORIMETRY_OPRGB, "opRGB" },
+	/* Colorimetry based on ITU-R BT.2020 */
+	{ COLORIMETRY_BT2020_RGB, "BT2020_RGB" },
+	/* Colorimetry based on ITU-R BT.2020 */
+	{ COLORIMETRY_BT2020_YCC, "BT2020_YCC" },
+	/* Colorimetry based on ITU-R BT.2020 */
+	{ COLORIMETRY_BT2020_CYCC, "BT2020_CYCC" },
+	/* For Default case, driver will set the colorspace */
+	{ COLORIMETRY_DEFAULT, "Default" },

"Default" needs to be the default.

Quoted 127 lines
drivers/gpu/drm/drm_connector.c +40 -0
+};
+
 /**
  * DOC: standard connector properties
  *
@@ -1402,6 +1426,44 @@ int drm_mode_create_aspect_ratio_property(struct drm_device *dev)
 EXPORT_SYMBOL(drm_mode_create_aspect_ratio_property);
 
 /**
+ * drm_mode_create_colorspace_property - create colorspace property
+ * colorspace:
+ *     This property helps select a suitable colorspace based on the sink
+ *     capability. Modern sink devices support wider gamut like BT2020.
+ *     This helps switch to BT2020 mode if the BT2020 encoded video stream
+ *     is being played by the user, same for any other colorspace.
+ * @dev: DRM device
+ *
+ * Called by a driver the first time it's needed, must be attached to desired
+ * connectors.
+ *
+ * Returns:
+ * Zero on success, negative errno on failure.
+ */
+int drm_mode_create_colorspace_property(struct drm_connector *connector)
+{
+	struct drm_device *dev = connector->dev;
+	struct drm_property *prop;
+
+	if (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
+			connector->connector_type == DRM_MODE_CONNECTOR_HDMIB) {
+		if (dev->mode_config.hdmi_colorspace_property)
+			return 0;
+
+		prop = drm_property_create_enum(dev, DRM_MODE_PROP_ENUM,
+				"HDMI_Colorspace",
+				hdmi_colorspace, ARRAY_SIZE(hdmi_colorspace));
+		if (!prop)
+			return -ENOMEM;
+
+		dev->mode_config.hdmi_colorspace_property = prop;
+	}
+
+	return 0;
+}
+EXPORT_SYMBOL(drm_mode_create_colorspace_property);
+
+/**
  * drm_mode_create_content_type_property - create content type property
  * @dev: DRM device
  *
include/drm/drm_connector.h +8 -0
index af0a761..5fda56d 100644
@@ -497,6 +497,13 @@ struct drm_connector_state {
 	unsigned int content_protection;
 
 	/**
+	 * @hdmi_colorspace: Connector property to request colorspace
+	 * change on HDMI Sink. This is most commonly used to switch to
+	 * wider color gamuts like BT2020.
+	 */
+	enum hdmi_full_colorimetry hdmi_colorspace;
+
+	/**
 	 * @writeback_job: Writeback job for writeback connectors
 	 *
 	 * Holds the framebuffer and out-fence for a writeback connector. As
@@ -1272,6 +1279,7 @@ int drm_connector_attach_scaling_mode_property(struct drm_connector *connector,
 int drm_connector_attach_content_protection_property(
 		struct drm_connector *connector);
 int drm_mode_create_aspect_ratio_property(struct drm_device *dev);
+int drm_mode_create_colorspace_property(struct drm_connector *connector);
 int drm_mode_create_content_type_property(struct drm_device *dev);
 void drm_hdmi_avi_infoframe_content_type(struct hdmi_avi_infoframe *frame,
 					 const struct drm_connector_state *conn_state);
include/drm/drm_mode_config.h +6 -0
index 5dbeabd..ec7cab8 100644
@@ -869,6 +869,12 @@ struct drm_mode_config {
 	uint32_t cursor_width, cursor_height;
 
 	/**
+	 * @hdmi_colorspace_property: Connector property to set the suitable
+	 * colorspace supported by the HDMI sink.
+	 */
+	struct drm_property *hdmi_colorspace_property;
+
+	/**
 	 * @suspend_state:
 	 *
 	 * Atomic state when suspended.
include/uapi/drm/drm_mode.h +16 -0
index d3e0fe3..cc4df26 100644
@@ -210,6 +210,22 @@
 #define DRM_MODE_CONTENT_PROTECTION_DESIRED     1
 #define DRM_MODE_CONTENT_PROTECTION_ENABLED     2
 
+enum hdmi_full_colorimetry {
+	/* CEA 861 Normal Colorimetry options */
+	COLORIMETRY_ITU_601 = 0,
+	COLORIMETRY_ITU_709,
+	/* CEA 861 Extended Colorimetry Options */
+	COLORIMETRY_XV_YCC_601,
+	COLORIMETRY_XV_YCC_709,
+	COLORIMETRY_S_YCC_601,
+	COLORIMETRY_OPYCC_601,
+	COLORIMETRY_OPRGB,
+	COLORIMETRY_BT2020_RGB,
+	COLORIMETRY_BT2020_YCC,
+	COLORIMETRY_BT2020_CYCC,
+	COLORIMETRY_DEFAULT,
+};
+
 struct drm_mode_modeinfo {
 	__u32 clock;
 	__u16 hdisplay;
Signature · 6 lines
1.9.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#3 lore raw

RE: [v3 1/3] drm: Add HDMI colorspace property

Quoted 71 lines

-----Original Message-----
From: Ville Syrjälä [mailto:[email protected]]
Sent: Tuesday, November 20, 2018 8:56 PM
To: Shankar, Uma <[email protected]>
Cc: [email protected]; [email protected]; Syrjala, Ville <[email protected]>; [email protected]; [email protected]; Lankhorst, Maarten <[email protected]>
Subject: Re: [v3 1/3] drm: Add HDMI colorspace property

Quoted 15 lines · Uma Shankar

This patch adds a HDMI colorspace property, enabling userspace to switch to various supported colorspaces.
This will help enable BT2020 along with other colorspaces.

v2: Addressed Maarten and Ville's review comments. Enhanced the colorspace enum to incorporate both HDMI and DP supported colorspaces. Also, added a default option for colorspace.

v3: Removed Adobe references from enum definitions as per Ville, Hans Verkuil and Jonas Karlman suggestions. Changed Default to an unset state where driver will assign the colorspace is not chosen by user, suggested by Ville and Maarten. Addressed other misc review comments from Maarten. Split the changes to have separate colorspace property for DP and HDMI.

Quoted 4 lines
---
 drivers/gpu/drm/drm_atomic_uapi.c |  4 +++
 drivers/gpu/drm/drm_connector.c   | 62

+++++++++++++++++++++++++++++++++++++++

drivers/gpu/drm/drm_atomic_uapi.c static int drm_atomic_connector_set_property(struct

Quoted 11 lines
 include/drm/drm_connector.h       |  8 +++++
 include/drm/drm_mode_config.h     |  6 ++++
 include/uapi/drm/drm_mode.h       | 16 ++++++++++
 5 files changed, 96 insertions(+)
drivers/gpu/drm/drm_atomic_uapi.c +0 -0
index 86ac339..4e09a38 100644
@@ -721,6 +721,8 @@ static int drm_atomic_connector_set_property(struct

drm_connector *connector,

drivers/gpu/drm/drm_atomic_uapi.c static int drm_atomic_connector_set_property(struct drm_connector *connector,

Quoted 9 lines
drivers/gpu/drm/drm_atomic_uapi.c +2 -1
 		state->picture_aspect_ratio = val;
 	} else if (property == config->content_type_property) {
 		state->content_type = val;
+	} else if (property == config->hdmi_colorspace_property) {
+		state->hdmi_colorspace = val;
 	} else if (property == connector->scaling_mode_property) {
 		state->scaling_mode = val;
 	} else if (property == connector->content_protection_property) { @@
-797,6 +799,8 @@ static int drm_atomic_connector_set_property(struct

drm_connector *connector,

Quoted 13 lines
drivers/gpu/drm/drm_atomic_uapi.c +2 -0
 		*val = state->picture_aspect_ratio;
 	} else if (property == config->content_type_property) {
 		*val = state->content_type;
+	} else if (property == config->hdmi_colorspace_property) {
+		*val = state->hdmi_colorspace;
 	} else if (property == connector->scaling_mode_property) {
 		*val = state->scaling_mode;
 	} else if (property == connector->content_protection_property) {
(quoted diff) +0 -0

b/drivers/gpu/drm/drm_connector.c index fa9baac..1906e4a 100644

drivers/gpu/drm/drm_connector.c int drm_display_info_set_bus_formats(struct · line 827

Quoted 2 lines
drivers/gpu/drm/drm_connector.c +0 -0
@@ -826,6 +826,30 @@ int drm_display_info_set_bus_formats(struct
 drm_display_info *info,  };
 DRM_ENUM_NAME_FN(drm_get_content_protection_name,

drm_cp_enum_list)

Quoted 1 line
Quoted 3 lines
Quoted 1 line

+static const struct drm_prop_enum_list hdmi_colorspace[] = {

My idea was that we create just the one prop, and filter it as needed.

Got it Ville, It can be done with one property. I will create an absolute list with all the colorspaces and then create subset out of this list for respective connectors (DP and HDMI) keeping common property name as "Colorspace". Will float the new version shortly.

Quoted 15 lines
Quoted 15 lines
drivers/gpu/drm/drm_connector.c +15 -0
+	/* Standard Definition Colorimetry based on CEA 861 */
+	{ COLORIMETRY_ITU_601, "ITU_601" },
+	{ COLORIMETRY_ITU_709, "ITU_709" },
+	/* Standard Definition Colorimetry based on IEC 61966-2-4 */
+	{ COLORIMETRY_XV_YCC_601, "XV_YCC_601" },
+	/* High Definition Colorimetry based on IEC 61966-2-4 */
+	{ COLORIMETRY_XV_YCC_709, "XV_YCC_709" },
+	/* Colorimetry based on IEC 61966-2-1/Amendment 1 */
+	{ COLORIMETRY_S_YCC_601, "S_YCC_601" },
+	/* Colorimetry based on IEC 61966-2-5 [33] */
+	{ COLORIMETRY_OPYCC_601, "opYCC_601" },
+	/* Colorimetry based on IEC 61966-2-5 */
+	{ COLORIMETRY_OPRGB, "opRGB" },
+	/* Colorimetry based on ITU-R BT.2020 */
+	{ COLORIMETRY_BT2020_RGB, "BT2020_RGB" },
Quoted 8 lines

drivers/gpu/drm/drm_connector.c int drm_display_info_set_bus_formats(struct drm_display_info *info, · line 850

Quoted 6 lines
drivers/gpu/drm/drm_connector.c +6 -0
+	/* Colorimetry based on ITU-R BT.2020 */
+	{ COLORIMETRY_BT2020_YCC, "BT2020_YCC" },
+	/* Colorimetry based on ITU-R BT.2020 */
+	{ COLORIMETRY_BT2020_CYCC, "BT2020_CYCC" },
+	/* For Default case, driver will set the colorspace */
+	{ COLORIMETRY_DEFAULT, "Default" },

"Default" needs to be the default.

Ok, will make this as 0 and put it in the beginning of the list. Hope that is ok.

Quoted 132 lines
Quoted 22 lines
drivers/gpu/drm/drm_connector.c +14 -0
+};
+
 /**
  * DOC: standard connector properties
  *
@@ -1402,6 +1426,44 @@ int
 drm_mode_create_aspect_ratio_property(struct drm_device *dev)
 EXPORT_SYMBOL(drm_mode_create_aspect_ratio_property);
 
 /**
+ * drm_mode_create_colorspace_property - create colorspace property
+ * colorspace:
+ *     This property helps select a suitable colorspace based on the sink
+ *     capability. Modern sink devices support wider gamut like BT2020.
+ *     This helps switch to BT2020 mode if the BT2020 encoded video stream
+ *     is being played by the user, same for any other colorspace.
+ * @dev: DRM device
+ *
+ * Called by a driver the first time it's needed, must be attached to
+desired
+ * connectors.
+ *

drivers/gpu/drm/drm_connector.c int · line 1451

Quoted 10 lines
drivers/gpu/drm/drm_connector.c +10 -0
+ * Returns:
+ * Zero on success, negative errno on failure.
+ */
+int drm_mode_create_colorspace_property(struct drm_connector
+*connector) {
+	struct drm_device *dev = connector->dev;
+	struct drm_property *prop;
+
+	if (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
+			connector->connector_type ==

DRM_MODE_CONNECTOR_HDMIB) {

drivers/gpu/drm/drm_connector.c int drm_mode_create_aspect_ratio_property(struct drm_device *dev)

Quoted 4 lines
drivers/gpu/drm/drm_connector.c +4 -0
+		if (dev->mode_config.hdmi_colorspace_property)
+			return 0;
+
+		prop = drm_property_create_enum(dev,

DRM_MODE_PROP_ENUM,

drivers/gpu/drm/drm_connector.c int · line 1457

Quoted 2 lines
drivers/gpu/drm/drm_connector.c +2 -0
+				"HDMI_Colorspace",
+				hdmi_colorspace,

ARRAY_SIZE(hdmi_colorspace));

Quoted 33 lines
drivers/gpu/drm/drm_connector.c +11 -0
+		if (!prop)
+			return -ENOMEM;
+
+		dev->mode_config.hdmi_colorspace_property = prop;
+	}
+
+	return 0;
+}
+EXPORT_SYMBOL(drm_mode_create_colorspace_property);
+
+/**
  * drm_mode_create_content_type_property - create content type property
  * @dev: DRM device
  *
include/drm/drm_connector.h +7 -0
index af0a761..5fda56d 100644
@@ -497,6 +497,13 @@ struct drm_connector_state {
 	unsigned int content_protection;
 
 	/**
+	 * @hdmi_colorspace: Connector property to request colorspace
+	 * change on HDMI Sink. This is most commonly used to switch to
+	 * wider color gamuts like BT2020.
+	 */
+	enum hdmi_full_colorimetry hdmi_colorspace;
+
+	/**
 	 * @writeback_job: Writeback job for writeback connectors
 	 *
 	 * Holds the framebuffer and out-fence for a writeback connector. As
@@ -1272,6 +1279,7 @@ int
Quoted 1 line

drm_connector_attach_scaling_mode_property(struct drm_connector

*connector, int drm_connector_attach_content_protection_property(

Quoted 6 lines
include/drm/drm_connector.h +2 -0
 		struct drm_connector *connector);
 int drm_mode_create_aspect_ratio_property(struct drm_device *dev);
+int drm_mode_create_colorspace_property(struct drm_connector
+*connector);
 int drm_mode_create_content_type_property(struct drm_device *dev);

void drm_hdmi_avi_infoframe_content_type(struct hdmi_avi_infoframe

*frame,

Quoted 1 line

const struct drm_connector_state

*conn_state); diff --git

Quoted 47 lines

a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h index 5dbeabd..ec7cab8 100644

include/drm/drm_mode_config.h +6 -0
@@ -869,6 +869,12 @@ struct drm_mode_config {
 	uint32_t cursor_width, cursor_height;
 
 	/**
+	 * @hdmi_colorspace_property: Connector property to set the suitable
+	 * colorspace supported by the HDMI sink.
+	 */
+	struct drm_property *hdmi_colorspace_property;
+
+	/**
 	 * @suspend_state:
 	 *
 	 * Atomic state when suspended.
include/uapi/drm/drm_mode.h +16 -1
index d3e0fe3..cc4df26 100644
@@ -210,6 +210,22 @@
 #define DRM_MODE_CONTENT_PROTECTION_DESIRED     1
 #define DRM_MODE_CONTENT_PROTECTION_ENABLED     2
 
+enum hdmi_full_colorimetry {
+	/* CEA 861 Normal Colorimetry options */
+	COLORIMETRY_ITU_601 = 0,
+	COLORIMETRY_ITU_709,
+	/* CEA 861 Extended Colorimetry Options */
+	COLORIMETRY_XV_YCC_601,
+	COLORIMETRY_XV_YCC_709,
+	COLORIMETRY_S_YCC_601,
+	COLORIMETRY_OPYCC_601,
+	COLORIMETRY_OPRGB,
+	COLORIMETRY_BT2020_RGB,
+	COLORIMETRY_BT2020_YCC,
+	COLORIMETRY_BT2020_CYCC,
+	COLORIMETRY_DEFAULT,
+};
+
 struct drm_mode_modeinfo {
 	__u32 clock;
 	__u16 hdisplay;
--

1.9.1

Quoted 8 lines
Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Ville Syrjälä
Intel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw

PATCH v3 2/3 drm: Add DP colorspace property

In reply to Uma Shankar

This patch adds a DP colorspace property, enabling userspace to switch to various supported colorspaces. This will help enable BT2020 along with other colorspaces.

v2: Addressed Maarten and Ville's review comments. Enhanced
the colorspace enum to incorporate both HDMI and DP supported colorspaces. Also, added a default option for colorspace.

v3: Split the changes to have separate colorspace property for DP and HDMI.

---
 drivers/gpu/drm/drm_atomic_uapi.c |  4 ++++
 drivers/gpu/drm/drm_connector.c   | 35 +++++++++++++++++++++++++++++++++++
 include/drm/drm_connector.h       |  7 +++++++
 include/drm/drm_mode_config.h     |  6 ++++++
 include/uapi/drm/drm_mode.h       | 19 +++++++++++++++++++
 5 files changed, 71 insertions(+)
drivers/gpu/drm/drm_atomic_uapi.c +4 -0
index 4e09a38..37d51299b 100644
@@ -723,6 +723,8 @@ static int drm_atomic_connector_set_property(struct drm_connector *connector,
 		state->content_type = val;
 	} else if (property == config->hdmi_colorspace_property) {
 		state->hdmi_colorspace = val;
+	} else if (property == config->dp_colorspace_property) {
+		state->dp_colorspace = val;
 	} else if (property == connector->scaling_mode_property) {
 		state->scaling_mode = val;
 	} else if (property == connector->content_protection_property) {
@@ -801,6 +803,8 @@ static int drm_atomic_connector_set_property(struct drm_connector *connector,
 		*val = state->content_type;
 	} else if (property == config->hdmi_colorspace_property) {
 		*val = state->hdmi_colorspace;
+	} else if (property == config->dp_colorspace_property) {
+		*val = state->dp_colorspace;
 	} else if (property == connector->scaling_mode_property) {
 		*val = state->scaling_mode;
 	} else if (property == connector->content_protection_property) {
drivers/gpu/drm/drm_connector.c +35 -0
index 1906e4a..5bb9cb6 100644
@@ -850,6 +850,29 @@ int drm_display_info_set_bus_formats(struct drm_display_info *info,
 	{ COLORIMETRY_DEFAULT, "Default" },
 };
 
+static const struct drm_prop_enum_list dp_colorspace[] = {
+	/* Standard Definition Colorimetry based on CEA 861 */
+	{ DP_COLORIMETRY_ITU_601, "ITU_601" },
+	{ DP_COLORIMETRY_ITU_709, "ITU_709" },
+	/* Standard Definition Colorimetry based on IEC 61966-2-4 */
+	{ DP_COLORIMETRY_XV_YCC_601, "XV_YCC_601" },
+	/* High Definition Colorimetry based on IEC 61966-2-4 */
+	{ DP_COLORIMETRY_XV_YCC_709, "XV_YCC_709" },
+	/* Colorimetry based on IEC 61966-2-5 */
+	{ DP_COLORIMETRY_OPRGB, "opRGB" },
+	/* DP MSA Colorimetry */
+	{ DP_COLORIMETRY_Y_CBCR_ITU_601, "YCBCR_ITU_601" },
+	{ DP_COLORIMETRY_Y_CBCR_ITU_709, "YCBCR_ITU_709" },
+	{ DP_COLORIMETRY_SRGB, "sRGB" },
+	{ DP_COLORIMETRY_RGB_WIDE_GAMUT, "RGB Wide Gamut" },
+	{ DP_COLORIMETRY_SCRGB, "scRGB" },
+	{ DP_COLORIMETRY_DCI_P3, "DCI-P3" },
+	{ DP_COLORIMETRY_CUSTOM_COLOR_PROFILE, "Custom Profile" },
+	/* For Default case, driver will set the colorspace */
+	{ DP_COLORIMETRY_DEFAULT, "Default" },
+};
+
+
 /**
  * DOC: standard connector properties
  *
@@ -1457,6 +1480,18 @@ int drm_mode_create_colorspace_property(struct drm_connector *connector)
 			return -ENOMEM;
 
 		dev->mode_config.hdmi_colorspace_property = prop;
+	} else if (connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
+		connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
+		if (dev->mode_config.dp_colorspace_property)
+			return 0;
+
+		prop = drm_property_create_enum(dev, DRM_MODE_PROP_ENUM,
+						"DP_Colorspace", dp_colorspace,
+						ARRAY_SIZE(dp_colorspace));
+		if (!prop)
+			return -ENOMEM;
+
+		dev->mode_config.dp_colorspace_property = prop;
 	}
 
 	return 0;
include/drm/drm_connector.h +7 -0
index 5fda56d..4596e24 100644
@@ -504,6 +504,13 @@ struct drm_connector_state {
 	enum hdmi_full_colorimetry hdmi_colorspace;
 
 	/**
+	 * @dp_colorspace: Connector property to request colorspace
+	 * change on DP Sink. This is most commonly used to switch to
+	 * wider color gamuts like BT2020.
+	 */
+	enum dp_full_colorimetry dp_colorspace;
+
+	/**
 	 * @writeback_job: Writeback job for writeback connectors
 	 *
 	 * Holds the framebuffer and out-fence for a writeback connector. As
include/drm/drm_mode_config.h +6 -0
index ec7cab8..87b0698 100644
@@ -875,6 +875,12 @@ struct drm_mode_config {
 	struct drm_property *hdmi_colorspace_property;
 
 	/**
+	 * @dp_colorspace_property: Connector property to set the suitable
+	 * colorspace supported by the DP sink.
+	 */
+	struct drm_property *dp_colorspace_property;
+
+	/**
 	 * @suspend_state:
 	 *
 	 * Atomic state when suspended.
include/uapi/drm/drm_mode.h +19 -0
index cc4df26..1cd7346 100644
@@ -226,6 +226,25 @@ enum hdmi_full_colorimetry {
 	COLORIMETRY_DEFAULT,
 };
 
+enum dp_full_colorimetry {
+	/* CEA 861 Normal Colorimetry options */
+	DP_COLORIMETRY_ITU_601 = 0,
+	DP_COLORIMETRY_ITU_709,
+	/* CEA 861 Extended Colorimetry Options */
+	DP_COLORIMETRY_XV_YCC_601,
+	DP_COLORIMETRY_XV_YCC_709,
+	DP_COLORIMETRY_OPRGB,
+	/* DP MSA Colorimetry Options */
+	DP_COLORIMETRY_Y_CBCR_ITU_601,
+	DP_COLORIMETRY_Y_CBCR_ITU_709,
+	DP_COLORIMETRY_SRGB,
+	DP_COLORIMETRY_RGB_WIDE_GAMUT,
+	DP_COLORIMETRY_SCRGB,
+	DP_COLORIMETRY_DCI_P3,
+	DP_COLORIMETRY_CUSTOM_COLOR_PROFILE,
+	DP_COLORIMETRY_DEFAULT,
+};
+
 struct drm_mode_modeinfo {
 	__u32 clock;
 	__u16 hdisplay;
Signature · 6 lines
1.9.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#5 lore raw

Re: [v3 2/3] drm: Add DP colorspace property

Quoting Uma Shankar (2018-11-20 14:22:10)

Quoted 4 lines
drivers/gpu/drm/drm_connector.c +0 -0
@@ -1457,6 +1480,18 @@ int drm_mode_create_colorspace_property(struct drm_connector *connector)
                        return -ENOMEM;
 
                dev->mode_config.hdmi_colorspace_property = prop;

drivers/gpu/drm/drm_connector.c int drm_mode_create_colorspace_property(struct drm_connector *connector) · line 1492

Quoted 10 lines
drivers/gpu/drm/drm_connector.c +10 -0
+       } else if (connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
+               connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
+               if (dev->mode_config.dp_colorspace_property)
+                       return 0;
+
+               prop = drm_property_create_enum(dev, DRM_MODE_PROP_ENUM,
+                                               "DP_Colorspace", dp_colorspace,
+                                               ARRAY_SIZE(dp_colorspace));
+               if (!prop)
+                       return -ENOMEM;

Why different names for DP/HDMI?
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

Re: [v3 2/3] drm: Add DP colorspace property

Quoted 31 lines

-----Original Message-----
From: Chris Wilson [mailto:[email protected]]
Sent: Tuesday, November 20, 2018 7:41 PM
To: Shankar, Uma <[email protected]>; [email protected]; [email protected]
Cc: Syrjala, Ville <[email protected]>; [email protected]; [email protected]; Shankar, Uma <[email protected]>; Lankhorst, Maarten <[email protected]>
Subject: Re: [v3 2/3] drm: Add DP colorspace property

Quoting Uma Shankar (2018-11-20 14:22:10)

Review int drm_mode_create_colorspace_property(struct

Quoted 1 line
(quoted diff) +0 -0
@@ -1457,6 +1480,18 @@ int drm_mode_create_colorspace_property(struct

drm_connector *connector)

drivers/gpu/drm/drm_connector.c int drm_mode_create_colorspace_property(struct drm_connector *connector)

Quoted 4 lines
drivers/gpu/drm/drm_connector.c +1 -0
                        return -ENOMEM;
 
                dev->mode_config.hdmi_colorspace_property = prop;
+       } else if (connector->connector_type == DRM_MODE_CONNECTOR_eDP
||
> +               connector->connector_type ==

DRM_MODE_CONNECTOR_DisplayPort) {

drivers/gpu/drm/drm_connector.c int drm_mode_create_colorspace_property(struct drm_connector *connector) · line 1492

Quoted 8 lines
drivers/gpu/drm/drm_connector.c +8 -0
+               if (dev->mode_config.dp_colorspace_property)
+                       return 0;
+
+               prop = drm_property_create_enum(dev, DRM_MODE_PROP_ENUM,
+                                               "DP_Colorspace", dp_colorspace,
+                                               ARRAY_SIZE(dp_colorspace));
+               if (!prop)
+                       return -ENOMEM;
Quoted 1 line

Why different names for DP/HDMI?

There are some colorspaces specific to HDMI and DP, hence we created separate properties for these encoders. This is just to expose DP specifc colorspaces on a DP connector and same way for HDMI. Earlier, we had just one but it was giving DP stuff as well to a HDMI Connector and vice-versa which was not looking good.

Regards,
Uma Shankar

Quoted 1 line

-Chris

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

Re: [v3 2/3] drm: Add DP colorspace property

Quoted 31 lines · Uma
Quoted 31 lines

-----Original Message-----
From: Chris Wilson [mailto:[email protected]]
Sent: Tuesday, November 20, 2018 7:41 PM
To: Shankar, Uma <[email protected]>; [email protected]; [email protected]
Cc: Syrjala, Ville <[email protected]>; [email protected]; [email protected]; Shankar, Uma <[email protected]>; Lankhorst, Maarten <[email protected]>
Subject: Re: [v3 2/3] drm: Add DP colorspace property

Quoting Uma Shankar (2018-11-20 14:22:10)

Review int drm_mode_create_colorspace_property(struct

Quoted 1 line
(quoted diff) +0 -0
@@ -1457,6 +1480,18 @@ int drm_mode_create_colorspace_property(struct

drm_connector *connector)

drivers/gpu/drm/drm_connector.c int drm_mode_create_colorspace_property(struct drm_connector *connector)

Quoted 4 lines
drivers/gpu/drm/drm_connector.c +1 -0
                        return -ENOMEM;
 
                dev->mode_config.hdmi_colorspace_property = prop;
+       } else if (connector->connector_type == DRM_MODE_CONNECTOR_eDP
||
> +               connector->connector_type ==

DRM_MODE_CONNECTOR_DisplayPort) {

Quoted 8 lines
drivers/gpu/drm/drm_connector.c +8 -0
+               if (dev->mode_config.dp_colorspace_property)
+                       return 0;
+
+               prop = drm_property_create_enum(dev, DRM_MODE_PROP_ENUM,
+                                               "DP_Colorspace", dp_colorspace,
+                                               ARRAY_SIZE(dp_colorspace));
+               if (!prop)
+                       return -ENOMEM;
Quoted 3 lines
Quoted 1 line

Why different names for DP/HDMI?

There are some colorspaces specific to HDMI and DP, hence we created separate properties for these encoders.

Why does that require different names for the props?

Quoted 11 lines

This is just to expose DP specifc colorspaces on a DP connector and same way
for HDMI. Earlier, we had just one but it was giving DP stuff as well to a HDMI Connector and vice-versa which was not looking good.

Regards,
Uma Shankar

Quoted 1 line

-Chris

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#8 lore raw

PATCH v3 3/3 drm/i915: Attach colorspace property and enable modeset

In reply to Uma Shankar

This patch attaches the colorspace connector property to the hdmi connector. Based on colorspace change, modeset will be triggered to switch to new colorspace.

Based on colorspace property value create an infoframe with appropriate colorspace. This can be used to send an infoframe packet with proper colorspace value set which will help to enable wider color gamut like BT2020 on sink.

This patch attaches and enables HDMI colorspace, DP will be taken care separately.

v2: Merged the changes of creating infoframe as well to this patch as per Maarten's suggestion.

v3: Addressed review comments from Shashank. Separated HDMI and DP colorspaces as suggested by Ville and Maarten.

---
 drivers/gpu/drm/i915/intel_atomic.c    | 2 ++
 drivers/gpu/drm/i915/intel_connector.c | 8 ++++++++
 drivers/gpu/drm/i915/intel_drv.h       | 1 +
 drivers/gpu/drm/i915/intel_hdmi.c      | 7 +++++++
 4 files changed, 18 insertions(+)
drivers/gpu/drm/i915/intel_atomic.c +2 -0
index a5a2c8f..45624ca 100644
@@ -125,6 +125,8 @@ int intel_digital_connector_atomic_check(struct drm_connector *conn,
 	 */
 	if (new_conn_state->force_audio != old_conn_state->force_audio ||
 	    new_conn_state->broadcast_rgb != old_conn_state->broadcast_rgb ||
+	    new_state->hdmi_colorspace != old_state->hdmi_colorspace ||
+	    new_state->dp_colorspace != old_state->dp_colorspace ||
 	    new_conn_state->base.picture_aspect_ratio != old_conn_state->base.picture_aspect_ratio ||
 	    new_conn_state->base.content_type != old_conn_state->base.content_type ||
 	    new_conn_state->base.scaling_mode != old_conn_state->base.scaling_mode)
drivers/gpu/drm/i915/intel_connector.c +8 -0
index 18e370f..b4c20d8 100644
@@ -262,3 +262,11 @@ int intel_ddc_get_modes(struct drm_connector *connector,
 			connector->dev->mode_config.aspect_ratio_property,
 			DRM_MODE_PICTURE_ASPECT_NONE);
 }
+
+void
+intel_attach_hdmi_colorspace_property(struct drm_connector *connector)
+{
+	if (!drm_mode_create_colorspace_property(connector))
+		drm_object_attach_property(&connector->base,
+		connector->dev->mode_config.hdmi_colorspace_property, 0);
+}
drivers/gpu/drm/i915/intel_drv.h +1 -0
index f575ba2..a1afe71 100644
@@ -1761,6 +1761,7 @@ int intel_connector_update_modes(struct drm_connector *connector,
 void intel_attach_force_audio_property(struct drm_connector *connector);
 void intel_attach_broadcast_rgb_property(struct drm_connector *connector);
 void intel_attach_aspect_ratio_property(struct drm_connector *connector);
+void intel_attach_hdmi_colorspace_property(struct drm_connector *connector);
 
 /* intel_csr.c */
 void intel_csr_ucode_init(struct drm_i915_private *);
drivers/gpu/drm/i915/intel_hdmi.c +7 -0
index e2c6a2b..26e8828 100644
@@ -486,6 +486,11 @@ static void intel_hdmi_set_avi_infoframe(struct intel_encoder *encoder,
 	else
 		frame.avi.colorspace = HDMI_COLORSPACE_RGB;
 
+	if (conn_state->hdmi_colorspace >= COLORIMETRY_XV_YCC_601) {
+		frame.avi.colorimetry = HDMI_COLORIMETRY_EXTENDED;
+		frame.avi.extended_colorimetry = conn_state->hdmi_colorspace;
+	}
+
 	drm_hdmi_avi_infoframe_quant_range(&frame.avi, adjusted_mode,
 					   crtc_state->limited_color_range ?
 					   HDMI_QUANTIZATION_RANGE_LIMITED :
@@ -2135,6 +2140,8 @@ static void intel_hdmi_destroy(struct drm_connector *connector)
 	intel_attach_force_audio_property(connector);
 	intel_attach_broadcast_rgb_property(connector);
 	intel_attach_aspect_ratio_property(connector);
+	intel_attach_hdmi_colorspace_property(connector);
+
 	drm_connector_attach_content_type_property(connector);
 	connector->state->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
 
Signature · 6 lines
1.9.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#9 lore raw

✗ Fi.CI.CHECKPATCH: warning for Add Colorspace connector property interface (rev3)

In reply to Uma Shankar
== Series Details ==

== Series Details ==

Series: Add Colorspace connector property interface (rev3)
URL : https://patchwork.freedesktop.org/series/47132/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a84155117012 drm: Add HDMI colorspace property
-:105: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#105: FILE: drivers/gpu/drm/drm_connector.c:1449:
+	if (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
+			connector->connector_type == DRM_MODE_CONNECTOR_HDMIB) {

-:110: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #110: FILE: drivers/gpu/drm/drm_connector.c:1454:
+ prop = drm_property_create_enum(dev, DRM_MODE_PROP_ENUM,
+ "HDMI_Colorspace",

total: 0 errors, 0 warnings, 2 checks, 144 lines checked 468f981dd4cc drm: Add DP colorspace property
-:71: CHECK:LINE_SPACING: Please don't use multiple blank lines #71: FILE: drivers/gpu/drm/drm_connector.c:875:
+
+

total: 0 errors, 0 warnings, 1 checks, 113 lines checked d75c0c0c79de drm/i915: Attach colorspace property and enable modeset -:53: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #53: FILE: drivers/gpu/drm/i915/intel_connector.c:271:
+ drm_object_attach_property(&connector->base,
+ connector->dev->mode_config.hdmi_colorspace_property, 0);

total: 0 errors, 0 warnings, 1 checks, 45 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

✗ Fi.CI.SPARSE: warning for Add Colorspace connector property interface (rev3)

In reply to Uma Shankar
== Series Details ==

== Series Details ==

Series: Add Colorspace connector property interface (rev3)
URL : https://patchwork.freedesktop.org/series/47132/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm: Add HDMI colorspace property
Okay!

Commit: drm: Add DP colorspace property
Okay!

Commit: drm/i915: Attach colorspace property and enable modeset
+drivers/gpu/drm/i915/intel_hdmi.c:491:60: int enum hdmi_extended_colorimetry
+drivers/gpu/drm/i915/intel_hdmi.c:491:60: int enum hdmi_full_colorimetry versus
+drivers/gpu/drm/i915/intel_hdmi.c:491:60: warning: mixing different enum types

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#11 lore raw

✓ Fi.CI.BAT: success for Add Colorspace connector property interface (rev3)

In reply to Uma Shankar
== Series Details ==

== Series Details ==

Series: Add Colorspace connector property interface (rev3)
URL : https://patchwork.freedesktop.org/series/47132/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_5174 -> Patchwork_10862 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/47132/revisions/3/mbox/

== Known issues ==

Here are the changes found in Patchwork_10862 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_suspend@basic-s3:
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
      fi-byt-clapper:     PASS -> FAIL (fdo#103191, fdo#107362) +1

    
    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s3:
      fi-icl-u2:          DMESG-WARN (fdo#107724) -> PASS

    igt@i915_selftest@live_execlists:
      fi-apl-guc:         DMESG-WARN (fdo#108622) -> PASS

    igt@kms_flip@basic-flip-vs-dpms:
      fi-skl-6700hq:      DMESG-WARN (fdo#105998) -> PASS

fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
fdo#108622 https://bugs.freedesktop.org/show_bug.cgi?id=108622

== Participating hosts (52 -> 46) ==

Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-u3

== Build changes ==

* Linux: CI_DRM_5174 -> Patchwork_10862

CI_DRM_5174: 0bfa7192170c039a271ebc27222b4b91516e73f6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4722: fdcdfa1e220c5070072d5dac9523cd105e7406c2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10862: d75c0c0c79deb06a7a96cc9e775333ea485485bd @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

d75c0c0c79de drm/i915: Attach colorspace property and enable modeset 468f981dd4cc drm: Add DP colorspace property
a84155117012 drm: Add HDMI colorspace property

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10862/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#12 lore raw

✓ Fi.CI.IGT: success for Add Colorspace connector property interface (rev3)

In reply to Uma Shankar
== Series Details ==

== Series Details ==

Series: Add Colorspace connector property interface (rev3)
URL : https://patchwork.freedesktop.org/series/47132/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_5174_full -> Patchwork_10862_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_10862_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10862_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10862_full:

=== IGT changes ===

    ==== Warnings ====

    igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic:
      shard-snb:          PASS -> SKIP +3

    igt@pm_rc6_residency@rc6-accuracy:
      shard-snb:          SKIP -> PASS

== Known issues ==

Here are the changes found in Patchwork_10862_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@i915_suspend@shrink:
      {shard-iclb}:       NOTRUN -> DMESG-WARN (fdo#108784)

    igt@kms_busy@extended-modeset-hang-newfb-render-b:
      {shard-iclb}:       NOTRUN -> DMESG-WARN (fdo#107956)

    igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
      {shard-iclb}:       PASS -> DMESG-WARN (fdo#107956) +1

    igt@kms_chv_cursor_fail@pipe-a-128x128-top-edge:
      shard-skl:          NOTRUN -> FAIL (fdo#104671) +1

    igt@kms_cursor_crc@cursor-64x64-suspend:
      {shard-iclb}:       NOTRUN -> FAIL (fdo#103232) +1

    igt@kms_fbcon_fbt@psr:
      shard-skl:          NOTRUN -> FAIL (fdo#107882)

    igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-wc:
      shard-skl:          NOTRUN -> FAIL (fdo#103167) +2

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
      shard-apl:          PASS -> FAIL (fdo#103167)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
      shard-skl:          NOTRUN -> FAIL (fdo#105682)

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
      shard-glk:          PASS -> FAIL (fdo#103167) +1

    igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-wc:
      {shard-iclb}:       PASS -> FAIL (fdo#103167) +8

    igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-render:
      shard-skl:          NOTRUN -> FAIL (fdo#105682, fdo#103167)

    igt@kms_plane@pixel-format-pipe-b-planes:
      {shard-iclb}:       NOTRUN -> FAIL (fdo#103166)

    igt@kms_plane@pixel-format-pipe-c-planes:
      shard-glk:          PASS -> FAIL (fdo#103166) +1

    igt@kms_plane@plane-position-covered-pipe-a-planes:
      shard-skl:          NOTRUN -> FAIL (fdo#103166)

    igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
      shard-skl:          NOTRUN -> FAIL (fdo#107815, fdo#108145) +2

    igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
      {shard-iclb}:       PASS -> FAIL (fdo#103166) +2

    igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
      shard-apl:          PASS -> FAIL (fdo#103166)

    igt@kms_plane_scaling@pipe-a-scaler-with-pixel-format:
      {shard-iclb}:       NOTRUN -> DMESG-WARN (fdo#107724)

    igt@pm_rpm@debugfs-read:
      {shard-iclb}:       PASS -> DMESG-WARN (fdo#107724)

    igt@pm_rpm@system-suspend-devices:
      shard-skl:          PASS -> INCOMPLETE (fdo#107807)

    igt@pm_rps@min-max-config-loaded:
      {shard-iclb}:       NOTRUN -> FAIL (fdo#102250)

    
    ==== Possible fixes ====

    igt@gem_pwrite@big-gtt-backwards:
      shard-apl:          INCOMPLETE (fdo#103927) -> PASS

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
      shard-kbl:          DMESG-WARN (fdo#107956) -> PASS

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
      shard-apl:          DMESG-WARN (fdo#107956) -> PASS

    igt@kms_color@pipe-a-ctm-max:
      shard-apl:          FAIL (fdo#108147) -> PASS

    igt@kms_color@pipe-c-legacy-gamma:
      shard-apl:          FAIL (fdo#104782) -> PASS

    igt@kms_cursor_crc@cursor-256x85-sliding:
      shard-apl:          FAIL (fdo#103232) -> PASS +2

    igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
      shard-glk:          DMESG-WARN (fdo#105763, fdo#106538) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
      shard-glk:          FAIL (fdo#103167) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
      shard-apl:          FAIL (fdo#103167) -> PASS +1

    igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite:
      {shard-iclb}:       FAIL (fdo#103167) -> PASS +1

    igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
      shard-skl:          FAIL (fdo#107815) -> PASS

    igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
      shard-glk:          FAIL (fdo#103166) -> PASS +1

    igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
      {shard-iclb}:       FAIL (fdo#103166) -> PASS

    igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
      shard-apl:          FAIL (fdo#103166) -> PASS +2

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS

    igt@pm_rpm@fences:
      {shard-iclb}:       DMESG-WARN (fdo#108654) -> PASS

    igt@pm_rpm@gem-mmap-cpu:
      {shard-iclb}:       INCOMPLETE -> PASS

    
    ==== Warnings ====

    igt@i915_suspend@shrink:
      shard-skl:          DMESG-WARN (fdo#108784) -> INCOMPLETE (fdo#106886)

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

fdo#102250 https://bugs.freedesktop.org/show_bug.cgi?id=102250
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104671 https://bugs.freedesktop.org/show_bug.cgi?id=104671
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#107882 https://bugs.freedesktop.org/show_bug.cgi?id=107882
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108147 https://bugs.freedesktop.org/show_bug.cgi?id=108147
fdo#108654 https://bugs.freedesktop.org/show_bug.cgi?id=108654
fdo#108784 https://bugs.freedesktop.org/show_bug.cgi?id=108784
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912

== Participating hosts (7 -> 7) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_5174 -> Patchwork_10862

CI_DRM_5174: 0bfa7192170c039a271ebc27222b4b91516e73f6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4722: fdcdfa1e220c5070072d5dac9523cd105e7406c2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10862: d75c0c0c79deb06a7a96cc9e775333ea485485bd @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10862/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx