Skip to contentSkip to conversation

Enable compilation of various Renesas drivers with COMPILE_TEST

PATCH New Laurent Pinchart 16 participants 65 messages Nov 27, 2013 – Mar 4, 2014

Subsystems (17)
lore
Share & tools
lore
#0 lore raw

cover Enable compilation of various Renesas drivers with COMPILE_TEST

Hello,

This patch series enables driver compilation with COMPILE_TEST for various Renesas drivers. The approach taken here is to split the Kconfig depends line in two, with compile dependencies (if any) on one line and runtime dependencies (as a list of the platforms on which the hardware can be found) on another line. The runtime dependencies line is extended with || COMPILE_TEST to enable test compilation. This clearly identifies compile dependencies, and allow test compilation while not clobbering the configuration menu with useless options in the normal case.

The patches are based on top of v3.13-rc1. To avoid build warnings or errors during bisection the following patches sent to linux-sh and appropriate mailing lists should be applied first:

serial: sh-sci: Fix warnings due to improper casts and printk formats
DMA: shdma: Fix warnings due to improper casts and printk formats
DMA: shdma: Fix warnings due to declared but unused symbols
DMA: shdma: Make sh_dmae_pm static
v4l: sh_vou: Fix warnings due to improper casts and printk formats
mmc: sh_mmcif: Factorize DMA channel request and configuration code
mmc: sh_mmcif: Fix compilation warning on 64-bit platforms
mtd: sh_flctl: Fix warnings due to improper casts
fbdev: sh_mobile_lcdcfb: Don't use plain 0 as NULL pointer
spi: sh-msiof: Fix warnings due to improper casts
spi: rcar: Fix uninitialized variable warning
spi: rcar: Fix pointer cast in the remove function

For convenience I've pushed the whole series and its prerequisites to my git tree at

git://linuxtv.org/pinchartl/fbdev.git clocks/ccf/multiarch-drivers

The patches will need to go through their respective subsystem's trees. To help me tracking the mainlining state I'd appreciate if the respective maintainers could notify me when applying the patches to their trees. Before doing so I'd like to get an ack from Mark Brown and/or Russell King on the approach.

Cc dmaengine at vger.kernel.org
Cc iommu at lists.linux-foundation.org
Cc linux-fbdev at vger.kernel.org
Cc linux-i2c at vger.kernel.org
Cc linux-input at vger.kernel.org
Cc linux-media at vger.kernel.org
Cc linux-mmc at vger.kernel.org
Cc linux-mtd at lists.infradead.org
Cc linux-pm at vger.kernel.org
Cc linux-pwm at vger.kernel.org
Cc linux-serial at vger.kernel.org
Cc linux-spi at vger.kernel.org
Cc netdev at vger.kernel.org
Cc Chris Ball <[email protected]>
Cc David Woodhouse <[email protected]>
Cc Dmitry Torokhov <[email protected]>
Cc Eduardo Valentin <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Guennadi Liakhovetski <[email protected]>
Cc Ian Molton <[email protected]>
Cc Jean-Christophe Plagniol-Villard <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc Magnus Damm <[email protected]>
Cc Mark Brown <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Cc Russell King <[email protected]>
Cc Samuel Ortiz <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Cc Vinod Koul <[email protected]>
Cc Wolfram Sang <[email protected]>
Cc Zhang Rui <[email protected]>

Laurent Pinchart (15):
i2c: shmobile/rcar: Restrict non-COMPILE_TEST compilation
input: sh_keysc: Restrict non-COMPILE_TEST compilation
serial: sh-sci: Restrict non-COMPILE_TEST compilation
iommu: shmobile: Enable driver compilation with COMPILE_TEST
DMA: shdma: Enable driver compilation with COMPILE_TEST
v4l: sh_vou: Enable driver compilation with COMPILE_TEST
mmc: sdhi: Enable driver compilation with COMPILE_TEST
mmc: sh_mmcif: Enable driver compilation with COMPILE_TEST
mtd: sh_flctl: Enable driver compilation with COMPILE_TEST
irda: sh_irda: Enable driver compilation with COMPILE_TEST
pwm: pwm-renesas-tpu: Enable driver compilation with COMPILE_TEST
thermal: rcar-thermal: Enable driver compilation with COMPILE_TEST
fbdev: sh-mobile-lcdcfb: Enable driver compilation with COMPILE_TEST
spi: sh-msiof: Enable driver compilation with COMPILE_TEST
sh: intc: Enable driver compilation with COMPILE_TEST

 drivers/dma/sh/Kconfig         | 2 +-
 drivers/i2c/busses/Kconfig     | 4 ++--
 drivers/input/keyboard/Kconfig | 2 +-
 drivers/iommu/Kconfig          | 1 +
 drivers/media/platform/Kconfig | 3 ++-
 drivers/mmc/host/Kconfig       | 6 ++++--
 drivers/mtd/nand/Kconfig       | 2 +-
 drivers/net/irda/Kconfig       | 3 ++-
 drivers/pwm/Kconfig            | 2 +-
 drivers/sh/intc/Kconfig        | 2 +-
 drivers/spi/Kconfig            | 3 ++-
 drivers/thermal/Kconfig        | 2 +-
 drivers/tty/serial/Kconfig     | 3 ++-
 drivers/video/Kconfig          | 8 +++++---
 14 files changed, 26 insertions(+), 17 deletions(-)
Signature · 3 lines
Regards,

Laurent Pinchart
#1 lore raw

PATCH 1/15 i2c: shmobile/rcar: Restrict non-COMPILE_TEST compilation

Hardware supported by the i2c sh_mobile and rcar drivers is only found on SUPERH or ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.

Cc Wolfram Sang <[email protected]>
Cc linux-i2c at vger.kernel.org
---
 drivers/i2c/busses/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/busses/Kconfig +2 -2
index 3b26129..92bdcf9 100644
@@ -683,7 +683,7 @@ config I2C_SH7760
 
 config I2C_SH_MOBILE
 	tristate "SuperH Mobile I2C Controller"
-	depends on SUPERH || ARM || COMPILE_TEST
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  If you say yes to this option, support will be included for the
 	  built-in I2C interface on the Renesas SH-Mobile processor.
@@ -796,7 +796,7 @@ config I2C_XLR
 
 config I2C_RCAR
 	tristate "Renesas R-Car I2C Controller"
-	depends on ARM || COMPILE_TEST
+	depends on ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  If you say yes to this option, support will be included for the
 	  R-Car I2C controller.
Signature · 1 line
1.8.3.2
#2 lore raw

PATCH 1/15 i2c: shmobile/rcar: Restrict non-COMPILE_TEST compilation

Quoted 7 lines · Laurent Pinchart

Hardware supported by the i2c sh_mobile and rcar drivers is only found on SUPERH or ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.

Cc Wolfram Sang <[email protected]>
Cc linux-i2c at vger.kernel.org
Quoted 34 lines
---
 drivers/i2c/busses/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/busses/Kconfig +2 -2
index 3b26129..92bdcf9 100644
@@ -683,7 +683,7 @@ config I2C_SH7760
 
 config I2C_SH_MOBILE
 	tristate "SuperH Mobile I2C Controller"
-	depends on SUPERH || ARM || COMPILE_TEST
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  If you say yes to this option, support will be included for the
 	  built-in I2C interface on the Renesas SH-Mobile processor.
@@ -796,7 +796,7 @@ config I2C_XLR
 
 config I2C_RCAR
 	tristate "Renesas R-Car I2C Controller"
-	depends on ARM || COMPILE_TEST
+	depends on ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  If you say yes to this option, support will be included for the
 	  R-Car I2C controller.
Signature · 6 lines
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw

PATCH 1/15 i2c: shmobile/rcar: Restrict non-COMPILE_TEST compilation

Hi Wolfram,

Could you please pick this patch up for v3.14 ?

Quoted 39 lines · On Thursday 28 November 2013 16:36:21 Simon Horman wrote:
Quoted 8 lines · Laurent Pinchart

Hardware supported by the i2c sh_mobile and rcar drivers is only found on SUPERH or ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.

Cc: Wolfram Sang <[email protected]>
Cc: linux-i2c at vger.kernel.org
Signed-off-by: Laurent Pinchart
<[email protected]>

Quoted 27 lines

---

 drivers/i2c/busses/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/busses/Kconfig +2 -2
index 3b26129..92bdcf9 100644
@@ -683,7 +683,7 @@ config I2C_SH7760
 
 config I2C_SH_MOBILE
 	tristate "SuperH Mobile I2C Controller"
-	depends on SUPERH || ARM || COMPILE_TEST
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  If you say yes to this option, support will be included for the
 	  built-in I2C interface on the Renesas SH-Mobile processor.
@@ -796,7 +796,7 @@ config I2C_XLR
 
 config I2C_RCAR
 	tristate "Renesas R-Car I2C Controller"
-	depends on ARM || COMPILE_TEST
+	depends on ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  If you say yes to this option, support will be included for the
 	  R-Car I2C controller.
Signature · 3 lines
Regards,

Laurent Pinchart
#4 lore raw

PATCH 1/15 i2c: shmobile/rcar: Restrict non-COMPILE_TEST compilation

Hi Wolfram,

Quoted 3 lines · On Wednesday 11 December 2013 13:47:34 Laurent Pinchart wrote:

Hi Wolfram,

Could you please pick this patch up for v3.14 ?

Ping ?

Quoted 49 lines · On Thursday 28 November 2013 16:36:21 Simon Horman wrote:
Quoted 48 lines · Laurent Pinchart
Quoted 8 lines

Hardware supported by the i2c sh_mobile and rcar drivers is only found on SUPERH or ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.

Cc: Wolfram Sang <[email protected]>
Cc: linux-i2c at vger.kernel.org
Signed-off-by: Laurent Pinchart
<[email protected]>

Quoted 36 lines

---

 drivers/i2c/busses/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/busses/Kconfig +1 -1
index 3b26129..92bdcf9 100644
@@ -683,7 +683,7 @@ config I2C_SH7760
 
 config I2C_SH_MOBILE
 
 	tristate "SuperH Mobile I2C Controller"
 
-	depends on SUPERH || ARM || COMPILE_TEST
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 
drivers/i2c/busses/Kconfig +1 -1
 	help
 
 	  If you say yes to this option, support will be included for the
 	  built-in I2C interface on the Renesas SH-Mobile processor.
@@ -796,7 +796,7 @@ config I2C_XLR
 
 config I2C_RCAR
 
 	tristate "Renesas R-Car I2C Controller"
 
-	depends on ARM || COMPILE_TEST
+	depends on ARCH_SHMOBILE || COMPILE_TEST
 
drivers/i2c/busses/Kconfig +0 -0
 	help
 
 	  If you say yes to this option, support will be included for the
 	  R-Car I2C controller.
Signature · 3 lines
Regards,

Laurent Pinchart
Applied
#5 lore raw

PATCH 1/15 i2c: shmobile/rcar: Restrict non-COMPILE_TEST compilation

In reply to Laurent Pinchart
Quoted 7 lines · Laurent Pinchart

Hardware supported by the i2c sh_mobile and rcar drivers is only found on SUPERH or ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.

Cc Wolfram Sang <[email protected]>
Cc linux-i2c at vger.kernel.org

Applied to for-next, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140103/7f3e244d/attachment.sig>

#6 lore raw

PATCH 2/15 input: sh_keysc: Restrict non-COMPILE_TEST compilation

In reply to Laurent Pinchart

Hardware supported by the driver is only found on SUPERH or ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.

Cc Dmitry Torokhov <[email protected]>
Cc linux-input at vger.kernel.org
---
 drivers/input/keyboard/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/keyboard/Kconfig +1 -1
index bb174c1..a673c9f 100644
@@ -525,7 +525,7 @@ config KEYBOARD_SUNKBD
 
 config KEYBOARD_SH_KEYSC
 	tristate "SuperH KEYSC keypad support"
-	depends on SUPERH || ARM || COMPILE_TEST
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  Say Y here if you want to use a keypad attached to the KEYSC block
 	  on SuperH processors such as sh7722 and sh7343.
Signature · 1 line
1.8.3.2
#7 lore raw

PATCH 2/15 input: sh_keysc: Restrict non-COMPILE_TEST compilation

Quoted 6 lines · Laurent Pinchart

Hardware supported by the driver is only found on SUPERH or ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.

Cc Dmitry Torokhov <[email protected]>
Cc linux-input at vger.kernel.org
Quoted 25 lines
---
 drivers/input/keyboard/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/keyboard/Kconfig +1 -1
index bb174c1..a673c9f 100644
@@ -525,7 +525,7 @@ config KEYBOARD_SUNKBD
 
 config KEYBOARD_SH_KEYSC
 	tristate "SuperH KEYSC keypad support"
-	depends on SUPERH || ARM || COMPILE_TEST
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  Say Y here if you want to use a keypad attached to the KEYSC block
 	  on SuperH processors such as sh7722 and sh7343.
Signature · 6 lines
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
maintainer Applied
#8 lore raw

PATCH 2/15 input: sh_keysc: Restrict non-COMPILE_TEST compilation

Quoted 9 lines · Simon Horman
Quoted 6 lines · Laurent Pinchart

Hardware supported by the driver is only found on SUPERH or ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.

Cc Dmitry Torokhov <[email protected]>
Cc linux-input at vger.kernel.org

Applied, thank you.

Quoted 26 lines
Quoted 26 lines
---
 drivers/input/keyboard/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/keyboard/Kconfig +1 -1
index bb174c1..a673c9f 100644
@@ -525,7 +525,7 @@ config KEYBOARD_SUNKBD
 
 config KEYBOARD_SH_KEYSC
 	tristate "SuperH KEYSC keypad support"
-	depends on SUPERH || ARM || COMPILE_TEST
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  Say Y here if you want to use a keypad attached to the KEYSC block
 	  on SuperH processors such as sh7722 and sh7343.
Signature · 6 lines
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 1 line
Dmitry
#9 lore raw

PATCH 3/15 serial: sh-sci: Restrict non-COMPILE_TEST compilation

In reply to Laurent Pinchart

Hardware supported by the driver is only found on SUPERH or ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.

Cc Greg Kroah-Hartman <[email protected]>
Cc linux-serial at vger.kernel.org
---
 drivers/tty/serial/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/tty/serial/Kconfig +2 -1
index a3817ab..a640d0b 100644
@@ -709,7 +709,8 @@ config SERIAL_IP22_ZILOG_CONSOLE
 
 config SERIAL_SH_SCI
 	tristate "SuperH SCI(F) serial port support"
-	depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST)
+	depends on HAVE_CLK
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	select SERIAL_CORE
 
 config SERIAL_SH_SCI_NR_UARTS
Signature · 1 line
1.8.3.2
#10 lore raw

PATCH 3/15 serial: sh-sci: Restrict non-COMPILE_TEST compilation

Quoted 6 lines · Laurent Pinchart

Hardware supported by the driver is only found on SUPERH or ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.

Cc Greg Kroah-Hartman <[email protected]>
Cc linux-serial at vger.kernel.org
Quoted 26 lines
---
 drivers/tty/serial/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/tty/serial/Kconfig +2 -1
index a3817ab..a640d0b 100644
@@ -709,7 +709,8 @@ config SERIAL_IP22_ZILOG_CONSOLE
 
 config SERIAL_SH_SCI
 	tristate "SuperH SCI(F) serial port support"
-	depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST)
+	depends on HAVE_CLK
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	select SERIAL_CORE
 
 config SERIAL_SH_SCI_NR_UARTS
Signature · 6 lines
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#11 lore raw

PATCH 3/15 serial: sh-sci: Restrict non-COMPILE_TEST compilation

Hi Simon,

Could you please add this patch to your tree with the "[PATCH 00/47] sh-sci updates for v3.14" series ?

Quoted 30 lines · On Thursday 28 November 2013 16:37:11 Simon Horman wrote:
Quoted 7 lines · Laurent Pinchart

Hardware supported by the driver is only found on SUPERH or ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.

Cc: Greg Kroah-Hartman <[email protected]>
Cc: [email protected]
Signed-off-by: Laurent Pinchart <[email protected]>

Quoted 19 lines

---

 drivers/tty/serial/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/tty/serial/Kconfig +2 -1
index a3817ab..a640d0b 100644
@@ -709,7 +709,8 @@ config SERIAL_IP22_ZILOG_CONSOLE
 
 config SERIAL_SH_SCI
 	tristate "SuperH SCI(F) serial port support"
-	depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST)
+	depends on HAVE_CLK
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	select SERIAL_CORE
 
 config SERIAL_SH_SCI_NR_UARTS
Signature · 3 lines
Regards,

Laurent Pinchart
#12 lore raw

PATCH 3/15 serial: sh-sci: Restrict non-COMPILE_TEST compilation

Hi Simon,

Quoted 4 lines · On Wednesday 11 December 2013 13:44:54 Laurent Pinchart wrote:

Hi Simon,

Could you please add this patch to your tree with the "[PATCH 00/47] sh-sci updates for v3.14" series ?

I've updated all my pending branches to your latest devel tag and this patch is missing. Could you please pick it up ?

Quoted 31 lines · On Thursday 28 November 2013 16:37:11 Simon Horman wrote:
Quoted 30 lines · Laurent Pinchart
Quoted 7 lines

Hardware supported by the driver is only found on SUPERH or ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.

Cc: Greg Kroah-Hartman <[email protected]>
Cc: [email protected]
Signed-off-by: Laurent Pinchart <[email protected]>

Quoted 19 lines

---

 drivers/tty/serial/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/tty/serial/Kconfig +2 -1
index a3817ab..a640d0b 100644
@@ -709,7 +709,8 @@ config SERIAL_IP22_ZILOG_CONSOLE
 
 config SERIAL_SH_SCI
 	tristate "SuperH SCI(F) serial port support"
-	depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST)
+	depends on HAVE_CLK
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	select SERIAL_CORE
 
 config SERIAL_SH_SCI_NR_UARTS
Signature · 3 lines
Regards,

Laurent Pinchart
#13 lore raw

PATCH 3/15 serial: sh-sci: Restrict non-COMPILE_TEST compilation

Quoted 10 lines · Laurent Pinchart

Hi Simon,

Quoted 4 lines · On Wednesday 11 December 2013 13:44:54 Laurent Pinchart wrote:

Hi Simon,

Could you please add this patch to your tree with the "[PATCH 00/47] sh-sci updates for v3.14" series ?

I've updated all my pending branches to your latest devel tag and this patch is missing. Could you please pick it up ?

Sure, will do.

Quoted 43 lines
Quoted 32 lines · On Thursday 28 November 2013 16:37:11 Simon Horman wrote:
Quoted 30 lines · Laurent Pinchart
Quoted 7 lines

Hardware supported by the driver is only found on SUPERH or ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.

Cc: Greg Kroah-Hartman <[email protected]>
Cc: linux-serial at vger.kernel.org
Signed-off-by: Laurent Pinchart <[email protected]>

Quoted 19 lines

---

 drivers/tty/serial/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/tty/serial/Kconfig +2 -1
index a3817ab..a640d0b 100644
@@ -709,7 +709,8 @@ config SERIAL_IP22_ZILOG_CONSOLE
 
 config SERIAL_SH_SCI
 	tristate "SuperH SCI(F) serial port support"
-	depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST)
+	depends on HAVE_CLK
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	select SERIAL_CORE
 
 config SERIAL_SH_SCI_NR_UARTS
Signature · 8 lines
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#14 lore raw

PATCH 3/15 serial: sh-sci: Restrict non-COMPILE_TEST compilation

Quoted 6 lines · Simon Horman
Quoted 5 lines · Laurent Pinchart

Hi Simon,

Quoted 2 lines · On Wednesday 11 December 2013 13:44:54 Laurent Pinchart wrote:

Hi Simon,

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Could you please add this patch to your tree with the "[PATCH 00/47] sh-sci updates for v3.14" series ?

I've updated all my pending branches to your latest devel tag and this patch is missing. Could you please pick it up ?

Sure, will do.

I have now done so. But I'm not sure that it will make it into v3.14. If not it might be best to send it back to Greg for v3.15. I can handle that.

#15 lore raw

PATCH 3/15 serial: sh-sci: Restrict non-COMPILE_TEST compilation

In reply to Laurent Pinchart
Quoted 9 lines · Laurent Pinchart

Hardware supported by the driver is only found on SUPERH or ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.

---
 drivers/tty/serial/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
#16 lore raw

PATCH 4/15 iommu: shmobile: Enable driver compilation with COMPILE_TEST

In reply to Laurent Pinchart

This helps increasing build testing coverage.

The driver doesn't compile on non-ARM platforms due to usage of the ARM DMA IOMMU API, restrict compilation to ARM.

Cc Joerg Roedel <[email protected]>
Cc iommu at lists.linux-foundation.org
---
 drivers/iommu/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/iommu/Kconfig +1 -0
index 3e7fdbb..79bbc21 100644
@@ -207,6 +207,7 @@ config SHMOBILE_IOMMU
 	bool "IOMMU for Renesas IPMMU/IPMMUI"
 	default n
 	depends on ARM
+	depends on SH_MOBILE || COMPILE_TEST
 	select IOMMU_API
 	select ARM_DMA_USE_IOMMU
 	select SHMOBILE_IPMMU
Signature · 1 line
1.8.3.2
#17 lore raw

PATCH 4/15 iommu: shmobile: Enable driver compilation with COMPILE_TEST

Quoted 8 lines · Laurent Pinchart

This helps increasing build testing coverage.

The driver doesn't compile on non-ARM platforms due to usage of the ARM DMA IOMMU API, restrict compilation to ARM.

Cc Joerg Roedel <[email protected]>
Cc iommu at lists.linux-foundation.org
Quoted 24 lines
---
 drivers/iommu/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/iommu/Kconfig +1 -0
index 3e7fdbb..79bbc21 100644
@@ -207,6 +207,7 @@ config SHMOBILE_IOMMU
 	bool "IOMMU for Renesas IPMMU/IPMMUI"
 	default n
 	depends on ARM
+	depends on SH_MOBILE || COMPILE_TEST
 	select IOMMU_API
 	select ARM_DMA_USE_IOMMU
 	select SHMOBILE_IPMMU
Signature · 6 lines
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#18 lore raw

PATCH 4/15 iommu: shmobile: Enable driver compilation with COMPILE_TEST

Hi Joerg,

Could you please pick this patch up for v3.14 ?

Quoted 30 lines · On Thursday 28 November 2013 16:36:51 Simon Horman wrote:
Quoted 9 lines · Laurent Pinchart

This helps increasing build testing coverage.

The driver doesn't compile on non-ARM platforms due to usage of the ARM DMA IOMMU API, restrict compilation to ARM.

Cc: Joerg Roedel <[email protected]>
Cc: iommu at lists.linux-foundation.org
Signed-off-by: Laurent Pinchart
<[email protected]>

Quoted 17 lines

---

 drivers/iommu/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/iommu/Kconfig +1 -0
index 3e7fdbb..79bbc21 100644
@@ -207,6 +207,7 @@ config SHMOBILE_IOMMU
 	bool "IOMMU for Renesas IPMMU/IPMMUI"
 	default n
 	depends on ARM
+	depends on SH_MOBILE || COMPILE_TEST
 	select IOMMU_API
 	select ARM_DMA_USE_IOMMU
 	select SHMOBILE_IPMMU
Signature · 3 lines
Regards,

Laurent Pinchart
maintainer Applied
#19 lore raw

PATCH 4/15 iommu: shmobile: Enable driver compilation with COMPILE_TEST

Quoted 3 lines · Laurent Pinchart

Hi Joerg,

Could you please pick this patch up for v3.14 ?

Applied, thanks.

#20 lore raw

PATCH 5/15 DMA: shdma: Enable driver compilation with COMPILE_TEST

In reply to Laurent Pinchart

This helps increasing build testing coverage.

Cc Guennadi Liakhovetski <[email protected]>
Cc Vinod Koul <[email protected]>
Cc dmaengine at vger.kernel.org
---
 drivers/dma/sh/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/sh/Kconfig +1 -1
index dadd9e01..dc0fe03 100644
@@ -4,7 +4,7 @@
 
 config SH_DMAE_BASE
 	bool "Renesas SuperH DMA Engine support"
-	depends on (SUPERH && SH_DMA) || (ARM && ARCH_SHMOBILE)
+	depends on (SUPERH && SH_DMA) || ARCH_SHMOBILE || COMPILE_TEST
 	depends on !SH_DMA_API
 	default y
 	select DMA_ENGINE
Signature · 1 line
1.8.3.2
#21 lore raw

PATCH 5/15 DMA: shdma: Enable driver compilation with COMPILE_TEST

Hi Vinod,

Could you please pick this patch up for v3.14 ?

Quoted 24 lines · On Wednesday 27 November 2013 02:18:27 Laurent Pinchart wrote:

This helps increasing build testing coverage.

Cc Guennadi Liakhovetski <[email protected]>
Cc Vinod Koul <[email protected]>
Cc dmaengine at vger.kernel.org
---
 drivers/dma/sh/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/sh/Kconfig +1 -1
index dadd9e01..dc0fe03 100644
@@ -4,7 +4,7 @@
 
 config SH_DMAE_BASE
 	bool "Renesas SuperH DMA Engine support"
-	depends on (SUPERH && SH_DMA) || (ARM && ARCH_SHMOBILE)
+	depends on (SUPERH && SH_DMA) || ARCH_SHMOBILE || COMPILE_TEST
 	depends on !SH_DMA_API
 	default y
 	select DMA_ENGINE
Signature · 3 lines
Regards,

Laurent Pinchart
#22 lore raw

PATCH 6/15 v4l: sh_vou: Enable driver compilation with COMPILE_TEST

In reply to Laurent Pinchart

This helps increasing build testing coverage.

Cc Guennadi Liakhovetski <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Cc linux-media at vger.kernel.org
---
 drivers/media/platform/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/platform/Kconfig +2 -1
index d7f0249..7f6ea65 100644
@@ -36,7 +36,8 @@ source "drivers/media/platform/blackfin/Kconfig"
 config VIDEO_SH_VOU
 	tristate "SuperH VOU video output driver"
 	depends on MEDIA_CAMERA_SUPPORT
-	depends on VIDEO_DEV && ARCH_SHMOBILE && I2C
+	depends on VIDEO_DEV && I2C
+	depends on ARCH_SHMOBILE || COMPILE_TEST
 	select VIDEOBUF_DMA_CONTIG
 	help
 	  Support for the Video Output Unit (VOU) on SuperH SoCs.
Signature · 1 line
1.8.3.2
#23 lore raw

PATCH 6/15 v4l: sh_vou: Enable driver compilation with COMPILE_TEST

Hi Mauro,

Could you please pick this patch up for v3.14 ?

Quoted 25 lines · On Wednesday 27 November 2013 02:18:28 Laurent Pinchart wrote:

This helps increasing build testing coverage.

---
 drivers/media/platform/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/platform/Kconfig +2 -1
index d7f0249..7f6ea65 100644
@@ -36,7 +36,8 @@ source "drivers/media/platform/blackfin/Kconfig"
 config VIDEO_SH_VOU
 	tristate "SuperH VOU video output driver"
 	depends on MEDIA_CAMERA_SUPPORT
-	depends on VIDEO_DEV && ARCH_SHMOBILE && I2C
+	depends on VIDEO_DEV && I2C
+	depends on ARCH_SHMOBILE || COMPILE_TEST
 	select VIDEOBUF_DMA_CONTIG
 	help
 	  Support for the Video Output Unit (VOU) on SuperH SoCs.
Signature · 3 lines
Regards,

Laurent Pinchart
#24 lore raw

PATCH 7/15 mmc: sdhi: Enable driver compilation with COMPILE_TEST

In reply to Laurent Pinchart

This helps increasing build testing coverage.

The driver doesn't compile on (at least) x86 due (possibly among others) to missing readsw/writesw I/O accessors, restrict compilation to SUPERH or ARM.

Whether the CTL_DMA_ENABLE register is part of the standard TMIO controller or is Renesas-specific is unknown and impossible to test as we have no current or planned TMIO DMA users other than SUPERH and ARCH_SHMOBILE. Writing to the register is thus conditionally compiled for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the list would extend this to multiarch kernels, but would break the driver for non-shmobile platforms if the register is Renesas-specific. We can thus get rid of the conditional compilation completely without introducing any further issue, and let future non-Renesas users deal with the situation if it turns out to be a the problem.

Cc Chris Ball <[email protected]>
Cc Guennadi Liakhovetski <[email protected]>
Cc Ian Molton <[email protected]>
Cc linux-mmc at vger.kernel.org
---
 drivers/mmc/host/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/Kconfig +2 -1
index 7fc5099..ca1315e 100644
@@ -479,7 +479,8 @@ config MMC_TMIO
 
 config MMC_SDHI
 	tristate "SH-Mobile SDHI SD/SDIO controller support"
-	depends on SUPERH || ARCH_SHMOBILE
+	depends on SUPERH || ARM
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	select MMC_TMIO_CORE
 	help
 	  This provides support for the SDHI SD/SDIO controller found in
Signature · 1 line
1.8.3.2
#25 lore raw

PATCH 7/15 mmc: sdhi: Enable driver compilation with COMPILE_TEST

Hi Chris,

Could you please pick this patch (and patch 08/15 in the same series) up for v3.14 ?

Quoted 41 lines · On Wednesday 27 November 2013 02:18:29 Laurent Pinchart wrote:

This helps increasing build testing coverage.

The driver doesn't compile on (at least) x86 due (possibly among others) to missing readsw/writesw I/O accessors, restrict compilation to SUPERH or ARM.

Whether the CTL_DMA_ENABLE register is part of the standard TMIO controller or is Renesas-specific is unknown and impossible to test as we have no current or planned TMIO DMA users other than SUPERH and ARCH_SHMOBILE. Writing to the register is thus conditionally compiled for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the list would extend this to multiarch kernels, but would break the driver for non-shmobile platforms if the register is Renesas-specific. We can thus get rid of the conditional compilation completely without introducing any further issue, and let future non-Renesas users deal with the situation if it turns out to be a the problem.

---
 drivers/mmc/host/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/Kconfig +2 -1
index 7fc5099..ca1315e 100644
@@ -479,7 +479,8 @@ config MMC_TMIO
 
 config MMC_SDHI
 	tristate "SH-Mobile SDHI SD/SDIO controller support"
-	depends on SUPERH || ARCH_SHMOBILE
+	depends on SUPERH || ARM
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	select MMC_TMIO_CORE
 	help
 	  This provides support for the SDHI SD/SDIO controller found in
Signature · 3 lines
Regards,

Laurent Pinchart
#26 lore raw

PATCH 7/15 mmc: sdhi: Enable driver compilation with COMPILE_TEST

Hi Chris,

Quoted 4 lines · On Wednesday 11 December 2013 13:53:21 Laurent Pinchart wrote:

Hi Chris,

Could you please pick this patch (and patch 08/15 in the same series) up for v3.14 ?

Ping ?

Quoted 48 lines · On Wednesday 27 November 2013 02:18:29 Laurent Pinchart wrote:
Quoted 47 lines

This helps increasing build testing coverage.

The driver doesn't compile on (at least) x86 due (possibly among others) to missing readsw/writesw I/O accessors, restrict compilation to SUPERH or ARM.

Whether the CTL_DMA_ENABLE register is part of the standard TMIO controller or is Renesas-specific is unknown and impossible to test as we have no current or planned TMIO DMA users other than SUPERH and ARCH_SHMOBILE. Writing to the register is thus conditionally compiled for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the list would extend this to multiarch kernels, but would break the driver for non-shmobile platforms if the register is Renesas-specific. We can thus get rid of the conditional compilation completely without introducing any further issue, and let future non-Renesas users deal with the situation if it turns out to be a the problem.

Cc: Chris Ball <[email protected]>
Cc: Guennadi Liakhovetski <[email protected]>
Cc: Ian Molton <[email protected]>
Cc: [email protected]
Signed-off-by: Laurent Pinchart
<[email protected]>

---

 drivers/mmc/host/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/Kconfig +2 -1
index 7fc5099..ca1315e 100644
@@ -479,7 +479,8 @@ config MMC_TMIO
 
 config MMC_SDHI
 
 	tristate "SH-Mobile SDHI SD/SDIO controller support"
 
-	depends on SUPERH || ARCH_SHMOBILE
+	depends on SUPERH || ARM
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 
drivers/mmc/host/Kconfig +0 -0
 	select MMC_TMIO_CORE
 	help
 
 	  This provides support for the SDHI SD/SDIO controller found in
Signature · 3 lines
Regards,

Laurent Pinchart
#27 lore raw

PATCH 7/15 mmc: sdhi: Enable driver compilation with COMPILE_TEST

Hi Laurent,

Quoted 9 lines · Laurent Pinchart

Hi Chris,

Quoted 4 lines · On Wednesday 11 December 2013 13:53:21 Laurent Pinchart wrote:

Hi Chris,

Could you please pick this patch (and patch 08/15 in the same series) up for v3.14 ?

Ping ?

Thanks, both pushed to mmc-next for 3.14, sorry for the delay.

- Chris.

Signature · 1 line
Chris Ball   <[email protected]>   <http://printf.net/>
#28 lore raw

PATCH 7/15 mmc: sdhi: Enable driver compilation with COMPILE_TEST

Quoted 10 lines · On Tuesday 07 January 2014 15:50:45 Chris Ball wrote:
Quoted 7 lines · Laurent Pinchart
Quoted 4 lines · On Wednesday 11 December 2013 13:53:21 Laurent Pinchart wrote:

Hi Chris,

Could you please pick this patch (and patch 08/15 in the same series) up for v3.14 ?

Ping ?

Thanks, both pushed to mmc-next for 3.14, sorry for the delay.

No worries, thank you.

Signature · 3 lines
Regards,

Laurent Pinchart
#29 lore raw

PATCH 7/15 mmc: sdhi: Enable driver compilation with COMPILE_TEST

In reply to Laurent Pinchart

Hello.

Quoted 32 lines · Laurent Pinchart

This helps increasing build testing coverage.

The driver doesn't compile on (at least) x86 due (possibly among others) to missing readsw/writesw I/O accessors, restrict compilation to SUPERH or ARM.

Whether the CTL_DMA_ENABLE register is part of the standard TMIO controller or is Renesas-specific is unknown and impossible to test as we have no current or planned TMIO DMA users other than SUPERH and ARCH_SHMOBILE. Writing to the register is thus conditionally compiled for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the list would extend this to multiarch kernels, but would break the driver for non-shmobile platforms if the register is Renesas-specific. We can thus get rid of the conditional compilation completely without introducing any further issue, and let future non-Renesas users deal with the situation if it turns out to be a the problem.

Cc Chris Ball <[email protected]>
Cc Guennadi Liakhovetski <[email protected]>
Cc Ian Molton <[email protected]>
Cc linux-mmc at vger.kernel.org
---
  drivers/mmc/host/Kconfig | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/Kconfig +0 -0
index 7fc5099..ca1315e 100644

drivers/mmc/host/Kconfig config MMC_TMIO · line 483

Quoted 6 lines
drivers/mmc/host/Kconfig +2 -1
@@ -479,7 +479,8 @@ config MMC_TMIO
 
  config MMC_SDHI
  	tristate "SH-Mobile SDHI SD/SDIO controller support"
-	depends on SUPERH || ARCH_SHMOBILE
+	depends on SUPERH || ARM
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST

Hm, why 2 "depends" lines with SUPERH in both?

WBR, Sergei

#30 lore raw

PATCH 7/15 mmc: sdhi: Enable driver compilation with COMPILE_TEST

Quoted 40 lines · On Wednesday 11 December 2013 22:01:53 Sergei Shtylyov wrote:

Hello.

Quoted 37 lines · Laurent Pinchart

This helps increasing build testing coverage.

The driver doesn't compile on (at least) x86 due (possibly among others) to missing readsw/writesw I/O accessors, restrict compilation to SUPERH or ARM.

Whether the CTL_DMA_ENABLE register is part of the standard TMIO controller or is Renesas-specific is unknown and impossible to test as we have no current or planned TMIO DMA users other than SUPERH and ARCH_SHMOBILE. Writing to the register is thus conditionally compiled for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the list would extend this to multiarch kernels, but would break the driver for non-shmobile platforms if the register is Renesas-specific. We can thus get rid of the conditional compilation completely without introducing any further issue, and let future non-Renesas users deal with the situation if it turns out to be a the problem.

Cc: Chris Ball <[email protected]>
Cc: Guennadi Liakhovetski <[email protected]>
Cc: Ian Molton <[email protected]>
Cc: linux-mmc at vger.kernel.org
Signed-off-by: Laurent Pinchart
<[email protected]>

---

  drivers/mmc/host/Kconfig | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/Kconfig +0 -0
index 7fc5099..ca1315e 100644
@@ -479,7 +479,8 @@ config MMC_TMIO
 
  config MMC_SDHI
 
Quoted 7 lines

drivers/mmc/host/Kconfig config MMC_TMIO · line 483

Quoted 5 lines
drivers/mmc/host/Kconfig +2 -1
  	tristate "SH-Mobile SDHI SD/SDIO controller support"
 
-	depends on SUPERH || ARCH_SHMOBILE
+	depends on SUPERH || ARM
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST

Hm, why 2 "depends" lines with SUPERH in both?

The first line means "this driver requires SUPERH || ARM to be compiled", while the second line means "devices supported by this driver are only found on SUPERH || ARCH_SHMOBILE platforms".

Signature · 3 lines
Regards,

Laurent Pinchart
#31 lore raw

PATCH 7/15 mmc: sdhi: Enable driver compilation with COMPILE_TEST

Quoted 24 lines · Laurent Pinchart
Quoted 24 lines
Quoted 24 lines

This helps increasing build testing coverage.

The driver doesn't compile on (at least) x86 due (possibly among others) to missing readsw/writesw I/O accessors, restrict compilation to SUPERH or ARM.

Whether the CTL_DMA_ENABLE register is part of the standard TMIO controller or is Renesas-specific is unknown and impossible to test as we have no current or planned TMIO DMA users other than SUPERH and ARCH_SHMOBILE. Writing to the register is thus conditionally compiled for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the list would extend this to multiarch kernels, but would break the driver for non-shmobile platforms if the register is Renesas-specific. We can thus get rid of the conditional compilation completely without introducing any further issue, and let future non-Renesas users deal with the situation if it turns out to be a the problem.

Cc: Chris Ball <[email protected]>
Cc: Guennadi Liakhovetski <[email protected]>
Cc: Ian Molton <[email protected]>
Cc: linux-mmc at vger.kernel.org
Signed-off-by: Laurent Pinchart
<[email protected]>

[...]

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
drivers/mmc/host/Kconfig +0 -0
index 7fc5099..ca1315e 100644
@@ -479,7 +479,8 @@ config MMC_TMIO
 
   config MMC_SDHI
 
   	tristate "SH-Mobile SDHI SD/SDIO controller support"
 
Quoted 7 lines
Quoted 5 lines

drivers/mmc/host/Kconfig config MMC_TMIO · line 483

Quoted 3 lines
drivers/mmc/host/Kconfig +2 -1
-	depends on SUPERH || ARCH_SHMOBILE
+	depends on SUPERH || ARM
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST

Hm, why 2 "depends" lines with SUPERH in both?

The first line means "this driver requires SUPERH || ARM to be compiled",

Then COMPILE_TEST should be there, no?

Quoted 2 lines

while the second line means "devices supported by this driver are only found on SUPERH || ARCH_SHMOBILE platforms".

WBR, Sergei

#32 lore raw

PATCH 7/15 mmc: sdhi: Enable driver compilation with COMPILE_TEST

Hi Sergei,

Quoted 42 lines · On Wednesday 11 December 2013 22:22:19 Sergei Shtylyov wrote:
Quoted 24 lines · Laurent Pinchart
Quoted 24 lines
Quoted 24 lines

This helps increasing build testing coverage.

The driver doesn't compile on (at least) x86 due (possibly among others) to missing readsw/writesw I/O accessors, restrict compilation to SUPERH or ARM.

Whether the CTL_DMA_ENABLE register is part of the standard TMIO controller or is Renesas-specific is unknown and impossible to test as we have no current or planned TMIO DMA users other than SUPERH and ARCH_SHMOBILE. Writing to the register is thus conditionally compiled for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the list would extend this to multiarch kernels, but would break the driver for non-shmobile platforms if the register is Renesas-specific. We can thus get rid of the conditional compilation completely without introducing any further issue, and let future non-Renesas users deal with the situation if it turns out to be a the problem.

Cc: Chris Ball <[email protected]>
Cc: Guennadi Liakhovetski <[email protected]>
Cc: Ian Molton <[email protected]>
Cc: [email protected]
Signed-off-by: Laurent Pinchart
<[email protected]>

[...]

Quoted 14 lines
Quoted 13 lines

drivers/mmc/host/Kconfig config MMC_TMIO · line 484

Quoted 12 lines
drivers/mmc/host/Kconfig +2 -1
index 7fc5099..ca1315e 100644
@@ -479,7 +479,8 @@ config MMC_TMIO
 
   config MMC_SDHI
   	tristate "SH-Mobile SDHI SD/SDIO controller support"
-	depends on SUPERH || ARCH_SHMOBILE
+	depends on SUPERH || ARM
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 

Hm, why 2 "depends" lines with SUPERH in both?

Quoted 3 lines
Quoted 1 line

The first line means "this driver requires SUPERH || ARM to be compiled",

Then COMPILE_TEST should be there, no?

No, because the first line says that the driver is known *not* to compile on platforms other than ARM and SUPERH. Adding || COMPILE_TEST there would break compilation with allyesconfig and randconfig on those other platforms.

Stated differently, the first line restricts the driver from being compiled on architectures where it doesn't compile, regardless of COMPILE_TEST, and the second line restricts it to platform where hardware is known to exists, with COMPILE_TEST to optionally extend build coverage.

Quoted 2 lines
Quoted 2 lines

while the second line means "devices supported by this driver are only found on SUPERH || ARCH_SHMOBILE platforms".

Signature · 3 lines
Regards,

Laurent Pinchart
#33 lore raw

PATCH 8/15 mmc: sh_mmcif: Enable driver compilation with COMPILE_TEST

In reply to Laurent Pinchart

This helps increasing build testing coverage.

Cc Chris Ball <[email protected]>
Cc Guennadi Liakhovetski <[email protected]>
Cc linux-mmc at vger.kernel.org
---
 drivers/mmc/host/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/Kconfig +2 -1
index ca1315e..265ba48 100644
@@ -589,7 +589,8 @@ config MMC_DW_PCI
 
 config MMC_SH_MMCIF
 	tristate "SuperH Internal MMCIF support"
-	depends on MMC_BLOCK && (SUPERH || ARCH_SHMOBILE)
+	depends on MMC_BLOCK
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  This selects the MMC Host Interface controller (MMCIF).
 
Signature · 1 line
1.8.3.2
#34 lore raw

PATCH 9/15 mtd: sh_flctl: Enable driver compilation with COMPILE_TEST

In reply to Laurent Pinchart

This helps increasing build testing coverage.

Cc David Woodhouse <[email protected]>
Cc linux-mtd at lists.infradead.org
---
 drivers/mtd/nand/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/Kconfig +1 -1
index 93ae6a6..cb1f2ec 100644
@@ -458,7 +458,7 @@ config MTD_NAND_MXC
 
 config MTD_NAND_SH_FLCTL
 	tristate "Support for NAND on Renesas SuperH FLCTL"
-	depends on SUPERH || ARCH_SHMOBILE
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  Several Renesas SuperH CPU has FLCTL. This option enables support
 	  for NAND Flash using FLCTL.
Signature · 1 line
1.8.3.2
#35 lore raw

PATCH 9/15 mtd: sh_flctl: Enable driver compilation with COMPILE_TEST

Hi David,

Could you please pick this patch up for v3.14 ?

Quoted 23 lines · On Wednesday 27 November 2013 02:18:31 Laurent Pinchart wrote:

This helps increasing build testing coverage.

Cc David Woodhouse <[email protected]>
Cc linux-mtd at lists.infradead.org
---
 drivers/mtd/nand/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/Kconfig +1 -1
index 93ae6a6..cb1f2ec 100644
@@ -458,7 +458,7 @@ config MTD_NAND_MXC
 
 config MTD_NAND_SH_FLCTL
 	tristate "Support for NAND on Renesas SuperH FLCTL"
-	depends on SUPERH || ARCH_SHMOBILE
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  Several Renesas SuperH CPU has FLCTL. This option enables support
 	  for NAND Flash using FLCTL.
Signature · 3 lines
Regards,

Laurent Pinchart
#36 lore raw

PATCH 9/15 mtd: sh_flctl: Enable driver compilation with COMPILE_TEST

Quoted 3 lines · Laurent Pinchart

Hi David,

Could you please pick this patch up for v3.14 ?

I'm not David, but I pushed your patch over a week ago. I guess I forgot to warn you. Sorry!

Quoted 7 lines · On Wednesday 27 November 2013 02:18:31 Laurent Pinchart wrote:
Quoted 6 lines

This helps increasing build testing coverage.

Cc David Woodhouse <[email protected]>
Cc linux-mtd at lists.infradead.org

This patch is in l2-mtd.git. Thanks!

Brian

#37 lore raw

PATCH 10/15 irda: sh_irda: Enable driver compilation with COMPILE_TEST

In reply to Laurent Pinchart

This helps increasing build testing coverage.

Cc Samuel Ortiz <[email protected]>
Cc netdev at vger.kernel.org
---
 drivers/net/irda/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/irda/Kconfig +2 -1
index 2a30193..cae5ee2 100644
@@ -403,7 +403,8 @@ config MCS_FIR
 
 config SH_IRDA
 	tristate "SuperH IrDA driver"
-	depends on IRDA && ARCH_SHMOBILE
+	depends on IRDA
+	depends on ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  Say Y here if your want to enable SuperH IrDA devices.
 
Signature · 1 line
1.8.3.2
#38 lore raw

Re: [PATCH 10/15] irda: sh_irda: Enable driver compilation with COMPILE_TEST

Hi Samuel,

Could you please pick this patch up for v3.14 ?

Quoted 23 lines · On Wednesday 27 November 2013 02:18:32 Laurent Pinchart wrote:

This helps increasing build testing coverage.

Cc Samuel Ortiz <[email protected]>
Cc netdev at vger.kernel.org
---
 drivers/net/irda/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/irda/Kconfig +2 -1
index 2a30193..cae5ee2 100644
@@ -403,7 +403,8 @@ config MCS_FIR
 
 config SH_IRDA
 	tristate "SuperH IrDA driver"
-	depends on IRDA && ARCH_SHMOBILE
+	depends on IRDA
+	depends on ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  Say Y here if your want to enable SuperH IrDA devices.
Signature · 3 lines
Regards,

Laurent Pinchart
#39 lore raw

Re: [PATCH 10/15] irda: sh_irda: Enable driver compilation with COMPILE_TEST

Quoted 3 lines · On Wednesday 11 December 2013 13:49:15 Laurent Pinchart wrote:

Hi Samuel,

Could you please pick this patch up for v3.14 ?

Ping ?

Quoted 30 lines · On Wednesday 27 November 2013 02:18:32 Laurent Pinchart wrote:
Quoted 29 lines

This helps increasing build testing coverage.

Cc: Samuel Ortiz <[email protected]>
Cc: netdev at vger.kernel.org
Signed-off-by: Laurent Pinchart
<[email protected]>

---

 drivers/net/irda/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/irda/Kconfig +2 -1
index 2a30193..cae5ee2 100644
@@ -403,7 +403,8 @@ config MCS_FIR
 
 config SH_IRDA
 
 	tristate "SuperH IrDA driver"
 
-	depends on IRDA && ARCH_SHMOBILE
+	depends on IRDA
+	depends on ARCH_SHMOBILE || COMPILE_TEST
 
drivers/net/irda/Kconfig +0 -0
 	help
 
 	  Say Y here if your want to enable SuperH IrDA devices.
Signature · 3 lines
Regards,

Laurent Pinchart
#40 lore raw

Re: [PATCH 10/15] irda: sh_irda: Enable driver compilation with COMPILE_TEST

Hi Samuel,

Quoted 6 lines · On Tuesday 07 January 2014 16:13:49 Laurent Pinchart wrote:
Quoted 3 lines · On Wednesday 11 December 2013 13:49:15 Laurent Pinchart wrote:

Hi Samuel,

Could you please pick this patch up for v3.14 ?

Ping ?

PING ?

Quoted 30 lines
Quoted 30 lines · On Wednesday 27 November 2013 02:18:32 Laurent Pinchart wrote:
Quoted 29 lines

This helps increasing build testing coverage.

Cc: Samuel Ortiz <[email protected]>
Cc: netdev at vger.kernel.org
Signed-off-by: Laurent Pinchart
<[email protected]>

---

 drivers/net/irda/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/irda/Kconfig +2 -1
index 2a30193..cae5ee2 100644
@@ -403,7 +403,8 @@ config MCS_FIR
 
 config SH_IRDA
 
 	tristate "SuperH IrDA driver"
 
-	depends on IRDA && ARCH_SHMOBILE
+	depends on IRDA
+	depends on ARCH_SHMOBILE || COMPILE_TEST
 
drivers/net/irda/Kconfig +0 -0
 	help
 
 	  Say Y here if your want to enable SuperH IrDA devices.
Signature · 3 lines
Regards,

Laurent Pinchart
#41 lore raw

PATCH 11/15 pwm: pwm-renesas-tpu: Enable driver compilation with COMPILE_TEST

In reply to Laurent Pinchart

This helps increasing build testing coverage.

Cc Thierry Reding <[email protected]>
Cc linux-pwm at vger.kernel.org
---
 drivers/pwm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pwm/Kconfig +1 -1
index eece329..5de6fcf 100644
@@ -139,7 +139,7 @@ config PWM_PXA
 
 config PWM_RENESAS_TPU
 	tristate "Renesas TPU PWM support"
-	depends on ARCH_SHMOBILE
+	depends on ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  This driver exposes the Timer Pulse Unit (TPU) PWM controller found
 	  in Renesas chips through the PWM API.
Signature · 1 line
1.8.3.2
#42 lore raw

PATCH 11/15 pwm: pwm-renesas-tpu: Enable driver compilation with COMPILE_TEST

Quoted 9 lines · Laurent Pinchart

This helps increasing build testing coverage.

Cc Thierry Reding <[email protected]>
Cc linux-pwm at vger.kernel.org
---
 drivers/pwm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I'm not sure if this has been answered in any of the various subthreads before. I've tried to read through them, but I may have missed some. It was mentioned that iowrite16() wasn't supported on all architectures; won't this possibly cause randconfig autobuilders to break?

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131129/f510a42a/attachment-0001.sig>

#43 lore raw

PATCH 11/15 pwm: pwm-renesas-tpu: Enable driver compilation with COMPILE_TEST

Hi Thierry,

Quoted 10 lines · On Friday 29 November 2013 11:53:54 Thierry Reding wrote:
Quoted 9 lines · Laurent Pinchart

This helps increasing build testing coverage.

Cc: Thierry Reding <[email protected]>
Cc: linux-pwm at vger.kernel.org
Signed-off-by: Laurent Pinchart
<[email protected]>

---

Quoted 7 lines
Quoted 2 lines
 drivers/pwm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I'm not sure if this has been answered in any of the various subthreads before. I've tried to read through them, but I may have missed some. It was mentioned that iowrite16() wasn't supported on all architectures; won't this possibly cause randconfig autobuilders to break?

That's possible (although it has been reported to me that the situation got fixed on arch/cris in v3.12), but the only way to find out is to try it. That would be a bug in the architecture, and it should then get fixed.

Signature · 10 lines
Regards,

Laurent Pinchart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131129/ef9d4ba2/attachment.sig>
#44 lore raw

PATCH 11/15 pwm: pwm-renesas-tpu: Enable driver compilation with COMPILE_TEST

Hi Thierry,

Quoted 14 lines · On Friday 29 November 2013 14:51:25 Laurent Pinchart wrote:
Quoted 13 lines · On Friday 29 November 2013 11:53:54 Thierry Reding wrote:
Quoted 11 lines · Laurent Pinchart

This helps increasing build testing coverage.

Cc: Thierry Reding <[email protected]>
Cc: [email protected]
Signed-off-by: Laurent Pinchart
<[email protected]>

---

 drivers/pwm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 8 lines
Quoted 4 lines

I'm not sure if this has been answered in any of the various subthreads before. I've tried to read through them, but I may have missed some. It was mentioned that iowrite16() wasn't supported on all architectures; won't this possibly cause randconfig autobuilders to break?

That's possible (although it has been reported to me that the situation got fixed on arch/cris in v3.12), but the only way to find out is to try it. That would be a bug in the architecture, and it should then get fixed.

Would you consider picking this patch up for v3.14 ?

Signature · 3 lines
Regards,

Laurent Pinchart
#45 lore raw

PATCH 11/15 pwm: pwm-renesas-tpu: Enable driver compilation with COMPILE_TEST

In reply to Laurent Pinchart
Quoted 9 lines · Laurent Pinchart

This helps increasing build testing coverage.

Cc Thierry Reding <[email protected]>
Cc linux-pwm at vger.kernel.org
---
 drivers/pwm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131212/221115d9/attachment.sig>

#46 lore raw

PATCH 12/15 thermal: rcar-thermal: Enable driver compilation with COMPILE_TEST

In reply to Laurent Pinchart

This helps increasing build testing coverage.

Cc Zhang Rui <[email protected]>
Cc Eduardo Valentin <[email protected]>
Cc linux-pm at vger.kernel.org
---
 drivers/thermal/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/Kconfig +1 -1
index f35a1f7..661cafc 100644
@@ -121,7 +121,7 @@ config SPEAR_THERMAL
 
 config RCAR_THERMAL
 	tristate "Renesas R-Car thermal driver"
-	depends on ARCH_SHMOBILE
+	depends on ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  Enable this to plug the R-Car thermal sensor driver into the Linux
 	  thermal framework.
Signature · 1 line
1.8.3.2
#47 lore raw

PATCH 12/15 thermal: rcar-thermal: Enable driver compilation with COMPILE_TEST

Hi Zhang and Eduardo,

Could you please pick this patch up for v3.14 ?

Quoted 24 lines · On Wednesday 27 November 2013 02:18:34 Laurent Pinchart wrote:

This helps increasing build testing coverage.

Cc Zhang Rui <[email protected]>
Cc Eduardo Valentin <[email protected]>
Cc linux-pm at vger.kernel.org
---
 drivers/thermal/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/Kconfig +1 -1
index f35a1f7..661cafc 100644
@@ -121,7 +121,7 @@ config SPEAR_THERMAL
 
 config RCAR_THERMAL
 	tristate "Renesas R-Car thermal driver"
-	depends on ARCH_SHMOBILE
+	depends on ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  Enable this to plug the R-Car thermal sensor driver into the Linux
 	  thermal framework.
Signature · 3 lines
Regards,

Laurent Pinchart
#48 lore raw

PATCH 12/15 thermal: rcar-thermal: Enable driver compilation with COMPILE_TEST

Quoted 3 lines · Laurent Pinchart

Hi Zhang and Eduardo,

Could you please pick this patch up for v3.14 ?

Yes Laurent, I can pick it.

Quoted 9 lines · On Wednesday 27 November 2013 02:18:34 Laurent Pinchart wrote:
Quoted 7 lines

This helps increasing build testing coverage.

Cc Zhang Rui <[email protected]>
Cc Eduardo Valentin <[email protected]>
Cc linux-pm at vger.kernel.org
Quoted 17 lines
Quoted 17 lines
---
 drivers/thermal/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/Kconfig +1 -1
index f35a1f7..661cafc 100644
@@ -121,7 +121,7 @@ config SPEAR_THERMAL
 
 config RCAR_THERMAL
 	tristate "Renesas R-Car thermal driver"
-	depends on ARCH_SHMOBILE
+	depends on ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  Enable this to plug the R-Car thermal sensor driver into the Linux
 	  thermal framework.
Signature · 11 lines
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 295 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131212/d2cc23db/attachment-0001.sig>
reviewer Applied
#49 lore raw

PATCH 12/15 thermal: rcar-thermal: Enable driver compilation with COMPILE_TEST

Quoted 11 lines · Eduardo Valentin
Quoted 3 lines · Laurent Pinchart

Hi Zhang and Eduardo,

Could you please pick this patch up for v3.14 ?

Yes Laurent, I can pick it.

Quoted 4 lines · On Wednesday 27 November 2013 02:18:34 Laurent Pinchart wrote:
Quoted 2 lines

This helps increasing build testing coverage.

Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
Cc Zhang Rui <[email protected]>
Cc Eduardo Valentin <[email protected]>
Cc linux-pm at vger.kernel.org

applied.

thanks,
rui

Quoted 20 lines
Quoted 18 lines
Quoted 18 lines
---
 drivers/thermal/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/Kconfig +1 -1
index f35a1f7..661cafc 100644
@@ -121,7 +121,7 @@ config SPEAR_THERMAL
 
 config RCAR_THERMAL
 	tristate "Renesas R-Car thermal driver"
-	depends on ARCH_SHMOBILE
+	depends on ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  Enable this to plug the R-Car thermal sensor driver into the Linux
 	  thermal framework.
#50 lore raw

PATCH 13/15 fbdev: sh-mobile-lcdcfb: Enable driver compilation with COMPILE_TEST

In reply to Laurent Pinchart

This helps increasing build testing coverage.

Cc Jean-Christophe Plagniol-Villard <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Cc linux-fbdev at vger.kernel.org
---
 drivers/video/Kconfig | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/video/Kconfig +5 -3
index 4f2e1b3..2aceb08 100644
@@ -10,7 +10,8 @@ config HAVE_FB_ATMEL
 
 config SH_MIPI_DSI
 	tristate
-	depends on (SUPERH || ARCH_SHMOBILE) && HAVE_CLK
+	depends on HAVE_CLK
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 
 config SH_LCD_MIPI_DSI
 	bool
@@ -1997,7 +1998,8 @@ config FB_W100
 
 config FB_SH_MOBILE_LCDC
 	tristate "SuperH Mobile LCDC framebuffer support"
-	depends on FB && (SUPERH || ARCH_SHMOBILE) && HAVE_CLK
+	depends on FB && HAVE_CLK
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	select FB_SYS_FILLRECT
 	select FB_SYS_COPYAREA
 	select FB_SYS_IMAGEBLIT
@@ -2484,7 +2486,7 @@ endif
 
 config FB_SH_MOBILE_MERAM
 	tristate "SuperH Mobile MERAM read ahead support"
-	depends on (SUPERH || ARCH_SHMOBILE)
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	select GENERIC_ALLOCATOR
 	---help---
 	  Enable MERAM support for the SuperH controller.
Signature · 1 line
1.8.3.2
#51 lore raw

PATCH 13/15 fbdev: sh-mobile-lcdcfb: Enable driver compilation with COMPILE_TEST

Hi Jean-Christophe and Tomi,

Could you please pick this patch up for v3.14 ?

Quoted 44 lines · On Wednesday 27 November 2013 02:18:35 Laurent Pinchart wrote:

This helps increasing build testing coverage.

Cc Jean-Christophe Plagniol-Villard <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Cc linux-fbdev at vger.kernel.org
---
 drivers/video/Kconfig | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/video/Kconfig +5 -3
index 4f2e1b3..2aceb08 100644
@@ -10,7 +10,8 @@ config HAVE_FB_ATMEL
 
 config SH_MIPI_DSI
 	tristate
-	depends on (SUPERH || ARCH_SHMOBILE) && HAVE_CLK
+	depends on HAVE_CLK
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 
 config SH_LCD_MIPI_DSI
 	bool
@@ -1997,7 +1998,8 @@ config FB_W100
 
 config FB_SH_MOBILE_LCDC
 	tristate "SuperH Mobile LCDC framebuffer support"
-	depends on FB && (SUPERH || ARCH_SHMOBILE) && HAVE_CLK
+	depends on FB && HAVE_CLK
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	select FB_SYS_FILLRECT
 	select FB_SYS_COPYAREA
 	select FB_SYS_IMAGEBLIT
@@ -2484,7 +2486,7 @@ endif
 
 config FB_SH_MOBILE_MERAM
 	tristate "SuperH Mobile MERAM read ahead support"
-	depends on (SUPERH || ARCH_SHMOBILE)
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	select GENERIC_ALLOCATOR
 	---help---
 	  Enable MERAM support for the SuperH controller.
Signature · 3 lines
Regards,

Laurent Pinchart
#52 lore raw

PATCH 13/15 fbdev: sh-mobile-lcdcfb: Enable driver compilation with COMPILE_TEST

Quoted 3 lines · On Wednesday 11 December 2013 13:51:18 Laurent Pinchart wrote:

Hi Jean-Christophe and Tomi,

Could you please pick this patch up for v3.14 ?

Ping ?

Quoted 47 lines · On Wednesday 27 November 2013 02:18:35 Laurent Pinchart wrote:
Quoted 46 lines

This helps increasing build testing coverage.

Cc: Jean-Christophe Plagniol-Villard <[email protected]>
Cc: Tomi Valkeinen <[email protected]>
Cc: linux-fbdev at vger.kernel.org
Signed-off-by: Laurent Pinchart <[email protected]>

---

 drivers/video/Kconfig | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/video/Kconfig +5 -3
index 4f2e1b3..2aceb08 100644
@@ -10,7 +10,8 @@ config HAVE_FB_ATMEL
 
 config SH_MIPI_DSI
 	tristate
-	depends on (SUPERH || ARCH_SHMOBILE) && HAVE_CLK
+	depends on HAVE_CLK
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 
 config SH_LCD_MIPI_DSI
 	bool
@@ -1997,7 +1998,8 @@ config FB_W100
 
 config FB_SH_MOBILE_LCDC
 	tristate "SuperH Mobile LCDC framebuffer support"
-	depends on FB && (SUPERH || ARCH_SHMOBILE) && HAVE_CLK
+	depends on FB && HAVE_CLK
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	select FB_SYS_FILLRECT
 	select FB_SYS_COPYAREA
 	select FB_SYS_IMAGEBLIT
@@ -2484,7 +2486,7 @@ endif
 
 config FB_SH_MOBILE_MERAM
 	tristate "SuperH Mobile MERAM read ahead support"
-	depends on (SUPERH || ARCH_SHMOBILE)
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	select GENERIC_ALLOCATOR
 	---help---
 	  Enable MERAM support for the SuperH controller.
Signature · 3 lines
Regards,

Laurent Pinchart
#53 lore raw

PATCH 13/15 fbdev: sh-mobile-lcdcfb: Enable driver compilation with COMPILE_TEST

Quoted 6 lines · Laurent Pinchart
Quoted 3 lines · On Wednesday 11 December 2013 13:51:18 Laurent Pinchart wrote:

Hi Jean-Christophe and Tomi,

Could you please pick this patch up for v3.14 ?

Ping ?

Queued for 3.14.

Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140108/674b3c3d/attachment.sig>

#54 lore raw

PATCH 13/15 fbdev: sh-mobile-lcdcfb: Enable driver compilation with COMPILE_TEST

Hi,

Quoted 9 lines · Tomi Valkeinen
Quoted 6 lines · Laurent Pinchart
Quoted 3 lines · On Wednesday 11 December 2013 13:51:18 Laurent Pinchart wrote:

Hi Jean-Christophe and Tomi,

Could you please pick this patch up for v3.14 ?

Ping ?

Queued for 3.14.

I'll drop this patch, as it causes compile break (from kbuild test robot):

All error/warnings:

drivers/built-in.o: In function `sh_mobile_lcdc_pan':

Quoted 1 line
Quoted 1 line

sh_mobile_lcdcfb.c:(.text+0x77373): undefined reference to

`sh_mobile_meram_cache_update'
drivers/built-in.o: In function `sh_mobile_lcdc_start':

Quoted 1 line
Quoted 1 line

sh_mobile_lcdcfb.c:(.text+0x79320): undefined reference to

`sh_mobile_meram_cache_free'

Quoted 1 line
Quoted 1 line

sh_mobile_lcdcfb.c:(.text+0x79394): undefined reference to

`sh_mobile_meram_cache_alloc'

Quoted 1 line
Quoted 1 line

sh_mobile_lcdcfb.c:(.text+0x793d4): undefined reference to

`sh_mobile_meram_cache_update'
drivers/built-in.o: In function `sh_mobile_lcdc_stop':

Quoted 1 line
Quoted 1 line

sh_mobile_lcdcfb.c:(.text+0x79616): undefined reference to

`sh_mobile_meram_cache_free'

Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140117/cb1f7878/attachment.sig>

#55 lore raw

PATCH 13/15 fbdev: sh-mobile-lcdcfb: Enable driver compilation with COMPILE_TEST

Hi Tomi,

Quoted 22 lines · On Friday 17 January 2014 11:00:58 Tomi Valkeinen wrote:

Hi,

Quoted 9 lines · Tomi Valkeinen
Quoted 6 lines · Laurent Pinchart
Quoted 3 lines · On Wednesday 11 December 2013 13:51:18 Laurent Pinchart wrote:

Hi Jean-Christophe and Tomi,

Could you please pick this patch up for v3.14 ?

Ping ?

Queued for 3.14.

I'll drop this patch, as it causes compile break (from kbuild test robot):

All error/warnings:

drivers/built-in.o: In function `sh_mobile_lcdc_pan':

Quoted 1 line
Quoted 1 line

sh_mobile_lcdcfb.c:(.text+0x77373): undefined reference to

`sh_mobile_meram_cache_update'
drivers/built-in.o: In function `sh_mobile_lcdc_start':

Quoted 1 line
Quoted 1 line

sh_mobile_lcdcfb.c:(.text+0x79320): undefined reference to

Quoted 8 lines

`sh_mobile_meram_cache_free'

Quoted 1 line
Quoted 1 line

sh_mobile_lcdcfb.c:(.text+0x79394): undefined reference to

`sh_mobile_meram_cache_alloc'

Quoted 1 line
Quoted 1 line

sh_mobile_lcdcfb.c:(.text+0x793d4): undefined reference to

`sh_mobile_meram_cache_update'
drivers/built-in.o: In function `sh_mobile_lcdc_stop':

Quoted 1 line
Quoted 1 line

sh_mobile_lcdcfb.c:(.text+0x79616): undefined reference to

`sh_mobile_meram_cache_free'

The lcdc driver can be compiled without meram support. This is handled by conditional compilation in include/video/sh_mobile_meram.h that defines the meram functions as stubs when meram support isn't selected.

The problem comes from the combination of FB_SH_MOBILE_MERAM=m and FB_SH_MOBILE_LCDC=y. The former makes the meram function non-stubs, while the later makes the LCDC driver fail to link, as meram support is then compiled as a module.

How do you usually handle this ?

Signature · 10 lines
Regards,

Laurent Pinchart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140119/329d9343/attachment.sig>
#56 lore raw

PATCH 13/15 fbdev: sh-mobile-lcdcfb: Enable driver compilation with COMPILE_TEST

Quoted 6 lines · Laurent Pinchart

Hi Tomi,

The lcdc driver can be compiled without meram support. This is handled by conditional compilation in include/video/sh_mobile_meram.h that defines the meram functions as stubs when meram support isn't selected.

Quoted 6 lines

The problem comes from the combination of FB_SH_MOBILE_MERAM=m and FB_SH_MOBILE_LCDC=y. The former makes the meram function non-stubs, while the later makes the LCDC driver fail to link, as meram support is then compiled as a module.

How do you usually handle this ?

I guess the easiest option is to make FB_SH_MOBILE_MERAM a bool, instead of tristate.

Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140120/6d5866fc/attachment.sig>

#57 lore raw

PATCH 13/15 fbdev: sh-mobile-lcdcfb: Enable driver compilation with COMPILE_TEST

Hi Tomi,

Quoted 13 lines · On Monday 20 January 2014 13:21:47 Tomi Valkeinen wrote:
Quoted 12 lines · Laurent Pinchart

Hi Tomi,

The lcdc driver can be compiled without meram support. This is handled by conditional compilation in include/video/sh_mobile_meram.h that defines the
meram functions as stubs when meram support isn't selected.

The problem comes from the combination of FB_SH_MOBILE_MERAM=m and FB_SH_MOBILE_LCDC=y. The former makes the meram function non-stubs, while the later makes the LCDC driver fail to link, as meram support is then compiled as a module.

Quoted 4 lines
Quoted 1 line

How do you usually handle this ?

I guess the easiest option is to make FB_SH_MOBILE_MERAM a bool, instead of tristate.

That's easy, but it would prevent meram support from being compiled as a module when lcdc support is compiled as a module as well.

Signature · 10 lines
Regards,

Laurent Pinchart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140120/5f7481fa/attachment-0001.sig>
#58 lore raw

PATCH 14/15 spi: sh-msiof: Enable driver compilation with COMPILE_TEST

In reply to Laurent Pinchart

This helps increasing build testing coverage.

Cc Mark Brown <[email protected]>
Cc linux-spi at vger.kernel.org
---
 drivers/spi/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/spi/Kconfig +2 -1
index eb1f1ef..51ae940 100644
@@ -407,7 +407,8 @@ config SPI_SC18IS602
 
 config SPI_SH_MSIOF
 	tristate "SuperH MSIOF SPI controller"
-	depends on (SUPERH || ARCH_SHMOBILE) && HAVE_CLK
+	depends on HAVE_CLK
+	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
 	select SPI_BITBANG
 	help
 	  SPI driver for SuperH and SH Mobile MSIOF blocks.
Signature · 1 line
1.8.3.2
#60 lore raw

PATCH 15/15 sh: intc: Enable driver compilation with COMPILE_TEST

In reply to Laurent Pinchart

This helps increasing build testing coverage.

---
 drivers/sh/intc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/sh/intc/Kconfig +1 -1
index a305731..f7d9061 100644
@@ -6,7 +6,7 @@ comment "Interrupt controller options"
 
 config INTC_USERIMASK
 	bool "Userspace interrupt masking support"
-	depends on ARCH_SHMOBILE || (SUPERH && CPU_SH4A)
+	depends on ARCH_SHMOBILE || (SUPERH && CPU_SH4A) || COMPILE_TEST
 	help
 	  This enables support for hardware-assisted userspace hardirq
 	  masking.
Signature · 1 line
1.8.3.2
#61 lore raw

PATCH 15/15 sh: intc: Enable driver compilation with COMPILE_TEST

Hi Magnus,

Could you tell me who is responsible for merging drivers/sh patches ? If that's one of you, could you please pick this patch up for v3.14 ?

Quoted 21 lines · On Wednesday 27 November 2013 02:18:37 Laurent Pinchart wrote:

This helps increasing build testing coverage.

---
 drivers/sh/intc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/sh/intc/Kconfig +1 -1
index a305731..f7d9061 100644
@@ -6,7 +6,7 @@ comment "Interrupt controller options"
 
 config INTC_USERIMASK
 	bool "Userspace interrupt masking support"
-	depends on ARCH_SHMOBILE || (SUPERH && CPU_SH4A)
+	depends on ARCH_SHMOBILE || (SUPERH && CPU_SH4A) || COMPILE_TEST
 	help
 	  This enables support for hardware-assisted userspace hardirq
 	  masking.
Signature · 3 lines
Regards,

Laurent Pinchart
#62 lore raw

PATCH 15/15 sh: intc: Enable driver compilation with COMPILE_TEST

Quoted 4 lines · On Wednesday 11 December 2013 13:52:31 Laurent Pinchart wrote:

Hi Magnus,

Could you tell me who is responsible for merging drivers/sh patches ? If that's one of you, could you please pick this patch up for v3.14 ?

Ping ?

Quoted 28 lines · On Wednesday 27 November 2013 02:18:37 Laurent Pinchart wrote:
Quoted 27 lines

This helps increasing build testing coverage.

Cc: Magnus Damm <[email protected]>
Signed-off-by: Laurent Pinchart
<[email protected]>
---

 drivers/sh/intc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/sh/intc/Kconfig +1 -1
index a305731..f7d9061 100644
@@ -6,7 +6,7 @@ comment "Interrupt controller options"
 
 config INTC_USERIMASK
 
 	bool "Userspace interrupt masking support"
 
-	depends on ARCH_SHMOBILE || (SUPERH && CPU_SH4A)
+	depends on ARCH_SHMOBILE || (SUPERH && CPU_SH4A) || COMPILE_TEST
 
drivers/sh/intc/Kconfig +0 -0
 	help
 
 	  This enables support for hardware-assisted userspace hardirq
 	  masking.
Signature · 3 lines
Regards,

Laurent Pinchart
#63 lore raw

PATCH 15/15 sh: intc: Enable driver compilation with COMPILE_TEST

Quoted 7 lines · Laurent Pinchart
Quoted 4 lines · On Wednesday 11 December 2013 13:52:31 Laurent Pinchart wrote:

Hi Magnus,

Could you tell me who is responsible for merging drivers/sh patches ? If that's one of you, could you please pick this patch up for v3.14 ?

Ping ?

I am happy to take this if no one objects.

Quoted 35 lines
Quoted 29 lines · On Wednesday 27 November 2013 02:18:37 Laurent Pinchart wrote:
Quoted 27 lines

This helps increasing build testing coverage.

Cc: Magnus Damm <[email protected]>
Signed-off-by: Laurent Pinchart
<[email protected]>
---

 drivers/sh/intc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/sh/intc/Kconfig +1 -1
index a305731..f7d9061 100644
@@ -6,7 +6,7 @@ comment "Interrupt controller options"
 
 config INTC_USERIMASK
 
 	bool "Userspace interrupt masking support"
 
-	depends on ARCH_SHMOBILE || (SUPERH && CPU_SH4A)
+	depends on ARCH_SHMOBILE || (SUPERH && CPU_SH4A) || COMPILE_TEST
 
drivers/sh/intc/Kconfig +0 -0
 	help
 
 	  This enables support for hardware-assisted userspace hardirq
 	  masking.
Signature · 3 lines
Regards,

Laurent Pinchart
#64 lore raw

PATCH 15/15 sh: intc: Enable driver compilation with COMPILE_TEST

Quoted 10 lines · Simon Horman
Quoted 7 lines · Laurent Pinchart
Quoted 4 lines · On Wednesday 11 December 2013 13:52:31 Laurent Pinchart wrote:

Hi Magnus,

Could you tell me who is responsible for merging drivers/sh patches ? If that's one of you, could you please pick this patch up for v3.14 ?

Ping ?

I am happy to take this if no one objects.

Sorry for the extended delay on this one.
I have finally queued it up.

Quoted 39 lines
Quoted 21 lines
Quoted 21 lines · On Wednesday 27 November 2013 02:18:37 Laurent Pinchart wrote:
Quoted 20 lines

This helps increasing build testing coverage.

Cc: Magnus Damm <[email protected]>
Signed-off-by: Laurent Pinchart
<[email protected]>
---

 drivers/sh/intc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/sh/intc/Kconfig +0 -0
index a305731..f7d9061 100644
@@ -6,7 +6,7 @@ comment "Interrupt controller options"
 
 config INTC_USERIMASK
 
 	bool "Userspace interrupt masking support"
 
Quoted 13 lines
Quoted 7 lines
Quoted 7 lines
drivers/sh/intc/Kconfig +1 -1
-	depends on ARCH_SHMOBILE || (SUPERH && CPU_SH4A)
+	depends on ARCH_SHMOBILE || (SUPERH && CPU_SH4A) || COMPILE_TEST
 
drivers/sh/intc/Kconfig +0 -0
 	help
 
 	  This enables support for hardware-assisted userspace hardirq
 	  masking.
Signature · 3 lines
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html